WordPress.org

Make WordPress Themes

Opened 7 months ago

Closed 5 months ago

#41231 closed theme (live)

THEME: Academic – 1.0

Reported by: themepalace Owned by: juhise
Priority: previously reviewed Keywords: theme-academic
Cc: info@…

Description

Academic - 0.5

A clean, modern, engaging and responsive WordPress education theme ideal for educational institutions and agencies. Features including full width and boxed layout with slider, focused content, slick effects, posts/features/courses showcasing. It is loaded with theme options and provides several features to make user-friendly, interactive and visually stunning website with implementation of all features of latest WordPress like partial refresh and validation. It is compatible with top WordPress plugins such as JetPack and Contact Form 7. A special accent is made on its cross-browser compatibility, mobile friendly design and responsive features.

Theme URL - http://themepalace.com/downloads/academic/
Author URL - http://themepalace.com/

Trac Browser - https://themes.trac.wordpress.org/browser/academic/0.5

SVN - https://themes.svn.wordpress.org/academic/0.5
ZIP - https://wordpress.org/themes/download/academic.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=academic/0.4&new_path=academic/0.5

History:

Ticket Summary Status Resolution Owner
#11598 THEME: Academica - 1.2.2 closed live life.object
#23934 THEME: Academica – 2.0 closed live djrmom
#32914 THEME: Academica – 2.0.1 closed live themetracbot
#34222 THEME: Academic – 0.4 closed not-approved greenshady
#40181 THEME: Academica – 2.0.2 closed live themetracbot
#41231 THEME: Academic – 1.0 closed live juhise

(this ticket)

#41911 THEME: Academica – 2.0.3 closed live themetracbot
#43546 THEME: Academic – 1.1 closed live themetracbot
#43753 THEME: Academic – 1.2 closed live themetracbot
#46798 THEME: Academic – 1.3 closed live themetracbot


https://themes.svn.wordpress.org/academic/0.5/screenshot.png

Change History (27)

#1 @joyously
6 months ago

  • The wider windows do not show a menu when none is selected, but the narrow windows do. They should be the same.
  • The narrow windows do not show a site title, but the wider windows do.
  • On a small screen (~585px or less), the menu icon is covered by the admin bar.
  • Start with a small screen and open the menu. Then make the screen wider, and you can no longer close the menu.
  • Comment author website is not linked.
  • Comment anchor is not linked. This is typically put on the comment date for easy copy/paste access.
  • Comment date is not shown in user choice of date format.
  • <q> tag is unstyled (default removed)
  • Page links (generated by <!--nextpage-->) are being output in the same div as the content instead of after it.
  • Clicking on a thumbnail in a gallery shows a blank lightbox. It should show the attachment page.
  • Theme tags have custom-background, custom-menu twice.
  • In academic_head(), why call $options = academic_get_theme_options(); at the end?
  • In structure.php, why call $options = academic_get_theme_options(); at the top? This is an unprefixed global, but I think it's never used.
  • For header image post meta, use featured image instead.
  • Default images used when there are no featured image have some problems.
    • Theme or brand name is shown.
    • untranslatable text is shown.
    • text is instructions that site visitors should not see.
    • Consider using a random color or a gradient instead.

#2 @kevinhaig
6 months ago

Note to Author

  1. The above preview by @joyously is not an official review. You must still wait to get to the top of the review queue before an official review will begin.
  1. Many of the concerns above relate to results from Theme Unit Test and you should always test your theme with that package. However please note that many of the comments are considered recommended. Recommended comments DO NOT have to be addressed for theme approval. In many cases it is good advice, but the decision to address those issues is yours.
  1. There may be some comment items that are required. Requires items must be addressed or the theme will not be approved. Please visit https://make.wordpress.org/themes/handbook/review/required/ to double check required items. Note that when an official review starts your theme may be closed if 5 or more distinct requirements are not met.
  1. If you are in doubt of a comment, or do not want to address something please ask for a confirmation in the ticket, or on the open Slack channel.

#3 @themetracbot
6 months ago

  • Summary changed from THEME: Academic – 0.5 to THEME: Academic – 0.6

Academic - 0.6

A clean, modern, engaging and responsive WordPress education theme ideal for educational institutions and agencies. Features including full width and boxed layout with slider, focused content, slick effects, posts/features/courses showcasing. It is loaded with theme options and provides several features to make user-friendly, interactive and visually stunning website with implementation of all features of latest WordPress like partial refresh and validation. It is compatible with top WordPress plugins such as JetPack and Contact Form 7. A special accent is made on its cross-browser compatibility, mobile friendly design and responsive features.

Theme URL - https://themepalace.com/downloads/academic/
Author URL - https://themepalace.com/

Trac Browser - https://themes.trac.wordpress.org/browser/academic/0.6

SVN - https://themes.svn.wordpress.org/academic/0.6
ZIP - https://wordpress.org/themes/download/academic.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=academic/0.5&new_path=academic/0.6

History:

Ticket Summary Status Resolution Owner
#11598 THEME: Academica - 1.2.2 closed live life.object
#23934 THEME: Academica – 2.0 closed live djrmom
#32914 THEME: Academica – 2.0.1 closed live themetracbot
#34222 THEME: Academic – 0.4 closed not-approved greenshady
#40181 THEME: Academica – 2.0.2 closed live themetracbot
#41231 THEME: Academic – 1.0 closed live juhise

(this ticket)

#41911 THEME: Academica – 2.0.3 closed live themetracbot
#43546 THEME: Academic – 1.1 closed live themetracbot
#43753 THEME: Academic – 1.2 closed live themetracbot
#46798 THEME: Academic – 1.3 closed live themetracbot


https://themes.svn.wordpress.org/academic/0.6/screenshot.png

#4 @themepalace
6 months ago

@joyously

Thank you for your review. Most of the issues are fixed.

@kevinhaig

Thanks for the heads up.

Regards,

Theme Palace

#5 @themetracbot
6 months ago

  • Owner set to shabujames
  • Status changed from new to reviewing

#6 @themepalace
6 months ago

@djrmom

It has already been 3 days that this ticket is assigned. As per the handbook, a reviewer should provide feedbacks within 24hrs after the ticket assigned. Kindly assign a new reviewer to this ticket.

Regards,
Theme Palace

This ticket was mentioned in Slack in #themereview by sachyya. View the logs.


6 months ago

#8 @poena
6 months ago

  • Owner shabujames deleted

#9 @themetracbot
6 months ago

  • Owner set to acmethemes

#10 @acmethemes
6 months ago

Hello @themepalace ,

I am going to review your theme, If you want to update your theme before review, let me know.

Theme reviewer are now allowed to close the ticket if there are 5+ distinct issues. So, make sure there are not such issues. Let me know if you need more time. https://make.wordpress.org/themes/handbook/review/required/

Regards
Acme Themes

#11 @acmethemes
6 months ago

Hello @themepalace ,

Please find the below listed issues, solve them and submit your theme again. If you have any query, you can ask in the ticket or on the open Slack channel #themereview

Required

  • use esc_attr for escaping placeholder and other attributes eg: extras.php Line 62.
  • Use &hellip; instead of ....
  • Hook excerpt_more and excerpt_length should be applied on front end only.
  • File background-01.jpg not found but used in style.css 2859.
  • Remove search-form from add_theme_support( 'html5' ) as you are overriding search form yourself using get_search_form filter.
  • Check academic_simple_breadcrumb, depriciated functions being used.
  • helpers.php line 188 - $homeLink . '/' . $slug['slug'] . '/' - Use appropriate function to fetch URL.
  • social-link.php - Widget title should be passed through widget_title filter with parameters instance and id base. Ref: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/widgets/class-wp-widget-text.php#L48 .
  • Closures / anonymous functions are not available in PHP 5.2 or earlier - Check /inc/widgets/widgets.php line 55. This will give fatal error in PHP 5.2.
  • Unminified css files have wrong path of image and other assets.
  • You may want to check @package and @subpackage of theme files.

Regards,
Acme Themes

#12 @themepalace
6 months ago

Hello @acmethemes

Thank you for taking our ticket for the review and feedbacks. We will get back to you ASAP.

Regards,
Theme Palace

#13 @themetracbot
6 months ago

  • Summary changed from THEME: Academic – 0.6 to THEME: Academic – 0.7

Academic - 0.7

A clean, modern, engaging and responsive WordPress education theme ideal for educational institutions and agencies. Features including full width and boxed layout with slider, focused content, slick effects, posts/features/courses showcasing. It is loaded with theme options and provides several features to make user-friendly, interactive and visually stunning website with implementation of all features of latest WordPress like partial refresh and validation. It is compatible with top WordPress plugins such as JetPack and Contact Form 7. A special accent is made on its cross-browser compatibility, mobile friendly design and responsive features.

Theme URL - https://themepalace.com/downloads/academic/
Author URL - https://themepalace.com/

Trac Browser - https://themes.trac.wordpress.org/browser/academic/0.7

SVN - https://themes.svn.wordpress.org/academic/0.7
ZIP - https://wordpress.org/themes/download/academic.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=academic/0.6&new_path=academic/0.7

History:

Ticket Summary Status Resolution Owner
#11598 THEME: Academica - 1.2.2 closed live life.object
#23934 THEME: Academica – 2.0 closed live djrmom
#32914 THEME: Academica – 2.0.1 closed live themetracbot
#34222 THEME: Academic – 0.4 closed not-approved greenshady
#40181 THEME: Academica – 2.0.2 closed live themetracbot
#41231 THEME: Academic – 1.0 closed live juhise

(this ticket)

#41911 THEME: Academica – 2.0.3 closed live themetracbot
#43546 THEME: Academic – 1.1 closed live themetracbot
#43753 THEME: Academic – 1.2 closed live themetracbot
#46798 THEME: Academic – 1.3 closed live themetracbot


https://themes.svn.wordpress.org/academic/0.7/screenshot.png

#14 @themepalace
6 months ago

Hello @acmethemes ,

Thank you for pointing out those issues. All the above mentioned issues are fixed.

Kindly let us know of any other know issues.

Regards,
Theme Palace

#15 @acmethemes
6 months ago

Hello @themepalace ,

There are still issues remaining.

Required

  • About section undefined notice when page does not have image, check on others section too !!!
  • Console error. lightbox.min.js, Failed to load resource: the server responded with a status of 404 (Not Found).
  • Use &hellip; instead of .... eg, excerpt_more hook.
  • Breadcrumb library license is missing.
  • social-link.php duplicate attribute class line 58.
  • Unminified css files have wrong path of image and other assets.

Please solve all required issues and submit your theme again. If you have any query, you can ask in the ticket or on the open Slack channel #themereview.

Regards,
Acme Themes

#16 @themetracbot
6 months ago

  • Summary changed from THEME: Academic – 0.7 to THEME: Academic – 0.8

Academic - 0.8

A clean, modern, engaging and responsive WordPress education theme ideal for educational institutions and agencies. Features including full width and boxed layout with slider, focused content, slick effects, posts/features/courses showcasing. It is loaded with theme options and provides several features to make user-friendly, interactive and visually stunning website with implementation of all features of latest WordPress like partial refresh and validation. It is compatible with top WordPress plugins such as JetPack and Contact Form 7. A special accent is made on its cross-browser compatibility, mobile friendly design and responsive features.

Theme URL - https://themepalace.com/downloads/academic/
Author URL - https://themepalace.com/

Trac Browser - https://themes.trac.wordpress.org/browser/academic/0.8

SVN - https://themes.svn.wordpress.org/academic/0.8
ZIP - https://wordpress.org/themes/download/academic.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=academic/0.7&new_path=academic/0.8

History:

Ticket Summary Status Resolution Owner
#11598 THEME: Academica - 1.2.2 closed live life.object
#23934 THEME: Academica – 2.0 closed live djrmom
#32914 THEME: Academica – 2.0.1 closed live themetracbot
#34222 THEME: Academic – 0.4 closed not-approved greenshady
#40181 THEME: Academica – 2.0.2 closed live themetracbot
#41231 THEME: Academic – 1.0 closed live juhise

(this ticket)

#41911 THEME: Academica – 2.0.3 closed live themetracbot
#43546 THEME: Academic – 1.1 closed live themetracbot
#43753 THEME: Academic – 1.2 closed live themetracbot
#46798 THEME: Academic – 1.3 closed live themetracbot


https://themes.svn.wordpress.org/academic/0.8/screenshot.png

#17 @themepalace
6 months ago

Hello @acmethemes

All the issues mentioned are fixed. Kindly let us know of any other known issues.

Regarding recommendation, since unminified files will be loaded only while developing, so we will let it be as it is for now.

Regards,
Theme Palace

#18 @joyously
6 months ago

Unminified css files have wrong path of image and other assets.

That should not be labeled as Recommendation. It is required that the unminified version be the actual source. The two must match (except for whitespace).

#19 @themetracbot
6 months ago

  • Summary changed from THEME: Academic – 0.8 to THEME: Academic – 0.9

Academic - 0.9

A clean, modern, engaging and responsive WordPress education theme ideal for educational institutions and agencies. Features including full width and boxed layout with slider, focused content, slick effects, posts/features/courses showcasing. It is loaded with theme options and provides several features to make user-friendly, interactive and visually stunning website with implementation of all features of latest WordPress like partial refresh and validation. It is compatible with top WordPress plugins such as JetPack and Contact Form 7. A special accent is made on its cross-browser compatibility, mobile friendly design and responsive features.

Theme URL - https://themepalace.com/downloads/academic/
Author URL - https://themepalace.com/

Trac Browser - https://themes.trac.wordpress.org/browser/academic/0.9

SVN - https://themes.svn.wordpress.org/academic/0.9
ZIP - https://wordpress.org/themes/download/academic.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=academic/0.8&new_path=academic/0.9

History:

Ticket Summary Status Resolution Owner
#11598 THEME: Academica - 1.2.2 closed live life.object
#23934 THEME: Academica – 2.0 closed live djrmom
#32914 THEME: Academica – 2.0.1 closed live themetracbot
#34222 THEME: Academic – 0.4 closed not-approved greenshady
#40181 THEME: Academica – 2.0.2 closed live themetracbot
#41231 THEME: Academic – 1.0 closed live juhise

(this ticket)

#41911 THEME: Academica – 2.0.3 closed live themetracbot
#43546 THEME: Academic – 1.1 closed live themetracbot
#43753 THEME: Academic – 1.2 closed live themetracbot
#46798 THEME: Academic – 1.3 closed live themetracbot


https://themes.svn.wordpress.org/academic/0.9/screenshot.png

#20 @themepalace
6 months ago

Hello @acmethemes

We have updated the theme with correct file path for assets on unminified version.

Kindly have a review and let us know.

Regards,
Theme Palace

#21 @acmethemes
6 months ago

  • Status changed from reviewing to approved

@joyously thanks!

@themepalace ,

No More Issues Found, I am approving your theme.
Please wait for the final review. You can check the queue here https://themes.trac.wordpress.org/report/24

Best Regards,
Acme Themes

#22 @juhise
5 months ago

@themepalace

I will do the final review, will update you soon.

Best Regards,
Juhi

#23 @juhise
5 months ago

  • Status changed from approved to reopened

@themepalace

I did the final review, theme looks good. Please fix some minor issues:

REQUIRED

  • Please mention license information for all images
  • First category blog and second category blog not using respective Titles 'category_blog_two_title' => esc_html__( 'First Category Blog', 'academic' ), 'category_blog_three_title' => esc_html__( 'Second Category Blog', 'academic' ),
  • Newsletter, contact info and schedule_post_num defaults are not being used L85 -L 100, remove these.


  • Need escaping 'pro_url' => 'https://themepalace.com/downloads/academic-pro/'

Best Regards,
Juhi

#24 @themetracbot
5 months ago

  • Summary changed from THEME: Academic – 0.9 to THEME: Academic – 1.0

Academic - 1.0

A clean, modern, engaging and responsive WordPress education theme ideal for educational institutions and agencies. Features including full width and boxed layout with slider, focused content, slick effects, posts/features/courses showcasing. It is loaded with theme options and provides several features to make user-friendly, interactive and visually stunning website with implementation of all features of latest WordPress like partial refresh and validation. It is compatible with top WordPress plugins such as JetPack and Contact Form 7. A special accent is made on its cross-browser compatibility, mobile friendly design and responsive features.

Theme URL - https://themepalace.com/downloads/academic/
Author URL - https://themepalace.com/

Trac Browser - https://themes.trac.wordpress.org/browser/academic/1.0

SVN - https://themes.svn.wordpress.org/academic/1.0
ZIP - https://wordpress.org/themes/download/academic.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=academic/0.9&new_path=academic/1.0

History:

Ticket Summary Status Resolution Owner
#11598 THEME: Academica - 1.2.2 closed live life.object
#23934 THEME: Academica – 2.0 closed live djrmom
#32914 THEME: Academica – 2.0.1 closed live themetracbot
#34222 THEME: Academic – 0.4 closed not-approved greenshady
#40181 THEME: Academica – 2.0.2 closed live themetracbot
#41231 THEME: Academic – 1.0 closed live juhise

(this ticket)

#41911 THEME: Academica – 2.0.3 closed live themetracbot
#43546 THEME: Academic – 1.1 closed live themetracbot
#43753 THEME: Academic – 1.2 closed live themetracbot
#46798 THEME: Academic – 1.3 closed live themetracbot


https://themes.svn.wordpress.org/academic/1.0/screenshot.png

#25 @themepalace
5 months ago

Hello @juhise

Thank you for taking the ticket and the review.

Please mention license information for all images
The license informations have been provided.

Custom-header tag is missing in style.css, The theme tags in style.css and description must match what the theme actually does in respect to functionality and design. Don’t use more than 3 subject tags https://make.wordpress.org/themes/handbook/review/required/theme-tags/
custom-header tag is added in both readme and style.css. Also subject tag unrelated has been removed.

First category blog and second category blog not using respective Titles 'category_blog_two_title' => esc_html( 'First Category Blog', 'academic' ), 'category_blog_three_title' => esc_html( 'Second Category Blog', 'academic' ),
Respective titles are being used on the category blogs.

Newsletter, contact info and schedule_post_num defaults are not being used L85 -L 100, remove these.
All the unused defaults are removed.

Need escaping 'pro_url' => 'https://themepalace.com/downloads/academic-pro/'
The URL is now escaped.

Regards,
Theme Palace

#26 @juhise
5 months ago

  • Owner changed from acmethemes to juhise
  • Status changed from reopened to reviewing

Hey @themepalace,

Thanks for the fixing issues.

Theme looks good to me. Congratulations, making your theme live.

It may take some time to show up in the directory.

Best Regards,
Juhi

#27 @juhise
5 months ago

  • Resolution set to live
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.