WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 7 months ago

#41406 closed theme (not-approved)

THEME: ElementorPress – 1.0.0

Reported by: ramiy Owned by: rabmalin
Priority: new theme Keywords: theme-elementorpress accessibility-ready
Cc: r_a_m_i@…

Description

ElementorPress - 1.0.0

Lightweight WordPress theme that helps you create high-end, pixel perfect websites using “Elementor” – an advanced frontend drag & drop page builder.

Theme URL - https://wordpress.org/themes/elementorpress/
Author URL - https://GenerateWP.com/

Trac Browser - https://themes.trac.wordpress.org/browser/elementorpress/1.0.0

SVN - https://themes.svn.wordpress.org/elementorpress/1.0.0
ZIP - https://wordpress.org/themes/download/elementorpress.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#41406 THEME: ElementorPress – 1.0.0 closed not-approved rabmalin

(this ticket)


https://themes.svn.wordpress.org/elementorpress/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: Tags: is either empty or missing in style.css header.

Change History (5)

#1 @ramiy
8 months ago

Hi,
This theme is built to be used with the "Elementor" page builder.

The huge Elementor community needs a simple full-width theme that has not post elements. A lightweight empty theme.

All the elements will be add using Elementor widgets and custom widgets like Press Elements.

The theme doesn't need a custom background and a custom header, those elements are built within the page builder. The builder allows the user to define backgrounds per page.

As for the the editor style, the page builder replaces the editor. The regular post editor is not in use. That is why this theme does not have a css file for the editor.

And the final recommendation seems wrong, the style.css header has Tags:.

Last edited 8 months ago by ramiy (previous) (diff)

#2 @joyously
7 months ago

Here is some user feedback to consider before your review.

  • Theme URI is optional, but it cannot be wordpress.org. That is for default themes only.
  • See Proper Copyright/License Attribution for Themes to list all resources used (scripts, css, fonts, images).
  • The screenshot is larger than everything else (over 1meg). Please reduce the file size of it.
  • Need to output pingback <link>. (conditional on singular and pings_open)
  • The "Widget Area" needs a better description for when and where it is output. (head, side, foot?)
  • There is no call to output the sidebar.
  • Two menus are registered, but neither are output. The tag custom-menu cannot be listed if the theme doesn't do it. And it's extremely difficult to get around a site without a menu.
  • Theme is tagged featured-images, but does not output them.
  • Theme is tagged theme-options, but does not provide any.
  • Theme is calling load_theme_textdomain() with a folder that does not exist. (but I saw no error)
  • If you want to use the same template file for posts and pages, rename single.php to singular.php. Right now, the Page is displayed with index.php, so it shows no comments. Static Pages should show comments and page links.
  • There are no post or page titles output.
  • The archive pages have only one <article> tag with all output in it, even the pagination. The search.php and index.php are identical, with only one <article> tag and no pagination. There is a case left unhandled: no matches for the search and no posts for index.
  • Search results work much better as excerpts, so the user can see where the matches are instead of a flood of mostly non-matching content.
  • Formatting:
    • blockquote looks the same as <cite> and <em>, in fact it can contain those tags, but you wouldn't be able to tell
    • The bullets and numbers for lists are cut off by the left edge of the window.
    • <q> tag is unstyled (default removed by reset)
    • class alignleft is defined, but img.alignleft overrides it with float:none. Images are the thing most needing the float styling. Remove the rule for float:none.
    • Floats are not being cleared properly after the content area. (and there is no "content area")
  • Themes should support the gallery default of 3 columns.
  • Theme shows a totally blank page for 404.

Please read the guidelines and use the theme test data as described here, without the Elementor plugin. Review tickets can be closed for having 5 or more required fix issues. Themes must work without plugins.

#3 @kevinhaig
7 months ago

  • Keywords changed from theme-elementorpress, accessibility-ready to theme-elementorpress accessibility-ready

Note to Author

  1. The above preview by @joyously is not an official review. You must still wait to get to the top of the review queue before an official review will begin.
  1. Many of the concerns above relate to results from Theme Unit Test and you should always test your theme with that package. However please note that many of the comments are considered recommended. Recommended comments DO NOT have to be addressed for theme approval. In many cases it is good advice, but the decision to address those issues is yours.
  1. There may be some comment items that are required. Required items must be addressed or the theme will not be approved. Please visit https://make.wordpress.org/themes/handbook/review/required/ to double check required items. Note that when an official review starts your theme may be closed if 5 or more distinct requirements are not met.
  1. If you are in doubt of a comment, or do not want to address something please ask for a confirmation in the ticket, or on the open Slack channel.
  1. If I get a chance I will take a look later and split out the above comments between Requirements and Recommended as @joyously should be doing :(

#4 @rabmalin
7 months ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#5 @rabmalin
7 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello,

Your theme has been reviewed against this Theme Review Guideline.

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues. This is part of our long term goals to improve the theme quality and shorten the queues. You can read more about this change here: https://make.wordpress.org/themes.

Please do not get discouraged by the ticket being closed. We want you to resubmit your theme, but we do ask that you spend more time making sure that your theme meets all the requirements. You can upload your updated theme here: https://wordpress.org/themes/upload/

Because of the large number of themes waiting for review, we might not be able to follow up immediately. We will review your update when your theme reaches the top of the review queue.

Issues

  • REQUIRED: Theme URL is invalid. https://make.wordpress.org/themes/handbook/review/required/#selling-credits-and-links
  • REQUIRED: Screenshot is wrong size! Detected: 1903x957px. Maximum allowed size is 1200x900px. Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
  • REQUIRED: Custom Logo support declared but not implemented.
  • REQUIRED: post-thumbnails support declared but not implemented.
  • REQUIRED: Menu registered but not implemented.
  • REQUIRED: Please use https://developer.wordpress.org/reference/functions/post_class/ properly as it may break plugins if not implemented.
  • REQUIRED: Pagination or navigation is needed in archive templates.
  • REQUIRED: Update readme file to keep credits and license info of all third party resources (like scripts, styles, libraries, images, etc). Sample format: https://make.wordpress.org/themes/2015/04/29/a-revised-readme/
  • REQUIRED: In readme file, please declare your theme copyright in following format.
    Fred WordPress Theme, Copyright 2012 Joe Smith
    Fred is distributed under the terms of the GNU GPL
    
  • REQUIRED: File has mixed line endings; this may cause incorrect results - functions.php file has Windows line ending whereas other files has MACOS. Please make it uniform.
  • REQUIRED: Most Important - Theme should work in decent manner even without plugins installed and activated.
Note: See TracTickets for help on using tickets.