WordPress.org

Make WordPress Themes

Attachments (1)

post-font.jpg (74.7 KB) - added by garinungkadol 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 jquindlen3 years ago

Submitted for your approval you will find version 1.1.1 of the "wpStoreCart Default" theme. The only changes made that are different from the 1.1.0 version previously submitted, is that I made the changes required from this ticket:
http://themes.trac.wordpress.org/ticket/4050

I have changed the footer title tag to wpStoreCart

I have changed the Theme URI to the theme's documentation, located here:
http://wpstorecart.com/documentation/wpstorecart-theme/

Thanks for taking the time to consider this theme, looking forward to your reply ;)

comment:2 jquindlen3 years ago

I know you all are certainly very busy, but please do let me know if there's anything I can do to help or if there's still things you need me to do. Again, not trying to be impatient, as I realize the workload there is probably neverending, but just thought I'd poke my head in here and see if I can be of assistance or whatnot. Thanks again!

comment:3 garinungkadol3 years ago

  • Owner set to garinungkadol
  • Status changed from new to assigned

garinungkadol3 years ago

comment:4 garinungkadol3 years ago


THEME REVIEW RESULTS
Below are the theme review results. Anything marked FAIL needs to be addressed. Anything marked REQUIRED is needed to be fixed while anything marked RECOMMENDED is strongly advised. Other points may be raised purely for information.

There are too many coding issues to warrant approval of this theme at this time.

RECOMMENDATION: NOT-APPROVED


Theme Check Results:

  • RECOMMENDED: Text domain problems in sidebar.php. You have not included a text domain!
    Line 82: <div class='title'><?php _e('Categories'); ?></div>
    
  • RECOMMENDED: Text domain problems in functions.php. The twentyten text domain is being used!
    Line 187: <p><?php _e( 'Pingback:', 'twentyten' ); ?> <?php comment_author_link(); ?><?php edi
    
  • RECOMMENDED: Text domain problems in functions.php. The twentyten text domain is being used!
    Line 170: printf( __( '%1$s at %2$s', 'twentyten' ), get_comment_date(),  get_comment_time() ); ?></a><?php edit_comment_link( __( '(Edit)', 'twentyten' ), ' ' );
    
Line 187: <p><?php _e( 'Pingback:', 'twentyten' ); ?> <?php comment_author_link(); ?><?php edit_comment_link( __( '(Edit)', 'twentyten' ), ' ' ); ?></p>
  • RECOMMENDED: Text domain problems in functions.php. The twentyten text domain is being used!
    Line 170: printf( __( '%1$s at %2$s', 'twentyten' ), get_comment_date(),  get_comment_time() 
    
  • RECOMMENDED: Text domain problems in functions.php. The twentyten text domain is being used!
    Line 163: <em class='comment-awaiting-moderation'><?php _e( 'Your comment is awaiting moderation.', 'twentyten' ); ?></em>
    
  • RECOMMENDED: Text domain problems in functions.php. The twentyten text domain is being used!
    Line 160: <?php printf( __( '%s <span class='says'>says:</span>', 'twentyten' ), sprintf( '<cite cl
    
  • RECOMMENDED: Text domain problems in comments.php. The twentyten text domain is being used!
    Line 72: <p class='nocomments'><?php _e( '<!-- Comments are closed. -->', 'twentyten' ); ?></p>
    
  • RECOMMENDED: Text domain problems in comments.php. The twentyten text domain is being used!
    Line 18: <p class='nopassword'><?php _e( 'This post is password protected. Enter the password to view any commen
    
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( 'post-thumbnails' )in the functions.php file.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to add_custom_image_header was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_custom_background() was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: get_bloginfo(template_directory) was found in the file functions.php. Use get_template_directory_uri() instead.
  • RECOMMENDED: get_bloginfo(stylesheet_directory) was found in the file functions.php. Use get_stylesheet_directory_uri() instead.
  • RECOMMENDED: bloginfo(template_directory) was found in the file index.php. Use get_template_directory_uri() instead.
  • RECOMMENDED: bloginfo(template_directory) was found in the file header.php. Use get_template_directory_uri() instead.

Deprecated Calls:
File: wp-admin/upgrade-functions.php
Used in wp-content/themes/wpstorecart-default/functions.php on line 37.
Use wp-admin/includes/upgrade.php instead.
Deprecated in version 2.5.


Debugger results: FAIL
-- Debug: Undefined offset: 0 on line 610 of C:\xampp\htdocs\wpthemes\wp-content\themes\wpStoreCartTheme\functions.php

On store page:
-- Debug: Undefined variable: usetext on line 238 of C:\xampp\htdocs\wordpress\themereview\wp-content\themes\wpStoreCartTheme\index.php
-- Debug: Undefined variable: usetext on line 238 of C:\xampp\htdocs\wordpress\themereview\wp-content\themes\wpStoreCartTheme\index.php
-- Debug: Undefined variable: usetext on line 238 of C:\xampp\htdocs\wordpress\themereview\wp-content\themes\wpStoreCartTheme\index.php


Test data results:
Single Post View

  • REQUIRED: Posts with comments closed should display some kind of "Comments are closed" mesage. This refers to posts only and not pages.
  • RECOMMENDATION: More line-height or padding will improve the readability of text

Visual issues / functionality / browser checks: FAIL

  • Upon theme activation, a blank page is returned.
  • Post Slider - The image uploader does not check for maximum dimensions when uploading images so even large images will be uploaded. Either resize the image on upload or note the maximum dimensions in the readme.txt
  • Consider changing the font of the post content so that it matches with the rest of your layout. See post-font.jpg.
  • There seems to a missing <div> in your theme settings page

Appearance >> Theme Settings >> Display >> Main Page
"Content on Main Page"
-- The select option "List all categories (Ascending)" results in broken images displayed on the store page.
-- The select option "List newest products" still shows the first set of posts rather than the newest products.

"Display titles on Main Page?"
-- Titles still appears on the store page no matter what the setting.

"Display small descriptions on Main Page?"
-- No description appears on the store page even when setting is set to "Yes". By changing this setting to "No", the product title is not displayed on the store page.

"Display the prices of products?"
-- No price is displayed even when setting is "Yes".

"Display Type"
-- The product display is the same for "list" and "grid" selections.

Appearance >> Theme Settings >> Shipping

  • Upon saving the options, I am redirected to the Display options page

"Flat Rate Shipping"
-- The select option "Each product has it's own flat rate amount" does not display the product's flat rate for shipping. The value is always 0.


Validation: PASS
CSS: PASS

HTML: PASS


Code Quality:

  • REQUIRED: Themes must use edit_theme_options as the capability when calling the add_theme_page function. This theme is using activate_plugins instead on Line 196 of functions.php
  • REQUIRED: wp_head() should be placed directly before </head>
  • REQUIRED: Custom scripts should not be hard-coded into the head tags. They should be registered and enqueued using wp_register_script, wp_enqueue_script and hooked into wp_head.
  • REQUIRED: Themes should not place hard-coded links to rss feeds in header.php. Since you have provided theme support for automatic feed links, please remove Lines 54 - 56
  • REQUIRED: Since you are not providing translation support, please remove all references to the textdomain slug 'twentyten' in comments.php
  • Pagination is not working properly when Pretty Permalinks are turned on. Expected link for page 2 is: http://domain.com/store/page/2. Instead what is appearing is http://domain.com/store/comment-page-2.
  • Template files are intended primarily for presentation and PHP code belongs inside functions.php. All code from Lines 148 to 256 of index.php should be placed in separate functions and called inside index.php.
  • Your comments.php template is referencing the Twenty Ten theme in comments.php. Please change the references to your theme's name

Other notes


Information
If there are any issues once resolved, please re-submit your Theme using the uploader tool on wordpress.org/extend/themes, and a new Trac ticket will be generated.
Note:

  • Re-submitted Themes are given review priority over new Themes.

You can use the following tools to recreate the issues raised above if any have been:

Themes should be reviewed using define('WP_DEBUG', true); in wp-config.php
You can also view the Theme Review page.

Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:

  • 1) Leave a comment on this ticket
  • 2) Email the theme-reviewers email list
  • 3) Use the #wordpress-themes channel on irc.freenode.net

comment:5 cais3 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

Resolved as "not-approved" per reviewers comments.

Last edited 3 years ago by cais (previous) (diff)
Note: See TracTickets for help on using tickets.