WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 6 months ago

Last modified 6 months ago

#41588 closed theme (live)

THEME: Blogostrap – 1.2.4

Reported by: nsthemes Owned by: poena
Priority: previously reviewed Keywords: theme-blogostrap
Cc: info@…

Description

Blogostrap - 1.2.0

Blogostrap is a simple clean WordPress blog. The horizontal image header with a left sidebar is beauty for website and blog. It has a theme option to customize this theme as you like.

Theme URL -
Author URL - http://www.nsthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/blogostrap/1.2.0

SVN - https://themes.svn.wordpress.org/blogostrap/1.2.0
ZIP - https://wordpress.org/themes/download/blogostrap.1.2.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blogostrap/1.1.0&new_path=blogostrap/1.2.0

History:

Ticket Summary Status Resolution Owner
#36207 THEME: Blogostrap – 1.0 closed not-approved poena
#39404 THEME: Blogostrap – 1.1.0 closed not-approved acosmin
#41588 THEME: Blogostrap – 1.2.4 closed live poena

(this ticket)

#43264 THEME: Blogostrap – 1.2.5 closed live themetracbot
#43716 THEME: Blogostrap – 1.2.6 closed live themetracbot
#44302 THEME: Blogostrap – 1.2.7 closed live themetracbot


https://themes.svn.wordpress.org/blogostrap/1.2.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

Attachments (1)

blogostrap.zip (1.3 MB) - added by nsthemes 6 months ago.
Fix some bug, please use this zip for review.

Download all attachments as: .zip

Change History (23)

This ticket was mentioned in Slack in #themereview by nsthemes. View the logs.


6 months ago

@nsthemes
6 months ago

Fix some bug, please use this zip for review.

#2 @themetracbot
6 months ago

  • Summary changed from THEME: Blogostrap – 1.2.0 to THEME: Blogostrap – 1.2.1

Blogostrap - 1.2.1

Blogostrap is a simple clean WordPress blog. The horizontal image header with a left sidebar is beauty for website and blog. It has a theme option to customize this theme as you like.

Theme URL -
Author URL - http://www.nsthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/blogostrap/1.2.1

SVN - https://themes.svn.wordpress.org/blogostrap/1.2.1
ZIP - https://wordpress.org/themes/download/blogostrap.1.2.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blogostrap/1.2.0&new_path=blogostrap/1.2.1

History:

Ticket Summary Status Resolution Owner
#36207 THEME: Blogostrap – 1.0 closed not-approved poena
#39404 THEME: Blogostrap – 1.1.0 closed not-approved acosmin
#41588 THEME: Blogostrap – 1.2.4 closed live poena

(this ticket)

#43264 THEME: Blogostrap – 1.2.5 closed live themetracbot
#43716 THEME: Blogostrap – 1.2.6 closed live themetracbot
#44302 THEME: Blogostrap – 1.2.7 closed live themetracbot


https://themes.svn.wordpress.org/blogostrap/1.2.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#3 @joyously
6 months ago

Here is some user feedback to consider before your review.

  • The title for the recommended plugins page is "Install Required Plugins". (should not say Required)
  • The menu needs to have a fallback for when no menu is selected. Use the default value of fallback_cb parameter of wp_nav_menu() instead of setting it to .
  • Any restrictions or limitations (such as menu depth=2) need to be documented for the user.
  • Any copyright statements on the front end should display the user's copyright, not the theme author's copyright.
  • The theme name in the footer links to wordpress.org.
  • Remove the CSS to center the user content. body {text-align:center} (text alignment is inherited)
  • blockquote is styled as italic, making it difficult to distinguish nested <em> and <cite> tags.
  • tables could use a little padding
  • There is always a big white space above the content. The homeArchiveHeder class is output with an empty img tag.
  • Post titles on archive pages are not links. (It feels like it doesn't work right.)
  • The alignleft class needs some right margin.
  • A captioned image with class aligncenter is not centered. (100% width)
  • A captioned image with class alignleft is not having the text wrap on the right. (100% width)
  • A captioned image with class alignright is not having the text wrap on the left. (100% width)
  • Floats are not being cleared properly after the content area.
  • The comments are missing the author website links, comment date, link to comment anchor (usually put on the date), Edit links.
  • Post navigation links would be nice.
  • The theme needs to use the_excerpt() instead of echo wp_trim_words( get_the_content(), 60, '...' ); so that user defined excerpts are used and the correct filters are run (for plugins and child themes).
  • Search results should not show the author and date of static Pages.
  • The 404 page is not very helpful and has incorrect grammar. Could it have a sidebar, please?
  • There is something wrong with the print styles. Only the first page of a long Page shows text, then the comment form and then 3 blank pages.
  • In Customizer, the Background Color needs a default value.
  • Theme layout is not responsive to window size. Small screens get a horizontal scrollbar.

Please read the guidelines and use the theme test data as described here. Review tickets can be closed for having 5 or more required fix issues.

#4 @nsthemes
6 months ago

Thank you for your comments!

Sorry but we don't understand:

  • Floats are not being cleared properly after the content area.
  • Post navigation links would be nice.

#5 @joyously
6 months ago

  • For floats, you have to remember that you don't know what the user will put in the content area. The very last thing could be floated, and it should not affect the theme's layout. So in this screenshot, I am in the Customizer for a page that has a floating thumbnail as the last thing. You can see that it is not handled properly two ways. First, the category and tags are wrapped next to the image. Second, I have applied a user style (Additional CSS) to color the post content yellow, and the image does not have the yellow background because the parent container of a float does not know its height unless it is cleared. The best way to handle this is to output a clearing div immediately following the_content(). https://s22.postimg.org/imt1em0pt/Customize-content-with-float.jpg
  • For post navigation, it is not required, but very useful to have links on the single post page to the next and previous posts. See the_post_navigation().

#6 @kevinhaig
6 months ago

Note to Author

  1. The above preview by @joyously is not an official review. You must still wait to get to the top of the review queue before an official review will begin.
  1. Many of the concerns above relate to results from Theme Unit Test and you should always test your theme with that package. However please note that many of the comments are considered recommended. Recommended comments DO NOT have to be addressed for theme approval. In many cases it is good advice, but the decision to address those issues is yours.
  1. There may be some comment items that are required. Required items must be addressed or the theme will not be approved. Please visit https://make.wordpress.org/themes/handbook/review/required/ to double check required items. Note that when an official review starts your theme may be closed if 5 or more distinct requirements are not met.
  1. If you are in doubt of a comment, or do not want to address something please ask for a confirmation in the ticket, or on the open Slack channel.
  1. If I get a chance I will take a look later and split out the above comments between Requirements and Recommended as @joyously should be doing :(

#7 @themetracbot
6 months ago

  • Owner set to zagorakis
  • Status changed from new to reviewing

#8 in reply to: ↑ description @zagorakis
6 months ago

Hi @nsthemes

Today is contributor day in Belgrade so I'm going to review your theme now.

Last edited 6 months ago by zagorakis (previous) (diff)

#9 @zagorakis
6 months ago

Hi @nsthemes

We have only 2 hours for review so there are comments:

  • In style.css there is post-format, but in the functions.php add_theme_support( 'post-formats' ) is missing.

(link: https://make.wordpress.org/themes/handbook/review/required/theme-tags/)

  • For Page atribute in edit page you need to add Template options.

I hope someone else will finish review of your theme.

Best

#10 @nsthemes
6 months ago

Sorry we don't understand:
-For Page atribute in edit page you need to add Template options.

#11 @themetracbot
6 months ago

  • Summary changed from THEME: Blogostrap – 1.2.1 to THEME: Blogostrap – 1.2.2

Blogostrap - 1.2.2

Blogostrap is a simple clean WordPress blog. The horizontal image header with a left sidebar is beauty for website and blog. It has a theme option to customize this theme as you like.

Theme URL -
Author URL - http://www.nsthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/blogostrap/1.2.2

SVN - https://themes.svn.wordpress.org/blogostrap/1.2.2
ZIP - https://wordpress.org/themes/download/blogostrap.1.2.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blogostrap/1.2.1&new_path=blogostrap/1.2.2

History:

Ticket Summary Status Resolution Owner
#36207 THEME: Blogostrap – 1.0 closed not-approved poena
#39404 THEME: Blogostrap – 1.1.0 closed not-approved acosmin
#41588 THEME: Blogostrap – 1.2.4 closed live poena

(this ticket)

#43264 THEME: Blogostrap – 1.2.5 closed live themetracbot
#43716 THEME: Blogostrap – 1.2.6 closed live themetracbot
#44302 THEME: Blogostrap – 1.2.7 closed live themetracbot


https://themes.svn.wordpress.org/blogostrap/1.2.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#12 @themetracbot
6 months ago

  • Summary changed from THEME: Blogostrap – 1.2.2 to THEME: Blogostrap – 1.2.3

Blogostrap - 1.2.3

Blogostrap is a simple clean WordPress blog. The horizontal image header with a left sidebar is beauty for website and blog. It has a theme option to customize this theme as you like.

Theme URL -
Author URL - http://www.nsthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/blogostrap/1.2.3

SVN - https://themes.svn.wordpress.org/blogostrap/1.2.3
ZIP - https://wordpress.org/themes/download/blogostrap.1.2.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blogostrap/1.2.2&new_path=blogostrap/1.2.3

History:

Ticket Summary Status Resolution Owner
#36207 THEME: Blogostrap – 1.0 closed not-approved poena
#39404 THEME: Blogostrap – 1.1.0 closed not-approved acosmin
#41588 THEME: Blogostrap – 1.2.4 closed live poena

(this ticket)

#43264 THEME: Blogostrap – 1.2.5 closed live themetracbot
#43716 THEME: Blogostrap – 1.2.6 closed live themetracbot
#44302 THEME: Blogostrap – 1.2.7 closed live themetracbot


https://themes.svn.wordpress.org/blogostrap/1.2.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#13 @nsthemes
6 months ago

Thaks you @joyously for your feedback!
Many thanks to @zagorakis for your review!
We just uploaded the new version updated.

This ticket was mentioned in Slack in #themereview by nsthemes. View the logs.


6 months ago

This ticket was mentioned in Slack in #themereview by zzap. View the logs.


6 months ago

#16 @poena
6 months ago

  • Owner changed from zagorakis to poena

#17 @poena
6 months ago

Hi!
Sorry for the wait, I will look through your theme today.

#18 @poena
6 months ago

Hi again!
I have reviewed version 1.2.3 and there are lots of improvements since I last saw the theme, nice job.
There are some problems left that needs to be solved.

Required

When I activate the theme I see the following php notices:

Notice: Trying to get property of non-object in themes\blogostrap\inc\class\blogostrap-walker-class.php on line 50
Notice: Trying to get property of non-object in themes\blogostrap\inc\class\blogostrap-walker-class.php on line 52
Notice: Trying to get property of non-object in themes\blogostrap\inc\class\blogostrap-walker-class.php on line 54
Notice: Trying to get property of non-object in themes\blogostrap\inc\class\blogostrap-walker-class.php on line 55

FILE: blogostrap\functions.php
1 error
Line: 108 ERROR Overriding WordPress globals is prohibited

There is a lot of text in the theme that is missing translation functions and text domain.
To find text that is not translation ready you need to open and check each file.

wp_enqueue_script( 'comment-reply' ); should be added conditionally:

if ( is_singular() && comments_open() && get_option( 'thread_comments' ) ) {
	wp_enqueue_script( 'comment-reply' );
}

This handle needs to be prefixed: font-google-apis.

The header image option and the social links needs to be escaped with esc_url().

strip_tags is not enough to sanitize the widget data before saving. Use sanitize_text_field and sanitize_textarea_field respectively.


Please reply within 7 days, or your ticket may be closed due to inactivity

#19 @themetracbot
6 months ago

  • Summary changed from THEME: Blogostrap – 1.2.3 to THEME: Blogostrap – 1.2.4

Blogostrap - 1.2.4

Blogostrap is a simple clean WordPress blog. The horizontal image header with a left sidebar is beauty for website and blog. It has a theme option to customize this theme as you like.

Theme URL -
Author URL - http://www.nsthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/blogostrap/1.2.4

SVN - https://themes.svn.wordpress.org/blogostrap/1.2.4
ZIP - https://wordpress.org/themes/download/blogostrap.1.2.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blogostrap/1.2.3&new_path=blogostrap/1.2.4

History:

Ticket Summary Status Resolution Owner
#36207 THEME: Blogostrap – 1.0 closed not-approved poena
#39404 THEME: Blogostrap – 1.1.0 closed not-approved acosmin
#41588 THEME: Blogostrap – 1.2.4 closed live poena

(this ticket)

#43264 THEME: Blogostrap – 1.2.5 closed live themetracbot
#43716 THEME: Blogostrap – 1.2.6 closed live themetracbot
#44302 THEME: Blogostrap – 1.2.7 closed live themetracbot


https://themes.svn.wordpress.org/blogostrap/1.2.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#20 @nsthemes
6 months ago

Hello @poena , thank you for your time and thanks a lot for this review!

We updated with this fix.
We hope everything is well now.

#21 @poena
6 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi
Your theme should be live shortly.

Most of the problems have been fixed, please add the remaining missing translation functions for
the_tags('TAG: ', ', ' , ''); in your next update.

#22 @nsthemes
6 months ago

Thank you for your review @poena !

We update and fix it!

Last edited 6 months ago by nsthemes (previous) (diff)
Note: See TracTickets for help on using tickets.