WordPress.org

Make WordPress Themes

Opened 7 months ago

Closed 5 months ago

Last modified 5 months ago

#41635 closed theme (not-approved)

THEME: Constra – 1.0.1

Reported by: navthemes Owned by: shrimp2t
Priority: new theme Keywords: theme-constra
Cc: jiteshjk@…

Description

Constra - 1.0

This theme can be used to create any contruction website.

Theme URL - http://www.navthemes.com/construction-multipurpose-wordpress-theme
Author URL - http://www.navthemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/constra/1.0

SVN - https://themes.svn.wordpress.org/constra/1.0
ZIP - https://wordpress.org/themes/download/constra.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#41635 THEME: Constra – 1.0.1 closed not-approved shrimp2t

(this ticket)

#43447 THEME: Constra – 1.0.2 closed not-approved Mirucon


https://themes.svn.wordpress.org/constra/1.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Tags: is either empty or missing in style.css header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are construction, kirki

Change History (13)

#1 @Mahesh901122
6 months ago

Hi @navthemes,

Your theme has only 1 tag one-column in style.css.


E.g. Tags: one-column

Add missing tags from the available tag list from https://make.wordpress.org/themes/handbook/review/required/theme-tags/#post-2553

#2 @navthemes
6 months ago

Hello Mahesh.

Yes i will update new version today. thanks for review.

#3 @navthemes
6 months ago

Hello Mahesh, i will update theme today.

#4 @themetracbot
6 months ago

  • Summary changed from THEME: Constra – 1.0 to THEME: Constra – 1.0.1

Constra - 1.0.1

Constra themes

Theme URL - https://navthemes.com/contsra-construction-theme
Author URL - https://navthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/constra/1.0.1

SVN - https://themes.svn.wordpress.org/constra/1.0.1
ZIP - https://wordpress.org/themes/download/constra.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=constra/1.0&new_path=constra/1.0.1

History:

Ticket Summary Status Resolution Owner
#41635 THEME: Constra – 1.0.1 closed not-approved shrimp2t

(this ticket)

#43447 THEME: Constra – 1.0.2 closed not-approved Mirucon


https://themes.svn.wordpress.org/constra/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Found a translation function that is missing a text-domain. Function _e, with the arguments 'constra'
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are constra, kirki

#5 @joyously
5 months ago

Here is some user feedback to consider before your review.

  • Your theme zip file is 7.5Meg! (about the same as all of WordPress) Why such a big file?
  • WARNING: wp-admin/admin-header.php:9 - Cannot modify header information - headers already sent by (output started at wp-content/themes/constra/functions.php:14)
  • Javascript TypeError: $ is not a function wp-content/themes/constra/assets/custom/js/footer.js?ver=4.7.4 line 76
  • Placeholder content should not be shown to site visitors. (front page) It's odd, the comments for my static home Page are shown, but the content for that page is not shown. The default values should be to not show the extra sections.
  • The menu needs to have a fallback for when no menu is selected. Remove the if statement around it.
  • Once I select a menu, it is not shown on a small screen (unless it's hidden by the admin bar).
  • The featured image is distorted. Use img {height:auto} to fix.
  • At the bottom of the category page, there are 11 post titles for no reason. They are the most recent posts, not the ones in this category. The titles are cut off at the left edge. I have my "Show at most" option set to 5, so this really makes no sense. I see it is on the Blog page also. https://s24.postimg.org/qiprlmmhh/post-titles-bottom-of-category-page.jpg
  • The theme is allowed one credit link in the footer, either the Theme URI or the Author URI.
  • header.php:
    • no hardcoded charset
    • remove <meta> tags for description and keywords and author
    • No hardcoded script tags. Enqueue all scripts -- but Google Maps is plugin territory.
    • The $content_width variable you are checking is local, since this is a template file.
    • This is not a valid link href="<?php home_url(); ?>/construction/contact" The theme should not be involved in this.
    • This is not valid: bloginfo('name', 'constra');
  • theme-options.php: No hot linking for the logo.
  • Page links (generated by <!--nextpage-->) are not being output.
  • On a single post page, the post meta shows the number of comments for the entire site instead of for this one post. Also, it does not link to the comment section. It links to the current page.
  • The comment author avatar is outside the container, on the right.
  • Post navigation links would be nice.
  • Archive pages show the first post title as the page title.
  • Floats are not being cleared properly after the content area for posts.
  • Large images with captions overflow the container.
  • <h6> is quite small.
  • <hr> is nearly invisible.
  • The class aligncenter is correct on a static Page, but not on a Post.
  • I rarely see the sidebar, even though it has widgets and its description says "Widgets in this area will be shown on all posts and pages."
  • Themes should support the gallery default of 3 columns.
  • Search results should not show the author and date of static Pages.
  • Search results work much better as excerpts, so the user can see where the matches are instead of a flood of mostly non-matching content.
  • The 404 page is not at all helpful.

#6 @kevinhaig
5 months ago

Note to Author

  1. The above preview by @joyously is not an official review. You must still wait to get to the top of the review queue before an official review will begin.
  1. Many of the concerns above relate to results from Theme Unit Test and you should always test your theme with that package. However please note that many of the comments are considered recommended. Recommended comments DO NOT have to be addressed for theme approval. In many cases it is good advice, but the decision to address those issues is yours.
  1. There may be some comment items that are required. Required items must be addressed or the theme will not be approved. Please visit https://make.wordpress.org/themes/handbook/review/required/ to double check required items. Note that when an official review starts your theme may be closed if 5 or more distinct requirements are not met.
  1. If you are in doubt of a comment, or do not want to address something please ask for a confirmation in the ticket, or on the open Slack channel.
  1. If I get a chance I will take a look later and split out the above comments between Requirements and Recommended as @joyously should be doing :(

#7 @themetracbot
5 months ago

  • Owner set to shrimp2t
  • Status changed from new to reviewing

#8 @shrimp2t
5 months ago

Hi,

I found some issues in your theme:

  1. REQUIRED: Translation issue. You should escape all translation strings before echoing to the page, use esc_html_e(); instead of _e();, use esc_html__(); instead of __();. Please check all file for this issue.
  2. REQUIRED: All default strings should translatable, example get_theme_mod('about_title', 'Who We Are') should be get_theme_mod('about_title', esc_html__( ‘'Who We Are', 'constra')), Please check all files for this issue.
  3. REQUIRED: All theme options should sanitize before echoing, Example <?php _e(get_theme_mod('about_title', 'Who We Are'), 'constra'); ?> this code is incorrect, it should be <?php esc_html( get_theme_mod('about_title', esc_html__( ‘Who We Are’, ‘constra’ ) ) ); ?> Please check all files for this issue.
  4. REQUIRED: kirki should recommend by TGM ( http://tgmpluginactivation.com/installation/ ), and plugins which you recommended must exists on https://wordpress.org/plugins/
  5. REQUIRED: Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, image size, etc. http://themereview.co/prefix-all-the-things/
  6. REQUIRED: include('navthemes_functions.php'); should be include_once get_template_directory().'/navthemes_functions.php'; the same for all include or require file.
  7. REQUIRED: The URL in footer credit should escape and translatable, example <a href="<?php echo esc_url( __( 'https://wordpress.org/', 'twentyfifteen' ) ); ?>"><?php printf( esc_html__( 'Proudly powered by %s', 'twentyfifteen' ), 'WordPress' ); ?></a>;
  8. REQUIRED: Please make all texts in file comment_form.php are translatable.

Edit:

@navthemes Please respond within 7 days to void closing the ticket.

Last edited 5 months ago by shrimp2t (previous) (diff)

#9 @navthemes
5 months ago

Sure. i am fixing issues.

Last edited 5 months ago by navthemes (previous) (diff)

#10 @shrimp2t
5 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hey

I'm so sorry, no new version update i must set to not approved to review other themes.

#11 @navthemes
5 months ago

Hey, i think 7 days is given to update it ?/ its just 3 days.

#12 @shrimp2t
5 months ago

Hey,

I wrote my review issues 9 days and no new version updated. That why i set status to close.

Last edited 5 months ago by shrimp2t (previous) (diff)

#13 @navthemes
5 months ago

But as per guideline, if ticket is not updated for more than 7 days then only it can be closed. Please check

Note: See TracTickets for help on using tickets.