WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 4 months ago

#41836 closed theme (live)

THEME: Eighties – 1.3.0

Reported by: Kopepasah Owned by: benlumia007
Priority: theme update Keywords: theme-eighties
Cc: justin@…

Description

Eighties - 1.3.0

Hello, my name is Eighties and I am a modern, progressively enhanced theme designed to keep your content front and center. My menu and sidebar are built to stay out of the way until a user wants to see them. When clicked, users get a nice, clean overlay. You can upload a custom header image or select to use the featured image of the post as the header image. Both you and your site’s visitors will love me and you can expect updates and future enhancements for years to come (because my maker loves me, too).

Theme URL - http://eighties.me
Author URL - http://kopepasah.com/

Trac Browser - https://themes.trac.wordpress.org/browser/eighties/1.3.0

SVN - https://themes.svn.wordpress.org/eighties/1.3.0
ZIP - https://wordpress.org/themes/download/eighties.1.3.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=eighties/1.2.1&new_path=eighties/1.3.0

History:

Ticket Summary Status Resolution Owner
#18794 THEME: Eighties - 1.0.0 closed not-approved imon Hasan
#19074 THEME: Eighties - 1.0.2 closed live imon Hasan
#19387 THEME: Eighties - 1.0.3 closed live poena
#19582 THEME: Eighties - 1.1.0 closed live catchthemes
#19802 THEME: Eighties - 1.2.0 closed live Milmor
#20259 THEME: Eighties - 1.2.1 closed live sixhours
#41836 THEME: Eighties – 1.3.0 closed live benlumia007

(this ticket)


https://themes.svn.wordpress.org/eighties/1.3.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

Change History (12)

#1 @themetracbot
4 months ago

  • Owner set to themetracbot
  • Status changed from new to reviewing

Theme Update for existing Live theme - automatically reviewed

#2 @themetracbot
4 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Theme Update for existing Live theme - automatically approved

#3 @Kopepasah
4 months ago

This theme was updated to 1.3.0 three days ago, but the changes have not reflected those updates on the theme page (which still says the theme is outdated).

Does anyone have an idea why this is happening?

This ticket was mentioned in Slack in #themereview by kopepasah. View the logs.


4 months ago

#5 @benlumia007
4 months ago

  • Resolution live deleted
  • Status changed from closed to reopened

@Kopepasah
Themes that have not been updated in two years need to be reviewed, they don't go live automatically.

#6 @benlumia007
4 months ago

  • Owner changed from themetracbot to benlumia007
  • Status changed from reopened to reviewing

#7 @benlumia007
4 months ago

@Kopepasah
Since the theme is a theme update, i will be performing a full review of the theme and since it has been 3 years since the last time you have updated. I will comment on this ticket and submit a fixes that is needed. Once that's done, I will set live after everything is completed.

Thanks
@benlumia007

#8 @benlumia007
4 months ago

@Kopepasah

Note: Errors need to be fixed and Warnings are things that need to be checked manually.

FILE: /srv/www/themereview/public_html/wp-content/themes/eighties/comments.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 26 | ERROR | Missing singular placeholder, needed for some languages. See
    |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
--------------------------------------------------------------------------------------------------------------


FILE: /srv/www/themereview/public_html/wp-content/themes/eighties/inc/custom-header.php
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 45 | ERROR | Found usage of constant "HEADER_TEXTCOLOR". Use add_theme_support( 'custom-header' ) instead.
------------------------------------------------------------------------------------------------------------


FILE: /srv/www/themereview/public_html/wp-content/themes/eighties/inc/extras.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 115 | ERROR | Overriding WordPress globals is prohibited
--------------------------------------------------------------------------------


FILE: /srv/www/themereview/public_html/wp-content/themes/eighties/inc/template-tags.php
---------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------
 75 | ERROR | Overriding WordPress globals is prohibited
 91 | ERROR | Strings should have translatable content
---------------------------------------------------------------------------------------

Fixed these above and I'll set live afterwards, this is just a sniff, and a quick look at the theme.

Last edited 4 months ago by benlumia007 (previous) (diff)

#9 @benlumia007
4 months ago

@Kopepasah
Are you going to fixed the issue above so that I can set this back to live.

Thanks
@benlumia007

#10 @Kopepasah
4 months ago

@benlumia007 yes, I intend to do this task on Wednesday, April 19th.

#11 @benlumia007
4 months ago

@Kopepasah
You currently have 3 days to complete the changes, If no changes, I will have to set theme not approved. Please note that since this is just a sniff/quick look at the theme because it was recently live. There will no no full review. Please make change as soon as possible so theme can go live.

Thanks
@benlumia007

#12 @benlumia007
4 months ago

  • Resolution set to live
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.