WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#42017 closed theme (not-approved)

THEME: Live It Up – 1.1

Reported by: sagarprajapati Owned by: kafleg
Priority: new theme Keywords: theme-live-it-up
Cc: sagarprajapati48@…

Description

Live It Up - 1.0

WordPress Theme for blog

Theme URL -
Author URL - https://about.me/sagarprajapati48

Trac Browser - https://themes.trac.wordpress.org/browser/live-it-up/1.0

SVN - https://themes.svn.wordpress.org/live-it-up/1.0
ZIP - https://wordpress.org/themes/download/live-it-up.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#42017 THEME: Live It Up – 1.1 closed not-approved kafleg

(this ticket)

#42078 THEME: Live It Up – 1.15 closed live benlumia007


https://themes.svn.wordpress.org/live-it-up/1.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments 'Search'

Change History (4)

#1 @themetracbot
6 months ago

  • Summary changed from THEME: Live It Up – 1.0 to THEME: Live It Up – 1.1

Live It Up - 1.1

WordPress Theme for blog

Theme URL -
Author URL - https://about.me/sagarprajapati48

Trac Browser - https://themes.trac.wordpress.org/browser/live-it-up/1.1

SVN - https://themes.svn.wordpress.org/live-it-up/1.1
ZIP - https://wordpress.org/themes/download/live-it-up.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=live-it-up/1.0&new_path=live-it-up/1.1

History:

Ticket Summary Status Resolution Owner
#42017 THEME: Live It Up – 1.1 closed not-approved kafleg

(this ticket)

#42078 THEME: Live It Up – 1.15 closed live benlumia007


https://themes.svn.wordpress.org/live-it-up/1.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

#2 @kafleg
6 months ago

  • Owner set to kafleg
  • Status changed from new to reviewing

#3 @kafleg
6 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

I am going to close this ticket because there are lots of issues on the theme. Please solve all the issues based on theme guidelines https://make.wordpress.org/themes/handbook/review/ and submit your theme again. https://wordpress.org/themes/upload/
This is not a full review,please check all the theme files based on guidelines.

REQUIRED

  • No any errors, warning or notices allowed on theme.
    <?php
    TEXTCOLOR already defined in wp-content\themes\live-it-up\functions.php on line 121
    Notice: Constant HEADER_IMAGE already defined in C:\xampp\htdocs\read-more\wp-content\themes\live-it-up\functions.php on line 123
    Notice: Constant HEADER_IMAGE_WIDTH already defined in wp-content\themes\live-it-up\functions.php on line 127
    Notice: Constant HEADER_IMAGE_HEIGHT already defined in wp-content\themes\live-it-up\functions.php on line 128
    
  • Invalid text domain, your text domain shoudl be live-it-up.
  • Default text needs to be translation ready. It is missing on theme. https://make.wordpress.org/themes/handbook/review/required/#language
  • Static ID is used on theme showposts=1000&cat=-8, static IDs not allowed.
  • Missing singular placeholder, needed for some languages. See https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
  • Overriding WordPress globals is prohibited.
  • Stylesheets must be registered/enqueued via wp_enqueue_style.
  • Provide proper sanitization and validation on theme. Example, URL need to be escaped with esc_url. It's missing on home_url. Please check all other files as well.
  • Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc. http://themereview.co/prefix-all-the-things/ It is missing on theme liu_fix_widget_title. Please check on all files.
  • Excerpt length needs to be applied on front end only. It's not allowed to effect admin side.
  • Commented codes found on functions.php. Remove unwanted files and folders.

Do not get discouraged. A closed ticket is not the end. We want you to resubmit your theme. If you need any help, you can ask on #themereview channel on slack.
Regards
KafleG

#4 @sagarprajapati
6 months ago

Hi @kafleg

Thank you for your time. I have updated above changes on my theme. Please have a look it and let me know. Also check with accessibility point of view.

https://themes.trac.wordpress.org/ticket/42078

Thanks

Note: See TracTickets for help on using tickets.