WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 6 months ago

#42038 closed theme (live)

THEME: HamzahShop – 1.1.4

Reported by: proscriptsell Owned by: meissudeep
Priority: previously reviewed Keywords: theme-hamzahshop
Cc: e2getway@…

Description

HamzahShop - 1.0.7

Hamzah Shop is a simple yet modern e-commerce WordPress theme. It is esthetically minimalist, fresh-faced and bright, elegantly styled and well developed, readily responsive e-commerce WordPress theme. It is a perfect theme for commercial endeavors of all kinds, from digital download shops to online commercial retail of all kinds. It integrates the industry standard WooCommerce e-commerce plugin, a wonderful solution for all your online commerce needs, which allows your users to browse your product catalogs in easy but stylish grace, add items to their shopping carts intuitively, and proceed to checkout and make payments, all right off your website. Official Support Forum: https://edatastyle.com/dwqa-questions/Full Demo: http://edatastyle.com/product/hamzahshop/

Theme URL - http://edatastyle.com/product/hamzahshop-free/
Author URL - http://edatastyle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/hamzahshop/1.0.7

SVN - https://themes.svn.wordpress.org/hamzahshop/1.0.7
ZIP - https://wordpress.org/themes/download/hamzahshop.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hamzahshop/1.0.6&new_path=hamzahshop/1.0.7

History:

Ticket Summary Status Resolution Owner
#40653 THEME: HamzahShop – 1.0.6 closed not-approved walksteve
#42038 THEME: HamzahShop – 1.1.4 closed live meissudeep

(this ticket)

#44878 THEME: HamzahShop – 1.1.5 closed live themetracbot
#48393 THEME: HamzahShop – 1.1.6 closed live themetracbot


https://themes.svn.wordpress.org/hamzahshop/1.0.7/screenshot.png

Attachments (1)

Home – My Theme.png (25.4 KB) - added by juiiee8487 7 months ago.
Undefined variable: order in /opt/lampp/htdocs/MY_Theme/wp-content/plugins/woo-product-multi-layout/class/class-views.php on line 283

Download all attachments as: .zip

Change History (34)

#1 @joyously
7 months ago

  • A theme cannot "require" plugins. Themes must work without plugins.
  • White screen of death: Fatal error: Call to undefined function wc_get_cart_url() in wp-content/themes/hamzahshop/inc/template-functions.php on line 110

#2 @themetracbot
7 months ago

  • Summary changed from THEME: HamzahShop – 1.0.7 to THEME: HamzahShop – 1.0.8

HamzahShop - 1.0.8

Hamzah Shop is a simple yet modern e-commerce WordPress theme. It is esthetically minimalist, fresh-faced and bright, elegantly styled and well developed, readily responsive e-commerce WordPress theme. It is a perfect theme for commercial endeavors of all kinds, from digital download shops to online commercial retail of all kinds. It integrates the industry standard WooCommerce e-commerce plugin, a wonderful solution for all your online commerce needs, which allows your users to browse your product catalogs in easy but stylish grace, add items to their shopping carts intuitively, and proceed to checkout and make payments, all right off your website. Official Support Forum: https://edatastyle.com/dwqa-questions/Full Demo: http://edatastyle.com/product/hamzahshop/

Theme URL - http://edatastyle.com/product/hamzahshop-free/
Author URL - http://edatastyle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/hamzahshop/1.0.8

SVN - https://themes.svn.wordpress.org/hamzahshop/1.0.8
ZIP - https://wordpress.org/themes/download/hamzahshop.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hamzahshop/1.0.7&new_path=hamzahshop/1.0.8

History:

Ticket Summary Status Resolution Owner
#40653 THEME: HamzahShop – 1.0.6 closed not-approved walksteve
#42038 THEME: HamzahShop – 1.1.4 closed live meissudeep

(this ticket)

#44878 THEME: HamzahShop – 1.1.5 closed live themetracbot
#48393 THEME: HamzahShop – 1.1.6 closed live themetracbot


https://themes.svn.wordpress.org/hamzahshop/1.0.8/screenshot.png

#3 @joyously
7 months ago

Here is some user feedback to consider before your review.

  • The base font size is a bit small. <h6> is even smaller. It feels like the difference between regular text and the headings used is too much. It feels unbalanced.
  • The blockquote is only setting open-quote, not close-quote, so the first one in the page gets the double quote and the second one gets the single quote. It's probably not as intended.
  • table in content needs a little padding.
  • The <q> tag is styled like blockquote instead of as short, inline quote.
  • The <cite> tag should not be display:block.
  • The social share buttons should be removed as that is plugin territory.
  • Floats are not being cleared properly after the content area on Pages.
  • Lists do not have bullets or numbers or show nesting on static Pages.
  • Comments are always showing the Reply link even though my settings say 5 levels deep only.

#4 @themetracbot
7 months ago

  • Owner set to juiiee8487
  • Status changed from new to reviewing

#5 @proscriptsell
7 months ago

Hi juiiee8487
Thanks for reviewing my theme . please don't reject without giving opportunity fix bug..

Thanks

#6 @proscriptsell
7 months ago

Hi
Can i upload new versions . Some point fixed @joyously ...

Thanks

#7 @themetracbot
7 months ago

  • Summary changed from THEME: HamzahShop – 1.0.8 to THEME: HamzahShop – 1.0.9

HamzahShop - 1.0.9

Hamzah Shop is a simple yet modern e-commerce WordPress theme. It is esthetically minimalist, fresh-faced and bright, elegantly styled and well developed, readily responsive e-commerce WordPress theme. It is a perfect theme for commercial endeavors of all kinds, from digital download shops to online commercial retail of all kinds. It integrates the industry standard WooCommerce e-commerce plugin, a wonderful solution for all your online commerce needs, which allows your users to browse your product catalogs in easy but stylish grace, add items to their shopping carts intuitively, and proceed to checkout and make payments, all right off your website. Official Support Forum: https://edatastyle.com/dwqa-questions/Full Demo: http://edatastyle.com/product/hamzahshop/

Theme URL - http://edatastyle.com/product/hamzahshop-free/
Author URL - http://edatastyle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/hamzahshop/1.0.9

SVN - https://themes.svn.wordpress.org/hamzahshop/1.0.9
ZIP - https://wordpress.org/themes/download/hamzahshop.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hamzahshop/1.0.8&new_path=hamzahshop/1.0.9

History:

Ticket Summary Status Resolution Owner
#40653 THEME: HamzahShop – 1.0.6 closed not-approved walksteve
#42038 THEME: HamzahShop – 1.1.4 closed live meissudeep

(this ticket)

#44878 THEME: HamzahShop – 1.1.5 closed live themetracbot
#48393 THEME: HamzahShop – 1.1.6 closed live themetracbot


https://themes.svn.wordpress.org/hamzahshop/1.0.9/screenshot.png

@juiiee8487
7 months ago

Undefined variable: order in /opt/lampp/htdocs/MY_Theme/wp-content/plugins/woo-product-multi-layout/class/class-views.php on line 283

#8 in reply to: ↑ description @juiiee8487
7 months ago

Hey,
There where many errors Like theme required plugins installation error.

And Woo Multi Layout Plugin is not porparly working that gave error like :- Notice: Undefined variable: meta_key in /opt/lampp/htdocs/MY_Theme/wp-content/plugins/woo-product-multi-layout/class/class-views.php on line 282

#9 @themetracbot
7 months ago

  • Summary changed from THEME: HamzahShop – 1.0.9 to THEME: HamzahShop – 1.1.0

HamzahShop - 1.1.0

Hamzah Shop is a simple yet modern e-commerce WordPress theme. It is esthetically minimalist, fresh-faced and bright, elegantly styled and well developed, readily responsive e-commerce WordPress theme. It is a perfect theme for commercial endeavors of all kinds, from digital download shops to online commercial retail of all kinds. It integrates the industry standard WooCommerce e-commerce plugin, a wonderful solution for all your online commerce needs, which allows your users to browse your product catalogs in easy but stylish grace, add items to their shopping carts intuitively, and proceed to checkout and make payments, all right off your website. Official Support Forum: https://edatastyle.com/dwqa-questions/Full Demo: http://edatastyle.com/product/hamzahshop/

Theme URL - http://edatastyle.com/product/hamzahshop-free/
Author URL - http://edatastyle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/hamzahshop/1.1.0

SVN - https://themes.svn.wordpress.org/hamzahshop/1.1.0
ZIP - https://wordpress.org/themes/download/hamzahshop.1.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hamzahshop/1.0.9&new_path=hamzahshop/1.1.0

History:

Ticket Summary Status Resolution Owner
#40653 THEME: HamzahShop – 1.0.6 closed not-approved walksteve
#42038 THEME: HamzahShop – 1.1.4 closed live meissudeep

(this ticket)

#44878 THEME: HamzahShop – 1.1.5 closed live themetracbot
#48393 THEME: HamzahShop – 1.1.6 closed live themetracbot


https://themes.svn.wordpress.org/hamzahshop/1.1.0/screenshot.png

#10 @proscriptsell
7 months ago

Hi @juiiee8487 .
Hope you're doing great ! thanks for your good feedback and so far i know Recommended plugins isn't issue with my theme . and the Notice coming from the plugins .it's not issue of hamzah theme .

what's ever i have removed few Recommended plugins :)

Hope now you will approve

Thanks

#11 in reply to: ↑ description @juiiee8487
7 months ago

  • Status changed from reviewing to approved

#12 @proscriptsell
7 months ago

Hi @juiiee8487
Thanks for approved my theme . Hope ASAP you will live the theme ..

Thanks ..

#13 @meissudeep
6 months ago

Hello @proscriptsell

I'm taking this on final review, will be back soon.

#14 @proscriptsell
6 months ago

Hello @meissudeep

Thanks for review my theme .

#15 @meissudeep
6 months ago

  • Status changed from approved to reopened

Hello @proscriptsell,

Please fix this issue before going ahead:

  • Doesn't see any use of woocommerce/global/breadcrumb.php like wise rtl.css, custom-editor-style.css file If you have such files as well as commented codes remove them all.
  • functions.php L185 - Change handle scrollUpto jquery-scrollUp.
  • ScrollUp js is GPL compatible or not it's licence is missing for readme.txt as well.
  • You have modified comment field so remove form 'html5' supports in function.php
  • Prefixing in function pro.php L-5 eds_theme_add_editor_styles().
  • I am unable to see any use of this code
         <?php if ( function_exists( 'the_subtitle' ) ) { ?>
             <div class="subtitle"><?php the_subtitle();?></div>
         <?php }?>
    

can you please check this out.

Note: Regarding the premium code you just have commented the code on your files. remove all commented and unused codes.

#16 @themetracbot
6 months ago

  • Summary changed from THEME: HamzahShop – 1.1.0 to THEME: HamzahShop – 1.1.1

HamzahShop - 1.1.1

Hamzah Shop is a simple yet modern e-commerce WordPress theme. It is esthetically minimalist, fresh-faced and bright, elegantly styled and well developed, readily responsive e-commerce WordPress theme. It is a perfect theme for commercial endeavors of all kinds, from digital download shops to online commercial retail of all kinds. It integrates the industry standard WooCommerce e-commerce plugin, a wonderful solution for all your online commerce needs, which allows your users to browse your product catalogs in easy but stylish grace, add items to their shopping carts intuitively, and proceed to checkout and make payments, all right off your website. Official Support Forum: https://edatastyle.com/dwqa-questions/Full Demo: http://edatastyle.com/product/hamzahshop/

Theme URL - http://edatastyle.com/product/hamzahshop-free/
Author URL - http://edatastyle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/hamzahshop/1.1.1

SVN - https://themes.svn.wordpress.org/hamzahshop/1.1.1
ZIP - https://wordpress.org/themes/download/hamzahshop.1.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hamzahshop/1.1.0&new_path=hamzahshop/1.1.1

History:

Ticket Summary Status Resolution Owner
#40653 THEME: HamzahShop – 1.0.6 closed not-approved walksteve
#42038 THEME: HamzahShop – 1.1.4 closed live meissudeep

(this ticket)

#44878 THEME: HamzahShop – 1.1.5 closed live themetracbot
#48393 THEME: HamzahShop – 1.1.6 closed live themetracbot


https://themes.svn.wordpress.org/hamzahshop/1.1.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#17 @proscriptsell
6 months ago

Hi @meissudeep

Thanks for your great feedback . i have fixed all issue . would you check now ! waiting for your more feedback ready to fix all issue :)

have a nice day

Thanks for your help !

#18 @meissudeep
6 months ago

Hello @proscriptsell

Fix this issue before setting your theme to live.

  • Welcome message as admin notice should be dismissable. And when dismissed, it should not reappear in page reload.
  • Custom Header implemented but theme tag custom-header missing.
  • Style handle hamzah-custom-css should be hamzahshop-custom-css.
  • Google font handle should be prefixed with theme slug.
  • In browser console there are several JS errors. There should be no any errors in the console.
  • Multi level menu doesn't seem to be working propery check that too.

#19 @themetracbot
6 months ago

  • Summary changed from THEME: HamzahShop – 1.1.1 to THEME: HamzahShop – 1.1.2

HamzahShop - 1.1.2

Hamzah Shop is a simple yet modern e-commerce WordPress theme. It is esthetically minimalist, fresh-faced and bright, elegantly styled and well developed, readily responsive e-commerce WordPress theme. It is a perfect theme for commercial endeavors of all kinds, from digital download shops to online commercial retail of all kinds. It integrates the industry standard WooCommerce e-commerce plugin, a wonderful solution for all your online commerce needs, which allows your users to browse your product catalogs in easy but stylish grace, add items to their shopping carts intuitively, and proceed to checkout and make payments, all right off your website. Official Support Forum: https://edatastyle.com/dwqa-questions/Full Demo: http://edatastyle.com/product/hamzahshop/

Theme URL - http://edatastyle.com/product/hamzahshop-free/
Author URL - http://edatastyle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/hamzahshop/1.1.2

SVN - https://themes.svn.wordpress.org/hamzahshop/1.1.2
ZIP - https://wordpress.org/themes/download/hamzahshop.1.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hamzahshop/1.1.1&new_path=hamzahshop/1.1.2

History:

Ticket Summary Status Resolution Owner
#40653 THEME: HamzahShop – 1.0.6 closed not-approved walksteve
#42038 THEME: HamzahShop – 1.1.4 closed live meissudeep

(this ticket)

#44878 THEME: HamzahShop – 1.1.5 closed live themetracbot
#48393 THEME: HamzahShop – 1.1.6 closed live themetracbot


https://themes.svn.wordpress.org/hamzahshop/1.1.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#20 @proscriptsell
6 months ago

Hello @meissudeep

Thanks for your awesome feedback ! we have fixed all issue .. Hope it's time to go live

thanks for your help

#21 in reply to: ↑ description @juiiee8487
6 months ago

  • Resolution set to not-approved
  • Status changed from reopened to closed

This ticket was mentioned in Slack in #themereview by edatasyle. View the logs.


6 months ago

#23 @proscriptsell
6 months ago

Hi @juiiee8487 ..
Can you reopen the ticket ? and set live ..

#24 @proscriptsell
6 months ago

Hello @juiiee8487 .

is your mistake ? Can you reopen the ticket ?

Thanks

#25 @rinkuyadav999
6 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

Hi @juiiee8487

Please do not close ticket @meissudeep is taking final review.

Thanks

#26 @meissudeep
6 months ago

Hello @proscriptsell

Many thing happens within an hour. . .. :)

No need to worry, you still haven't fixed previous issues regarding the console error .../themes/hamzahshop/img/icon/down-arrowblk.png 404 (Not Found) and multilevel menu see the screenshot here https://prnt.sc/fgw60i

#27 @themetracbot
6 months ago

  • Summary changed from THEME: HamzahShop – 1.1.2 to THEME: HamzahShop – 1.1.3

HamzahShop - 1.1.3

Hamzah Shop is a simple yet modern e-commerce WordPress theme. It is esthetically minimalist, fresh-faced and bright, elegantly styled and well developed, readily responsive e-commerce WordPress theme. It is a perfect theme for commercial endeavors of all kinds, from digital download shops to online commercial retail of all kinds. It integrates the industry standard WooCommerce e-commerce plugin, a wonderful solution for all your online commerce needs, which allows your users to browse your product catalogs in easy but stylish grace, add items to their shopping carts intuitively, and proceed to checkout and make payments, all right off your website. Official Support Forum: https://edatastyle.com/dwqa-questions/Full Demo: http://edatastyle.com/product/hamzahshop/

Theme URL - http://edatastyle.com/product/hamzahshop-free/
Author URL - http://edatastyle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/hamzahshop/1.1.3

SVN - https://themes.svn.wordpress.org/hamzahshop/1.1.3
ZIP - https://wordpress.org/themes/download/hamzahshop.1.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hamzahshop/1.1.2&new_path=hamzahshop/1.1.3

History:

Ticket Summary Status Resolution Owner
#40653 THEME: HamzahShop – 1.0.6 closed not-approved walksteve
#42038 THEME: HamzahShop – 1.1.4 closed live meissudeep

(this ticket)

#44878 THEME: HamzahShop – 1.1.5 closed live themetracbot
#48393 THEME: HamzahShop – 1.1.6 closed live themetracbot


https://themes.svn.wordpress.org/hamzahshop/1.1.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#28 @proscriptsell
6 months ago

Hi @meissudeep .
i have fixed the menu issue . may be it's cache problem :). icon issue fixed !

Thanks for your quick reply !

#29 @meissudeep
6 months ago

Don't get hurried your ticket will not be deleted :)
See here the problem with the icon https://prnt.sc/fgx1wj

#30 @themetracbot
6 months ago

  • Summary changed from THEME: HamzahShop – 1.1.3 to THEME: HamzahShop – 1.1.4

HamzahShop - 1.1.4

Hamzah Shop is a simple yet modern e-commerce WordPress theme. It is esthetically minimalist, fresh-faced and bright, elegantly styled and well developed, readily responsive e-commerce WordPress theme. It is a perfect theme for commercial endeavors of all kinds, from digital download shops to online commercial retail of all kinds. It integrates the industry standard WooCommerce e-commerce plugin, a wonderful solution for all your online commerce needs, which allows your users to browse your product catalogs in easy but stylish grace, add items to their shopping carts intuitively, and proceed to checkout and make payments, all right off your website. Official Support Forum: https://edatastyle.com/dwqa-questions/Full Demo: http://edatastyle.com/product/hamzahshop/

Theme URL - http://edatastyle.com/product/hamzahshop-free/
Author URL - http://edatastyle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/hamzahshop/1.1.4

SVN - https://themes.svn.wordpress.org/hamzahshop/1.1.4
ZIP - https://wordpress.org/themes/download/hamzahshop.1.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hamzahshop/1.1.3&new_path=hamzahshop/1.1.4

History:

Ticket Summary Status Resolution Owner
#40653 THEME: HamzahShop – 1.0.6 closed not-approved walksteve
#42038 THEME: HamzahShop – 1.1.4 closed live meissudeep

(this ticket)

#44878 THEME: HamzahShop – 1.1.5 closed live themetracbot
#48393 THEME: HamzahShop – 1.1.6 closed live themetracbot


https://themes.svn.wordpress.org/hamzahshop/1.1.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#31 @proscriptsell
6 months ago

hi @meissudeep

Thanks for you help !

#32 @meissudeep
6 months ago

  • Owner changed from juiiee8487 to meissudeep
  • Status changed from reopened to reviewing

#33 @meissudeep
6 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hello @proscriptsell

Everything looks cool, setting this live.

Note: See TracTickets for help on using tickets.