WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 4 months ago

#42078 closed theme (live)

THEME: Live It Up – 1.15

Reported by: sagarprajapati Owned by: benlumia007
Priority: previously reviewed Keywords: theme-live-it-up
Cc: sagarprajapati48@…

Description

Live It Up - 1.11

WordPress Theme for blog

Theme URL -
Author URL - https://about.me/sagarprajapati48

Trac Browser - https://themes.trac.wordpress.org/browser/live-it-up/1.11

SVN - https://themes.svn.wordpress.org/live-it-up/1.11
ZIP - https://wordpress.org/themes/download/live-it-up.1.11.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=live-it-up/1.1&new_path=live-it-up/1.11

History:

Ticket Summary Status Resolution Owner
#42017 THEME: Live It Up – 1.1 closed not-approved kafleg
#42078 THEME: Live It Up – 1.15 closed live benlumia007

(this ticket)


https://themes.svn.wordpress.org/live-it-up/1.11/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

Attachments (1)

download (1).png (40.0 KB) - added by benlumia007 5 months ago.

Download all attachments as: .zip

Change History (19)

#1 @sagarprajapati
6 months ago

Hi @kafleg

I have made the changes as you suggested in the previous ticket. Please have a look and let me know.

Thanks

#2 @benlumia007
5 months ago

  • Owner set to benlumia007
  • Status changed from new to reviewing

#3 @benlumia007
5 months ago

@sagarprajapati

I will be reviewing your theme and will respond within 24 - 48 hours.

Thanks
@benlumia007

#4 @benlumia007
5 months ago

404.php
What is the purposed of this following script

<script type="text/javascript">
    // focus on search field after it has loaded
    document.getElementById('s') && document.getElementById('s').focus();
</script>

archive.php

  • It is not necessary to do a rewind_posts() since it is already done automatically please remove it
  • Instead of creating your own page title such as
    <?php if ( is_day() ) : ?>
    				<?php printf( esc_html__( 'Daily Archives: <span>%s</span>', 'live-it-up' ), get_the_date() ); ?>
    <?php elseif ( is_month() ) : ?>
    				<?php printf( esc_html__( 'Monthly Archives: <span>%s</span>', 'live-it-up' ), get_the_date('F Y') ); ?>
    <?php elseif ( is_year() ) : ?>
    				<?php printf( esc_html__( 'Yearly Archives: <span>%s</span>', 'live-it-up' ), get_the_date('Y') ); ?>
    <?php else : ?>
    				<?php esc_html_e( 'Blog Archives', 'live-it-up' ); ?>
    <?php endif; ?>
    

why not use the following the_archive_title() to display archive titles and authors etc.

footer.php
There are some text that are hardcoded, please use translation and escape it.

functions.php
Please do not comment out codes that are not in used, you will need to remove codes or functions that are not in used must be removed and not commented out.

eaders/concave.jpg',
			'thumbnail_url' => '%s/images/headers/concave-thumbnail.jpg',
			/* translators: header image description */
			'description' => esc_html__( 'Concave', 'live-it-up' )
		),
		'fern' => array(
			'url' => '%s/images/headers/fern.jpg',
			'thumbnail_url' => '%s/images/headers/fern-thumbnail.jpg',
			/* translators: header image description */
			'description' => esc_html__( 'Fern', 'live-it-up' )
		),
		'forestfloor' => array(
			'url' => '%s/images/headers/forestfloor.jpg',
			'thumbnail_url' => '%s/images/headers/forestfloor-thumbnail.jpg',
			/* translators: header image description */
			'description' => esc_html__( 'Forest Floor', 'live-it-up' )
		),
		'inkwell' => array(
			'url' => '%s/images/headers/inkwell.jpg',
			'thumbnail_url' => '%s/images/headers/inkwell-thumbnail.jpg',
			/* translators: header image description */
			'description' => esc_html__( 'Inkwell', 'live-it-up' )
		),
		'path' => array(
			'url' => '%s/images/headers/path.jpg',
			'thumbnail_url' => '%s/images/headers/path-thumbnail.jpg',
			/* translators: header image description */
			'description' => esc_html__( 'Path', 'live-it-up' )
		),
		'sunset' => array(
			'url' => '%s/images/headers/sunset.jpg',
			'thumbnail_url' => '%s/images/headers/sunset-thumbnail.jpg',
			/* translators: header image description */
			'description' => esc_html__( 'Sunset', 'live-it-up' )
		)

Invalid images check customizer in header image.

If you are supporting older version of IE, please don't, the WOrdPress 4.8 will be no longer supporting IE that are older than Version 12.

#5 @themetracbot
5 months ago

  • Summary changed from THEME: Live It Up – 1.11 to THEME: Live It Up – 1.12

Live It Up - 1.12

WordPress Theme for blog

Theme URL -
Author URL - https://about.me/sagarprajapati48

Trac Browser - https://themes.trac.wordpress.org/browser/live-it-up/1.12

SVN - https://themes.svn.wordpress.org/live-it-up/1.12
ZIP - https://wordpress.org/themes/download/live-it-up.1.12.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=live-it-up/1.11&new_path=live-it-up/1.12

History:

Ticket Summary Status Resolution Owner
#42017 THEME: Live It Up – 1.1 closed not-approved kafleg
#42078 THEME: Live It Up – 1.15 closed live benlumia007

(this ticket)


https://themes.svn.wordpress.org/live-it-up/1.12/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

#6 @sagarprajapati
5 months ago

Hi @benlumia007

Thank you for review my theme. I have updated your above suggestion in SVN. Please check it.

Regarding 404.php focus jquery code, It focus the search text box when page is fully loaded. But I think it's not necessary and I have removed it.

Thanks

#7 @benlumia007
5 months ago

@sagarprajapati

Sorry for the delay, since it was memorial weekend, i didn't bother to do any reviews. I will continue your review today!

Thanks
@benlumia007

#8 @sagarprajapati
5 months ago

No problem @benlumia007

Please let me know when you finished the review.

Thank you in advance.

#9 @benlumia007
5 months ago

you have not fixed the following items that i have asked please fix, see attachment.

#10 @themetracbot
5 months ago

  • Summary changed from THEME: Live It Up – 1.12 to THEME: Live It Up – 1.13

Live It Up - 1.13

WordPress Theme for blog

Theme URL -
Author URL - https://about.me/sagarprajapati48

Trac Browser - https://themes.trac.wordpress.org/browser/live-it-up/1.13

SVN - https://themes.svn.wordpress.org/live-it-up/1.13
ZIP - https://wordpress.org/themes/download/live-it-up.1.13.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=live-it-up/1.12&new_path=live-it-up/1.13

History:

Ticket Summary Status Resolution Owner
#42017 THEME: Live It Up – 1.1 closed not-approved kafleg
#42078 THEME: Live It Up – 1.15 closed live benlumia007

(this ticket)


https://themes.svn.wordpress.org/live-it-up/1.13/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

#11 @sagarprajapati
5 months ago

Hi @benlumia007

I have fixed above changes on the above-attached theme. Please review it.

Thanks

#12 @benlumia007
5 months ago

style.css
Tags should be used if the theme is currently supports, does it support custsom-header, custom menu, etc, having just blog

how does the templates for membership work. I know it's a template file, but how does it work with the theme.

template-members-no-comm.php and template-members.php needs to translation and escape, you have some that are hardcoded text.

#13 @themetracbot
5 months ago

  • Summary changed from THEME: Live It Up – 1.13 to THEME: Live It Up – 1.14

Live It Up - 1.14

WordPress Theme for blog

Theme URL -
Author URL - https://about.me/sagarprajapati48

Trac Browser - https://themes.trac.wordpress.org/browser/live-it-up/1.14

SVN - https://themes.svn.wordpress.org/live-it-up/1.14
ZIP - https://wordpress.org/themes/download/live-it-up.1.14.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=live-it-up/1.13&new_path=live-it-up/1.14

History:

Ticket Summary Status Resolution Owner
#42017 THEME: Live It Up – 1.1 closed not-approved kafleg
#42078 THEME: Live It Up – 1.15 closed live benlumia007

(this ticket)


https://themes.svn.wordpress.org/live-it-up/1.14/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

#14 @sagarprajapati
5 months ago

Hi @benlumia007

I have updated tags in the style.css. There is no need for members template I have removed it. I will release it in the next release.

Thanks

#15 @benlumia007
5 months ago

I have found that you are currently using add_theme_support('post-thumbnails'); but you are not using the_post_thumbnail(); to display output of the thumbnail. if you add theme support, it needs to be used correctly and display correctly

you are looking using live it up, but your text domain is still not correct when it comes to prefixing, the correct prefix is live_it_up for functions and translation should be live-it-up, but you have it as liveitup.

please fix.

#16 @themetracbot
5 months ago

  • Summary changed from THEME: Live It Up – 1.14 to THEME: Live It Up – 1.15

Live It Up - 1.15

WordPress Theme for blog

Theme URL -
Author URL - https://about.me/sagarprajapati48

Trac Browser - https://themes.trac.wordpress.org/browser/live-it-up/1.15

SVN - https://themes.svn.wordpress.org/live-it-up/1.15
ZIP - https://wordpress.org/themes/download/live-it-up.1.15.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=live-it-up/1.14&new_path=live-it-up/1.15

History:

Ticket Summary Status Resolution Owner
#42017 THEME: Live It Up – 1.1 closed not-approved kafleg
#42078 THEME: Live It Up – 1.15 closed live benlumia007

(this ticket)


https://themes.svn.wordpress.org/live-it-up/1.15/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.

#17 @sagarprajapati
5 months ago

Hi @benlumia007

I have removed add_theme_support( 'post-thumbnails' ); and also made changes for the text domain.

Thanks

#18 @benlumia007
4 months ago

  • Resolution set to live
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.