WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 4 months ago

#42133 closed theme (not-approved)

THEME: Solidus – 1.1.0

Reported by: henry.wright Owned by: benlumia007
Priority: new theme Keywords: theme-solidus accessibility-ready
Cc: henrywright@…

Description

Solidus - 1.0.0

Solidus is a theme for blogging.

Theme URL - https://github.com/lsquo/solidus
Author URL - https://lsquo.com

Trac Browser - https://themes.trac.wordpress.org/browser/solidus/1.0.0

SVN - https://themes.svn.wordpress.org/solidus/1.0.0
ZIP - https://wordpress.org/themes/download/solidus.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#42133 THEME: Solidus – 1.1.0 closed not-approved benlumia007

(this ticket)


https://themes.svn.wordpress.org/solidus/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.

Change History (14)

#1 @joyously
5 months ago

Here is some user feedback to consider before your review.

  • As an admin user, I really don't want to have to put the same widgets into all the widget areas for the different pages. It's so much easier to use the same widget area for all or most pages.
  • The theme is not setting the body background color. I am seeing my browser default color of yellow.
  • Required: Display the correct content according to the front page setting. I am seeing the same thing, regardless of my setting, and it doesn't match either 'posts' or 'page'.
  • A menu would be nice.
  • A custom menu widget in the sidebar is displaying horizontally, so it overlaps the post content.
  • A calendar widget in the sidebar overflows the container and overlaps the content.
  • Post navigation links would be nice.
  • There is a CSS rule that interferes with the user specified HTML width attribute for images. This should be removed, as that attribute is the only way the user can choose the size. The default value for CSS width is auto, so there is no need to specify it. When it is, it overrides the HTML from the user. And, of course, specifying the height is not good either. (Even the margin property in that same rule messes up the margins set for floats.) The theme can't know what the user intended or how big the image really is.
    main img:first-of-type {
        height: 8rem;
        width: auto;
    }
    
  • Floats are not being cleared properly after the content area.
  • Large images with captions overflow the container.
  • blockquote is styled as italic, so nested <em> and <cite> tags are indistinguishable.
  • Lists have a bottom margin that looks odd in nested lists. (can't make a "short list"!)
  • You might want to hide the widget areas and comment form for the print styles.
  • The image attachment page does not show the image or have a comment form.
  • Search results should not show the date of static Pages.
  • The 404 page is not at all helpful, especially in getting anywhere else.
  • The comment avatar is not being shown, despite being enabled in the settings.

#2 @henry.wright
5 months ago

Thanks for taking the time to provide such detailed feedback. I'll try to push some updates before my review.

#3 @benlumia007
5 months ago

  • Keywords changed from theme-solidus, accessibility-ready to theme-solidus accessibility-ready
  • Owner set to benlumia007
  • Status changed from new to reviewing

@henry.wright

Already took the theme. :) Do not make any updates until i do my review.

#4 @benlumia007
5 months ago

@henry.wright

Sorry for the delay, since it was memorial weekend, i didn't bother to do any reviews. I will continue your review today!

Thanks
@benlumia007

#5 @benlumia007
5 months ago

@henry.wright
i have finished reviewing your theme, I will make a comment tonight or tomorrow morning for sure. Sorry for the delay

Thanks
@benlumia007

#6 @henry.wright
5 months ago

Thanks, looking forward to reading your review

#7 @benlumia007
5 months ago

@henry.wright

Required

  • needs the standard loop for blogs
  • front-page.php is not use properly
  • index.php is empty, why is this empty, the standard loop should here for the latest blog posts.
  • no need to create so many widgets_init when u can use one function to do all that
  • you should have a function for theme setup, one for enqueue_scripts and one for registering widgets

#8 @henry.wright
5 months ago

@benlumia007

Thanks for reviewing and for your feedback.

needs the standard loop for blogs

The theme does use a standard loop. Please see the archive.php and home.php templates for examples.

front-page.php is not use properly

front-page.php is designed to list posts from 3 categories. See WP Carrot for an example of this in action.

index.php is empty, why is this empty, the standard loop should here for the latest blog posts.

index.php is empty because it's never used. The rest of the templates in the theme will catch all possible URLs.

no need to create so many widgets_init when u can use one function to do all that

I was just being modular :)

you should have a function for theme setup, one for enqueue_scripts and one for registering widgets

I was just being modular :) :)

#9 @benlumia007
5 months ago

@henry.wright
You are still not using the standard loop for certain pages.

You have

front-page.php
no home.php
index.php

The template hierarchy for these options is as follow

Your latest posts : front-page.php->home.php->index.php
A static page -> Front page : front-page.php->custom templates->page.php->index.php
A static page -> Posts page : home.php->index.php

if you do not have a front-page.php or home.php, the index.php takes affect
if you do not have front-page.php but you have home.php and index.php, the home.php takes over, HOME.php is for the latest blog post.

if none of the front page.php and home.php not there, it uses index.php.

sorry but can't be modular when it comes to putting functions together, i would have closed this ticket,

https://codex.wordpress.org/Creating_a_Static_Front_Page
http://underscores.me/

Last edited 5 months ago by benlumia007 (previous) (diff)

#10 @benlumia007
5 months ago

users should the choice to use the static page, you can't control it.

#11 @henry.wright
5 months ago

I thought the theme had both a home.php and front-page.php template but of course it doesn't. I added these files to my dev copy but forgot to upload the new version to here.

Ref https://github.com/lsquo/solidus

I'm away from the desk now it's the weekend but I'll upload the new version asap.

#12 @themetracbot
4 months ago

  • Summary changed from THEME: Solidus – 1.0.0 to THEME: Solidus – 1.1.0

Solidus - 1.1.0

Solidus is a theme for blogging.

Theme URL - https://github.com/lsquo/solidus
Author URL - https://lsquo.com

Trac Browser - https://themes.trac.wordpress.org/browser/solidus/1.1.0

SVN - https://themes.svn.wordpress.org/solidus/1.1.0
ZIP - https://wordpress.org/themes/download/solidus.1.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=solidus/1.0.0&new_path=solidus/1.1.0

History:

Ticket Summary Status Resolution Owner
#42133 THEME: Solidus – 1.1.0 closed not-approved benlumia007

(this ticket)


https://themes.svn.wordpress.org/solidus/1.1.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.

#13 @henry.wright
4 months ago

@benlumia007

Please find 1.1.0 ready for review. Thanks again!

#14 @benlumia007
4 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello @henry.wright

Closing ticket as per author's request.

Note: See TracTickets for help on using tickets.