WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 4 days ago

#42451 closed theme (not-approved)

THEME: Education Pack – 1.0.2

Reported by: ThimPress Owned by: sami.keijonen
Priority: new theme Keywords: theme-education-pack accessibility-ready
Cc: dev@…

Description

Education Pack - 1.0.0

A free University WordPress theme for all universities, colleges, schools, educational institutions, learning centers, learning hubs. This theme is best used as an Education WordPress Theme.

Theme URL - http://university.thimpress.com/
Author URL - http://thimpress.com

Trac Browser - https://themes.trac.wordpress.org/browser/education-pack/1.0.0

SVN - https://themes.svn.wordpress.org/education-pack/1.0.0
ZIP - https://wordpress.org/themes/download/education-pack.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#42451 THEME: Education Pack – 1.0.2 closed not-approved sami.keijonen

(this ticket)


https://themes.svn.wordpress.org/education-pack/1.0.0/screenshot.png

Change History (21)

#1 @joyously
5 months ago

Here is some user feedback to consider before your review.

  • PHP Notice: Undefined index: title in wp-content/themes/education-pack/inc/widgets/heading/heading.php on line 27
  • PHP Notice: Undefined index: subtitle in wp-content/themes/education-pack/inc/widgets/heading/heading.php on line 28
  • Theme or author name/brand should not be output on front end except as allowed in a credit link.
  • Use the user's site title, not the theme name.
  • Any copyright statements on the front end should display the user's copyright, not the theme author's copyright.
  • Comment author name is linked even if there is no website to link to.
  • The comment date is not output. (and it's typically linked to the comment anchor for easy copy/paste)
  • I am showing my latest posts on a static Page, but the title/breadcrumb says "Blog" instead of the name of my Page.
  • The date shown in the post meta is not using my choice of date format.
  • The social media share buttons are plugin territory and should be removed.
  • Floats are not being cleared properly after the content area.
  • blockquote is styled as italic, but can have nested <em> and <cite> tags which are indistinguishable.
  • Ok, that last comment was from looking at the formatting Post, but looking at the formatting Page, I see that there is a different font size. The blockquote is very different. Why the difference?
  • This screenshot is from the bottom of the formatting page. See if you can tell where the page content ends and the comment section begins. https://s10.postimg.org/gdqou12o9/end-of-page-comment-section.jpg
  • You might want to hide the menu, breadcrumbs, comment form, related posts, widget areas for the print styles.
  • The gallery captions are only shown on hover. How does that work for touch screens?
  • Search results should not show the author and date of static Pages.
  • The 404 page is not very helpful. (and no sidebar?)

#2 @themetracbot
5 months ago

  • Owner set to maciejmackowiak
  • Status changed from new to reviewing

#4 @themetracbot
4 months ago

  • Keywords changed from theme-education-pack, accessibility-ready to theme-education-pack accessibility-ready
  • Summary changed from THEME: Education Pack – 1.0.0 to THEME: Education Pack – 1.0.1

Education Pack - 1.0.1

A free University WordPress theme for all universities, colleges, schools, educational institutions, learning centers, learning hubs. This theme is best used as an Education WordPress Theme.

Theme URL - http://university.thimpress.com/
Author URL - http://thimpress.com

Trac Browser - https://themes.trac.wordpress.org/browser/education-pack/1.0.1

SVN - https://themes.svn.wordpress.org/education-pack/1.0.1
ZIP - https://wordpress.org/themes/download/education-pack.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=education-pack/1.0.0&new_path=education-pack/1.0.1

History:

Ticket Summary Status Resolution Owner
#42451 THEME: Education Pack – 1.0.2 closed not-approved sami.keijonen

(this ticket)


https://themes.svn.wordpress.org/education-pack/1.0.1/screenshot.png

#5 @ThimPress
4 months ago

Hi, Thank you for your feedbacks. We have updated a new version of the theme.

#6 @djrmom
4 months ago

  • Owner maciejmackowiak deleted

I am sorry this review is taking so long. I am going to add this to the new queue again as a priority. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#7 @joedolson
4 months ago

  • Owner set to sami.keijonen

#8 @sami.keijonen
4 months ago

Hi. I'm going to review this theme. Also the accessibility-ready part. It can take few days before I start because I just came back from travelling and need to sort work/rest balance first.

#9 @sami.keijonen
4 months ago

Sorry it took so long for starting review. Here is my first round that I noticed, second round is coming.

  • Prefix all functions as education_pack and handles etc. as education-pack.
  • Provide non-minified files for all javascript files in js folder
  • Use build in Core feature for logo. I can't change the default logo.
  • Open Graph support is plugin territory. Or does that come from some plugin which user need to install? If that's the case put all those stuff in a plugin, not in a theme.
  • When I add header image it doesn't appear anywhere.
  • I can't dismiss the admin notice "Education Pack notice!". It should be dismissible.
  • I get this error when adding Gallery widget: Fatal error: Call to undefined function thim_meta() in /app/public/wp-content/themes/education-pack/inc/widgets/gallery/gallery.php on line 159
  • There seems to be lot's of plugin territory widgets in inc/widgets folder. For example Google Maps and testimonials. They should all be in a plugin and not in a theme itself.
  • I'm not sure is the featured post meta box allowed in single post. That should probably be done via tag or category.
  • I can't find license for image in screenshot.png. Or license for Fontawesome and all the other resources like JS libraries used. Readme.txt is empty and changelog.html almost empty.

#10 @themetracbot
3 months ago

  • Summary changed from THEME: Education Pack – 1.0.1 to THEME: Education Pack – 1.0.2

Education Pack - 1.0.2

A free University WordPress theme for all universities, colleges, schools, educational institutions, learning centers, learning hubs. This theme is best used as an Education WordPress Theme.

Theme URL - http://university.thimpress.com/
Author URL - http://thimpress.com

Trac Browser - https://themes.trac.wordpress.org/browser/education-pack/1.0.2

SVN - https://themes.svn.wordpress.org/education-pack/1.0.2
ZIP - https://wordpress.org/themes/download/education-pack.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=education-pack/1.0.1&new_path=education-pack/1.0.2

History:

Ticket Summary Status Resolution Owner
#42451 THEME: Education Pack – 1.0.2 closed not-approved sami.keijonen

(this ticket)


https://themes.svn.wordpress.org/education-pack/1.0.2/screenshot.png

#11 @ThimPress
3 months ago

Hi sami.keijonen,
Thanks for your feedbacks. We have updated a new version of the theme.

#12 @sami.keijonen
3 months ago

Quick note about the Customizer. Core features like changing the logo can't be in Pro version. I still can't change default logo. Same goes for all other Core features like changing the header image or site name.

There are tons of Customizer options in inc/admin/customizer-sections. If those are only available in Pro version, they should be in the Pro version.

This ticket was mentioned in Slack in #themereview by sami.keijonen. View the logs.


3 months ago

#14 @djrmom
3 months ago

Hi @ThimPress,

@sami.keijonen asked to have someone look at this review. Here are some additional things I see. This is not a full review but I will try to look at some more later.

Errors from Theme sniff need to be fixed. For the PHP version support, you will need to do a version check to prevent fatal errors or you need to fix the syntax to support a min 5.2.

education-pack/inc/admin/customizer-options.php
15	ERROR	Short array syntax (open) is available since 5.4
15	ERROR	Short array syntax (close) is available since 5.4
16	ERROR	Short array syntax (open) is available since 5.4
16	ERROR	Short array syntax (close) is available since 5.4
education-pack/inc/custom-functions.php
122	ERROR	Silencing errors is forbidden
570	ERROR	Silencing errors is forbidden
education-pack/inc/libs/installer.php
242	ERROR	Silencing errors is forbidden
775	ERROR	Multiple placeholders should be ordered. Expected '%1$s, %2$s', but got %s, %s.
821	ERROR	Multiple placeholders should be ordered. Expected '%1$s, %2$s', but got %s, %s.
education-pack/inc/template-tags.php
225	ERROR	Scripts must be registered/enqueued via wp_enqueue_script
231	ERROR	Scripts must be registered/enqueued via wp_enqueue_script
238	ERROR	Scripts must be registered/enqueued via wp_enqueue_script
386	ERROR	Overriding WordPress globals is prohibited
520	ERROR	Strings should have translatable content
522	ERROR	Strings should have translatable content
524	ERROR	Strings should have translatable content
550	ERROR	Strings should have translatable content
education-pack/templates/page-title/page-title.php
7	ERROR	Overriding WordPress globals is prohibited
7	ERROR	Silencing errors is forbidden
  • The Thim Core Installer should not appear on activation, the admin notice linking to it is okay. There needs to be an exit in the installer.
  • Thim Core must be hosted in the .org plugin directory if you are going to have an installer for it. Otherwise, you may include that information in your documentation on your site and have users manually install it.
  • You are allowed to configure options in your theme that are only available when a plugin is activated (similar to how kirki works) but all code in your theme must meet our guidelines even if it is not used without a plugin. This means that you cannot have options such as logo or custom css instead of using core functionality.
  • Removing core panels/section/controls is not allowed, see inc/admin/customizer-options.php and inc/customizer.php
  • Using glob to load files is not allowed
  • education_pack_get_all_plugins_require you cannot require plugins and all plugins must be hosted on in the .org plugin directory
  • education_pack_render_social_link sharing links connecting to third party apis is plugin territory
  • inc/data/demos.php, you cannot hotlink to an image url for display
  • you cannot remove the emoji script and styles unless replacing them in your theme
  • education_pack_optimize_remove_script_version is plugin territory
  • what is the purpose of these?
    add_filter( 'wp_calculate_image_srcset', 'education_pack_ssl_secure_image_srcset' );
    add_filter( 'wp_get_attachment_url', 'education_pack_ssl_secure_url', 1000 );
    add_filter( 'image_widget_image_url', 'education_pack_ssl_secure_url' );
    
  • Use core the_posts_pagination instead of creating your own in education_pack_paging_nav
  • add_editor_style() is being called but editor-style.css does not exist
  • wp_enqueue_style( 'thim-default', EDUCATION_PACK_URL . 'inc/data/default.css', array() ); - this css file does not exist
  • You need to add copyright/licence attribution for images in screenshot and any other images bundled in your theme that are not created originally by you. This would included the background patterns and icons, unless they are your own work.
  • I also see some functions and files that look like they are from underscores or a default theme but there is no attribution. Please be sure you give credit for all code that is not your own.

#15 @sami.keijonen
3 months ago

I noticed this comment about 100% GPL: https://themes.trac.wordpress.org/ticket/42451#comment:3

Can admins like @greenshady or @grapplerulrich comment on that?

#16 @grapplerulrich
3 months ago

@ThimPress To be able to host your theme on w.org theme repository any other themes should be GPL too regardless where they are being hosted. This means you have two options

  • Change the licensing of the theme on ThemeForest to GPL
  • Not upload your theme to wordpress.org

#17 @djrmom
2 months ago

@ThimPress, did you have any questions about becoming 100% GPL? Please let us know if you want to continue with this ticket. Thanks.

#18 @ThimPress
2 months ago

Can we move the theme to another website? At the website, we only show off free themes 100% GPL.

#19 @djrmom
6 weeks ago

Hi @ThimPress, sorry for the delay. You may host your 100% GPL themes at a separate website (or even not link to an author or theme url or other links) however, there must be no cross-linking or advertising of your theme shop or themes that are not 100% GPL. Thanks.

#20 @rabmalin
11 days ago

Hello @ThimPress any updates?

#21 @rabmalin
4 days ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Closing ticket. You can upload your theme when you are ready.

Note: See TracTickets for help on using tickets.