WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 5 months ago

#42539 closed theme (live)

THEME: Shuban – 1.0.4

Reported by: salttechno Owned by: imon Hasan
Priority: new theme Keywords: theme-shuban
Cc: sales@…

Description

Shuban - 1.0.0

Clean and professional WordPress blog theme for a business & personal blog. This is two-column theme with right-sidebar on posts & pages.

Theme URL - http://shuban.themesease.com
Author URL - http://www.salttechno.com

Trac Browser - https://themes.trac.wordpress.org/browser/shuban/1.0.0

SVN - https://themes.svn.wordpress.org/shuban/1.0.0
ZIP - https://wordpress.org/themes/download/shuban.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#42539 THEME: Shuban – 1.0.4 closed live imon Hasan

(this ticket)

#44990 THEME: Shuban – 1.1.0 closed live themetracbot
#45711 THEME: Shuban – 1.1.1 closed live themetracbot
#46653 THEME: Shuban – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/shuban/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (41)

#1 @salttechno
7 months ago

Hello There,

When can I expect a review of this theme?

Thanks,
Nilesh G

#2 @poena
7 months ago

Hi!
The current waiting time for the first review is 6 weeks.

#3 follow-up: @joyously
6 months ago

Here is some user feedback to consider before your review.

  • The style is very nicely implemented.
  • The fallback menu dropdown menus need a background color to be able to read them.
  • The mobile menu works with hover instead of click, making it difficult to use on a touch screen.
  • Links look the same as regular text. How does a user find links?
  • <q> tag is unstyled (default removed).
  • I went from blog page to author page and the sidebar is showing at the bottom, not full width. (no window size change) It seems to be the same for all archive pages except for latest posts.
  • Comments are showing the ordered list number, which is confusing for paged and nested comments. Try using CSS to hide the number or CSS counters to make it more logical.
  • Floats are not being cleared properly after the content area on Posts. https://s1.postimg.org/8nyctv5q7/floats-not-cleared.jpg
  • The search results page shows a different background for Posts and Pages and other post types. https://s7.postimg.org/u54uuipgr/search-different-background.jpg
  • In Customizer, Background Color - the default value is white, but that is not what is shown on the front end. They should match.
  • Remove the empty rtl.css or add actual styles to it.
  • See Proper Copyright/License Attribution for Themes to list all resources used (PHP, JS, CSS, fonts, images).
  • Remove development files and folders. (config file, .map file, sass folder, ...)

#4 @themetracbot
6 months ago

  • Owner set to Ahmis
  • Status changed from new to reviewing

#5 follow-ups: @Ahmis
6 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello! I just gave a review to your theme and here's some points that I made:

  • There are two Readme files + they are basically almost all about underscores (should be about this theme)
  • Google Font should not be imported in CSS files. Enqueue it instead.
  • Since I can change background image or background colour it would also be nice if I could change content area text colour (so that if I change dark bg colour I could still see the text).
  • In sidebar.php last comment is typed wrong: <!-- /.st-sidebar-wrapper col-md-3 --> (should be 4 instead of 3)
  • Please read / fix the points @joyously listed before. There were many good suggestions how to improve this theme before someone reviews it again. Actual errors from there that should be fixed:
  • In Customizer, Background Color - the default value is white, but that is not what is shown on the front end. They should match.
  • Remove the empty rtl.css or add actual styles to it.
  • See Proper Copyright/License Attribution for Themes to list all resources used (PHP, JS, CSS, fonts, images).
Last edited 6 months ago by Ahmis (previous) (diff)

#6 in reply to: ↑ 5 @salttechno
6 months ago

Hello,

Thank you for your time & the review.

Can I resolve these issues & upload theme here again (in this same ticket)?

Regards,
Nilesh G

Replying to Ahmis:

Hello! I just gave a review to your theme and here's some points that I made:

  • There are two Readme files + they are basically almost all about underscores (should be about this theme)
  • Google Font should not be imported in CSS files. Enqueue it instead.
  • Since I can change background image or background colour it would also be nice if I could change content area text colour (so that if I change dark bg colour I could still see the text).
  • In sidebar.php last comment is typed wrong: <!-- /.st-sidebar-wrapper col-md-3 --> (should be 4 instead of 3)
  • Please read / fix the points @joyously listed before. There were many good suggestions how to improve this theme before someone reviews it again. Actual errors from there that should be fixed:
  • In Customizer, Background Color - the default value is white, but that is not what is shown on the front end. They should match.
  • Remove the empty rtl.css or add actual styles to it.
  • See Proper Copyright/License Attribution for Themes to list all resources used (PHP, JS, CSS, fonts, images).
Last edited 6 months ago by salttechno (previous) (diff)

#7 @joyously
6 months ago

The way Trac works, if your ticket is open, any uploads of new versions will attach to that same ticket. If the ticket is closed, the upload creates a new ticket at the bottom of the queue.
I'm not sure if this ticket should have been closed, because there should be 5 issues from the Required page to close it.

This ticket was mentioned in Slack in #themereview by ahmis. View the logs.


6 months ago

#9 in reply to: ↑ 5 @salttechno
6 months ago

Hello,

How can I submit the theme again with recommended changes?

As mentioned on https://make.wordpress.org/themes/handbook/review/, the ticket should have been in 'reviewing' status for 7 days before closing.

Please let me know if I have misunderstood anything.

Regards,
Nilesh G

Replying to Ahmis:

Hello! I just gave a review to your theme and here's some points that I made:

  • There are two Readme files + they are basically almost all about underscores (should be about this theme)
  • Google Font should not be imported in CSS files. Enqueue it instead.
  • Since I can change background image or background colour it would also be nice if I could change content area text colour (so that if I change dark bg colour I could still see the text).
  • In sidebar.php last comment is typed wrong: <!-- /.st-sidebar-wrapper col-md-3 --> (should be 4 instead of 3)
  • Please read / fix the points @joyously listed before. There were many good suggestions how to improve this theme before someone reviews it again. Actual errors from there that should be fixed:
  • In Customizer, Background Color - the default value is white, but that is not what is shown on the front end. They should match.
  • Remove the empty rtl.css or add actual styles to it.
  • See Proper Copyright/License Attribution for Themes to list all resources used (PHP, JS, CSS, fonts, images).

This ticket was mentioned in Slack in #themereview by salttechno. View the logs.


6 months ago

#11 @rinkuyadav999
6 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#12 @rinkuyadav999
6 months ago

Hi @Ahmis

Please do not close ticket. If there is 5 or more required issues ( https://make.wordpress.org/themes/handbook/review/required/ ). you can close ticket and please also mention it in ticket when you close ticket.

Thanks

Last edited 6 months ago by rinkuyadav999 (previous) (diff)

#13 @rinkuyadav999
6 months ago

Hi @salttechno

Please fix all above required issues ( https://make.wordpress.org/themes/handbook/review/required/ ) and submit your theme again so @Ahmis can review it again.

Thanks

#14 follow-up: @Ahmis
6 months ago

Hi @salttechno!

I'm sorry, it was my mistake for closing it too early. Please submit a new version of your theme when you have fixed the issues. And thank you @rinkuyadav999 for opening this ticket again!

#15 in reply to: ↑ 14 @salttechno
6 months ago

Hello @Ahmis

Thank you for your reply. I am fixing all the mentioned changes. Can you please let me know which of them were "required" and which were "recommended"?

Also, can you please let me know how to upload corrected theme here?

Thanks in advance!

Regards,
Nilesh G

Replying to Ahmis:

Hi @salttechno!

I'm sorry, it was my mistake for closing it too early. Please submit a new version of your theme when you have fixed the issues. And thank you @rinkuyadav999 for opening this ticket again!

#16 @themetracbot
6 months ago

  • Summary changed from THEME: Shuban – 1.0.0 to THEME: Shuban – 1.0.1

Shuban - 1.0.1

Clean and professional WordPress blog theme for a business &amp; personal blog. This is two-column theme with right-sidebar on posts &amp; pages.

Theme URL - http://shuban.themesease.com
Author URL - http://www.salttechno.com

Trac Browser - https://themes.trac.wordpress.org/browser/shuban/1.0.1

SVN - https://themes.svn.wordpress.org/shuban/1.0.1
ZIP - https://wordpress.org/themes/download/shuban.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shuban/1.0.0&new_path=shuban/1.0.1

History:

Ticket Summary Status Resolution Owner
#42539 THEME: Shuban – 1.0.4 closed live imon Hasan

(this ticket)

#44990 THEME: Shuban – 1.1.0 closed live themetracbot
#45711 THEME: Shuban – 1.1.1 closed live themetracbot
#46653 THEME: Shuban – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/shuban/1.0.1/screenshot.png

#17 in reply to: ↑ 5 @salttechno
6 months ago

Hello @Ahmis ,

I have worked on all the mentioned points in the review and uploaded theme again. Please review it and let me know your valuable feedback.

Please find my comments below on review points you had mentioned:-

Replying to Ahmis:

Hello! I just gave a review to your theme and here's some points that I made:

  • There are two Readme files + they are basically almost all about underscores (should be about this theme) - Duplicate file removed. Now only one readme file is there and it has theme license attribution.
  • Google Font should not be imported in CSS files. Enqueue it instead. - Done. Google fonts are now enqueued using functions.php
  • Since I can change background image or background colour it would also be nice if I could change content area text colour (so that if I change dark bg colour I could still see the text). - Added a white background for .hentry making it possible to read text on any body background color.
  • In sidebar.php last comment is typed wrong: <!-- /.st-sidebar-wrapper col-md-3 --> (should be 4 instead of 3) - Updated as per requirement.
  • Please read / fix the points @joyously listed before. There were many good suggestions how to improve this theme before someone reviews it again. Actual errors from there that should be fixed: - Done.
  • In Customizer, Background Color - the default value is white, but that is not what is shown on the front end. They should match. - Updated. Now, the default color is gray, similar to default background.
  • Remove the empty rtl.css or add actual styles to it. - Applied rtl.css changes
  • See Proper Copyright/License Attribution for Themes to list all resources used (PHP, JS, CSS, fonts, images). - Updated on readme.txt. LICENSE file is also inculded.

Thanks in advance.

Regards,
Nilesh G
SaltTechno

#18 in reply to: ↑ 3 @salttechno
6 months ago

Hello @joyously ,

Thanks a lot for your valuable review & feedback. I have made all suggested changes and uploaded theme again. Your review has helped me a lot in updating the theme.

Do check the updated theme whenever you get time and let me know your feedback.

Thanks in advance.

Regards,
Nilesh G
SaltTechno

Replying to joyously:

Here is some user feedback to consider before your review.

  • The style is very nicely implemented.
  • The fallback menu dropdown menus need a background color to be able to read them.
  • The mobile menu works with hover instead of click, making it difficult to use on a touch screen.
  • Links look the same as regular text. How does a user find links?
  • <q> tag is unstyled (default removed).
  • I went from blog page to author page and the sidebar is showing at the bottom, not full width. (no window size change) It seems to be the same for all archive pages except for latest posts.
  • Comments are showing the ordered list number, which is confusing for paged and nested comments. Try using CSS to hide the number or CSS counters to make it more logical.
  • Floats are not being cleared properly after the content area on Posts. https://s1.postimg.org/8nyctv5q7/floats-not-cleared.jpg
  • The search results page shows a different background for Posts and Pages and other post types. https://s7.postimg.org/u54uuipgr/search-different-background.jpg
  • In Customizer, Background Color - the default value is white, but that is not what is shown on the front end. They should match.
  • Remove the empty rtl.css or add actual styles to it.
  • See Proper Copyright/License Attribution for Themes to list all resources used (PHP, JS, CSS, fonts, images).
  • Remove development files and folders. (config file, .map file, sass folder, ...)

#19 follow-up: @Ahmis
6 months ago

Hello @salttechno!

I will review this theme again as soon as possible and I'll let you know when I'm done! :)

#20 in reply to: ↑ 19 @salttechno
6 months ago

Hello @Ahmis ,

Thank you for your response. When can I expect a review?

Regards,
Nilesh G

Replying to Ahmis:

Hello @salttechno!

I will review this theme again as soon as possible and I'll let you know when I'm done! :)

#21 follow-up: @Ahmis
6 months ago

Hello @salttechno!

In a couple of days. Most propably Wednesday.

Best regards,
Ahmis

#22 in reply to: ↑ 21 @salttechno
6 months ago

Thank you @Ahmis for a quick response. Will wait for Wednesday.

Regards,
Nilesh G
SaltTechno

Replying to Ahmis:

Hello @salttechno!

In a couple of days. Most propably Wednesday.

Best regards,
Ahmis

#23 @rabmalin
6 months ago

  • Status changed from reopened to reviewing

#24 follow-up: @Ahmis
6 months ago

Hi @salttechno!

I checked the theme files again and there was one point that is required (and it would be great if you fixed it before I approve the theme):

  • No minification of scripts or files unless you provide original files.

And there were these two minified files included:

  • swiper.min.css
  • swiper.jquery.min

Other than that everything seemed to be okay. :)

Best,
Ahmis

#25 @themetracbot
6 months ago

  • Summary changed from THEME: Shuban – 1.0.1 to THEME: Shuban – 1.0.2

Shuban - 1.0.2

Clean and professional WordPress blog theme for a business &amp; personal blog. This is two-column theme with right-sidebar on posts &amp; pages.

Theme URL - http://shuban.themesease.com
Author URL - http://www.salttechno.com

Trac Browser - https://themes.trac.wordpress.org/browser/shuban/1.0.2

SVN - https://themes.svn.wordpress.org/shuban/1.0.2
ZIP - https://wordpress.org/themes/download/shuban.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shuban/1.0.1&new_path=shuban/1.0.2

History:

Ticket Summary Status Resolution Owner
#42539 THEME: Shuban – 1.0.4 closed live imon Hasan

(this ticket)

#44990 THEME: Shuban – 1.1.0 closed live themetracbot
#45711 THEME: Shuban – 1.1.1 closed live themetracbot
#46653 THEME: Shuban – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/shuban/1.0.2/screenshot.png

#26 in reply to: ↑ 24 @salttechno
6 months ago

Hello @Ahmis ,

Thanks a lot for your time & the review. :)

I have added both original files and updated the theme. Can you please review & approve it now?

Regards,
Nilesh G
SaltTechno

Replying to Ahmis:

Hi @salttechno!

I checked the theme files again and there was one point that is required (and it would be great if you fixed it before I approve the theme):

  • No minification of scripts or files unless you provide original files.

And there were these two minified files included:

  • swiper.min.css
  • swiper.jquery.min

Other than that everything seemed to be okay. :)

Best,
Ahmis

#27 @salttechno
6 months ago

Hello @Ahmis ,

Will it be set live directly after your approval?

Regards,
Nilesh G

#28 @salttechno
6 months ago

Hello @Ahmis ,

Can you please let me know when should I expect the next review from you? As per your last comment, other than that single issue, everything seemed to be okay. So, can you please approve it today?

Will it be set live directly after your approval?

Thanks in advance.

Regards,
Nilesh G
SaltTechno

#29 @Ahmis
6 months ago

  • Status changed from reviewing to approved

Hello!

I'm going to approve this theme now but it will not be set live yet. See how the process goes: https://make.wordpress.org/themes/handbook/review/

So next step is that 'Once a theme is approved the ticket will move to a new queue where a key reviewer will do the final review.'

Best regards,
Ahmis

#30 @salttechno
6 months ago

Thanks a lot, @Ahmis ! This is our first WordPress theme and your review has helped us a lot in improving the theme.

Regards,
Nilesh G
SaltTechno

#31 @Ahmis
6 months ago

No problem @salttechno! :) But be ready as there might be some other comments and recommendations coming from the final review also.

#32 @imon Hasan
5 months ago

  • Status changed from approved to reopened

Doing a final review

#33 @imon Hasan
5 months ago

I am reviewing your theme base on : https://make.wordpress.org/themes/handbook/review/required/

  • If the URI is a demo site, the content must be about the theme itself and not test data.
  • Author URI is optional. If used it is required to link to an author’s personal website or project/development website.

Licensing

  • Declare licenses of any resources included such as fonts or images.

=> Screenshot images licenses not find

=> fontawesome licence not declared

=> getbootstrap licence not declared

=> skip-link-focus-fix.js

Please add licenses for all resources

Code

  • do not prefix any third party script

example :

wp_enqueue_script( 'shuban-skip-link-focus-fix', get_template_directory_uri() . '/js/skip-link-focus-fix.js', array(), '20151215', true );

should be

wp_enqueue_script( 'skip-link-focus-fix', get_template_directory_uri() . '/js/skip-link-focus-fix.js', array(), '20151215', true );

Please fixed above required issue and Upload theme again

#34 @themetracbot
5 months ago

  • Summary changed from THEME: Shuban – 1.0.2 to THEME: Shuban – 1.0.3

Shuban - 1.0.3

Clean and professional WordPress blog theme for a business &amp; personal blog. This is two-column theme with right-sidebar on posts &amp; pages. The theme is designed with the classic elegance to keep your reader/website visitor more focused on the content &amp; images. Our professional designers have kept the design simple yet eye-pleasing.

Theme URL - https://themes.salttechno.com/downloads/shuban/
Author URL - https://themes.salttechno.com

Trac Browser - https://themes.trac.wordpress.org/browser/shuban/1.0.3

SVN - https://themes.svn.wordpress.org/shuban/1.0.3
ZIP - https://wordpress.org/themes/download/shuban.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shuban/1.0.2&new_path=shuban/1.0.3

History:

Ticket Summary Status Resolution Owner
#42539 THEME: Shuban – 1.0.4 closed live imon Hasan

(this ticket)

#44990 THEME: Shuban – 1.1.0 closed live themetracbot
#45711 THEME: Shuban – 1.1.1 closed live themetracbot
#46653 THEME: Shuban – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/shuban/1.0.3/screenshot.png

#35 @salttechno
5 months ago

Hello @imon-hasan,

Thank you for your review. I have updated the theme with all above-mentioned points. Please find my comments below against points you mentioned:

  • If the URI is a demo site, the content must be about the theme itself and not test data.

- Theme URI is updated to the theme description page instead of a demo site.

  • Author URI is optional. If used it is required to link to an author’s personal website or project/development website.

- Updated author URI to the project/development website.

Licensing

  • Declare licenses of any resources included such as fonts or images.

=> Screenshot images licenses not find
=> fontawesome licence not declared
=> getbootstrap licence not declared
=> skip-link-focus-fix.js

Please add licenses for all resources
- Added all licenses in readme.txt file

Code

  • do not prefix any third party script

- Removed prefix from third party js & css files like skip-link-focus-fix & swiper.

Last edited 5 months ago by salttechno (previous) (diff)

#36 @salttechno
5 months ago

Hello @imon-hasan,

Will the theme be live after your approval directly? This is my first theme. So, I am not aware of the process.

One more question: When can I expect the next review? :)

Regards,
SaltTechno

#37 @imon Hasan
5 months ago

Hi thank you for update you need to fix some more issue

Language

  • All theme text strings are to be translatable.


Not translatable

=> featured-posts.php line 51 and please check all

File: shuban\inc\featured-posts.php

0 errors and 3 warnings
Line: 42 	WARNING 	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_permalink'
Line: 42 	WARNING 	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$feat_image'
Line: 51 	WARNING 	Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'get_permalink'

File: shuban\inc\template-tags.php

4 errors and 5 warnings
Line: 28 	WARNING 	A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.
Line: 28 	ERROR 	Strings should have translatable content
Line: 33 	WARNING 	A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.
Line: 33 	ERROR 	Strings should have translatable content
Line: 48 	WARNING 	A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.
Line: 48 	ERROR 	Strings should have translatable content
Line: 63 	WARNING 	A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.
Line: 63 	ERROR 	Strings should have translatable content
Line: 69 	WARNING 	A gettext call containing placeholders was found, but was not accompanied by a "translators:" comment on the line above to clarify the meaning of the placeholders.

Please fix All isues .I will make your theme Live

#38 @themetracbot
5 months ago

  • Summary changed from THEME: Shuban – 1.0.3 to THEME: Shuban – 1.0.4

Shuban - 1.0.4

Clean and professional WordPress blog theme for a business &amp; personal blog. This is two-column theme with right-sidebar on posts &amp; pages. The theme is designed with the classic elegance to keep your reader/website visitor more focused on the content &amp; images. Our professional designers have kept the design simple yet eye-pleasing.

Theme URL - https://themes.salttechno.com/downloads/shuban/
Author URL - https://themes.salttechno.com

Trac Browser - https://themes.trac.wordpress.org/browser/shuban/1.0.4

SVN - https://themes.svn.wordpress.org/shuban/1.0.4
ZIP - https://wordpress.org/themes/download/shuban.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shuban/1.0.3&new_path=shuban/1.0.4

History:

Ticket Summary Status Resolution Owner
#42539 THEME: Shuban – 1.0.4 closed live imon Hasan

(this ticket)

#44990 THEME: Shuban – 1.1.0 closed live themetracbot
#45711 THEME: Shuban – 1.1.1 closed live themetracbot
#46653 THEME: Shuban – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/shuban/1.0.4/screenshot.png

#39 @salttechno
5 months ago

Hello @imon-hasan ,

Thank you for your quick response. I have fixed all of the above-mentioned issues.

Regards,
SaltTechno

#40 @imon Hasan
5 months ago

  • Owner changed from Ahmis to imon Hasan
  • Status changed from reopened to reviewing

#41 @imon Hasan
5 months ago

  • Resolution set to live
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.