WordPress.org

Make WordPress Themes

Opened 7 months ago

Closed 6 months ago

Last modified 6 months ago

#42825 closed theme (not-approved)

THEME: York Lite – 1.0.1

Reported by: themebeans Owned by: rabmalin
Priority: new theme Keywords: theme-york-lite
Cc: rich@…

Description

York Lite - 1.0.0

York Lite is a simple yet incredibly powerful portfolio WordPress theme for creatives, freelancers and agencies alike. York features a modern offset grid-based layout, bold typography and a minimalistic style that allows you to create a timeless website.

Theme URL - https://themebeans.com/themes/york-pro
Author URL - https://themebeans.com

Trac Browser - https://themes.trac.wordpress.org/browser/york-lite/1.0.0

SVN - https://themes.svn.wordpress.org/york-lite/1.0.0
ZIP - https://wordpress.org/themes/download/york-lite.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#42825 THEME: York Lite – 1.0.1 closed not-approved rabmalin

(this ticket)

#46115 THEME: York Lite – 1.0.9 reviewing ravioza


https://themes.svn.wordpress.org/york-lite/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

Change History (5)

#1 @themetracbot
6 months ago

  • Summary changed from THEME: York Lite – 1.0.0 to THEME: York Lite – 1.0.1

York Lite - 1.0.1

York Lite is a simple yet incredibly powerful portfolio WordPress theme for creatives, freelancers and agencies alike. York features a modern offset grid-based layout, bold typography and a minimalistic style that allows you to create a timeless website.

Theme URL - https://themebeans.com/themes/york-pro
Author URL - https://themebeans.com

Trac Browser - https://themes.trac.wordpress.org/browser/york-lite/1.0.1

SVN - https://themes.svn.wordpress.org/york-lite/1.0.1
ZIP - https://wordpress.org/themes/download/york-lite.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=york-lite/1.0.0&new_path=york-lite/1.0.1

History:

Ticket Summary Status Resolution Owner
#42825 THEME: York Lite – 1.0.1 closed not-approved rabmalin

(this ticket)

#46115 THEME: York Lite – 1.0.9 reviewing ravioza


https://themes.svn.wordpress.org/york-lite/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#2 @joyously
6 months ago

Here is some user feedback to consider before your review.

  • A theme cannot "require" plugins. Themes must work without plugins.
  • Remove all code to count post views york_set_post_views(), this is plugin territory.
  • In header.php, the class hfeed is hard-coded. This class should only be on archive pages (pages with multiple hentry).
  • Theme or author name/brand should not be output on front end except as allowed in a credit link. Logo should not be shown by default.
  • Use the user's site title, not the theme name.
  • The primary menu needs to have a fallback for when no menu is selected. The default value of fallback_cb parameter of wp_nav_menu() works really well, and it's core functionality.
  • Once a menu is selected, it is not shown correctly. All of the submenu arrows are shown in the same place (need to put position:relative on the li).
  • The flyout widget area is centering the widget content. It is always a bad idea to center user content unless the user chooses it. (Same for footer widgets.)
  • On a window about 760px wide, the flyout area goes to the bottom, but it has its own scrollbar.
  • Show correct content on front page. See this article. I do not see my static home Page. All I have is a theme logo and a footer widget area.
  • The post date is not using my choice of date format.
  • The number of comments is above the comment form instead of above the comment list.
  • The paged comment link is not output. Need a link to the other pages of comments.
  • Post navigation links would be nice. (single post pages)
  • Post pagination links are required. (multiple post pages)
  • There are no archive page titles and no static Page titles. I can't tell what I'm looking at.
  • On an archive page, I scrolled down and then tried to click on a post title. It was in the area between the logo and the menu icon. It must be covered by something because it does not work as a link when there. Scroll the title out of that spot and the link works. Does that mean that the sticky header needs a background color?
  • You might want to hide the sticky header, comment form, and widget areas for the print styles.
  • Looks like the gallery layout is controlled by the captions. Theme should support the gallery default of 3 columns.

https://s29.postimg.org/78fhnjdmv/gallery-captions.jpg

  • Page links (generated by <!--nextpage-->) are being output in the same div as the content instead of after it. Also, there is no padding, so when there are two pages, it looks like 12. It would be difficult for a fat finger to hit the desired number.
  • There is a CSS rule .size-full, .size-large, .alignnone {width: auto} that should be removed. The default for width is auto, so no need to specify it, and when you do, the CSS overrides the HTML attribute which is the only way the user can choose a specific width.
  • The space between paragraphs seems too large for the font size.
  • The <q> tag is unstyled (default removed).
  • Links in comments look just like regular text.
  • Pages and Posts are styled differently for HTML tags (and Pages have a white gap on the right).

https://s8.postimg.org/igyzynqsl/Page-headings-margins.jpg
https://s8.postimg.org/7inqgh279/Post-headings-margins.jpg

Page blockquote looks fine, correct order.
https://s17.postimg.org/ho1u148ov/Page-blockquote.jpg

Post blockquote using float:right and width:380px changes the flow of the sentences. This is not a good idea
https://s17.postimg.org/llp3qivi7/Post-blockquote.jpg

  • The <q> tag is unstyled (default removed).
  • NOTICE: wp-includes/comment-template.php:1194 - Trying to get property of non-object (this was on a search with no matches, also on 404 page)
  • Search results work much better as excerpts, so the user can see where the matches are instead of a flood of mostly non-matching content.
  • A custom post type as the first search result is under the header.

https://s2.postimg.org/9gwh0m0xl/search-results-custom-post.jpg

  • The 404 page is totally unhelpful and obnoxious. There is no explanation of what this is and no links to anywhere else. And scrollbars in both directions.
  • See Proper Copyright/License Attribution for Themes to list all resources used (PHP, JS, CSS, fonts, images).
  • Customizer:
    • Text Color option only works for page reload. It should change immediately, like the background color does.
    • Navigation icon color and hover color do not work.
    • Footer link color does not work.
    • Several sections have colors. It seems like they should all be under Colors section, or change the name of Colors section.

#3 @rabmalin
6 months ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#4 @rabmalin
6 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello,

Your theme has been partially reviewed against this Theme Review Guideline.

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues. This is part of our long term goals to improve the theme quality and shorten the queues. You can read more about this change here: https://make.wordpress.org/themes.

Please do not get discouraged by the ticket being closed. We want you to resubmit your theme, but we do ask that you spend more time making sure that your theme meets all the requirements. You can upload your updated theme here: https://wordpress.org/themes/upload/

Because of the large number of themes waiting for review, we might not be able to follow up immediately. We will review your update when your theme reaches the top of the review queue.

Issues

  • REQUIRED: Remove features which are considered plugin territory. See https://make.wordpress.org/themes/handbook/review/required/explanations-and-examples/#plugin-territory Eg, post views feature
  • REQUIRED: Plugins can be recommended but it is not allowed to make it required.
  • REQUIRED: Removing core settings is not allowed.
        $wp_customize->remove_section( 'colors' );
        $wp_customize->remove_section( 'background_image' );
        $wp_customize->remove_control( 'site_logo_header_text' );
        $wp_customize->remove_control( 'background_color' );
    
  • REQUIRED: Never use wp_print_styles hook. Please use alternative.
  • REQUIRED: editor-style.css - Do not use @import.
  • REQUIRED: Logo should be disabled by default.
  • REQUIRED: For upsell in Customizer, injecting HTML through JS is not allowed. Proper API should be used. Example - https://github.com/justintadlock/trt-customizer-pro
  • REQUIRED: Content creation - Remove Entry Header field from metabox.
  • REQUIRED: Avoid using create_function. It is going to be deprecated from PHP in near future.
  • REQUIRED: Please implement proper sanitization for values when saved to database. https://codex.wordpress.org/Data_Validation#Input_Validation Eg, sanitize_text_field() should be used to sanitize text field, esc_url_raw for URL field, for sanitizing field with HTML tags, use wp_kses_post() for sanitization, use absint() to sanitize positive integer. Check widgets and other places also.
  • REQUIRED: All theme text strings are to be translatable. https://make.wordpress.org/themes/handbook/review/required/#language
  • REQUIRED: Change date('Y') to date_i18n(__('Y','textdomain'))
  • REQUIRED: Remove york_admin_footer_version(). [Plugin Territory]
  • REQUIRED: Remove york_mce_before_init_insert_formats(). [Plugin Territory]
  • REQUIRED: york_enqueue_admin_style() - Make sure admin styles are only loaded in required pages.
  • REQUIRED: Never use query_posts(). Use WP_Query instead.
  • REQUIRED: Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc. http://themereview.co/prefix-all-the-things/ Eg, check admin.php L44, L66;
  • REQUIRED: Widget title should be passed through widget_title filter with parameters instance and id base. Ref: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/widgets/class-wp-widget-text.php#L48
  • REQUIRED: Update readme file to keep credits and license info of all third party resources (like scripts, styles, libraries, images, etc). Sample format: https://make.wordpress.org/themes/2015/04/29/a-revised-readme/
  • REQUIRED: In readme file, please declare your theme copyright in following format.
    Fred WordPress Theme, Copyright 2012 Joe Smith
    Fred is distributed under the terms of the GNU GPL
    
  • REQUIRED: style.css - At least one relevant subject tag is required (Max 3 subject tags allowed). https://make.wordpress.org/themes/handbook/review/required/theme-tags/
  • REQUIRED: Themes may have a single footer credit link, which is restricted to the Theme URI or Author URI defined in style.css.
  • REQUIRED: Use &hellip; instead of ...
  • REQUIRED: Translation strings in HTML attribute needs escaping also. Please check thoroughly. Eg, functions.php L452

Important

Before re-submitting themes, please check Theme Review Guidelines very thoroughly. Also, test your theme with following plugins.

Theme Check Sniffs

Note: Errors need to be fixed and Warnings are things that need to be checked manually.

FILE: /var/www/review.dev/public_html/wp-content/themes/york-lite/comments.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 36 | ERROR | Missing singular placeholder, needed for some languages. See
    |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
--------------------------------------------------------------------------------------------------------------

Time: 24964508 mins, 58.46 secs; Memory: 2Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/york-lite/footer.php
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
 36 | ERROR | [x] Multiple placeholders should be ordered. Expected '%1$s, %2$s', but got %s, %s.
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

Time: 24964508 mins, 58.72 secs; Memory: 2Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/york-lite/functions.php
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
 583 | ERROR | Overriding WordPress globals is prohibited
-------------------------------------------------------------------------------

Time: 24964508 mins, 58.82 secs; Memory: 6Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/york-lite/inc/plugins/class-tgm-plugin-activation.php
-------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 526 | ERROR | Silencing errors is forbidden
-------------------------------------------------------------------------------------------------------------

Time: 24964509 mins, 0.18 secs; Memory: 28Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/york-lite/inc/template-tags.php
---------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------
 127 | ERROR | Closures / anonymous functions are not available in PHP 5.2 or earlier
---------------------------------------------------------------------------------------

Time: 24964509 mins, 0.29 secs; Memory: 2Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/york-lite/inc/widgets/widget-flickr.php
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
 97 | ERROR | Scripts must be registered/enqueued via wp_enqueue_script
-----------------------------------------------------------------------------------------------

Time: 24964509 mins, 0.42 secs; Memory: 4Mb

#5 @jrf
6 months ago

Also: Please download a fresh copy of TGMPA using the correct settings - i.e choose "wordpress.org" as distribution channel in the Custom TGMPA Generator.
You are now using the Themeforest version. Once you've switched that out to use the correct version, the "Silencing errors is forbidden" issue will be gone.

Note: See TracTickets for help on using tickets.