WordPress.org

Make WordPress Themes

Opened 7 months ago

Closed 5 months ago

#42841 closed theme (not-approved)

THEME: ColorPop – 1.0.0

Reported by: gregoriofc Owned by: swapnild
Priority: new theme Keywords: theme-colorpop
Cc: gregoriofranco@…

Description

ColorPop - 1.0.0

ColorPop is a colorfull responsive magazine style WordPress theme.

Theme URL - http://bbbthemes.com/colorpop
Author URL - http://bbbthemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/colorpop/1.0.0

SVN - https://themes.svn.wordpress.org/colorpop/1.0.0
ZIP - https://wordpress.org/themes/download/colorpop.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#42841 THEME: ColorPop – 1.0.0 closed not-approved swapnild

(this ticket)


https://themes.svn.wordpress.org/colorpop/1.0.0/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (9)

#1 @joyously
6 months ago

Here is some user feedback to consider before your review.

  • The top menu needs to have a fallback for when no menu is selected. The default value of fallback_cb parameter of wp_nav_menu() works really well, and it's core functionality, but you know that because that is what the footer menu has. Maybe the footer menu should default to empty, or at least horizontal.
  • Comments are showing the ordered list number, which is confusing for paged and nested comments. Try using CSS to hide the number or CSS counters to make it more logical.
  • <tt> and <var> are tiny! because there is code, kbd, tt, var {font-size: 0.9375rem} and bootstrap has html {font-size: 10px}.
  • <q> tag is unstyled (default removed).
  • Post navigation links would be nice.
  • Page links (generated by <!--nextpage-->) are not being output for Posts.
  • The 404 page says "Maybe try one of the links below or a search?", but there are no links below and no search box.
  • In Customizer, the Header Text color has a default of black, but when I change it both the red site title and the black tagline change.
  • In Customizer, Categories Colors - add description of when and where the colors are used. And for a theme named ColorPop, the default colors are pretty boring.
  • Consider styling the site title and tagline to take up the entire header if no header widget is used.
  • You might want to hide the comment form and widget areas for the print styles.

#2 @swapnild
6 months ago

  • Owner set to swapnild
  • Status changed from new to reviewing

#3 @djrmom
6 months ago

@swapnild, you need to comment within 24 hours of taking a ticket to review even if only to let the author know the review is in progress.

#4 @swapnild
6 months ago

@djrmom sorry for late reply the review is in progress...

#5 @swapnild
6 months ago


#DESIGN


  1. Footer menu design - https://goo.gl/7zmeL1
  2. Submenus are not supported(support at least 2 levels) - https://goo.gl/mV42Hw
  3. Navigation next and previous icons are not looking properly - https://goo.gl/jcEMpo
  4. Text decoration to site title - https://goo.gl/3mjGNc

# Customizer


1.Scroll in customizer responsive settings- https://goo.gl/5Nyodx
2.Search widget design issue in header - https://goo.gl/APRa56
3.Where is this color options are applying - https://goo.gl/WdQH5p


# Theme Check


  1. RECOMMENDED: Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
  1. RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

# N S Theme Check


  1. ERROR The check has failed. This could happen due to running out of memory. Either reduce the file length or increase PHP memory.

colorpop/assets/js/jquery.min.js

  1. ERROR Missing singular placeholder, needed for some languages. See https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals

colorpop/components/footer/site-info.php

  1. ERROR Found usage of constant "HEADER_TEXTCOLOR". Use add_theme_support( 'custom-header' ) instead.

colorpop/inc/customizer.php

  1. ERROR Strings should have translatable content
  1. ERROR Strings should have translatable content
  1. ERROR Strings should have translatable content
  1. ERROR Strings should have translatable content

colorpop/inc/wp_bootstrap_navwalker.php

Last edited 6 months ago by swapnild (previous) (diff)

#6 @djrmom
5 months ago

@gregoriofc, you are required to communicate within 7 days, please upload a new version or comment here or this ticket will be closed. Thanks.

#7 @gregoriofc
5 months ago

At the moment I can not correct the errors. So you can close the ticket. I am sorry.

#8 @swapnild
5 months ago

@gregoriofc Please fix the issues. If you want some more time then you can, I will not close your ticket until you fix the issues...

#9 @swapnild
5 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.