WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 4 months ago

Last modified 3 months ago

#42865 closed theme (not-approved)

THEME: SShop – 1.0.4

Reported by: shrimp2t Owned by: nileshg
Priority: new theme Keywords: theme-sshop
Cc: shrimp2t@…

Description

sshop - 1.0.0

SShop is the perfect theme for your next WooCommerce project. Designed and developed by WooCommerce Core developers, it features a bespoke integration with WooCommerce itself plus many of the most popular customer facing WooCommerce extensions. There are several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it’s lean and extensible codebase making it a joy to customise and extend. Looking for a WooCommerce theme? Look no further!

Theme URL - https://shrimp2t.com/sshop
Author URL - https://shrimp2t.com/

Trac Browser - https://themes.trac.wordpress.org/browser/sshop/1.0.0

SVN - https://themes.svn.wordpress.org/sshop/1.0.0
ZIP - https://wordpress.org/themes/download/sshop.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#42865 THEME: SShop – 1.0.4 closed not-approved nileshg

(this ticket)

#44609 THEME: SShop – 1.0.8 closed live kevinhaig
#47069 THEME: SShop – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/sshop/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (24)

#1 @themetracbot
5 months ago

  • Keywords accessibility-ready removed
  • Summary changed from THEME: sshop – 1.0.0 to THEME: sshop – 1.0.1

sshop - 1.0.1

SShop is the perfect theme for your next WooCommerce project. Designed and developed by WooCommerce Core developers, it features a bespoke integration with WooCommerce itself plus many of the most popular customer facing WooCommerce extensions. There are several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it’s lean and extensible codebase making it a joy to customise and extend. Looking for a WooCommerce theme? Look no further!

Theme URL - https://shrimp2t.com/sshop
Author URL - https://shrimp2t.com/

Trac Browser - https://themes.trac.wordpress.org/browser/sshop/1.0.1

SVN - https://themes.svn.wordpress.org/sshop/1.0.1
ZIP - https://wordpress.org/themes/download/sshop.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sshop/1.0.0&new_path=sshop/1.0.1

History:

Ticket Summary Status Resolution Owner
#42865 THEME: SShop – 1.0.4 closed not-approved nileshg

(this ticket)

#44609 THEME: SShop – 1.0.8 closed live kevinhaig
#47069 THEME: SShop – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/sshop/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#2 @themetracbot
5 months ago

  • Summary changed from THEME: sshop – 1.0.1 to THEME: SShop – 1.0.2

SShop - 1.0.2

SShop is the best free WooCommerce theme. It features a bespoke integration with WooCommerce itself plus many widgets like Sales countdown, Product tabs, Blog posts, Services, Sliders. SShop is responsive mobile optimized and using bootstrap framework and FontAwesome icons. There are several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it’s lean and extensible codebase making it a joy to customise and extend. Looking for a WooCommerce theme? Look no further!

Theme URL - http://sshopwp.com/
Author URL - https://shrimp2t.com/

Trac Browser - https://themes.trac.wordpress.org/browser/sshop/1.0.2

SVN - https://themes.svn.wordpress.org/sshop/1.0.2
ZIP - https://wordpress.org/themes/download/sshop.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sshop/1.0.1&new_path=sshop/1.0.2

History:

Ticket Summary Status Resolution Owner
#42865 THEME: SShop – 1.0.4 closed not-approved nileshg

(this ticket)

#44609 THEME: SShop – 1.0.8 closed live kevinhaig
#47069 THEME: SShop – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/sshop/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Found a translation function that is missing a text-domain. Function esc_html_e, with the arguments 'Show page title'
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are sshop, textdomain

#3 @themetracbot
5 months ago

  • Summary changed from THEME: SShop – 1.0.2 to THEME: SShop – 1.0.3

SShop - 1.0.3

SShop is the best free WooCommerce theme. It features a bespoke integration with WooCommerce itself plus many widgets like Sales countdown, Product tabs, Blog posts, Services, Sliders. SShop is responsive mobile optimized and using bootstrap framework and FontAwesome icons. There are several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it’s lean and extensible codebase making it a joy to customise and extend. Looking for a WooCommerce theme? Look no further!

Theme URL - http://sshopwp.com/
Author URL - https://shrimp2t.com/

Trac Browser - https://themes.trac.wordpress.org/browser/sshop/1.0.3

SVN - https://themes.svn.wordpress.org/sshop/1.0.3
ZIP - https://wordpress.org/themes/download/sshop.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sshop/1.0.2&new_path=sshop/1.0.3

History:

Ticket Summary Status Resolution Owner
#42865 THEME: SShop – 1.0.4 closed not-approved nileshg

(this ticket)

#44609 THEME: SShop – 1.0.8 closed live kevinhaig
#47069 THEME: SShop – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/sshop/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#4 @themetracbot
4 months ago

  • Summary changed from THEME: SShop – 1.0.3 to THEME: SShop – 1.0.4

SShop - 1.0.4

SShop is the best free WooCommerce theme. It features a bespoke integration with WooCommerce itself plus many widgets like Sales countdown, Product tabs, Blog posts, Services, Sliders. SShop is responsive mobile optimized and using bootstrap framework and FontAwesome icons. There are several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it’s lean and extensible codebase making it a joy to customise and extend. Looking for a WooCommerce theme? Look no further!

Theme URL - http://demos.sshopwp.com/
Author URL - http://sshopwp.com/

Trac Browser - https://themes.trac.wordpress.org/browser/sshop/1.0.4

SVN - https://themes.svn.wordpress.org/sshop/1.0.4
ZIP - https://wordpress.org/themes/download/sshop.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sshop/1.0.3&new_path=sshop/1.0.4

History:

Ticket Summary Status Resolution Owner
#42865 THEME: SShop – 1.0.4 closed not-approved nileshg

(this ticket)

#44609 THEME: SShop – 1.0.8 closed live kevinhaig
#47069 THEME: SShop – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/sshop/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#5 @joyously
4 months ago

Here is some user feedback to consider before your review.

  • Custom widgets should be for presentation of existing data, since they will disappear on theme switch. So the Front Page: Services widget should be removed from the theme.
  • The Front Page: Blog widget has two fields for "Number posts to show".
  • The Front Page: Slider widget has a field for "Slider" with nothing to select.
  • Theme is adding "CSS Classes" and "CSS ID" fields to all widgets. This is plugin territory.
  • My site title is only partially shown, and on a smaller window the menu is only partially shown. It would definitely be more user friendly to keep these on separate lines so that they both fully display.
  • On a 740px window, my menu is partially shown. When I hover over the three dots, I get the top level items. When I hover over those, the submenus are half off the edge of the window, so I can't see them.
  • The fallback menu does not work correctly with the menu icon on a smaller window. Also, it doesn't behave like a custom menu does.
  • The mobile menu can be expanded taller than the window, but does not scroll.
  • I chose a static Page to show on front, but my home page is empty. Show correct content on front page. See this article.
  • Any copyright statements on the front end should display the user's copyright, not the theme author's copyright.
  • Remove rtl.css or add actual styles to it.
  • <q> tag is unstyled (default removed).
  • .gallery-item img {width: 100%;} This CSS rule should be removed, as the theme cannot know what the image width should be. It causes the browser to upscale thumbnails, which looks awful, and the user doesn't get the size he chose.
  • You might want to hide the menu, comment form, widget areas for the print styles. Also, the sticky header can mess up print layout.

#6 @joyously
4 months ago

I forgot to mention that all options should be in a single array. There is code to update single options for image sizes.

#7 @themetracbot
4 months ago

  • Owner set to shoutervilla
  • Status changed from new to reviewing

#8 @shrimp2t
4 months ago

Hey, @shoutervilla
Could you let me known if have any issues for this theme ?

#9 @shoutervilla
4 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello, Sorry for Inconvenience, Please consider first to resolve Theme Check Result.

If you found any issue try https://developer.wordpress.org/reference/functions/add_editor_style result for adding add_editor_style into your theme.

#10 @shrimp2t
4 months ago

Hey @shoutervilla

add_editor_style is RECOMMENDED not REQUIRED, you've closed my ticket without issues ?

This ticket was mentioned in Slack in #themereview by shrimp2t. View the logs.


4 months ago

#12 @djrmom
4 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#13 @djrmom
4 months ago

  • Status changed from reopened to reviewing

Hi @shoutervilla, tickets may be closed if 5 or more distinct requirements (https://make.wordpress.org/themes/handbook/review/required/) need to be fixed. Otherwise the ticket should be left open for the author to make updates. Please continue the review and ask here or in slack if you have any questions. Thanks.

#14 @Otto42
4 months ago

  • Owner shoutervilla deleted

Placing ticket back in queue.

#15 @themetracbot
4 months ago

  • Owner set to amolebonde

#16 @shrimp2t
4 months ago

Hey, @amolebonde
Could you let me known if have any issues for this theme ?

Last edited 4 months ago by shrimp2t (previous) (diff)

#17 @djrmom
4 months ago

  • Owner amolebonde deleted

This is being returned to the new queue again, as there has been no response yet from the reviewer. A reviewer should make an initial comment in ticket within 24 hours of being assigned, after which both reviewer and author should always communicate within 7 days.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#18 @themetracbot
4 months ago

  • Owner set to nileshg

#19 @nileshg
4 months ago

Hello shrimp2t,

I'll be reviewing your theme in some time. I'll update my comments here in some time.

Regards.

#20 @nileshg
4 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello,

Yout theme's review has been conducted on guideline based on https://make.wordpress.org/themes/handbook/review/required/. Bellow are my comments:-

Required

  1. Missing core functionality. - The homepage should display latest posts by default. Currently, it shows blank page by default.https://s22.postimg.org/eudr4234x/Screen_Shot_2017-07-07_at_11.02.01_PM.png
  2. Responsive issues. Fallback navigation, threaded comments & logo not displayed properly.

https://s1.postimg.org/a084rrp8v/Screen_Shot_2017-07-07_at_9.00.56_PM.png

  1. Tags in style.css & readme.txt, readme.md don't match.
  2. Provide a unique prefix for everything the Theme defines. Example:

https://s17.postimg.org/ayuc12mjz/Screen_Shot_2017-07-07_at_9.19.04_PM.png

  1. No minification of scripts or css files unless you provide original files. - You have not added bootstrap.css
  1. Remove blank rtl.css or add styles for rtl in it.

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues. This is part of our long-term goals to improve the theme quality and shorten the queues. You can read more about this change here: https://make.wordpress.org/themes.

joyously had already mentioned few required issues which were not solved. As your theme currently has 5 or more required issues, this ticket will be closed.

Please do not get discouraged by the ticket being closed. We want you to resubmit your theme, but we do ask that you spend more time making sure that your theme meets all the requirements. You can upload your updated theme here:
https://wordpress.org/themes/upload/

Thank you for contributing.

Regards.

#21 @shrimp2t
4 months ago

Hi @nileshg,

Thanks for your reviewing my theme,

I've uploaded new version (1.0.5) here https://themes.trac.wordpress.org/ticket/44609

About your feedback:

  1. I fixed, removed file font-page.php
  2. Add new fallback function.
  3. Updated readme files ( I think this is not required issue, just recomend )
  4. Wrap that const to conditional.
  5. Add bootstrap.css
  6. Remove services widget.
  7. Fix some bugs.

joyously is not reviewer who review this ticket so i need to wait reviewer who assigned to this ticket add their feedback to fix it.

Please open my ticket to reviewing, i has been waiting more than 2 months to get review, and now my ticket placing at the bottom of the queue.

https://themes.trac.wordpress.org/query?priority=new+theme&priority=previously+reviewed&status=new&status=reviewing&owner=&keywords=!~buddypress&page=2&col=id&col=summary&col=status&col=time&col=changetime&col=reporter&report=2&order=time

Last edited 4 months ago by shrimp2t (previous) (diff)

This ticket was mentioned in Slack in #themereview by shrimp2t. View the logs.


4 months ago

This ticket was mentioned in Slack in #themereview by shrimp2t. View the logs.


3 months ago

#24 @greenshady
3 months ago

@nileshg - Points 2, 3, and 4 are not requirements. Please make sure that you only close themes that have at least 5 legitimate issues. I've assigned you the new ticket to continue the review. You can find it here: https://themes.trac.wordpress.org/ticket/44609

Note: See TracTickets for help on using tickets.