WordPress.org

Make WordPress Themes

Opened 9 months ago

Closed 7 months ago

#43027 closed theme (not-approved)

THEME: protea – 1.0.2

Reported by: reazurra Owned by: AbdulWahab610
Priority: new theme Keywords: theme-protea
Cc: reazurra@…

Description

protea - 1.0.1

Free WordPress Theme by mizmizi

Theme URL - http://themes.mizmizi.com/protea
Author URL - http://mizmizi.com

Trac Browser - https://themes.trac.wordpress.org/browser/protea/1.0.1

SVN - https://themes.svn.wordpress.org/protea/1.0.1
ZIP - https://wordpress.org/themes/download/protea.1.0.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#43027 THEME: protea – 1.0.2 closed not-approved AbdulWahab610

(this ticket)


https://themes.svn.wordpress.org/protea/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (11)

#1 @themetracbot
9 months ago

  • Summary changed from THEME: protea – 1.0.1 to THEME: protea – 1.0.2

protea - 1.0.2

Free WordPress Theme by mizmizi

Theme URL - http://themes.mizmizi.com/protea
Author URL - http://mizmizi.com

Trac Browser - https://themes.trac.wordpress.org/browser/protea/1.0.2

SVN - https://themes.svn.wordpress.org/protea/1.0.2
ZIP - https://wordpress.org/themes/download/protea.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=protea/1.0.1&new_path=protea/1.0.2

History:

Ticket Summary Status Resolution Owner
#43027 THEME: protea – 1.0.2 closed not-approved AbdulWahab610

(this ticket)


https://themes.svn.wordpress.org/protea/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#2 @joyously
8 months ago

Here is some user feedback to consider before your review.

  • The menu needs to have a fallback for when no menu is selected. The default value of fallback_cb parameter of wp_nav_menu() works really well, and it's core functionality.
  • The content font size is a bit small with this font.
  • The regular text in the footer (and the tagline) is dark gray on black, very difficult to read.
  • Once open, the mobile menu does not react to window size changes. Making the window wider shows 2 menus and a truncated header background.

https://s21.postimg.org/rit5ngmaf/mobile-menu-persists.jpg

  • The latest posts page (mine is on a static Page) shows more posts than I set in the "Settings - Reading - Blog pages show at most" option. Themes need to respect the user's choices.
  • Post navigation links would be nice. Update: I made this comment because I did not see the links, but I just found them way at the bottom! So take that into account - your users might not see the links where you've chosen to put them, even when they are looking for them.
  • The Custom Menu widget does not show the structure of the menu (nested links do not look nested).
  • A vertical featured image overflows the container on the bottom.

https://s3.postimg.org/ky2pxwwlv/vertical-image-overflow.jpg

  • The <!--more--> tag is not showing, but it says "996".

https://s8.postimg.org/p50dlcvpx/more-tag-996.jpg

  • A video in the content overflows its container.

https://s7.postimg.org/p3iv311u3/video-overflows-container.jpg

  • A post without a title has no link to get to the post.
  • <h5> is quite small, <h6> is tiny. How is that a heading?
  • All the headings have a 60px top margin and 30px bottom margin. This seems a bit excessive, and would work better if it were proportional to the font size, so the smaller headings have a smaller margin. Try using em instead of px.
  • Tables look all smashed together.
  • The <dt> and <dd> tags look like regular text. (default margin removed)
  • The <ul> and <ol> tags have top and bottom margins that look bad when nested. (can't make a short list!)
  • The space between paragraphs feels too large for the font size.
  • The <pre> tag has a proportional font, which does not preserve the white space, which is the whole point of <pre>. Here is proportional and then monospace:

https://s8.postimg.org/r1d8akc1x/pre-tag-proportional.jpg
https://s8.postimg.org/srw9c1tl1/pre-tag-monospace.jpg

  • The <q> tag is unstyled (default removed).
  • The <small> tag is not enough smaller to be able to tell.
  • The <sub> and <sup> tags are unstyled (default removed).
  • A lot of these styling problems would be fixed easily if you normalize the styles instead of reset the styles. See http://necolas.github.io/normalize.css/
  • You might want to hide the menu, comment form, and widget areas for the print styles.
  • I searched for a non-existent keyword and got these
    NOTICE: wp-content/themes/protea/functions/post-meta.php:15 - Trying to get property of non-object
    NOTICE: wp-includes/comment-template.php:1194 - Trying to get property of non-object
    NOTICE: wp-content/themes/protea/functions/excerpts.php:20 - Trying to get property of non-object
    NOTICE: wp-includes/post-template.php:298 - Trying to get property of non-object
    
  • Search results should not show the author and date of static Pages.
  • The 404 page is not at all helpful. Sidebar, at least?
  • You have listed the Bootstrap NavWalker as GPL 2. If that is correct, your theme can't be GPL 3. That is incompatible. "2" is good with "2 or later" license, but "2" does not go with "3". WordPress is "2 or later". See https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility

It is recommended to use the standard readme.txt format to be compatible with future theme directory changes, like here: https://wordpress.org/plugins/files/2017/03/readme.txt

#3 @themetracbot
8 months ago

  • Owner set to AbdulWahab610
  • Status changed from new to reviewing

#4 @AbdulWahab610
8 months ago

Hi @reazurra
Just confirm your presence so I'll start the review :)

#5 @mizmizi
8 months ago

yes i am present

Last edited 8 months ago by mizmizi (previous) (diff)

#6 @AbdulWahab610
8 months ago

Hi @mizmizi

Bit busy in last week. Will give you review soon.

#7 @AbdulWahab610
7 months ago

Hello @mizmizi

First, you need to fix the above issues that are mentioned by @joyously.

Second, I review your Theme and find some issues that are required to fix.

Non-breaking text in the title, content, and comments http://prntscr.com/fw2wnx

Use the_archive_title for displaying archive titles.

Using a function get_post_format(); in index, archive and single.php but didn't define any format type. You create a function protea_post_video() for video format but didn't use anywhere.

Using a function get_theme_mod(); much in your theme. Why are you using this? This function should be used with set_theme_mod():https://codex.wordpress.org/Function_Reference/set_theme_mod or Settings API:https://codex.wordpress.org/Settings_API remove this function from the whole theme or use properly.

Comments layout:
with YouTube link: http://prntscr.com/fw32g8
with Image: http://prntscr.com/fw32ou
with the block of code: http://prntscr.com/fw334g

Using single_term_title() & term_description() function without any defination.

Here is a file fullwidth.php without calling anywhere remove it if don't need.

Suggestion:

In post-meta.php#45 using only category name here should be used a complete list of the category of that post.

In the footer, you display 3 widgets:
Case:
If the user wants to display only one widget than the other two remains empty.
Similarly, if the user wants to display two widgets in the footer then the 3rd widget remains empty. The empty area isn't looking good.
Solution:
If the user wants to use/select only one footer widget. The footer should convert it into one div,

example: <div class="col-md-12">

Similarly, if the user wants to use/select two widgets. The footer should convert it into two div,

example: <div class="col-md-6"> by <div class="col-md-6">

and for the three widgets, using the same strategy that you do.

#8 @joyously
7 months ago

Just a few notes:

Using a function get_post_format(); in index, archive and single.php but didn't define any format type.

This can be done for child themes.

Using a function get_theme_mod(); much in your theme. Why are you using this? This function should be used with set_theme_mod()

This is not entirely accurate. You can use get_theme_mod() without calling set_theme_mod(). The Customizer saving will put the options in the database. (Try searching Twenty Seventeen.)

Using single_term_title() & term_description() function without any defination.

What does this mean? Core functions are there to use.

Here is a file fullwidth.php without calling anywhere remove it if don't need.

This is a Page template. The user chooses it, not the theme.

#9 @AbdulWahab610
7 months ago

Follow up:

Really sorry about missing the core functions and Page Template. I just missed that.

Yes, we can use get_theme_mod() without set_theme_mod() but here no setting in Customizer for saving that options in the database.

Thanks, @joyously.

#10 @AbdulWahab610
7 months ago

Hello @mizmizi

How are you getting on with the update? Tickets are normally closed if there is no response within 7 days.

#11 @AbdulWahab610
7 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.