WordPress.org

Make WordPress Themes

Opened 7 months ago

Closed 5 months ago

#43102 closed theme (not-approved)

THEME: Stripes – 2017.4

Reported by: stripeswp Owned by: kharisblank
Priority: previously reviewed Keywords: theme-stripes
Cc: bhadaway+stripes@…

Description

Stripes - 2017.0

2 menu areas, 3 widget areas, 2 page templates, easily upload a custom logo, background, add Google fonts, and more. Fully responsive with WooCommerce and bbPress support built right in. Being carefully coded with quality and minimalism, Stripes manages to pack a punch and remain blazing-fast, without all the bloat.

Theme URL - https://github.com/stripeswp/stripes
Author URL - https://github.com/stripeswp

Trac Browser - https://themes.trac.wordpress.org/browser/stripes/2017.0

SVN - https://themes.svn.wordpress.org/stripes/2017.0
ZIP - https://wordpress.org/themes/download/stripes.2017.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=stripes/1.2&new_path=stripes/2017.0

History:

Ticket Summary Status Resolution Owner
#10177 THEME: Stripes and Blue - 1.0 closed not-approved nishasingh
#10417 THEME: Stripes and Blue - 1.1 closed closed-newer-version-uploaded Fingli
#11041 THEME: Stripes and Blue - 1.2 closed live Fingli
#43102 THEME: Stripes – 2017.4 closed not-approved kharisblank

(this ticket)

#44776 THEME: Stripes – 2017.9 closed live kevinhaig
#46652 THEME: Stripes – 2017.10 closed live themetracbot
#46721 THEME: Stripes – 2017.11 closed live themetracbot


https://themes.svn.wordpress.org/stripes/2017.0/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.

Change History (20)

#1 @themetracbot
7 months ago

  • Summary changed from THEME: Stripes – 2017.0 to THEME: Stripes – 2017.1

Stripes - 2017.1

Trying to make the best darn, always free theme that I can. 2 menu areas, 3 widget areas, 2 page templates, easily upload a custom logo, background, add Google fonts, and more. Fully responsive with WooCommerce and bbPress support built right in. Being carefully coded with quality and minimalism, Stripes manages to pack a punch and remain blazing-fast, without all the bloat.

Theme URL - https://github.com/stripeswp/stripes
Author URL - https://stripeswp.com/

Trac Browser - https://themes.trac.wordpress.org/browser/stripes/2017.1

SVN - https://themes.svn.wordpress.org/stripes/2017.1
ZIP - https://wordpress.org/themes/download/stripes.2017.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=stripes/2017.0&new_path=stripes/2017.1

History:

Ticket Summary Status Resolution Owner
#10177 THEME: Stripes and Blue - 1.0 closed not-approved nishasingh
#10417 THEME: Stripes and Blue - 1.1 closed closed-newer-version-uploaded Fingli
#11041 THEME: Stripes and Blue - 1.2 closed live Fingli
#43102 THEME: Stripes – 2017.4 closed not-approved kharisblank

(this ticket)

#44776 THEME: Stripes – 2017.9 closed live kevinhaig
#46652 THEME: Stripes – 2017.10 closed live themetracbot
#46721 THEME: Stripes – 2017.11 closed live themetracbot


https://themes.svn.wordpress.org/stripes/2017.1/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#2 @joyously
6 months ago

Here is some user feedback to consider before your review.

  • Wow, how did you get all this in a 73K zip? Awesome
  • The menu restriction of only one level showing on mobile needs to be documented for the user.
  • The <!--more--> tag should render a link.

https://s1.postimg.org/waw38uvb3/more-tag.jpg

  • Floats are not being cleared properly after the content area.

https://s13.postimg.org/wucxpdus7/floats-not-cleared.jpg

  • Lists have a bottom margin that makes nested lists look odd (and too tall).
  • The <pre> tag is using a proportional font, which does not preserve whitespace (which is the whole purpose of pre).
  • The <q> tag is unstyled (default removed).
  • This does not work well for nested tags and user changes in font size: small, sup, sub {font-size: 14px;} It should use a relative size, such as the browser defaults. Same for <big>.
  • You might want to hide the menu, comment form, widget areas for the print styles.
  • The pingback comments are labeled as trackbacks.
  • The sidebar is not shown on the single post page. (either add it or put something in the widget area description)
  • On the search page, a custom post type does not have the same bottom margin as posts and pages.
  • Customizer, Header Text Color - default is red, but that doesn't match the front end.
  • Customizer, Background Color - changing this has no effect, although I see it when I navigate to another page.
  • Customizer, Header Image - the header image replaces site title. That's a little bit obnoxious.
  • Customizer, Fonts, Header Text Font - add description for limits or possible values or syntax help.

#3 @themetracbot
6 months ago

  • Summary changed from THEME: Stripes – 2017.1 to THEME: Stripes – 2017.2

Stripes - 2017.2

Trying to make the best darn, always free theme that I can. 2 menu areas, 3 widget areas, 2 page templates, easily upload a custom logo, background, add Google fonts, and more. Fully responsive with WooCommerce and bbPress support built right in. Being carefully coded with quality and minimalism, Stripes manages to pack a punch and remain blazing-fast, without all the bloat.

Theme URL - https://github.com/stripeswp/stripes
Author URL - https://stripeswp.com/

Trac Browser - https://themes.trac.wordpress.org/browser/stripes/2017.2

SVN - https://themes.svn.wordpress.org/stripes/2017.2
ZIP - https://wordpress.org/themes/download/stripes.2017.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=stripes/2017.1&new_path=stripes/2017.2

History:

Ticket Summary Status Resolution Owner
#10177 THEME: Stripes and Blue - 1.0 closed not-approved nishasingh
#10417 THEME: Stripes and Blue - 1.1 closed closed-newer-version-uploaded Fingli
#11041 THEME: Stripes and Blue - 1.2 closed live Fingli
#43102 THEME: Stripes – 2017.4 closed not-approved kharisblank

(this ticket)

#44776 THEME: Stripes – 2017.9 closed live kevinhaig
#46652 THEME: Stripes – 2017.10 closed live themetracbot
#46721 THEME: Stripes – 2017.11 closed live themetracbot


https://themes.svn.wordpress.org/stripes/2017.2/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#4 @stripeswp
6 months ago

Hi @joyously,

Wow, how did you get all this in a 73K zip? Awesome

I've got to say, that's a refreshing reaction. Usually, I receive only confusion and criticism. I'm a minimalist and I hate bloat. I try to do everything in the simplest and cleanest way I can, including not adding unnecessary things, semi-minifying the code, and most importantly, using .jpg instead of .png for the screenshot (which should become the new standard).

Excellent feedback and I believe I was able to fix every item, which has made for a much better theme.

Thank you!

#5 @joyously
6 months ago

I'm a minimalist and I hate bloat. I try to do everything in the simplest and cleanest way I can, including not adding unnecessary things, semi-minifying the code, and most importantly, using .jpg instead of .png for the screenshot (which should become the new standard).

I agree with all of this, so we're kindred spirits. I've looked at several themes with 3 or 4 Meg zip files. Often the screenshot is half of it, along with a large header image (or worse, placeholder images for a slider, which are never used). I'm not sure that those authors have ever pulled up the theme repo on a slow connection, watching those large image files slowly appear. Themes with small screenshots pop right in.

An idea for your evolving theme: implement featured image support, because people love images and won't choose a theme without them after a theme that has it.

#6 @stripeswp
6 months ago

It does and I agree. Featured images are just hidden in entry-content.php because of the way templates are set up to only use what's needed, but also to allow for more surgical child-theming.

Even though philosophically, I'm generally against themes that do too much, that are all-in-one, cookie-cutter, bloat monsters, I'm trying to go that direction, but trying to do it right, do it differently.

So, I want to incorporate as many essentials as possible, while still not flying too close to the sun. ;)

I want to support popular plugins like WooCommerce and bbPress for common pain points that occur between them and themes. I also want to keep adding things based on feedback. Things that make sense for a large enough group of people. Not all the bells and whistles one can dream up, just really useful ones.

#7 @themetracbot
6 months ago

  • Summary changed from THEME: Stripes – 2017.2 to THEME: Stripes – 2017.3

Stripes - 2017.3

Add layered content with the Layers companion plugin: https://wordpress.org/plugins/layers/. Trying to make the best darn, always free theme that I can. 2 menu areas, 3 widget areas, 2 page templates, easily upload a custom logo, background, add Google fonts, and more. Fully responsive with WooCommerce and bbPress support built right in. Being carefully coded with quality and minimalism, Stripes manages to pack a punch and remain blazing-fast, without all the bloat.

Theme URL - https://github.com/stripeswp/stripes
Author URL - https://stripeswp.com/

Trac Browser - https://themes.trac.wordpress.org/browser/stripes/2017.3

SVN - https://themes.svn.wordpress.org/stripes/2017.3
ZIP - https://wordpress.org/themes/download/stripes.2017.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=stripes/2017.2&new_path=stripes/2017.3

History:

Ticket Summary Status Resolution Owner
#10177 THEME: Stripes and Blue - 1.0 closed not-approved nishasingh
#10417 THEME: Stripes and Blue - 1.1 closed closed-newer-version-uploaded Fingli
#11041 THEME: Stripes and Blue - 1.2 closed live Fingli
#43102 THEME: Stripes – 2017.4 closed not-approved kharisblank

(this ticket)

#44776 THEME: Stripes – 2017.9 closed live kevinhaig
#46652 THEME: Stripes – 2017.10 closed live themetracbot
#46721 THEME: Stripes – 2017.11 closed live themetracbot


https://themes.svn.wordpress.org/stripes/2017.3/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#8 @themetracbot
6 months ago

  • Summary changed from THEME: Stripes – 2017.3 to THEME: Stripes – 2017.4

Stripes - 2017.4

Add layered content with the Layers companion plugin: https://wordpress.org/plugins/layers/. Trying to make the best darn, always free theme that I can. 2 menu areas, 3 widget areas, 2 page templates, easily upload a custom logo, background, add Google fonts, and more. Fully responsive with WooCommerce and bbPress support built right in. Being carefully coded with quality and minimalism, Stripes manages to pack a punch and remain blazing-fast, without all the bloat.

Theme URL - https://github.com/stripeswp/stripes
Author URL - https://stripeswp.com/

Trac Browser - https://themes.trac.wordpress.org/browser/stripes/2017.4

SVN - https://themes.svn.wordpress.org/stripes/2017.4
ZIP - https://wordpress.org/themes/download/stripes.2017.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=stripes/2017.3&new_path=stripes/2017.4

History:

Ticket Summary Status Resolution Owner
#10177 THEME: Stripes and Blue - 1.0 closed not-approved nishasingh
#10417 THEME: Stripes and Blue - 1.1 closed closed-newer-version-uploaded Fingli
#11041 THEME: Stripes and Blue - 1.2 closed live Fingli
#43102 THEME: Stripes – 2017.4 closed not-approved kharisblank

(this ticket)

#44776 THEME: Stripes – 2017.9 closed live kevinhaig
#46652 THEME: Stripes – 2017.10 closed live themetracbot
#46721 THEME: Stripes – 2017.11 closed live themetracbot


https://themes.svn.wordpress.org/stripes/2017.4/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#9 @stripeswp
6 months ago

This theme has a companion plugin: https://wordpress.org/plugins/layers/

#10 @themetracbot
6 months ago

  • Owner set to kharisblank
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #themereview by kharisulistiyo. View the logs.


5 months ago

#12 @kharisblank
5 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Thank you for submitting your theme. Here is the review result:

NS Theme Check

The NS Theme Check is displaying these errors.

FILE: /srv/www/mywp/htdocs/wp-content/themes/stripes/about.php
———————————————————————-
FOUND 1 ERROR AFFECTING 1 LINE
———————————————————————-
14 | ERROR | Strings should have translatable content
———————————————————————-

Time: 24997626 mins, 21.79 secs; Memory: 4Mb

FILE: /srv/www/mywp/htdocs/wp-content/themes/stripes/functions.php
————————————————————————————————————–
FOUND 2 ERRORS AFFECTING 2 LINES
————————————————————————————————————–
103 | ERROR | Overriding WordPress globals is prohibited
194 | ERROR | The function ucwords() does not have a parameter “delimiters” in PHP version 5.4.31 or earlier
————————————————————————————————————–

Licensing

  • Please properly mention the license statement of all assets you’re using including media, CSS and JS libraries in the README.txt file. Be sure they are 100% GPL and/or 100% GPL-compatible.

Code Quality

  • Please use multiline CSS instead of single line which will help users easy to learn and edit the code.
  • Implement a proper PHP code indentation, so that it'll be easier to read.

Prefixing

  • Please prefix all functions to avoid conflicting with other functions that may come either from WP core or other active plugins. For instance, woocommerce_support is insecure for other plugins might possibly this function name

Data validation

All input/output data must be validated for security reason. I found the below data haven't been validated yet. Refer to this codex https://codex.wordpress.org/Data_Validation

    get_permalink
    wp_get_attachment_url
    $att_image[0];
    get_header_image()
    alt=”post_excerpt; ?>”

Responsiveness issue

Please use the monster widget plugin https://wordpress.org/plugins/monster-widget/ and test it in all of your sidebar areas with narrower browser window. I did this already and found image in the sidebar overlaps its container -- all image should be responsive.

JS script

Please properly include JS script in theme. Avoid writing it directly in the functions.php to output internal script. For instance:

if ( !is_admin() ) {
?>

jQuery(document).ready(function($){
$("#wrapper").vids();
});

<?php
}

You can use either wp_add_inline_script https://developer.wordpress.org/reference/functions/wp_add_inline_script/ or move it into the main theme’s JS file.

As there are more than 5 issues found, this ticket is closed. Please refine your theme in the new version and reupload it.

Best,
Kharis

#13 @stripeswp
5 months ago

Hi @kharisblank,

Thank you for your time.

Correct me if I'm wrong, the 5 issue rule is for required issues, not recommended issues, correct? Additionally, I don't agree with all the points made anyways.

Either way, is there no longer any grace time at all in which to upload a new version before being sent to the very beginning of the review queue again?

NS Theme Check

Is this a new plugin? Are we now required to pass these tests in addition to the original Theme Check?:

https://wordpress.org/plugins/theme-check/

Licensing

There is nothing here that requires a special mention. Everything is covered under:

License: GNU General Public License
License URI: https://www.gnu.org/licenses/gpl.html

Code Quality

This is a recommendation and opinion only.

Prefixing

This is not a conflict or a custom function. This is the specific declaration that's required officially by the WooCommerce plugin.

Data Validation

Happy to fix once this review is re-opened so that I may upload a new version.

Responsiveness Issue

The theme is fully responsive. That said, there will always be things that will break that responsiveness. It's impossible to accommodate all variables and I would argue it's a bad idea to overreach too much to where you're enforcing things that might actually begin breaking things in other ways.

JS Script

This has come up before and was given exemption by an admin.

As you can see, I contest most issues you've listed, and therefore might be well under the threshold of a true 5 required issues. That said, the rules and available code is constantly evolving. What might have been true in a previous review, might not be true now.

This will likely require a second opinion from an admin to confirm what's required and what isn't.

Thank you.

#14 @grapplerulrich
5 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

I hope this answers the questions.

NS Theme Check

Is this a new plugin?

This is a new plugin that we are working on to help automate the code reviews. Once the development is completed there will be only one Theme Check plugin.

Prefixing

This is not a conflict or a custom function.

The function should be named stripes_woocommerce_support() instead of woocommerce_support()

JS Script

This has come up before and was given exemption by an admin.

As wp_add_inline_script() was added in WP 4.5 which was over a year ago this falls under the requirement of using WordPress core features.

Responsiveness Issue & Code Quality Styling

These are both recommended but not requirements.

@kharisblank As I could only count 4 issues I think it is only fair to reopen the ticket. NS Theme Check, JS script, Prefixing & Data Validation.

#15 @grapplerulrich
5 months ago

  • Status changed from reopened to reviewing

#16 @kharisblank
5 months ago

Hello @stripeswp,

I am sorry, that was my mistake. @grapplerulrich thank you for your help.

#17 @stripeswp
5 months ago

@kharisblank

No worries at all. There are millions of variables and unique situations. We all just try our best to keep these themes safe and clean. But, it's impossible for this process to ever be perfect; it's impossible to know or keep track of all the guidelines; it's impossible to ever get a theme 100% perfect.

Okay, I've been able to correct all issues except for "Overriding WordPress globals is prohibited," which specifically involves this line:

$GLOBALS['comment'] = $comment;

And here's the entire block:

add_action( 'comment_form_before', 'stripes_enqueue_comment_reply_script' );
function stripes_enqueue_comment_reply_script()
{
if ( get_option( 'thread_comments' ) ) { wp_enqueue_script( 'comment-reply' ); }
}
function stripes_custom_pings( $comment )
{
$GLOBALS['comment'] = $comment;
?>
<li <?php comment_class(); ?> id="li-comment-<?php comment_ID(); ?>"><?php echo comment_author_link(); ?></li>
<?php 
}
add_filter( 'get_comments_number', 'stripes_comment_count', 0 );
function stripes_comment_count( $count ) {
if ( ! is_admin() ) {
global $id;
$get_comments = get_comments( 'status=approve&post_id=' . $id );
$comments_by_type = separate_comments( $get_comments );
return count( $comments_by_type['comment'] );
} else {
return $count;
}
}

And comments.php here: https://themes.trac.wordpress.org/browser/stripes/2017.4/comments.php?rev=79032

It's just a simple customization for a slightly cleaner presentation of: comments, trackbacks, and pingbacks.

@grapplerulrich

Any suggestions for keeping this intact, while appeasing NS Theme Check, maybe an exception, or should I just remove it altogether?

Thank you!

#18 @grapplerulrich
5 months ago

I could not seem to figure out why $GLOBALS['comment'] = $comment; was needed.

I am 99% sure this code should do the same thing.

function stripes_custom_pings( $comment )
{
?>
<li <?php comment_class('',$comment); ?> id="li-comment-<?php echo apply_filters( 'get_comment_ID', $comment->comment_ID, $comment ); ?>"><?php echo comment_author_link($comment); ?></li>
<?php
}

EDIT: It seems $GLOBALS['comment'] = $comment; is really not needed.

In `Walker_Comment::start_el` is $GLOBALS['comment'] = $comment; being defined in L176 shortly before the custom call back L180

So really you can just do.

function stripes_custom_pings( $comment )
{
?>
<li <?php comment_class(); ?> id="li-comment-<?php comment_ID(); ?>"><?php echo comment_author_link(); ?></li>
<?php
}

Last edited 5 months ago by grapplerulrich (previous) (diff)

#19 @stripeswp
5 months ago

Awesome. Thank you. Yes, that keeps everything intact. Looks like just another thing that was necessary in older versions of WordPress, but has now been addressed with newer versions straight out-of-the-box.

New version uploaded: https://themes.trac.wordpress.org/ticket/44776

Assuming because this ticket was closed and then re-opened, it got disconnected and started a new ticket instead of updating this one here.

#20 @rabmalin
5 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.