WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 2 months ago

Last modified 2 months ago

#43222 closed theme (live)

THEME: HitMag – 1.0.6

Reported by: Pubudu Malalasekara Owned by: uxl
Priority: new theme Keywords: theme-hitmag
Cc: pubuduranjan@…

Description

HitMag - 1.0.0

A powerfull magazine wordpress theme.

Theme URL - http://themezhut.com/themes/hitmag/
Author URL - http://themezhut.com

Trac Browser - https://themes.trac.wordpress.org/browser/hitmag/1.0.0

SVN - https://themes.svn.wordpress.org/hitmag/1.0.0
ZIP - https://wordpress.org/themes/download/hitmag.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#43222 THEME: HitMag – 1.0.6 closed live uxl

(this ticket)

#45776 THEME: HitMag – 1.0.7 closed live themetracbot
#45886 THEME: HitMag – 1.0.8 closed live themetracbot
#46464 THEME: HitMag – 1.0.9 closed live themetracbot


https://themes.svn.wordpress.org/hitmag/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are hitmag, kirki

Change History (31)

#1 @themetracbot
4 months ago

  • Summary changed from THEME: HitMag – 1.0.0 to THEME: HitMag – 1.0.1

HitMag - 1.0.1

A powerfull magazine wordpress theme.

Theme URL - http://themezhut.com/themes/hitmag/
Author URL - http://themezhut.com

Trac Browser - https://themes.trac.wordpress.org/browser/hitmag/1.0.1

SVN - https://themes.svn.wordpress.org/hitmag/1.0.1
ZIP - https://wordpress.org/themes/download/hitmag.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hitmag/1.0.0&new_path=hitmag/1.0.1

History:

Ticket Summary Status Resolution Owner
#43222 THEME: HitMag – 1.0.6 closed live uxl

(this ticket)

#45776 THEME: HitMag – 1.0.7 closed live themetracbot
#45886 THEME: HitMag – 1.0.8 closed live themetracbot
#46464 THEME: HitMag – 1.0.9 closed live themetracbot


https://themes.svn.wordpress.org/hitmag/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are hitmag, kirki

#2 @themetracbot
4 months ago

  • Summary changed from THEME: HitMag – 1.0.1 to THEME: HitMag – 1.0.2

HitMag - 1.0.2

HitMag is a stylish and powerful theme crafted for magazines, newspapers or personal blogs. HitMag comes with a handful of options to customize your site the way you want. Free version has included a magazine homepage layout, 4 different style blog listing layouts and main color options. Not only that it comes with so many handful of features like social sharing, author details box, Related posts after articles and control post metadata. All those features and options ensures that HitMag is not just another free WordPress theme but a powerful theme that fulfills all of the basic needs.

Theme URL - http://themezhut.com/themes/hitmag/
Author URL - http://themezhut.com

Trac Browser - https://themes.trac.wordpress.org/browser/hitmag/1.0.2

SVN - https://themes.svn.wordpress.org/hitmag/1.0.2
ZIP - https://wordpress.org/themes/download/hitmag.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hitmag/1.0.1&new_path=hitmag/1.0.2

History:

Ticket Summary Status Resolution Owner
#43222 THEME: HitMag – 1.0.6 closed live uxl

(this ticket)

#45776 THEME: HitMag – 1.0.7 closed live themetracbot
#45886 THEME: HitMag – 1.0.8 closed live themetracbot
#46464 THEME: HitMag – 1.0.9 closed live themetracbot


https://themes.svn.wordpress.org/hitmag/1.0.2/screenshot.png
Theme Check Results:

  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are hitmag, kirki

#3 @themetracbot
4 months ago

  • Summary changed from THEME: HitMag – 1.0.2 to THEME: HitMag – 1.0.3

HitMag - 1.0.3

HitMag is a stylish and powerful theme crafted for magazines, newspapers or personal blogs. HitMag comes with a handful of options to customize your site the way you want. Free version has included a magazine homepage layout, 4 different style blog listing layouts and main color options. Not only that it comes with so many handful of features like social sharing, author details box, Related posts after articles and control post metadata. All those features and options ensures that HitMag is not just another free WordPress theme but a powerful theme that fulfills all of the basic needs.

Theme URL - http://themezhut.com/themes/hitmag/
Author URL - http://themezhut.com

Trac Browser - https://themes.trac.wordpress.org/browser/hitmag/1.0.3

SVN - https://themes.svn.wordpress.org/hitmag/1.0.3
ZIP - https://wordpress.org/themes/download/hitmag.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hitmag/1.0.2&new_path=hitmag/1.0.3

History:

Ticket Summary Status Resolution Owner
#43222 THEME: HitMag – 1.0.6 closed live uxl

(this ticket)

#45776 THEME: HitMag – 1.0.7 closed live themetracbot
#45886 THEME: HitMag – 1.0.8 closed live themetracbot
#46464 THEME: HitMag – 1.0.9 closed live themetracbot


https://themes.svn.wordpress.org/hitmag/1.0.3/screenshot.png
Theme Check Results:

  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are hitmag, kirki

#4 @Pubudu Malalasekara
4 months ago

I cannot understand why "Diff with previous version" shows incorrectly. In 1.0.2 and 1.0.3 versions "Diff with previous versions shows incorrectly. Although there are small changes with only few files it shows as all the files edited.

Last edited 4 months ago by Pubudu Malalasekara (previous) (diff)

#5 @joyously
4 months ago

Here is some user feedback to consider before your review.

  • When I do not put widgets in the Sidebar, there is still space allocated to it. What good is that?
  • The mobile menu does not disappear when making the window wider (so both menus are showing).
  • I put the "HitMag: Popular Posts, Tags, Comments" widget in the footer. The links are black on dark gray. Sounds like the styling for links is too specific because other widgets have links that are white in the footer.
  • blockquote is styled as italic, but can have nested <em> and <cite> tags which are indistinguishable. It really does not need italics because it has a background color, a larger font size, and a left bar.
  • <q> tag is styled like a blockquote, but it is for short, inline quotes. It messes up user's sentences when styled as a block.
  • You might want to hide the menu, comment form, widget areas, and related posts for the print styles.
  • Social media share buttons are plugin territory and should be removed.
  • I was able to put a widget into the "Header Sidebar", but I never saw it displayed. Actually, I think I saw a piece of it in the print preview. Either improve the description of the widget area to indicate when it is shown or do not register it until it is enabled (if it's an option).
  • This theme looks great.

#6 @hardeepasrani
4 months ago

  • Owner set to rohittm
  • Status changed from new to reviewing

#7 @djrmom
3 months ago

@rohittm, are you still able to review this theme? If not, I can reassign. Thanks.

#8 @Rohittm
3 months ago

I will, I wasn't able to find the theme at Theme review assigned to me tab. Now that I have bookmarked it. I will do this. Sorry for not responding earlier.

#9 @djrmom
3 months ago

  • Owner changed from rohittm to Rohittm

#10 @Rohittm
3 months ago

So yes, I am now reviewing this theme, will give my reviews within couple of days. Thank you

#11 @Pubudu Malalasekara
3 months ago

Hello @joyously,

Thanks a lot for the feedback and showing issues. I will fix those issues after the first review by the reviewer.

Thank You.

This ticket was mentioned in Slack in #themereview by rohit. View the logs.


3 months ago

#13 @Pubudu Malalasekara
3 months ago

Hi @djrmom, Could you please assign this ticket to another reviewer? Rohittm is asking to do so on Slack.

Thank You.

#14 @djrmom
3 months ago

  • Owner Rohittm deleted

#15 @themetracbot
3 months ago

  • Owner set to uxl

#16 @uxl
3 months ago

Hi, completed an initial review of version 1.0.3

The following are required to be fixed

  • There are quite a lot of strings which are not sanitized/escaped correctly e.g. /inc/customizer/customizer.php L28 __( 'Header options', 'hitmag' ),

Please check all files and make sure all strings including translates are properly escaped.
https://make.wordpress.org/themes/handbook/review/required/#code
https://codex.wordpress.org/Data_Validation

  • Sticky posts are not distinguished in some way from normal posts.
  • The post titles of the 'HitMag:' widgets are very hard to read when placed in the footer. More specific styling is required e.g. .hmw-grid-post .post-title a could be changed to something like #primary .hmw-grid-post .post-title a

I realise that these widgets are not intended for the footer area but users invariably will (and should be able to) use them in any sidebar.

  • As previously mentioned by @joyously social media share buttons are plugin territory and should be removed. You could recommend a social media sharing plugin instead.
  • The open mobile menu does not close when resizing to a larger screen, and with no way to close it also.

Recommended

Just to clarify the Header Sidebar issue. It would also not display for me until I realised that I had Ad Blocking extension turned on in my browser. Turning my ad blocker off and it displayed OK.

I then changed the name of the container from header-ad-area to header-image-area and my ad blocker ignored it. Something to think about as users may choose to use the Header Sidebar for some content other than an advertisement.

#17 @themetracbot
3 months ago

  • Summary changed from THEME: HitMag – 1.0.3 to THEME: HitMag – 1.0.4

HitMag - 1.0.4

HitMag is a stylish and powerful theme crafted for magazines, newspapers or personal blogs. HitMag comes with a handful of options to customize your site the way you want. Free version has included a magazine homepage layout, 4 different style blog listing layouts and main color options. Not only that it comes with so many handful of features like social sharing, author details box, Related posts after articles and control post metadata. All those features and options ensures that HitMag is not just another free WordPress theme but a powerful theme that fulfills all of the basic needs.

Theme URL - http://themezhut.com/themes/hitmag/
Author URL - http://themezhut.com

Trac Browser - https://themes.trac.wordpress.org/browser/hitmag/1.0.4

SVN - https://themes.svn.wordpress.org/hitmag/1.0.4
ZIP - https://wordpress.org/themes/download/hitmag.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hitmag/1.0.3&new_path=hitmag/1.0.4

History:

Ticket Summary Status Resolution Owner
#43222 THEME: HitMag – 1.0.6 closed live uxl

(this ticket)

#45776 THEME: HitMag – 1.0.7 closed live themetracbot
#45886 THEME: HitMag – 1.0.8 closed live themetracbot
#46464 THEME: HitMag – 1.0.9 closed live themetracbot


https://themes.svn.wordpress.org/hitmag/1.0.4/screenshot.png
Theme Check Results:

  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are hitmag, kirki

#18 @Pubudu Malalasekara
3 months ago

Hi @uxl,

Thanks a lot for the review and the guidance. I have fixed the issues mentioned by you and joyously. Following are the changes made to the new update.

  • Fixed mobile menu not disappearing issue.
  • Hitmag Popular posts, tags, comments restyled for footer.
  • All the widgets are now working on any sidebar except header advertisement area.
  • Removed block styling for <q> tag.
  • Removed social media buttons.
  • Header sidebar renamed to Header Advertisement Area.
  • Escaped translation functions.
  • Posts widgets styled for footer.
  • Edited translation file.

Thank You.

#19 @uxl
3 months ago

Continuing review of updated version 1.0.4

Required

  • There are still some translation functions that need escaping:
  • functions.php L133, L142, L151
  • inc/class-meta-boxes.php L38
  • inc/customizer/custom-controls/control-category-dropdown.php L16
  • inc/template-tags.php L79, L84
  • inc/widgets/block-posts-dual.php L13, L14, L30, L34, L35, L39
  • inc/widgets/block-posts-grid.php L13, L14, L30, L34
  • inc/widgets/block-posts-single.php L14, L15, L29, L31
  • inc/widgets/popular-tags-comments.php L15, L16
  • inc/widgets/sidebar-posts.php L14, L15, L30
  • single.php L26, L28
  • template-parts/authorbox.php L11
  • the hitmag_social_sharing_buttons() function needs to be removed from inc/template-tags.php
  • Sticky posts are not distinguished in some way from normal posts

https://s17.postimg.org/toaqqiwbj/hitmag-sticky-posts.jpg

Last edited 3 months ago by uxl (previous) (diff)

#20 @Pubudu Malalasekara
3 months ago

Hi @uxl,

Thanks for showing those issues. I will correct them. I haven't used sticky-post tag in the style.css. As per my knowledge I think theme needs to have a visual distinctive for sticky posts if it has sticky-post tag. Please correct me if I am wrong.

Thank You.

#21 @uxl
3 months ago

Hi @pubudu-malalasekara

Yes you are absolutely correct, my mistake sorry about that. Thought I had seen sticky-post tag but I can see you are not using it.

If you can fix the other issues in comment:19 I'll mark as approved.

Last edited 3 months ago by uxl (previous) (diff)

#22 @themetracbot
3 months ago

  • Summary changed from THEME: HitMag – 1.0.4 to THEME: HitMag – 1.0.5

HitMag - 1.0.5

HitMag is a stylish and powerful theme crafted for magazines, newspapers or personal blogs. HitMag comes with a handful of options to customize your site the way you want. Free version has included a magazine homepage layout, 4 different style blog listing layouts and main color options. Not only that it comes with so many handful of features like social sharing, author details box, Related posts after articles and control post metadata. All those features and options ensures that HitMag is not just another free WordPress theme but a powerful theme that fulfills all of the basic needs.

Theme URL - http://themezhut.com/themes/hitmag/
Author URL - http://themezhut.com

Trac Browser - https://themes.trac.wordpress.org/browser/hitmag/1.0.5

SVN - https://themes.svn.wordpress.org/hitmag/1.0.5
ZIP - https://wordpress.org/themes/download/hitmag.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hitmag/1.0.4&new_path=hitmag/1.0.5

History:

Ticket Summary Status Resolution Owner
#43222 THEME: HitMag – 1.0.6 closed live uxl

(this ticket)

#45776 THEME: HitMag – 1.0.7 closed live themetracbot
#45886 THEME: HitMag – 1.0.8 closed live themetracbot
#46464 THEME: HitMag – 1.0.9 closed live themetracbot


https://themes.svn.wordpress.org/hitmag/1.0.5/screenshot.png
Theme Check Results:

  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are hitmag, kirki

#23 @Pubudu Malalasekara
3 months ago

Hi @uxl,

I guess I have fixed all the issues.

Thank You.

#24 @uxl
3 months ago

  • Status changed from reviewing to approved

Thanks, marking HitMag as approved.

Looking good it's a really nice theme and the welcome page is very helpful in explaining how to set up the magazine homepage.

#25 @Pubudu Malalasekara
3 months ago

Hi @uxl,

I am really glad you like the theme. Thanks again for the review.

#26 @rabmalin
2 months ago

  • Cc rabmalin added
  • Status changed from approved to reopened

Hello,

Please fix following issues are re-upload your theme.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Issues

  • REQUIRED: include_once( dirname( __FILE__ ) . '/inc/kirki/kirki.php' ); - Please use get_template_directory() to load non template PHP files.
  • REQUIRED: Closures / anonymous functions are not available in PHP 5.2 or earlier. inc/customizer/custom-controls/control-category-dropdown.php L35
  • REQUIRED: In readme file, please declare your theme copyright in following format.
    Fred WordPress Theme, Copyright 2012 Joe Smith
    Fred is distributed under the terms of the GNU GPL
    
  • REQUIRED: block-posts-grid.php L141 - Use esc_url() for escaping rather than esc_url_raw(). esc_url_raw() should be only used for sanitization of URL. Please check other places also.
  • REQUIRED: Incorrect prefixing - register_hitmag_tabbed_widget()
  • REQUIRED: Never use wp_reset_query(). Use wp_reset_postdata() instead.
  • REQUIRED: Translation issue - block-posts-dual.php L45. Please check in other places also.
  • REQUIRED: popular-tags-comments.php - Do not use inline script. Please use enqueu approach.

#27 @rabmalin
2 months ago

  • Status changed from reopened to reviewing

#28 @themetracbot
2 months ago

  • Summary changed from THEME: HitMag – 1.0.5 to THEME: HitMag – 1.0.6

HitMag - 1.0.6

HitMag is a stylish and powerful theme crafted for magazines, newspapers or personal blogs. HitMag comes with a handful of options to customize your site the way you want. Free version has included a magazine homepage layout, 4 different style blog listing layouts and main color options. Not only that it comes with so many handful of features like author details box, Related posts after articles and control post metadata. All those features and options ensures that HitMag is not just another free WordPress theme but a powerful theme that fulfills all of the basic needs. See all the theme information at https://themezhut.com/themes/hitmag/

Theme URL - http://themezhut.com/themes/hitmag/
Author URL - http://themezhut.com

Trac Browser - https://themes.trac.wordpress.org/browser/hitmag/1.0.6

SVN - https://themes.svn.wordpress.org/hitmag/1.0.6
ZIP - https://wordpress.org/themes/download/hitmag.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=hitmag/1.0.5&new_path=hitmag/1.0.6

History:

Ticket Summary Status Resolution Owner
#43222 THEME: HitMag – 1.0.6 closed live uxl

(this ticket)

#45776 THEME: HitMag – 1.0.7 closed live themetracbot
#45886 THEME: HitMag – 1.0.8 closed live themetracbot
#46464 THEME: HitMag – 1.0.9 closed live themetracbot


https://themes.svn.wordpress.org/hitmag/1.0.6/screenshot.png
Theme Check Results:

  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are hitmag, kirki

#29 @Pubudu Malalasekara
2 months ago

Hi @rabmalin,

I guess I have fixed all the stated issues. Please let me know if there is anything wrong.

Thank You very much for the review.

#30 @rabmalin
2 months ago

  • Cc rabmalin removed
  • Resolution set to live
  • Status changed from reviewing to closed

Looks good. Approving and setting live. It will take around 1 hour for theme to appear in the directory. Good luck!

#31 @Pubudu Malalasekara
2 months ago

Hi @rabmalin,

Thanks a lot for taking your time to review this.

Best Regards,
Pubudu.

Note: See TracTickets for help on using tickets.