WordPress.org

Make WordPress Themes

Opened 7 weeks ago

Closed 13 days ago

#43285 closed theme (not-approved)

THEME: Designer Friendly – 1.0

Reported by: seanfarnon Owned by: greenshady
Priority: new theme Keywords: theme-designer-friendly child-theme parent-twentysixteen accessibility-ready
Cc: sean.farnon@…

Description

Designer Friendly - 1.0

Custom theme extended from twentysixteen. I have added extra functionality, full width header, full width pages, custom footer copyright text and much more.

Theme URL -
Author URL - https://seanfarnon.com

Trac Browser - https://themes.trac.wordpress.org/browser/designer-friendly/1.0

SVN - https://themes.svn.wordpress.org/designer-friendly/1.0
ZIP - https://wordpress.org/themes/download/designer-friendly.1.0.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentysixteen

History:

Ticket Summary Status Resolution Owner
#43285 THEME: Designer Friendly – 1.0 closed not-approved greenshady

(this ticket)


https://themes.svn.wordpress.org/designer-friendly/1.0/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • WARNING: Found wrong tag, remove custom-footer from your style.css header.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().

Change History (2)

#1 @greenshady
13 days ago

  • Keywords changed from theme-designer-friendly, child-theme, parent-twentysixteen, accessibility-ready to theme-designer-friendly child-theme parent-twentysixteen accessibility-ready
  • Owner set to greenshady
  • Status changed from new to reviewing

#2 @greenshady
13 days ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Unfortunately, your theme is not yet ready for inclusion in the theme directory. Please make sure to clear up the following issues and resubmit the theme.

Prefixing: Function names

All custom function names in your theme should have a unique prefix. designer_friendly_ is ideal.

Function for style.css

Use get_stylesheet_uri() in the following code to get the correct style.css file:

wp_enqueue_style( 'child-style',
        get_stylesheet_directory_uri() . '/style.css',
        array( $parent_style ),
        wp_get_theme()->get('Version')
    );

Custom styles?

What's the purpose of the customstyle.css file? Why not just simply put those style rules in style.css. You're creating an additional HTTP request for just a few lines of CSS.

Theme textdomain

The textdomain for your child theme must be designer-friendly exactly. Don't use twentysixteen. That's the textdomain for the parent theme.

Style output in header.php

The following code in header.php should be hooked into wp_head or added via wp_add_inline_style():

if(!empty($hearerimgurl)){
	echo "<style>article{padding:20px;}#masthead{background:url('$hearerimgurl');background-repeat:no-repeat;background-size:100% 100%;}
	.header-image{display:none;}.entry-content{padding-top:15px;}
	.so-panel{border:none;}#content{padding:0;}</style>";
}

Additionally, you need to escape the $hearerimgurl variable before outputting it.

Overwriting templates

You should only overwrite templates where you're making actual changes to the code. For example, page.php is exactly the same as the page.php from the parent theme with just some spacing removed from the code. I haven't compared each template that you've overwritten, but there's no need to overwrite it unless you're changing something.

The navigation on multi-post pages, such as the home/blog page is messed up. It's above the final post's output. Normally, we wouldn't review design issues, but this is clearly broken and is, for all intents and purposes, unusable for the end user.

readme.txt

We're now asking that theme authors implement their readme.txt files following the plugin readme standard: https://wordpress.org/plugins/files/2017/03/readme.txt

Here's the readme validator: https://wordpress.org/plugins/developers/readme-validator/

Note: See TracTickets for help on using tickets.