WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4336 closed theme (not-approved)

THEME: Elbee Elgee - 1.1.1

Reported by: ZaMoose Owned by: garinungkadol
Priority: Keywords: theme-elbee-elgee, synchold
Cc: zamoose@…

Description

Elbee Elgee - 1.1.1

An extremely flexible 1, 2, or 3 column theme with over 30 possible layouts and support for widgetized sidebars, custom headers, custom backgrounds, custom navigation menus, BuddyPress and bbPress.

Theme URL - http://literalbarrage.org/blog/code/lblg
Author URL - http://literalbarrage.org/blog/

SVN - http://themes.svn.wordpress.org/elbee-elgee/1.1.1
ZIP - http://wordpress.org/extend/themes/download/elbee-elgee.1.1.1.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/elbee-elgee/1.1&new_path=/elbee-elgee/1.1.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-elbee-elgee&order=priority

https://themes.svn.wordpress.org/elbee-elgee/1.1.1/screenshot.png

Attachments (7)

calendar.jpg (11.3 KB) - added by garinungkadol 3 years ago.
captioned-images.jpg (105.7 KB) - added by garinungkadol 3 years ago.
floated-elements.jpg (25.4 KB) - added by garinungkadol 3 years ago.
html.jpg (67.3 KB) - added by garinungkadol 3 years ago.
layout-gala.jpg (132.8 KB) - added by garinungkadol 3 years ago.
whitespace.jpg (18.1 KB) - added by garinungkadol 3 years ago.
comment-thread.jpg (66.1 KB) - added by garinungkadol 3 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 zamoose3 years ago

Fixed a bug that was in upstream bbPress parent theme code.

comment:2 garinungkadol3 years ago

  • Owner set to garinungkadol
  • Status changed from new to assigned

garinungkadol3 years ago

garinungkadol3 years ago

garinungkadol3 years ago

garinungkadol3 years ago

garinungkadol3 years ago

comment:3 garinungkadol3 years ago

  • Keywords synchold added
  • Resolution set to not-approved
  • Status changed from assigned to closed

THEME REVIEW RESULTS
This is a complete review. of WordPress functionality. Below are the theme review results. Anything marked FAIL needs to be addressed. Anything marked REQUIRED is needed to be fixed while anything marked RECOMMENDED is strongly advised. Other points may be raised purely for information.

A further review is needed for BuddyPress functionality

RECOMMENDATION: NOT-APPROVED


Theme Check Results: PASS


Debugger results: PASS


Test data results: FAIL
Blog Post Index View

  • REQUIRED: Posts with no titles must still include a permalink to the single post view. The recommended practice is to place the permalink on the post date as well.

Single Post View

  • REQUIRED: You must provide styling for heading elements (<h2> - <h6>), blockquotes, tables, definition lists, ordered lists and unordered lists. See html.jpg. The same applies to HTML in comments.
  • REQUIRED: Posts with closed comments are required to display some kind of "Comments are disabled" message. This does not apply to Pages.
  • RECOMMENDED: Theme options using textareas that allow HTML should use wp_kses_post when sanitizing form data. See Data Validation

Visual issues / functionality / browser checks:

  • Provide more whitespace between the post meta and post content. See whitespace.jpg
  • This is the display when Theme Stylesheet - layoutgala.css is chosen. Is this intentional? It looks like there is no style. See layout-gala.jpg.
  • Content entered in "Copyright Statement" and "Footer Credits" does not show up on the site.

Validation: PASS
CSS: PASS

HTML: PASS


Code Quality: FAIL

  • REQUIRED: wp_footer() must be placed directly before </body>.
  • REQUIRED: All custom functions and global variables must be prefixed with the theme slug or an appropriate variant.

See theloop.php global $themename, $shortname;

  • REQUIRED: All data must be sanitized and validated before saving to the database and properly escaped when outputting to forms. Refer to includes\admin.php. For example instead of:
    Line 144 ....<?php echo $lblg_options[$key]; ?></textarea>
    

use

Line 144 ....<?php echo esc_html( $lblg_options[$key] ) ; ?></textarea>
  • REQUIRED: Themes are required to use checked() and selected() for checkbox and select options in forms respectively. Refer to includes\admin.php

Please look at Theme Settings and Data Security

  • Why is if ( ! isset( $content_width ) ) $content_width = '640'; entered twice in includes\supports.php?

Other notes

  • REQUIRED: Please note the license being used for your header images in the readme. They must be GPL-compatible.
  • RECOMMENDED: Screenshot should follow the recommended 4:3 W:H ratio, size 300x225px to a maximum of 320:240px

bbPress / BuddyPress Implementation

  • Are you supposed to be enqueuing Twenty Ten styles? See Line 43 of includes\bbpress.php
  • I don't think you need to include the text domains for 'bbpress' and 'buddypress' in those files since you are not providing localization support.

Information
If there are any issues once resolved, please re-submit your Theme using the uploader tool on wordpress.org/extend/themes, and a new Trac ticket will be generated.
Note:

  • Re-submitted Themes are given review priority over new Themes.

You can use the following tools to recreate the issues raised above if any have been:

Themes should be reviewed using define('WP_DEBUG', true); in wp-config.php
You can also view the Theme Review page.

Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:

  • 1) Leave a comment on this ticket
  • 2) Email the theme-reviewers email list
  • 3) Use the #wordpress-themes channel on irc.freenode.net
Last edited 3 years ago by garinungkadol (previous) (diff)

comment:4 follow-up: zamoose3 years ago

@garinungkadol:
Thanks for the comprehensive review. I've got a new version just about ready to push up to the repo which fixes many of these issues.

One question, though: when did checked()/selected() become REQUIRED? My recollection is that they were best-practices and they are easier in certain situations but actually make my work harder in the context of this theme, hence me avoiding them.

comment:5 in reply to: ↑ 4 garinungkadol3 years ago

Replying to zamoose:

One question, though: when did checked()/selected() become REQUIRED? My recollection is that they were best-practices and they are easier in certain situations but actually make my work harder in the context of this theme, hence me avoiding them.

I tracked down the codex revision and checked()/selected() became required on April 20, 2011 (http://codex.wordpress.org/index.php?title=Theme_Review&diff=prev&oldid=103765).

Can you cite some examples of how it makes your work more difficult? I can take it up with the other theme reviewers and we can see if there is a valid reason for giving this exception. Thanks.

Note: See TracTickets for help on using tickets.