WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 4 months ago

#43487 closed theme (live)

THEME: Owner – 1.0.7

Reported by: mysterythemes Owned by: utsavsinghrathour
Priority: previously reviewed Keywords: theme-owner
Cc: mysterythemes@…

Description

Owner - 1.0.3

Owner is a powerful Free WordPress Theme which is easy to use, highly customizable and well-designed Multi-Purpose Business Theme. Theme displays your site in the best possible way on smartphones, tablets, and laptops, as well as large desktop screens. The theme include many features that was most needed for the multipurpose theme. We have great customer support via email, support forum. View full Demo here: http://demo.mysterythemes.com/owner/ | Support: https://mysterythemes.com/support/forum/themes/free-themes/

Theme URL - https://mysterythemes.com
Author URL - https://mysterythemes.com/wp-themes/owner/

Trac Browser - https://themes.trac.wordpress.org/browser/owner/1.0.3

SVN - https://themes.svn.wordpress.org/owner/1.0.3
ZIP - https://wordpress.org/themes/download/owner.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=owner/1.0.2&new_path=owner/1.0.3

History:

Ticket Summary Status Resolution Owner
#32705 THEME: Owner – 1.0.1 closed not-approved sakinshrestha
#36826 THEME: Owner – 1.0.2 closed not-approved kevinhaig
#43487 THEME: Owner – 1.0.7 closed live utsavsinghrathour

(this ticket)

#45386 THEME: Owner – 1.0.8 closed live themetracbot
#45653 THEME: Owner – 1.0.9 closed live themetracbot
#46169 THEME: Owner – 1.1.0 closed live themetracbot
#46595 THEME: Owner – 1.1.1 closed live themetracbot
#47660 THEME: Owner – 1.1.2 closed live themetracbot
#49079 THEME: Owner – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/owner/1.0.3/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (21)

#1 @joyously
5 months ago

Here is some user feedback to consider before your review.

  • Upon activation, all my widgets were in Left Sidebar widget area. Looking at the site, however, no sidebar is shown, and there is an empty space for one on the right. So, two problems: what good is it to put no widgets if the widget area is still output? and why register a sidebar that isn't enabled? I'm assuming there is some option in Customizer for choosing layout. I should not be able to put widgets into an area that won't be displayed, but at the same time, if I change the layout then I wouldn't be able to move the widgets from the old to the new sidebar. It seems to me that you should have just one sidebar and choose which side to show it on. At the very least, improve the widget area descriptions to indicate when and where they are shown (requirement to document theme features).
  • The footer widget areas are similar -- there are 4 places to put widgets in, but they are not all displayed on the front end. As far as I can tell, only the first two are being shown, even though they are sized for three.
  • There is a fallback menu (Yay!), but the submenus do not work correctly on a narrow window.
  • On a small window, the custom menu I selected does not show its structure (all links at same level), although it confusingly changes the parent color when hovering over a child item. (not that big a deal since most small windows do not have hover)
  • The submenu line-height is too large. Long items wrapping around look like two items.
  • Can you do something new? Don't use the same color scheme as a dozen other new themes are using (orange-gold with white and light gray). This is a bad color combination, because it is difficult to read. All these new themes look alike... If you must keep this color scheme, use some text-shadow!
  • blockquote is styled as italic, but can have nested <em> and <cite> tags which are indistinguishable. It really doesn't need italics, because it has a larger font size, and a left indent.
  • <q> tag is unstyled (default removed)
  • You might want to hide the sticky header, menu, comment form, and widget areas for the print styles.
  • The Custom Menu widget in the sidebar and footer widget area shows only the top level items.
  • On the single post page, the post title is shown twice.
  • Theme should support the gallery default of 3 columns.
  • Since archive pages are showing full content of posts, it is easier to find the posts on the blog page than it is on the archive pages, because the post titles are a different color than the rest of the text.
  • The paged comment links interfere with the text that follows them.

https://s12.postimg.org/qn8utvhnx/paged-comment-link-top.jpg

https://s22.postimg.org/ng1ob3d1d/paged-comment-link-offset.jpg

  • The 404 page is not at all helpful. It says "Maybe try one of the links below", but there are no links below.
  • Customizer
    • Copyright Text has no copyright indication. But the default value is the name of the theme. Default to site title or empty, since theme has no copyright to site contents.
    • Additional Settings, Social Icons - add a description to say where these are shown.
    • Additional Header Settings - both Header Sticky and Search Icon options had no effect on the preview.
    • Top Header Settings - remove the text fields as this is content creation that will disappear on theme switch. You could put a widget area in that position, and style it to look the same, and the user could put anything in there instead of just the 3 fields you thought might be wanted.
    • Website Layout - add description for what these terms mean.
    • Colors - Header Text color default is showing as black, but the front end shows gold.
    • Colors - changing the Background color had no effect on the preview.

#2 @joyously
5 months ago

I forgot to mention the widgets.

  • Custom widgets should be for presentation of existing data, since they will disappear on theme switch. So the Call to Action widget should be removed from the theme, and the others should remove the text inputs and images. Content should not be stored in the options table.

#3 @mysterythemes
5 months ago

@joyously

Thank you for your great feedback :) ! We will fix it asap and submit another version.

Thanks :) !

#4 @utsavsinghrathour
5 months ago

  • Owner set to utsavsinghrathour
  • Status changed from new to reviewing

Hi @mysterythemes
I will be doing further review of the theme. Let me know if I can start now, or do I wait for the update you said you would upload in your last message. :)

Have a great day!

#5 @mysterythemes
5 months ago

Hi @utsavsinghrathour

Thank you for taking our theme for review!! We will update next version asap and you can start your review :)

Have a great day!

#6 @themetracbot
5 months ago

  • Summary changed from THEME: Owner – 1.0.3 to THEME: Owner – 1.0.4

Owner - 1.0.4

Owner is a powerful Free WordPress Theme which is easy to use, highly customizable and well-designed Multi-Purpose Business Theme. Theme displays your site in the best possible way on smartphones, tablets, and laptops, as well as large desktop screens. The theme include many features that was most needed for the multipurpose theme. We have great customer support via email, support forum. View full Demo here: http://demo.mysterythemes.com/owner/ | Support: https://mysterythemes.com/support/forum/themes/free-themes/

Theme URL - https://mysterythemes.com
Author URL - https://mysterythemes.com/wp-themes/owner/

Trac Browser - https://themes.trac.wordpress.org/browser/owner/1.0.4

SVN - https://themes.svn.wordpress.org/owner/1.0.4
ZIP - https://wordpress.org/themes/download/owner.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=owner/1.0.3&new_path=owner/1.0.4

History:

Ticket Summary Status Resolution Owner
#32705 THEME: Owner – 1.0.1 closed not-approved sakinshrestha
#36826 THEME: Owner – 1.0.2 closed not-approved kevinhaig
#43487 THEME: Owner – 1.0.7 closed live utsavsinghrathour

(this ticket)

#45386 THEME: Owner – 1.0.8 closed live themetracbot
#45653 THEME: Owner – 1.0.9 closed live themetracbot
#46169 THEME: Owner – 1.1.0 closed live themetracbot
#46595 THEME: Owner – 1.1.1 closed live themetracbot
#47660 THEME: Owner – 1.1.2 closed live themetracbot
#49079 THEME: Owner – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/owner/1.0.4/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#7 @mysterythemes
5 months ago

Hi @utsavsinghrathour

We have fixed some issues and uploaded newer version of theme. Now you can start your review process.

Regards,

Mystery Themes

#8 @utsavsinghrathour
5 months ago

Hi @mysterythemes I will be reviewing this today.

#9 @mysterythemes
4 months ago

Hi @utsavsinghrathour

Have you reviewed theme? We are waiting for your feedback for 1 week.

Thanks :) !

#10 @utsavsinghrathour
4 months ago

Hi @mysterythemes Yes Almost. Will post my feedback in sometime.

#11 @mysterythemes
4 months ago

Hi @utsavsinghrathour

We are waiting for your feedback

Thanks !

#12 @utsavsinghrathour
4 months ago

Please escape and sanitize all your data.
For example get_bloginfo or get_theme_mod and get_post_meta

Please check this across all files.

#13 @themetracbot
4 months ago

  • Summary changed from THEME: Owner – 1.0.4 to THEME: Owner – 1.0.5

Owner - 1.0.5

Owner is a powerful Free WordPress Theme which is easy to use, highly customizable and well-designed Multi-Purpose Business Theme. Theme displays your site in the best possible way on smartphones, tablets, and laptops, as well as large desktop screens. The theme include many features that was most needed for the multipurpose theme. We have great customer support via email, support forum. View full Demo here: http://demo.mysterythemes.com/owner/ | Support: https://mysterythemes.com/support/forum/themes/free-themes/

Theme URL - https://mysterythemes.com
Author URL - https://mysterythemes.com/wp-themes/owner/

Trac Browser - https://themes.trac.wordpress.org/browser/owner/1.0.5

SVN - https://themes.svn.wordpress.org/owner/1.0.5
ZIP - https://wordpress.org/themes/download/owner.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=owner/1.0.4&new_path=owner/1.0.5

History:

Ticket Summary Status Resolution Owner
#32705 THEME: Owner – 1.0.1 closed not-approved sakinshrestha
#36826 THEME: Owner – 1.0.2 closed not-approved kevinhaig
#43487 THEME: Owner – 1.0.7 closed live utsavsinghrathour

(this ticket)

#45386 THEME: Owner – 1.0.8 closed live themetracbot
#45653 THEME: Owner – 1.0.9 closed live themetracbot
#46169 THEME: Owner – 1.1.0 closed live themetracbot
#46595 THEME: Owner – 1.1.1 closed live themetracbot
#47660 THEME: Owner – 1.1.2 closed live themetracbot
#49079 THEME: Owner – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/owner/1.0.5/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#14 @mysterythemes
4 months ago

Hi @utsavsinghrathour ,

Thank you for review, but we have some confusion about escaping data,

  1. About get_bloginfo we have used 'dispaly' 2nd parameter in function which is also discussion in trac https://wordpress.slack.com/archives/C02RP4Y3K/p1486747121009913
  1. Now about escaping data of get_theme_mode and get_post meta we think it's needed for only display section not in checking values.

is there any other issues on theme then please do mention us.

Regards,
Mystery Themes

Last edited 4 months ago by mysterythemes (previous) (diff)

#15 @rabmalin
4 months ago

@mysterythemes Here are few issues you may want to check.

Issues

  • REQUIRED: Found usage of constant "HEADER_TEXTCOLOR". Use add_theme_support( 'custom-header' ) instead.
  • REQUIRED: comments.php L33 - Missing singular placeholder, needed for some languages. See https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals See Twenty Seventeen for reference.
  • REQUIRED: Remove sticky-post theme tag if you dont want to implement. https://make.wordpress.org/themes/handbook/review/required/theme-tags/
  • REQUIRED: Remove unused files and folders like layouts folder, etc. Please check thoroughly.
  • REQUIRED: Update your POT file according to your theme. Or you can remove whole languages folder if you want to take advantage of WordPress Language Pack.
  • REQUIRED: Removing core settings is not allowed.
    $wp_customize->remove_section( 'header_image' );
    
  • REQUIRED: page-metabox.php L82 - Can you please explain what is that?
  • REQUIRED: owner-widget-fields.php - Do not use strip_tags(). You can use sanitize_text_field()
  • REQUIRED: To sanitize textarea, use either wp_kses_post() or sanitize_textarea_field().

#16 @themetracbot
4 months ago

  • Summary changed from THEME: Owner – 1.0.5 to THEME: Owner – 1.0.6

Owner - 1.0.6

Owner is a powerful Free WordPress Theme which is easy to use, highly customizable and well-designed Multi-Purpose Business Theme. Theme displays your site in the best possible way on smartphones, tablets, and laptops, as well as large desktop screens. The theme include many features that was most needed for the multipurpose theme. We have great customer support via email, support forum. View full Demo here: http://demo.mysterythemes.com/owner/ | Support: https://mysterythemes.com/support/forum/themes/free-themes/

Theme URL - https://mysterythemes.com
Author URL - https://mysterythemes.com/wp-themes/owner/

Trac Browser - https://themes.trac.wordpress.org/browser/owner/1.0.6

SVN - https://themes.svn.wordpress.org/owner/1.0.6
ZIP - https://wordpress.org/themes/download/owner.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=owner/1.0.5&new_path=owner/1.0.6

History:

Ticket Summary Status Resolution Owner
#32705 THEME: Owner – 1.0.1 closed not-approved sakinshrestha
#36826 THEME: Owner – 1.0.2 closed not-approved kevinhaig
#43487 THEME: Owner – 1.0.7 closed live utsavsinghrathour

(this ticket)

#45386 THEME: Owner – 1.0.8 closed live themetracbot
#45653 THEME: Owner – 1.0.9 closed live themetracbot
#46169 THEME: Owner – 1.1.0 closed live themetracbot
#46595 THEME: Owner – 1.1.1 closed live themetracbot
#47660 THEME: Owner – 1.1.2 closed live themetracbot
#49079 THEME: Owner – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/owner/1.0.6/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Found a translation function that has an incorrect number of arguments. Function _n, with the arguments 'One thought on &ldquo;%2$s&rdquo;', '%1$s thoughts on &ldquo;%2$s&rdquo;', comments title, 'owner'
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are comments title, owner

#17 @mysterythemes
4 months ago

Hi @rabmalin @utsavsinghrathour ,

We have fixed all tasks and uploaded newer version. Hope you will be review soon.

Thanks,

#18 @rabmalin
4 months ago

There is still translation issue in comments.php. Please check again.

Important

Before re-submitting themes, please check Theme Review Guidelines very thoroughly. Also, test your theme with following plugins.

#19 @themetracbot
4 months ago

  • Summary changed from THEME: Owner – 1.0.6 to THEME: Owner – 1.0.7

Owner - 1.0.7

Owner is a powerful Free WordPress Theme which is easy to use, highly customizable and well-designed Multi-Purpose Business Theme. Theme displays your site in the best possible way on smartphones, tablets, and laptops, as well as large desktop screens. The theme include many features that was most needed for the multipurpose theme. We have great customer support via email, support forum. View full Demo here: http://demo.mysterythemes.com/owner/ | Support: https://mysterythemes.com/support/forum/themes/free-themes/

Theme URL - https://mysterythemes.com
Author URL - https://mysterythemes.com/wp-themes/owner/

Trac Browser - https://themes.trac.wordpress.org/browser/owner/1.0.7

SVN - https://themes.svn.wordpress.org/owner/1.0.7
ZIP - https://wordpress.org/themes/download/owner.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=owner/1.0.6&new_path=owner/1.0.7

History:

Ticket Summary Status Resolution Owner
#32705 THEME: Owner – 1.0.1 closed not-approved sakinshrestha
#36826 THEME: Owner – 1.0.2 closed not-approved kevinhaig
#43487 THEME: Owner – 1.0.7 closed live utsavsinghrathour

(this ticket)

#45386 THEME: Owner – 1.0.8 closed live themetracbot
#45653 THEME: Owner – 1.0.9 closed live themetracbot
#46169 THEME: Owner – 1.1.0 closed live themetracbot
#46595 THEME: Owner – 1.1.1 closed live themetracbot
#47660 THEME: Owner – 1.1.2 closed live themetracbot
#49079 THEME: Owner – 1.1.3 closed live themetracbot


https://themes.svn.wordpress.org/owner/1.0.7/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#20 @mysterythemes
4 months ago

Hi @rabmalin @utsavsinghrathour

We have fixed the issue at comments.php file and upload newer version.

Regards,

Mystery Themes

Last edited 4 months ago by mysterythemes (previous) (diff)

#21 @rabmalin
4 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Approving and setting live. It will take around 1 hour for theme to appear in the directory.

Note: See TracTickets for help on using tickets.