WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 3 months ago

#43644 closed theme (not-approved)

THEME: Discover RW – 1.0.0

Reported by: realweb Owned by: mp518
Priority: new theme Keywords: theme-discover-rw, accessibility-ready
Cc: dn190@…

Description

Discover RW - 1.0.0

Discover – Responsive WordPress Template

Theme URL - http://discover.real-web.pro
Author URL - http://themeforest.net/user/real-web/portfolio?ref=real-web

Trac Browser - https://themes.trac.wordpress.org/browser/discover-rw/1.0.0

SVN - https://themes.svn.wordpress.org/discover-rw/1.0.0
ZIP - https://wordpress.org/themes/download/discover-rw.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#43644 THEME: Discover RW – 1.0.0 closed not-approved mp518

(this ticket)


https://themes.svn.wordpress.org/discover-rw/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

Change History (4)

#1 @joyously
3 months ago

Here is some user feedback to consider before your review.

  • A theme cannot "require" plugins. Themes must work without plugins.
  • Themes are not allowed to have “obtrusive” upselling. Global notifications in the admin area are not allowed. Notifications must be restricted to theme related pages. (Also, I dismissed the notice, but it shows again on every admin page change.)
  • Custom widgets should be for presentation of existing data, since they will disappear on theme switch. So the Discover Events Calendar widget should be removed from the theme.
  • Improve the widget area description to indicate when and where the widgets will be shown. (I didn't see the sidebar on Pages; where else doesn't it show?)
  • The body background color is not being set. I see my browser default color of yellow.
  • The mobile menu is not closing itself on a window resize, although it does change from submenu click arrows to hover. I can see both menus at once. https://s2.postimg.org/5c2mgjwyx/both-menus-showing.jpg
  • You have not implemented custom menus correctly. Remove the menu parameter. Set the theme_location parameter to the ID used in register_nav_menus()
    wp_nav_menu( array( 'menu' => '', 'container' => false, 'container_class' => '', 'container_id' => '',
     'menu_class' => 'menu', 'menu_id' => '', 'echo' => true, 
     'items_wrap' => '<ul id="%1$s" class="%2$s">%3$s</ul>', 'theme_location' => '' ) );
    
  • Theme or author name/brand should not be output on front end except as allowed in a credit link.
  • Use the user's site title, not the theme name.
  • The comment date does not use my choice of date format.
  • There is no link to the comment anchor (for easy copy/paste). This is typically put on the comment date.
  • The comment form is inline with the other comments, looking like a comment. (I can see it better than most because my page background is yellow, but the textarea is white.) So, two things:
    • A lot of people (logged in) would not notice where to enter their comment since it does not stand out.
    • The comments can be ordered with oldest first or newest first. Shouldn't the input be next to the newest comment?
  • When comments are closed, the user avatar is still output as if the comment form would be output.
  • The Blog Page shows a list of categories, which is quite big on a site with a lot of categories, and all are shown on a narrow window. I do not like this at all. This page is for latest posts, not categories.
  • The post date is not using my choice of date format.
  • The search input in the search widget shows only 4 characters of what I type.

https://s24.postimg.org/p0czft1ud/search-input.jpg

  • The <!--more--> tag is not handled correctly.

https://s24.postimg.org/csveswqz9/more-tag.jpg

  • For a post with no title, there is no link to the single post page (from an archive).
  • Floats are not being cleared properly after the content area on Pages.
  • blockquote is styled as centered, but can have nested HTML tags that do not look good centered. User content should only be centered when the user chooses it.
  • blockquote is styled as italic, but can have nested <em> or <cite> tags which are indistinguishable.
  • blockquote is styled as bold, but can have nested <b> or <strong> (or other bolded) tags which are indistinguishable.
  • The space between paragraphs feels too large for the font size.
  • The CSS reset has removed the styles for <tt>, <kbd>, <var>. <big> is not big. <small> is not small. <q> tag is unstyled (default removed). <dt> and <dd> look mostly the same as regular text. Consider using normalize instead of reset.
  • You might want to hide the menu, comment form, and widget areas for the print styles.
  • Post navigation links would be nice. Oh sorry, they are there, but I didn't see them because they are at the top instead of the bottom where they are needed.
  • Search results should not show the date of static Pages.
  • Customizer
    • Other, Social Share - this is plugin territory and should be removed. Also, the default is enabled, yet none of these show on the front end.
    • Other, Google Maps API - this is plugin territory and should be removed.
    • Colors - the color picker you are using has problems. The alpha slider is under other color options. Also, it's difficult to tell which is the actual current color since where the label is shows a different color than the end. There are other alpha color pickers, but link colors don't really need alpha anyway. The core color picker has better UI. https://s14.postimg.org/tipki340x/color-selection-overlap.jpg
    • Colors - Changing the Links color did not change the preview.
    • Footer, Instagram Shortcode - this is plugin territory. You could just provide a widget area in the footer so the user could put anything they wanted there.
    • Footer, Copyright - this is not shown on the front end. Any copyright statements on the front end should display the user's copyright, not the theme author's copyright.
    • Header - What is Logotype? This is a combination of Header Image and Custom Logo? Use core functionality instead of writing your own. And I see no way to remove the default logo (which no one will want and should be removed).

#2 @themetracbot
3 months ago

  • Owner set to mp518
  • Status changed from new to reviewing

#3 @mp518
3 months ago

Hi @realweb
I will start review of your theme. But you should have done some changes as described above by @joyously. Than i will go to review after changes you will update.
Thanks

Last edited 3 months ago by mp518 (previous) (diff)

#4 @mp518
3 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Here is some glitches found in your theme below report generated by this plugin https://wordpress.org/plugins/theme-check/

Theme Review* RECOMMENDED: Possible variable $val found in translation function in lessc.inc.php. Translation function calls must NOT contain PHP variables.

Line 1059: $rep = $this->compileValue($this->lib_e($val));
  • RECOMMENDED: Possible variable $this found in translation function in lessc.inc.php. Translation function calls must NOT contain PHP variables.
    Line 1499: return $this->lib_e($this->reduce($inner));
    
  • RECOMMENDED: Possible variable $string found in translation function in lessc.inc.php. Translation function calls must NOT contain PHP variables.
    Line 1045: $template = $this->compileValue($this->lib_e($string));
    
  • RECOMMENDED: Possible variable $str found in translation function in lessc.inc.php. Translation function calls must NOT contain PHP variables.
    Line 101: $url = $this->compileValue($this->lib_e($str));
    
  • RECOMMENDED: Possible variable $res found in translation function in lessc.inc.php. Translation function calls must NOT contain PHP variables.
    Line 1461: if (empty($value[2])) $res = $this->lib_e($res);
    
  • RECOMMENDED: Possible variable $part found in translation function in lessc.inc.php. Translation function calls must NOT contain PHP variables.
    Line 1493: if ($strip) $part = $this->lib_e($part);
    
  • RECOMMENDED: Possible variable $newUnit found in translation function in lessc.inc.php. Translation function calls must NOT contain PHP variables.
    Line 1094: $this->compileValue($this->lib_e($newUnit)));
    
  • RECOMMENDED: Possible variable $key found in translation function in lessc.inc.php. Translation function calls must NOT contain PHP variables.
    Line 1468: $key = $this->vPrefix . $this->compileValue($this->lib_e($key));
    
  • RECOMMENDED: Possible variable $items found in translation function in lessc.inc.php. Translation function calls must NOT contain PHP variables.
    Line 1028: return $this->lib_e($items[0]);
    
  • RECOMMENDED: Possible variable $arg found in translation function in lessc.inc.php. Translation function calls must NOT contain PHP variables.
    Line 1023: protected function lib_e($arg) {
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • INFO: Themes that use the tag accessibility-ready will need to undergo an accessibility review. See https://make.wordpress.org/themes/handbook/review/accessibility/
  • INFO: Possible hard-coded links were found in the file notices.php.
    Line 28: <p><?php esc_html_e('Also please check a PRO version of the Discover theme - ', 'discover-rw'); ?> <a href='https://themeforest.net/item/discover-travel-lifestyle-multiconcept-blog-th
    
  • INFO: Possible hard-coded links were found in the file customizer.php.
    Line 28: 'default'     => '<div class='upgrade-pro'><ul><li class='upgrade-pro-ttl'>PRO Version</li><li><span class='dashicons dashicons-yes'></span> 1 Click Demo Install</li><li><span class='dashicons dashicons-yes'></span> Pagebuilder</li><li><span class='dashicons dashicons-yes'></span> Layered Slider</li><li><span class='dashicons dashicons-yes'></span> 24/7 Support</li><li><span class='dashicons dashicons-yes'></span> Live Customizer</li><li><span class='dashicons dashicons-yes'></span> 5 Post Types</li><li class='upgrade-pro-demo'><a target='_blank' href='http://discover.real-web.pro'>Demo Site</a><a target='_blank' href='https://themeforest.net/item/discover-travel-lifestyle-multiconcept-blog-th
    
Line 141: 'default'  => '<a href='https://themeforest.net/item/discover-travel-lifestyle-multiconcept-blog-th
  • INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs.The domain found is discover-rw
  • INFO: wp-less.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
    Line 18: require_once( trailingslashit( get_template_directory() ).'inc/less/lessc.i
    
Line 252: require_once (ABSPATH . '/wp-admin/includes/file.php');
  • INFO: tgm.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
    Line 34: require_once( trailingslashit( get_template_directory() ) . 'inc/class-tgm-
    
  • INFO: taxonomy-gallery_category.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
    Line 33: <?php include(locate_template( 'template-parts/gallery_list.php' )); ?>
    
  • INFO: single.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
    Line 90: include( trailingslashit( get_template_directory() ) . 'template-parts/shar
    
  • INFO: single-discover_gallery.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
    Line 85: include( trailingslashit( get_template_directory() ) . 'template-parts/shar
    
  • INFO: search.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
    Line 29: include(locate_template('template-parts/loop.php'));
    
  • INFO: page-tpl-gallery.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
    Line 34: <?php include(locate_template( 'template-parts/gallery_list.php' )); ?>
    
  • INFO: lessc.inc.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
    Line 122: require_once (ABSPATH . '/wp-admin/includes/file.php');
    
Line 1927: require_once (ABSPATH . '/wp-admin/includes/file.php');
Line 1938: require_once (ABSPATH . '/wp-admin/includes/file.php');
  • INFO: kirki.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
    Line 33: include_once( trailingslashit( get_template_directory() ) . 'inc/kirki/auto
    
  • INFO: index.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
    Line 75: include(locate_template('template-parts/loop.php'));
    
  • INFO: gallery_list.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
    Line 23: include(locate_template( 'template-parts/gallery-loop.php' ));
    
  • INFO: class-kirki-helper.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
    Line 85: require_once( ABSPATH . '/wp-admin/includes/file.php' );
    
Note: See TracTickets for help on using tickets.