WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 3 months ago

#43708 closed theme (live)

THEME: Saka – 1.0.7

Reported by: yochix2 Owned by: poena
Priority: new theme Keywords: theme-saka
Cc: yochi@…

Description

Saka - 1.0.0

Saka is a simple blog theme that is conscious of the readability of sentences. It is one-column design, it is a drawer type navigation menu. Features are, Font Awesome.

Theme URL - https://saka.yochix2.com/
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/saka/1.0.0

SVN - https://themes.svn.wordpress.org/saka/1.0.0
ZIP - https://wordpress.org/themes/download/saka.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#25346 THEME: sakarepku – 2.0.4 closed not-approved emiluzelac
#43708 THEME: Saka – 1.0.7 closed live poena

(this ticket)

#46736 THEME: Saka – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/saka/1.0.0/screenshot.png

Change History (13)

#1 @themetracbot
4 months ago

  • Summary changed from THEME: Saka – 1.0.0 to THEME: Saka – 1.0.1

Saka - 1.0.1

Saka is a simple blog theme that is conscious of the readability of sentences. It is one-column design, it is a drawer type navigation menu. Features are, Font Awesome.

Theme URL - https://saka.yochix2.com/
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/saka/1.0.1

SVN - https://themes.svn.wordpress.org/saka/1.0.1
ZIP - https://wordpress.org/themes/download/saka.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=saka/1.0.0&new_path=saka/1.0.1

History:

Ticket Summary Status Resolution Owner
#25346 THEME: sakarepku – 2.0.4 closed not-approved emiluzelac
#43708 THEME: Saka – 1.0.7 closed live poena

(this ticket)

#46736 THEME: Saka – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/saka/1.0.1/screenshot.png

#2 @themetracbot
4 months ago

  • Summary changed from THEME: Saka – 1.0.1 to THEME: Saka – 1.0.2

Saka - 1.0.2

Saka is a simple blog theme that is conscious of the readability of sentences. It is one-column design, it is a drawer type navigation menu. Features are, Font Awesome.

Theme URL - https://saka.yochix2.com/
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/saka/1.0.2

SVN - https://themes.svn.wordpress.org/saka/1.0.2
ZIP - https://wordpress.org/themes/download/saka.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=saka/1.0.1&new_path=saka/1.0.2

History:

Ticket Summary Status Resolution Owner
#25346 THEME: sakarepku – 2.0.4 closed not-approved emiluzelac
#43708 THEME: Saka – 1.0.7 closed live poena

(this ticket)

#46736 THEME: Saka – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/saka/1.0.2/screenshot.png

#3 @themetracbot
4 months ago

  • Summary changed from THEME: Saka – 1.0.2 to THEME: Saka – 1.0.3

Saka - 1.0.3

Saka is a simple blog theme that is conscious of the readability of sentences. It is one-column design, it is a drawer type navigation menu. Features are, Font Awesome.

Theme URL - https://saka.yochix2.com/
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/saka/1.0.3

SVN - https://themes.svn.wordpress.org/saka/1.0.3
ZIP - https://wordpress.org/themes/download/saka.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=saka/1.0.2&new_path=saka/1.0.3

History:

Ticket Summary Status Resolution Owner
#25346 THEME: sakarepku – 2.0.4 closed not-approved emiluzelac
#43708 THEME: Saka – 1.0.7 closed live poena

(this ticket)

#46736 THEME: Saka – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/saka/1.0.3/screenshot.png

#4 @themetracbot
3 months ago

  • Summary changed from THEME: Saka – 1.0.3 to THEME: Saka – 1.0.4

Saka - 1.0.4

Saka is a simple blog theme that is conscious of the readability of sentences. It is one-column design, it is a drawer type navigation menu. Features are, Font Awesome.

Theme URL -
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/saka/1.0.4

SVN - https://themes.svn.wordpress.org/saka/1.0.4
ZIP - https://wordpress.org/themes/download/saka.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=saka/1.0.3&new_path=saka/1.0.4

History:

Ticket Summary Status Resolution Owner
#25346 THEME: sakarepku – 2.0.4 closed not-approved emiluzelac
#43708 THEME: Saka – 1.0.7 closed live poena

(this ticket)

#46736 THEME: Saka – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/saka/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#5 @themetracbot
3 months ago

  • Summary changed from THEME: Saka – 1.0.4 to THEME: Saka – 1.0.5

Saka - 1.0.5

Saka is a simple blog theme that is conscious of the readability of sentences. It is one-column design, it is a drawer type navigation menu. Features are, Font Awesome.

Theme URL -
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/saka/1.0.5

SVN - https://themes.svn.wordpress.org/saka/1.0.5
ZIP - https://wordpress.org/themes/download/saka.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=saka/1.0.4&new_path=saka/1.0.5

History:

Ticket Summary Status Resolution Owner
#25346 THEME: sakarepku – 2.0.4 closed not-approved emiluzelac
#43708 THEME: Saka – 1.0.7 closed live poena

(this ticket)

#46736 THEME: Saka – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/saka/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#6 @poena
3 months ago

  • Owner set to poena
  • Status changed from new to reviewing

#7 @poena
3 months ago

Hi
Your theme is nearly ready to go live, I just have one question:
Why did you re-create an existing option to change the header text color?
We normally don't allow this, themes should use existing functionality when available, to be compatible with plugins for example.

Please explain and motivate why so that I can decide if I can make an exception.

(To use the standard header text color option, you would only need to set header-text to true in saka_custom_header_setup. I also noticed that you kept the wp.customize( 'header_textcolor' code snippet in customizer.js. )

Besides this, the following is required:
Even color options needs to be escaped before output:

$bg_color = get_theme_mod( 'header_background_color', '#ffffff' );
$link_color = get_theme_mod( 'link_color', '#4169e1' );
$link_hover_color = get_theme_mod( 'link_hover_color', '#191970' )

and so on.

And some notes:
You might want to update your read me file, it still says "A starter theme called Saka, or underscores."
Please double check that saka.pot is updated to the latest version of the theme.

#8 @themetracbot
3 months ago

  • Summary changed from THEME: Saka – 1.0.5 to THEME: Saka – 1.0.6

Saka - 1.0.6

Saka is a simple blog theme that is conscious of the readability of sentences. It is one-column design, it is a drawer type navigation menu. Features are, Font Awesome.

Theme URL -
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/saka/1.0.6

SVN - https://themes.svn.wordpress.org/saka/1.0.6
ZIP - https://wordpress.org/themes/download/saka.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=saka/1.0.5&new_path=saka/1.0.6

History:

Ticket Summary Status Resolution Owner
#25346 THEME: sakarepku – 2.0.4 closed not-approved emiluzelac
#43708 THEME: Saka – 1.0.7 closed live poena

(this ticket)

#46736 THEME: Saka – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/saka/1.0.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#9 @yochix2
3 months ago

Hello @poena,
I fixed some issues you found.
Best regards,
Yochi

#10 @poena
3 months ago

Hi
thank you for the update.

Options needs to be sanitized before saving them to the database -this is already solved-

All untrusted data should be escaped before output; your links and some of the texts are escaped, but not all the options.

$bg_color = get_theme_mod( 'header_background_color', '#fff' );
$bg_color = get_theme_mod( 'drawermenu_background_color', '#fff' );
$link_color = get_theme_mod( 'link_color', '#4169e1' );
$link_hover_color = get_theme_mod( 'link_hover_color', '#191970' )

I suggest:

$bg_color = esc_attr( get_theme_mod( 'header_background_color', '#fff' ) );
$bg_color = esc_attr( get_theme_mod( 'drawermenu_background_color', '#fff' ) );
$link_color = esc_attr( get_theme_mod( 'link_color', '#4169e1' ) );
$link_hover_color = esc_attr( get_theme_mod( 'link_hover_color', '#191970' ) );

#11 @themetracbot
3 months ago

  • Summary changed from THEME: Saka – 1.0.6 to THEME: Saka – 1.0.7

Saka - 1.0.7

Saka is a simple blog theme that is conscious of the readability of sentences. It is one-column design, it is a drawer type navigation menu. Features are, Font Awesome.

Theme URL -
Author URL - https://yochix2.com/

Trac Browser - https://themes.trac.wordpress.org/browser/saka/1.0.7

SVN - https://themes.svn.wordpress.org/saka/1.0.7
ZIP - https://wordpress.org/themes/download/saka.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=saka/1.0.6&new_path=saka/1.0.7

History:

Ticket Summary Status Resolution Owner
#25346 THEME: sakarepku – 2.0.4 closed not-approved emiluzelac
#43708 THEME: Saka – 1.0.7 closed live poena

(this ticket)

#46736 THEME: Saka – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/saka/1.0.7/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#12 @yochix2
3 months ago

Hi @poena,
Thank you for review.
I fixed the file as suggested.

#13 @poena
3 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Great, thank you, your theme should be live in the directory shortly.

Note: See TracTickets for help on using tickets.