WordPress.org

Make WordPress Themes

Opened 3 months ago

Closed 2 months ago

Last modified 6 weeks ago

#43780 closed theme (not-approved)

THEME: Mistercorporate – 1.0.3

Reported by: nsthemes Owned by: bhavhiranideveloper
Priority: new theme Keywords: theme-mistercorporate
Cc: info@…

Description

Mistercorporate - 1.0.1

Mistercorporate is an awsome one page WordPress theme, with gallery, pricing table, map, contact and much more.

Theme URL - http://mistercorporate.nsthemes.com/
Author URL - http://www.nsthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/mistercorporate/1.0.1

SVN - https://themes.svn.wordpress.org/mistercorporate/1.0.1
ZIP - https://wordpress.org/themes/download/mistercorporate.1.0.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#43780 THEME: Mistercorporate – 1.0.3 closed not-approved bhavhiranideveloper

(this ticket)

#45511 THEME: Mistercorporate – 1.1.0 reviewing


https://themes.svn.wordpress.org/mistercorporate/1.0.1/screenshot.png

Change History (7)

#1 @themetracbot
3 months ago

  • Summary changed from THEME: Mistercorporate – 1.0.1 to THEME: Mistercorporate – 1.0.2

#2 @themetracbot
2 months ago

  • Summary changed from THEME: Mistercorporate – 1.0.2 to THEME: Mistercorporate – 1.0.3

#3 @nsthemes
2 months ago

We fix comments template.
Fix some css issue and theme tags.

Thank you!

#4 @joyously
2 months ago

Here is some user feedback to consider before your review.

  • A theme cannot "require" plugins. Themes must work without plugins.
  • Custom widgets should be for presentation of existing data, since they will disappear on theme switch. So the Contact widget should be removed from the theme. This is plugin territory.
  • Remove all the Google Map stuff from the theme - plugin territory.
  • The site title and mobile menu icon are covered by the admin bar.
  • Clicking on a menu arrow to open a submenu gives an error:
    TypeError: jQuery(...).offset(...) is undefined 1 mistercorporate.js:42:24
    	scrollNav/< wp-content/themes/mistercorporate/assets/js/mistercorporate.js:42:24
    	dispatch wp-includes/js/jquery/jquery.js:3:12392
    	add/r.handle wp-includes/js/jquery/jquery.js:3:9156
    
  • GET wp-content/themes/mistercorporate/assets/css/bootstrap.css.map [HTTP/1.1 404 Not Found 168ms]
  • On the mobile menu, the current page is shown as white on light gray, which is difficult to read.
  • Custom menus do not work. Change the menu parameter to theme_location to fix.
  • Static Pages should not show the author and date.
  • User content should not be centered unless the user chooses it. Put the underlined-title class on the actual title and not on the entire post or excerpt.
  • Comment title needs number help: "3 reply to xxx" should be "3 replies to xxx".
  • The comment Reply link has "Reply to xxxx", but when there are more levels than the user chose the link is not output (correctly), yet the "to xxxx" part is always output.
  • The input fields for the comment form do not look like inputs. They look like lines.
  • Any copyright statements on the front end should display the user's copyright, not the theme author's copyright.
  • My latest posts are on a static Page, but instead of that Page title I see "Index" and "Archives".
  • Archive page post titles, except for the first one, are tall and overlay the other links. If you hover the links (continue reading, author, category, tag) from the top down, they work as expected, but if you hover from the post title upwards, they all take you to the post link. Here you can see in Firebug that with the h2 selected, a large area is light blue (that element, margins are yellow). https://s3.postimg.org/bdcdv2yr7/big-h2-overlays-other-links.jpg
  • Page links (generated by <!--nextpage-->) are not being output on Pages.
  • The post navigation links are to posts with the same tags, which means there is often not a link. This should be documented for the user. (requirement to document theme features and limitations) And doesn't it make more sense to put the page links first and then links to other posts?
  • This code is removing a space between attributes, causing it to not validate.
    function mistercorporate_menuclass_add($ulclass) {
        return preg_replace('/<a /', '<a class="smooth-scroll"', $ulclass);
    }
    add_filter('wp_nav_menu','mistercorporate_menuclass_add');
    
  • The call to body_class() is incorrect with regard to quotes and class attribute. https://s4.postimg.org/qryloorql/body-tag-classes.jpg
  • Rename the page-home.php file. The template hierarchy will use this for a Page with a slug of "home", which is not allowed.
  • Floats are not being cleared properly after the content area.
  • Images with class aligncenter are not centered. (because image is by default display:inline, so margins do not affect it)
  • class alignleft needs a little right margin
  • class alignright needs a little left margin
  • Large images overflow the container. Use img {max-width:100%; height:auto} to fix.
  • Large images with captions overflow the container. Use .wp-caption {max-width:100%; height:auto} to fix.
  • <h6> is quite small, which in this font is difficult to read.
  • blockquote is styled as italic, but can have nested <em> and <cite> tags which are indistinguishable. It doesn't really need to be italics, because it has a left bar, a different color, and a larger font size.
  • tables need a little padding. (see also calendar widget)
  • Unordered lists do not have bullets.
  • You might want to hide the comment form and widget areas for the print styles.
  • Theme should support the gallery default of 3 columns.
  • Can you put a search form on the search page when there are no matches?
  • The 404 page is really not helpful! With the site title under the admin bar, all I see is a white page and a footer. The menu and 404 message are white on white. The message sounds more like what a search page would say. Could you put a link or a search form?
  • Customizer
    • Header Image - the default image is not shown as the header image. How would a user remove it without adding another?
    • Header Text color needs a default value.
    • Site Identity - "Display site title and tagline" does do anything.
    • Mistercorporate Options
      • need a description of where these sections will show
      • Remove all the sections that create content, or change them to use existing content. Contact, Quote, Try It, Newsletter, Adv, Price, First Table Price, Second Table Price, Third Table Price, Partner, Map
Last edited 2 months ago by joyously (previous) (diff)

#5 @themetracbot
2 months ago

  • Owner set to bhavhiranideveloper
  • Status changed from new to reviewing

#6 @bhavhiranideveloper
2 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed
  • The call to body_class() is incorrect with regard to quotes and class attribute.
  • Clicking on a menu arrow to open a submenu gives an error:
      mistercorporate.js?ver=1.0:42 Uncaught TypeError: Cannot read property 'top' of undefined
          at HTMLAnchorElement.<anonymous> (mistercorporate.js?ver=1.0:42)
          at HTMLAnchorElement.dispatch (jquery.js?ver=1.12.4:3)
          at HTMLAnchorElement.r.handle (jquery.js?ver=1.12.4:3)
    
  • Leverage browser caching
  • Combine external JavaScript
Last edited 2 months ago by bhavhiranideveloper (previous) (diff)

#7 @williampatton
6 weeks ago

Hi @bhavhiranideveloper,

Thank you for reviewing themes!

For future reference to close a theme you need to state 5 or more unique issues from the required section of the theme review handbook. Minor issues like syntax errors or typos - such as that with the body_class() issue here - should be noted but would not count as a reason to close a theme.

If you are using notes provided by Joy as reasons for closure then please state which in your comment so that the theme authors know specifically what to work on. Many of those notes are design notes or user feedback, not all of it falls within the required category.

NOTE: Utilizing browser caching and combining external JS are not required items for themes.

If you're ever unsure of anything please ask in the slack channel or you can ping me in ticket for a 2nd opinion.

Note: See TracTickets for help on using tickets.