WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 7 months ago

Last modified 7 months ago

#43847 closed theme (not-approved)

THEME: Coffee Zen – 3.17.4

Reported by: corporatezen222 Owned by: AbdulWahab610
Priority: previously reviewed Keywords: theme-coffee-zen
Cc: jeremy@…

Description

Coffee Zen - 3.17.4

This Corporate Zen’s first theme. This theme, like WordPress, is licensed under the GNU GPL. Users can quickly build different types of pages using our custom built tools and dynamic post types. We will be constitanly updating and monitoring this theme.

Theme URL -
Author URL - http://www.corporatezen.com/

Trac Browser - https://themes.trac.wordpress.org/browser/coffee-zen/3.17.4

SVN - https://themes.svn.wordpress.org/coffee-zen/3.17.4
ZIP - https://wordpress.org/themes/download/coffee-zen.3.17.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=coffee-zen/3.17.3&new_path=coffee-zen/3.17.4

History:

Ticket Summary Status Resolution Owner
#42768 THEME: Coffee Zen – 3.17.3 closed not-approved rabmalin
#43847 THEME: Coffee Zen – 3.17.4 closed not-approved AbdulWahab610

(this ticket)


https://themes.svn.wordpress.org/coffee-zen/3.17.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

Change History (9)

#1 @joyously
7 months ago

Here is some user feedback to consider before your review.

  • The menu needs to have a fallback for when no menu is selected. The default value of fallback_cb parameter of wp_nav_menu() works really well, and it's core functionality. This is used in the footer, but not the main menu?
  • There is a horizontal scrollbar, due to the fallback menu in the footer.
  • Long menu items in submenus overflow the submenu container.
  • There is only one level of submenu. This must be documented for the user.
  • My normal window size is ~1070px, but the sidebar is at the bottom. There are a lot of laptops with only 1080px, so this seems like a large breakpoint. I have to go to ~1185px to get the sidebar on the side.
  • I like a font size that is easy to read, but having it 21px is a bit much. I feel like I'm using an old computer with low resolution.
  • The latest posts page has no links to the posts.
  • Try to keep the usage of !important to a minimum. It is more user and child theme friendly if the theme has none. Instead of .entry-content img {max-width: 100% !important;} use img {max-width:100%; height:auto}.
  • Floats are not being cleared properly after the content area.
  • Because you are using * {box-sizing:border-box}, then this .entry-content img {padding: 10px;} makes all user images smaller. If you used margin instead of padding, they won't be smaller.
  • Large images with captions overflow the container. Use .wp-caption {max-width:100%} to fix.
  • <h5> and <h6> are small for a normal content font size of 16px, but really small for 21px.
  • Tables look all smashed together. (see also calendar widget)
  • <hr> is almost invisible.
  • You might want to hide the menu, comment form, and widget areas for the print styles. And use a bigger font size!
  • Static Pages should show comments.
  • Comments are showing the ordered list number, which is confusing for paged and nested comments. Try using CSS to hide the number or CSS counters to make it more logical.
  • Post navigation links would be nice.
  • The archive pages do not have titles. (search does)
  • Search results should not show the date of static Pages.
  • The search page has post title links, but they all go to /.
  • Theme Settings pages are not allowed. The Customizer must be used for all options. The fields on the Theme Settings page are not presentational and should be removed from the theme.
  • In Customizer, Fonts - Add more description and use descriptive names for the option names.
  • The theme description says "Users can quickly build different types of pages using our custom built tools and dynamic post types." This is misleading. I didn't see anything in this theme to support that statement (and custom post types are not allowed in a theme).
  • Remove the <meta> tag for description. This is not allowed.
  • Remove the commented <link> and <script> tags.
  • Remove other commented code or HTML.
  • Remove empty folders.
  • Remove comments for @package WordPress since this is not part of WordPress.
  • There are comments showing pieces came from Twenty Seventeen, but no license or attribution is given. See Proper Copyright/License Attribution for Themes to list all resources used (PHP, JS, CSS, fonts, images).

Please read the guidelines and use the theme test data as described here. Review tickets can be closed for having 5 or more required fix issues.

#2 @AbdulWahab610
7 months ago

  • Owner set to AbdulWahab610
  • Status changed from new to reviewing

#3 @AbdulWahab610
7 months ago

Hi, @corporatezen222

Kindly show your presence so I continuous review this ticket.

Thank you.

#4 @AbdulWahab610
7 months ago

Hi, @corporatezen222

Normally tickets are closed if there is no response within 7 days.

#5 @corporatezen222
7 months ago

My apologies! I was not seeing the email notifications because of some gmail settings I was not aware of.

#6 @corporatezen222
7 months ago

So to move forward, what should I do? Should I fix all these issues and resubmit the theme?

#7 @AbdulWahab610
7 months ago

No, you just wait for my next comment.

#8 @AbdulWahab610
7 months ago

Hi @corporatezen222

Here is my Initial review.
Please fulfil the requirements.

Add prefix to your function name:
inc\getimageID.php # 9 zen_get_attachment_id()

Escape missing on:
1- template-parts\header\site-branding.php # 19, 21, 24
2- header.php # 45
3- footer.php # 25

Use require_once properly like require_once get_template_directory() . '/assets/wp_bootstrap_navwalker.php';
1- functions.php # 6, 7, 8, 191
2- inc/customizer.php # 3, 4.
3- inc/getimageID.php # 7.

Use prefix properly while enqueuing file functions.php # 56, 63.

Make translatable strings.
functions.php # 242, 259, 267, 272, 277, 282.

Remove commented code.
functions.php 217 - 229

Remove extra files and folders
1- assets\css\tool-grid.css
2- assets\images
3- assets\js

Why not you use sanitize_hex_color callback function for color customizer.php # 132.
You are not properly calling the callback in customizer.php please check it.
https://github.com/WPTRT/code-examples/blob/master/customizer/sanitization-callbacks.php

Please fix these issue and will give you the final review ASAP.
Thank you.
Abdul Wahab

#9 @AbdulWahab610
7 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi @corporatezen222

You are creating template parts that are not using properly. Please Use these template properly otherwise remove that files.

Drop down menus are not work.

Header layout call in the footer for displaying blog named etc.

Your theme is going to be close because have many issues. Please resolve the above mention issues and upload again.
Before uploading the theme make sure your theme fulfil the requirements.
https://make.wordpress.org/themes/handbook/review/

Last edited 7 months ago by AbdulWahab610 (previous) (diff)
Note: See TracTickets for help on using tickets.