WordPress.org

Make WordPress Themes

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#4392 closed theme (not-approved)

THEME: Launching - 1.0

Reported by: themesweet Owned by: garinungkadol
Priority: Keywords: theme-launching, synchold
Cc: hello@…

Description

Launching - 1.0

A highly configurable one-page theme to inform visitors of your site launch. Includes an email collection form.

Theme URL - http://themesweet.com/themes/launching
Author URL - http://themesweet.com

SVN - http://themes.svn.wordpress.org/launching/1.0
ZIP - http://wordpress.org/extend/themes/download/launching.1.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-launching

https://themes.svn.wordpress.org/launching/1.0/screenshot.png

Attachments (6)

attachment.jpg (44.1 KB) - added by garinungkadol 6 years ago.
image-space.jpg (49.7 KB) - added by garinungkadol 6 years ago.
menu.jpg (16.3 KB) - added by garinungkadol 6 years ago.
older-comments-link.jpg (30.1 KB) - added by garinungkadol 6 years ago.
older-comments-link2.jpg (8.3 KB) - added by garinungkadol 6 years ago.
table.jpg (12.3 KB) - added by garinungkadol 6 years ago.

Download all attachments as: .zip

Change History (9)

#1 @garinungkadol
6 years ago

  • Owner set to garinungkadol
  • Status changed from new to assigned

@garinungkadol
6 years ago

@garinungkadol
6 years ago

#2 @garinungkadol
6 years ago

  • Keywords synchold added
  • Resolution set to not-approved
  • Status changed from assigned to closed

THEME REVIEW RESULTS
This is a complete review. Below are the theme review results. Anything marked FAIL needs to be addressed. Anything marked REQUIRED is needed to be fixed while anything marked RECOMMENDED is strongly advised. Other points may be raised purely for information.

RECOMMENDATION: NOT-APPROVED


Theme check test results : FAIL

  • REQUIRED: No reference to add_custom_background() was found in the theme. Since your theme uses background images for the background, then it is required that the theme implement this functionality.
  • RECOMMENDED: could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.
  • RECOMMENDED: Text domain problems in admin/options-framework.php. You have not included a text domain!
    Line 252: <input type='submit' class='button-primary' name='update' value='<?php esc_attr_e( 'Save Options' ); ?>' />
    
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( 'post-thumbnails' )in the functions.php file.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to add_custom_image_header was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

Debugger results: FAIL
-- Debug: Undefined index : SCRIPT_URI on line 81 of C:\xampp\htdocs\wpthemes\wp-content\launching\index.php


Test data results: FAIL
Blog Post Index View

  • REQUIRED: Posts with no title should still display a permalink to the single post view. The recommended practice is to include the permalink on the post date as well.

Single Post View

  • REQUIRED: Large images should be resized and not overflow the content area.
  • RECOMMENDED: Post title should not have the permalink as it is essentially linking to itself.

Pages

  • REQUIRED: Pages should not display any kind of "Comments are closed" message. Add a check !is_page() to the comments_open() conditional statement in comments.php

Visual issues / functionality / browser checks: FAIL
Theme Options

  1. General Settings:
    • Updating the Typography has no effect on the front end.
    • Updating Container Background and Container Background Color has no effect on the front end.
  2. Background Image:
    • REQUIRED: Since you have a custom background image you are required to implement core functionality which is add_custom_background()
    • I cannot see what effect Background Opacity has. No matter what setting I choose, the background remains the same.



Validation: FAIL
CSS: PASS

HTML: FAIL

  • You have a self-closing syntax /> on an element that does not use self-closing: <a href="" target="_blank" />

Code Quality: FAIL

  • REQUIRED: wp_footer() must be directly before </body>.
  • REQUIRED: Scripts should not be hard-coded into the header.php / footer.php. Some resources:

http://codex.wordpress.org/Function_Reference/wp_register_script
http://codex.wordpress.org/Function_Reference/wp_enqueue_script
http://codex.wordpress.org/Function_Reference/wp_localize_script
http://weblogtoolscollection.com/archives/2010/05/06/adding-scripts-properly-to-wordpress-part-1-wp_enqueue_script/
http://weblogtoolscollection.com/archives/2010/05/07/adding-scripts-properly-to-wordpress-part-2-javascript-localization/

  • REQUIRED: All custom functions and global variables must be prefixed with either the theme slug or an appropriate variant. Since you are using an options framework, the prefixes optionsframework_ and of_ are acceptable. However, your function names in functions.php should be prefixed with launching_.
  • REQUIRED: Add an id to your sidebar so that it can be uniquely identified. For example:
    	register_sidebar(array(
    		'id' => 'footer'
    		'name' => 'Footer',
    		'before_widget' => '<div class="footer_widget">',
    
  • REQUIRED: Remove the checking if register_sidebar function exists in Line 40. This function has existed for quite some time now and there is no need for backward compatibility.

Other notes

  • REQUIRED: The Theme URI must be a valid URI. http://themesweet.com/themes/launching shows up with the title "Page Not Found"

Information
If there are any issues once resolved, please re-submit your Theme using the uploader tool on wordpress.org/extend/themes, and a new Trac ticket will be generated.
Note:

  • Re-submitted Themes are given review priority over new Themes.

You can use the following tools to recreate the issues raised above if any have been:

Themes should be reviewed using define('WP_DEBUG', true); in wp-config.php
You can also view the Theme Review page.

Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:

  • 1) Leave a comment on this ticket
  • 2) Email the theme-reviewers email list
  • 3) Use the #wordpress-themes channel on irc.freenode.net

#3 @themesweet
6 years ago

Hi garinungkadol,

Thank you so much for the detailed feedback and test results. The last time I submitted a theme was almost 2 years ago and it wasn't this in-depth. I really appreciate all of your help. I'll make these changes and improvements. Thanks again and take care!

Note: See TracTickets for help on using tickets.