WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 6 weeks ago

Last modified 6 weeks ago

#43956 closed theme (live)

THEME: UNISCO – 1.1.2

Reported by: snapthemes Owned by: kevinhaig
Priority: new theme Keywords: theme-unisco
Cc: hello@…

Description

UNISCO - 1.0.0

A theme for schools, colleges, universities or any other educational institutions.

Theme URL - https://snapthemes.io/
Author URL - https://gautamthapar.me/

Trac Browser - https://themes.trac.wordpress.org/browser/unisco/1.0.0

SVN - https://themes.svn.wordpress.org/unisco/1.0.0
ZIP - https://wordpress.org/themes/download/unisco.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#43956 THEME: UNISCO – 1.1.2 closed live kevinhaig

(this ticket)

#47092 THEME: UNISCO – 1.1.3 closed live themetracbot
#48329 THEME: UNISCO – 1.1.4 closed live themetracbot


https://themes.svn.wordpress.org/unisco/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

Attachments (3)

UNISCO_1.JPG (114.6 KB) - added by kevinhaig 8 weeks ago.
UNISCO_3.JPG (73.3 KB) - added by kevinhaig 8 weeks ago.
UNISCO_4.JPG (58.8 KB) - added by kevinhaig 8 weeks ago.

Download all attachments as: .zip

Change History (47)

#1 @themetracbot
5 months ago

  • Summary changed from THEME: UNISCO – 1.0.0 to THEME: UNISCO – 1.0.1

UNISCO - 1.0.1

A theme for schools, colleges, universities or any other educational institutions.

Theme URL - https://snapthemes.io/
Author URL - https://gautamthapar.me/

Trac Browser - https://themes.trac.wordpress.org/browser/unisco/1.0.1

SVN - https://themes.svn.wordpress.org/unisco/1.0.1
ZIP - https://wordpress.org/themes/download/unisco.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=unisco/1.0.0&new_path=unisco/1.0.1

History:

Ticket Summary Status Resolution Owner
#43956 THEME: UNISCO – 1.1.2 closed live kevinhaig

(this ticket)

#47092 THEME: UNISCO – 1.1.3 closed live themetracbot
#48329 THEME: UNISCO – 1.1.4 closed live themetracbot


https://themes.svn.wordpress.org/unisco/1.0.1/screenshot.png

#2 @themetracbot
5 months ago

  • Summary changed from THEME: UNISCO – 1.0.1 to THEME: UNISCO – 1.0.2

UNISCO - 1.0.2

A theme for schools, colleges, universities or any other educational institutions.

Theme URL - https://snapthemes.io/unisco/
Author URL - https://snapthemes.io/

Trac Browser - https://themes.trac.wordpress.org/browser/unisco/1.0.2

SVN - https://themes.svn.wordpress.org/unisco/1.0.2
ZIP - https://wordpress.org/themes/download/unisco.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=unisco/1.0.1&new_path=unisco/1.0.2

History:

Ticket Summary Status Resolution Owner
#43956 THEME: UNISCO – 1.1.2 closed live kevinhaig

(this ticket)

#47092 THEME: UNISCO – 1.1.3 closed live themetracbot
#48329 THEME: UNISCO – 1.1.4 closed live themetracbot


https://themes.svn.wordpress.org/unisco/1.0.2/screenshot.png

#3 @joyously
4 months ago

Here is some user feedback to consider before your review.

  • One of the menus needs to have a fallback for when no menu is selected. The default value of fallback_cb parameter of wp_nav_menu() works really well, and it's core functionality.
  • There is placeholder content showing to site visitors. (slider) This should never happen.
  • Theme or author name/brand should not be output on front end except as allowed in a credit link. Logo should be disabled by default.
  • Logo is linking to the wrong place. Use home_url() instead of site_url().
  • I do not like having to choose to see the comments or the comment form. I want to be able to refer to the comments as I type my comment.
  • The comment author is not linked to his website.
  • There is no link to the comment anchor (for easy copy/paste). This is typically put on the comment date.
  • A post with no title has no link to the single post page from an archive.
  • blockquote is styled as italic, but can have nested <em> and <cite> tags which are indistinguishable. It doesn't really need to be italics, because it has big quote marks, a different color and background color, and large indents. The same could be said of the bold, which won't allow nested <b> or <strong> tags to be seen.
  • The big quote marks in blockquote are showing as a box around a hex number.
  • Unordered lists do not have bullets.
  • Unordered list items have a bottom margin that spreads the list vertically. Can't have a short list! It also looks unbalanced when lists are nested.
  • Instead of .entry-content img, .comments-area img {height: auto; max-width: 100%;} and a separate img {max-width: 100%;}, there should be just one rule: img {height: auto; max-width: 100%;} because the two properties go together and should apply to all images.
  • You might want to hide the menu, comment form link, and widget areas for the print styles. The header image is not shown, but the space for it is still there. Even if the comments are showing in the page, they don't show in print preview.
  • .gallery img {width: 100%} This CSS rule should be removed, as the theme cannot know what the image width should be. It causes the browser to upscale thumbnails, which looks awful, and the user doesn't get the size he chose.
  • Search results work much better as excerpts, so the user can see where the matches are instead of a flood of mostly non-matching content.
  • The 404 page tries to be helpful, but it would be better to put those widgets into the page and output the user's sidebar as is.
  • Customizer
    • Front Slider - remove all the content fields (including images) as these will disappear on theme switch. Themes should present existing content only.
    • Header Image - I removed the header image and it still shows in the preview.
    • Colors - I changed Body Text color, but there is a lot of body text that did not change.
    • Colors - the footer takes on the color of Body Text color, which is not expected. Can you make it a separate option?
    • Site Identity - I removed the Responsive Logo and it is still showing in the preview. Why is there Logo and Responsive Logo?

#4 @snapthemes
4 months ago

@joyously - Thank you for the feedback! Much appreciated!

  • I do not like having to choose to see the comments or the comment form. I want to be able to refer to the comments as I type my comment. - Is this required or just a personal preference?
  • The big quote marks in blockquote are showing as a box around a hex number. - We will be grateful if you can share a screenshot.
  • Site Identity - I removed the Responsive Logo and it is still showing in the preview. Why is there Logo and Responsive Logo? - Changed to Mobile Logo and added description. This logo will be displayed on small screens.

#5 @themetracbot
4 months ago

  • Summary changed from THEME: UNISCO – 1.0.2 to THEME: UNISCO – 1.0.3

#6 @joyously
4 months ago

  • I think you haven't accounted for not having a logo. I get this: https://s3.postimg.org/jqzd701xv/center-logo-max-width-165.jpg
  • I do not like having to choose to see the comments or the comment form. I want to be able to refer to the comments as I type my comment. - Is this required or just a personal preference?

It is user feedback. Comments are the interactive part of a site. Users should be able to read the other comments as they type their own.

  • The big quote marks in blockquote are showing as a box around a hex number.

They look good in this new version.

  • Site Identity - I removed the Responsive Logo and it is still showing in the preview. Why is there Logo and Responsive Logo? - Changed to Mobile Logo and added description. This logo will be displayed on small screens.

That is a better description, thank you. But the theme logo should still not show on the front end, and should not be a default. Now when I remove it, I see the alt text "responsive-logo". You should be using the site title instead.

  • Header Image - I removed the header image and it still shows in the preview.

Now when I remove the header image, it goes away, but the default color of the header text is white, so then it is white on white. It is best for readability to use some text-shadow on text over images, so this is another reason to put that in place.

#7 @themetracbot
4 months ago

  • Summary changed from THEME: UNISCO – 1.0.3 to THEME: UNISCO – 1.0.4

#8 @snapthemes
4 months ago

@joyously Thank you again!

Fixed everything except the comments part. We are still not sure about it. The comment form shows below a comment if you are replying to a comment. This is the time a user would like to see the comment he/she is replying to. For a new comment we don't think a user would like to see other comments while writing. It can be done before writing a comment.

#9 @themetracbot
4 months ago

  • Owner set to cristiano.zanca
  • Status changed from new to reviewing

#10 @cristiano.zanca
4 months ago

Hi @snapthemes , I’ve started the review of your theme.

The review process follows procedures found here https://make.wordpress.org/themes/handbook/review/.

If a requirement or anything else is not clear in the review, please comment in the ticket.

Kind Regards

#11 follow-up: @cristiano.zanca
3 months ago

Hi @snapthemes ,

http://i.imgur.com/CyTrswc.png

the main reason I'm writing is to let you know that I'm not forgetting your theme.

this is not a required issue, but I'm missing the reason for the two menu available in the header, as it can be seen in this image it could be not very well readable.

meanwhile I'm still reviewing the theme, sorry for not being very fast. I hope in these days to check all the issue I can find and than pass to the admin review.

Kind Regards

#12 in reply to: ↑ 11 @snapthemes
3 months ago

Hi Cristiano,

The logo appears between the two menus once set. So user will have to divide his/her menu in two parts.

Replying to cristiano.zanca:

Hi @snapthemes ,

http://i.imgur.com/CyTrswc.png

the main reason I'm writing is to let you know that I'm not forgetting your theme.

this is not a required issue, but I'm missing the reason for the two menu available in the header, as it can be seen in this image it could be not very well readable.

meanwhile I'm still reviewing the theme, sorry for not being very fast. I hope in these days to check all the issue I can find and than pass to the admin review.

Kind Regards

#13 follow-up: @cristiano.zanca
3 months ago

Hi @snapthemes

1) instead of this >
'<a href="https://snapthemes.io/" rel="designer">SnapThemes</a>'

this is sanitized >
'<a href="' . esc_url('https://snapthemes.io', 'unisco') . '

line 62 footer.php

https://codex.wordpress.org/Function_Reference/esc_url
https://make.wordpress.org/themes/handbook/review/required/#core-functionality-and-features

2) if is selected a background image the page has no color background and become unreadable

http://i.imgur.com/sgzRLPG.jpg

I suggest to download this dummy data to test the layout with:

https://github.com/WPTRT/theme-unit-test

3) about the special splitted menu, it's better to document it well in the description:

"Any custom features, templates, options or any limitations (for example menu restrictions), should be explained. Enough documentation should be provided."

from https://make.wordpress.org/themes/handbook/review/required/#documentation

at the moment I don't see other issues

Kind Regards

#14 in reply to: ↑ 13 @snapthemes
3 months ago

Replying to cristiano.zanca:

Hi Cristiano,

Thanks for the review!

1) instead of this >
'<a href="https://snapthemes.io/" rel="designer">SnapThemes</a>'

this is sanitized >
'<a href="' . esc_url('https://snapthemes.io', 'unisco') . '

line 62 footer.php

Fixed! Thanks!

2) if is selected a background image the page has no color background and become unreadable

User is free to change the body text color from the colors section in customizer. I don't think we can provide one best color for every need.

3) about the special splitted menu, it's better to document it well in the description:

Where do you suggest to add this documentation? Readme file?

Best Regards,
~ Team SnapThemes

Last edited 3 months ago by snapthemes (previous) (diff)

#15 follow-up: @cristiano.zanca
3 months ago

Hi @snapthemes ,

3) about the special splitted menu, it's better to document it well in the description:
Where do you suggest to add this documentation? Readme file?

Yes, Readme file it's ok, where is visible enough to avoid people to ask your support about the use of the splitted theme.

Kind Regards

#16 @themetracbot
3 months ago

  • Summary changed from THEME: UNISCO – 1.0.4 to THEME: UNISCO – 1.0.5

#17 in reply to: ↑ 15 @snapthemes
3 months ago

Replying to cristiano.zanca:

Hi @snapthemes ,

3) about the special splitted menu, it's better to document it well in the description:
Where do you suggest to add this documentation? Readme file?

Yes, Readme file it's ok, where is visible enough to avoid people to ask your support about the use of the splitted theme.

Kind Regards

Thanks! Theme updated.

Cheers,
~ Team SnapThemes

Last edited 3 months ago by snapthemes (previous) (diff)

#18 @cristiano.zanca
3 months ago

  • Status changed from reviewing to approved

Hi @snapthemes ,

for what I can see it can pass at the second review phase.

Maybe there will be some more editing to do, I hope little things.

Kind Regards

#19 @kevinhaig
2 months ago

I will do this final review.

#20 @kevinhaig
2 months ago

  • Status changed from approved to reopened

Theme Review - UNISCO Version 1.0.5

  • Hi I am @kevinhaig and I have completed the second (final) review of your theme.
  • Sorry but the ticket has been reopened because there are requirements not met.
  • The review process follows procedures found in the theme handbook.
  • ref: https://make.wordpress.org/themes/handbook/review/
  • If you do not understand or agree with something in the review, please comment in the ticket.
  • I can then help you, or if I am not sure of something I will certainly seek a second opinion from another key reviewer.

Responding to the Review

  • Please respond with update or request an extension within 7 days, or theme may be closed.

Required Items

Code

PHP/JS Errors
  • No PHP or JS errors.
  • The following errors were encountered.
  • WARNING: C:\xampp\htdocs\wptesta\wp-content\themes\unisco\sidebar.php:17 - Illegal string offset 'sidebar'require('C:\xampp\htdocs\wptesta\wp-blog-header.php'), require_once('C:\xampp\htdocs\wptesta\wp-includes\template-loader.php'), include('C:\xampp\htdocs\wptesta\wp-content\themes\unisco\index.php'), get_sidebar, locate_template, load_template, require_once('C:\xampp\htdocs\wptesta\wp-content\themes\unisco\sidebar.php')
All untrusted data should be escaped before output.
  • get_permalink must be escaped, use esc_url() , file: unisco\comments.php, line: 126
  • get_permalink must be escaped, use esc_url() , file: unisco\comments.php, line: 135
  • get_permalink must be escaped, use esc_url() , file: unisco\inc\extras.php, line: 80
  • home_url must be escaped, use esc_url() , file: unisco\inc\extras.php, line: 87
Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.

Core Functionality and Features

Use WordPress functionality and features first, if available.
  • add_theme_support() for post-formats used but not found in tags list in style.css , file: unisco\functions.php, line: 31
  • add_theme_support() for custom-background used but not found in tags list in style.css , file: unisco\functions.php, line: 74

Presentation vs Functionality

The theme options should not be pseudo custom post types and save non-trivial user data. Non-design related functionality is not allowed.
  • Pseudo Custom Post Types are not allowed because they create non-trivial content. Pseudo CPT's are data that is entered multiple times, such as service boxes, or repeated titles and descriptions for slider images. These things result in content loss when the theme is switched that is not a favorable user experience.
  • Sorry but the method you are using to populate your slider is not allowed. Consider using Featured Posts instead.

Recommended Items

It is not required to complete recommended items, but considered good practice

  • get_home_url() is discouraged. Use home_url() instead. , file: unisco\inc\template-functions.php, line: 127
  • paginate_links() is discouraged. Use the_posts_pagination() instead. , file: unisco\inc\template-functions.php, line: 162
  • post titles should allow html markup
Last edited 2 months ago by kevinhaig (previous) (diff)

#21 @kevinhaig
2 months ago

I have not heard any thing?

Please indicate if you plan to update this theme, otherwise I will close the ticket.

#22 @snapthemes
2 months ago

Hi @kevinhaig @cristiano.zanca ,

Thank you so much for taking the time to review this theme. Sorry we got busy on a project. We will definitely update the theme in a few days.

Appreciate your hard work. Thanks!

Cheers,
~ Team SnapThemes

#23 @snapthemes
2 months ago

Hi @kevinhaig ,

Are we allowed to use a top level menu to provide instructions and information regarding the theme? And can you please provide more details on the PHP error you mentioned as we are unable to reproduce it.

Thanks!

Cheers,
~ Team SnapThemes

#24 @kevinhaig
2 months ago

I am using php 7.1. The error message is likely because it is looking for sidebar-1 file and can't find it.

You can have an admin notice but it must not be obtrusive and it must be dismiss-able.

#25 @joyously
2 months ago

Are we allowed to use a top level menu to provide instructions and information regarding the theme?

Not top level, but you can have one menu item under Appearance.

#26 @kevinhaig
2 months ago

Sorry @joyously, perhaps you are correct, and I am the one confused.

@snapthemes

Top level menu items are not allowed.

However you can put up a dismiss-able notice on theme switch that would point to a theme page.

Last edited 2 months ago by kevinhaig (previous) (diff)

#27 @themetracbot
8 weeks ago

  • Summary changed from THEME: UNISCO – 1.0.5 to THEME: UNISCO – 1.0.6

#28 @snapthemes
8 weeks ago

Thanks @kevinhaig @joyously ,

We have updated the theme based on your suggestions.

Cheers,
~ Team SnapThemes

#29 @kevinhaig
8 weeks ago

Please check your revisions before you upload a new version.

Your theme will not load.

Warning: require(C:\xampp\htdocs\wptesta/wp-content/themes/unisco/inc/navwalker.php): failed to open stream: No such file or directory in C:\xampp\htdocs\wptesta\wp-content\themes\unisco\functions.php on line 227 Fatal error: require(): Failed opening required 'C:\xampp\htdocs\wptesta/wp-content/themes/unisco/inc/navwalker.php' (include_path='C:\xampp\php\PEAR') in C:\xampp\htdocs\wptesta\wp-content\themes\unisco\functions.php on line 227

#30 @snapthemes
8 weeks ago

Hi @kevinhaig ,

Just downloaded the theme from the zip link above and installed it on a new WordPress install locally. Seems to be working fine.

Cheers,
~ Team SnapThemes

#31 @kevinhaig
8 weeks ago

Yeah sorry, must have been something I did. When I setup the new version the navwalker file was not there....very strange.

#32 @kevinhaig
8 weeks ago

Theme Review - UNISCO Version 1.0.6

  • Below is the review of the latest update of your theme.

Responding to the Review

  • Please respond with update or request an extension within 7 days, or theme may be closed.
  • you have made quite a few significant changes in this theme, and a thourough review was required.

Required Items

Code

PHP/JS Errors
  • No PHP or JS errors.
    • I am still seeing php errors/warnings/notices. See the screenshots below. These will need to be fixed.

Core Functionality and Features

Use WordPress functionality and features first, if available.
  • add_theme_support() for custom-background used but not found in tags list in style.css , file: unisco\functions.php, line: 74

Language

All theme text strings are to be translatable.
  • There are many strings in unisco_slide_repeater.php that are escaped but not translated?
  • There are many strings in slider.php that are not translated.
Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.

Stylesheets and Scripts

Include all scripts and resources it uses rather than hot-linking. The exception to this is Google Fonts.
  • Possible URL of a CDN has been found. You should not load CSS or Javascript resources from a CDN, please bundle them with the theme. , file: unisco\inc\extras.php, line: 267 ….This is not allowed.
  • Hardcoded URL found. Is this url acceptable? https://s3.amazonaws.com/downloads.mailchimp.com/js/mc-validate.js , file: unisco\inc\extras.php, line: 269 ….. This is not allowed.
  • Hardcoded URL found. Is this url acceptable? snapthemes.us16.list-manage.com/subscribe/post?u=0edfedc75f94556767afc7dd2& , file: unisco\inc\extras.php, line: 318….This is not allowed.
No minification of scripts or files unless provide original files.
  • Please provide an unminimized version of fontawesom-iconpicker.min.css in the same folder.
  • Why do you now have multiple versions of fontawesome? Please set up to use only one.

Other Required

  • Please remove the Subscrbe for updates section from your theme page. These are not allowed in .org themes.
  • There is nothing in the customizer/js folder. Why is the folder there?

Recommended Items

  • Why are you doing this $container = 'container'; then <div class="<?php echo esc_attr($container); ?>"> ?
    • use <div class="container"> instead

@kevinhaig
8 weeks ago

@kevinhaig
8 weeks ago

@kevinhaig
8 weeks ago

#33 @snapthemes
8 weeks ago

Hi @kevinhaig ,

Thank you!


Is there a good way to connect with the users?


Why are you doing this $container = 'container'; then <div class="<?php echo esc_attr($container); ?>"> ?

There are filters based on which we can override the $container variable when required. May be you missed:

if( 'full-width' == $page_template ){
        $container = 'container-fluid';
}


Cheers,
~ Team SnapThemes

#34 @themetracbot
8 weeks ago

  • Summary changed from THEME: UNISCO – 1.0.6 to THEME: UNISCO – 1.0.8

#35 @themetracbot
7 weeks ago

  • Summary changed from THEME: UNISCO – 1.0.8 to THEME: UNISCO – 1.0.9

UNISCO - 1.0.9

A theme for schools, colleges, universities or other educational institutions.

Theme URL - https://snapthemes.io/unisco/
Author URL - https://snapthemes.io/

Trac Browser - https://themes.trac.wordpress.org/browser/unisco/1.0.9

SVN - https://themes.svn.wordpress.org/unisco/1.0.9
ZIP - https://wordpress.org/themes/download/unisco.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=unisco/1.0.8&new_path=unisco/1.0.9

History:

Ticket Summary Status Resolution Owner
#43956 THEME: UNISCO – 1.1.2 closed live kevinhaig

(this ticket)

#47092 THEME: UNISCO – 1.1.3 closed live themetracbot
#48329 THEME: UNISCO – 1.1.4 closed live themetracbot


https://themes.svn.wordpress.org/unisco/1.0.9/screenshot.png
Theme Check Results:

  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments '%1$s done.'

#36 @themetracbot
7 weeks ago

  • Summary changed from THEME: UNISCO – 1.0.9 to THEME: UNISCO – 1.1.0

#37 @kevinhaig
7 weeks ago

NOTICE: C:\xampp\htdocs\wptesta\wp-content\themes\unisco\template-parts\header\header-slider.php:58 - Undefined property: stdClass::$content require('C:\xampp\htdocs\wptesta\wp-blog-header.php'), require_once('C:\xampp\htdocs\wptesta\wp-includes\template-loader.php'), include('C:\xampp\htdocs\wptesta\wp-content\themes\unisco\index.php'), get_header, locate_template, load_template, require_once('C:\xampp\htdocs\wptesta\wp-content\themes\unisco\header.php'), get_template_part, locate_template, load_template, require('C:\xampp\htdocs\wptesta\wp-content\themes\unisco\template-parts\header\header-image.php'), get_template_part, locate_template, load_template, require('C:\xampp\htdocs\wptesta\wp-content\themes\unisco\template-parts\header\header-slider.php')

Last edited 7 weeks ago by kevinhaig (previous) (diff)

#38 @themetracbot
7 weeks ago

  • Summary changed from THEME: UNISCO – 1.1.0 to THEME: UNISCO – 1.1.1

#39 @snapthemes
7 weeks ago

Oops, sorry about that! We were unable to replicate the issue but still tried our best to improve the code.

Cheers,
~ Team SnapThemes

#40 @kevinhaig
7 weeks ago

  • You still have a few untranslated strings in unisco_info_page_notice()
  • I also noticed that your single page nav is showing twice.

#41 @themetracbot
7 weeks ago

  • Summary changed from THEME: UNISCO – 1.1.1 to THEME: UNISCO – 1.1.2

#42 @kevinhaig
6 weeks ago

  • Owner changed from cristiano.zanca to kevinhaig
  • Status changed from reopened to reviewing

Approving on difference

#43 @kevinhaig
6 weeks ago

  • Resolution set to live
  • Status changed from reviewing to closed

setting live

#44 @snapthemes
6 weeks ago

Thank you Kevin! Do we need to push a new version for even small changes? For example, changing the Theme page URL which is right now pointing to the theme docs.

Cheers,
~ Team SnapThemes

Last edited 6 weeks ago by snapthemes (previous) (diff)
Note: See TracTickets for help on using tickets.