WordPress.org

Make WordPress Themes

Opened 6 years ago

Closed 6 years ago

#4398 closed theme (live)

THEME: Propress - 2.6.7

Reported by: Danielx64 Owned by: ArnoldGoodway
Priority: Keywords: theme-propress
Cc: danielx386@…

Description

Propress - 2.6.7

Theme for wordpress 3.1 based on the phpBB3 theme ProSilver.

Theme URL -
Author URL - http://danielx64.com/

SVN - http://themes.svn.wordpress.org/propress/2.6.7
ZIP - http://wordpress.org/extend/themes/download/propress.2.6.7.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-propress

https://themes.svn.wordpress.org/propress/2.6.7/screenshot.png

Change History (3)

#1 @ArnoldGoodway
6 years ago

  • Owner set to ArnoldGoodway
  • Status changed from new to assigned

#2 @ArnoldGoodway
6 years ago

Issues from Previous Ticket

  • Fixed - Theme name cannot include "for WP" or similar.
  • Fixed - Footer copyright/credit link text does not conform to current guidelines regarding such requests.
  • Fixed - Remove function_exists() conditionals from any WordPress? function or functionality introduced more than 2 major WordPress? versions prior, including dynamic_sidebar() (and any other Widgets functionality).
  • Fixed - If used, comments-popup.php must meet the same code standards of comments.php.
  • Fixed, templates removed - Include documentation (i.e. in readme.txt) for use of archives.php and links.php custom Page templates.
  • Fixed - In header.php in the site title, home_url() must be echoed.
  • Fixed - Same thing in searchform.php: call to home_url() needs to be echoed.
  • Fixed - Page With Comments - Comments are not displayed.
  • Fixed - Error 404 Page - Must display some explanatory text, beyond the "Error 404" heading.

Code Quality

  • Feed links are not to be hard-coded into the document head, 'automatic-feed-links' in functions.php already takes care of this. As things are now the feed link appears twice in the HEAD.

Theme Unit Tests

  • Oversized images are not properly resized. The width resizes but the height stays the same. Adding height: auto; to your image CSS should fix this. The large images do not overflow the content area so this is thus a recommendation.

Review Summary

  • All outstanding issues from the previous ticket have been resolved.
  • There is still just the one issue that needs attention, the matter of the hard-coded feed link.
  • The ticket is being resolved as approved with the understanding that the author will remove the code for the relevant feed link before the theme is submitted for any future revision.

#3 @ArnoldGoodway
6 years ago

  • Resolution set to approved
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.