WordPress.org

Make WordPress Themes

Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#44006 closed theme (not-approved)

THEME: Kafal – 1.0.0

Reported by: shubham9411 Owned by: poena
Priority: new theme Keywords: theme-kafal
Cc: shubham9411@…

Description

Kafal - 1.0.0

A Bootstrap Theme Based on Clean Blog Template from Start Bootstrap. A beutifully designed responsive blogging theme. Custom header with Parallax effect added.

Theme URL - https://shubhampandey.in/kafal
Author URL - http://shubhampandey.in

Trac Browser - https://themes.trac.wordpress.org/browser/kafal/1.0.0

SVN - https://themes.svn.wordpress.org/kafal/1.0.0
ZIP - https://wordpress.org/themes/download/kafal.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#44006 THEME: Kafal – 1.0.0 closed not-approved poena

(this ticket)

#44111 THEME: Kafal – 1.0.7 closed live kafleg
#45770 THEME: Kafal – 1.0.8 closed live themetracbot
#46343 THEME: Kafal – 1.0.9 closed live themetracbot
#49175 THEME: Kafal – 1.0.10 closed live themetracbot
#49758 THEME: Kafal – 1.0.11 closed live themetracbot


https://themes.svn.wordpress.org/kafal/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: Found the URL of a CDN in the code: <code>oss.maxcdn.com/libs/html5shiv</code>. You should not load CSS or Javascript resources from a CDN, please bundle them with the theme.
  • RECOMMENDED: Found the URL of a CDN in the code: <code>oss.maxcdn.com/libs/respond.js</code>. You should not load CSS or Javascript resources from a CDN, please bundle them with the theme.

Change History (3)

#1 @poena
7 months ago

  • Owner set to poena
  • Status changed from new to reviewing

#2 @poena
7 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi!
Thank you for submitting your theme.
Your theme has been partially reviewed against these requirements:
https://make.wordpress.org/themes/handbook/review/required/

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues.
This is part of our long term goals to improve the theme quality and shorten the queues.
You can read more about this change here: https://make.wordpress.org/themes.

Please do not get discouraged by the ticket being closed. -We want you to resubmit your theme,
but we do ask that you spend more time making sure that your theme meets all the requirements.
https://make.wordpress.org/themes/handbook/review/required/
You can upload your update here: https://wordpress.org/themes/upload/

Because of the large number of themes waiting for review, we might not be able to follow up immediately.
We will review your update when your theme reaches the top of the review queue.

If you have questions you can ask them here or in the #themereview channel on Slack
channel.

Required:
I am unable to find a copyright statement for the theme itself, this is required to use GPL.
You can read more about this here: https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

Declare licenses and copyright of any resources included such as fonts or images. The theme needs to be 100% gpl compatible.
-This includes images used in the screenshot, since the screenshot is part of the theme.

No hard coding of script and style files.
Include all scripts and resources it uses rather than hotlinking. The exception to this is Google Fonts.
-The html5shiv and respond.js needs to be included in the theme folder, and enqueued.
Please see these examples: https://developer.wordpress.org/reference/functions/wp_script_add_data/

(Yes the Theme Check results above says that it is recommended, but this is incorrect; the current checker is not "smart" enough to know if something is a false positive, that is why it is only a recommendation, that needs to be manually checked).

All theme text strings are to be translatable, please check all your files carefully. There are texts that are missing translation functions.

The langauge file refers to underscores and needs to be updated.

All untrusted data should be escaped before output.
This includes translated text inside html attributes. See the search form.
All instances of home_url() needs to be escaped with esc_url().
Please do not echo get_theme_mod without escaping, it is not safe. Do not trust any data.

Please remove wpcom.php.

rtl.css is commented out? Please update it.


Recommended reading:

https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/resources/

https://developer.wordpress.org/themes/

https://developer.wordpress.org/themes/functionality/internationalization/
https://codex.wordpress.org/Validating_Sanitizing_and_Escaping_User_Data
https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

The coding standards are not required to pass the review, but they can be helpful when developing your theme.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/

The code reference library is very useful when you want to know more about WordPress functions, classes, hooks and methods.
It can help you determine if a function needs to be escaped or not, or if a function you have planned to write is already available.
https://developer.wordpress.org/reference/

#3 @shubham9411
7 months ago

Hey @poena , Thanks for your review. 😊
I will upload new changes soon!

Note: See TracTickets for help on using tickets.