WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 3 months ago

#44132 closed theme (not-approved)

THEME: Colorskin – 1.0.1

Reported by: effpandim Owned by: codexdemon
Priority: new theme Keywords: theme-colorskin
Cc: pandim099@…

Description

Colorskin - 1.0.0

A simple responsive wordpress theme, blue, green and red colors mainly for blog.

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/colorskin/1.0.0

SVN - https://themes.svn.wordpress.org/colorskin/1.0.0
ZIP - https://wordpress.org/themes/download/colorskin.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#44132 THEME: Colorskin – 1.0.1 closed not-approved codexdemon

(this ticket)

#45611 THEME: Colorskin – 1.0.3 closed live rodicaelena


https://themes.svn.wordpress.org/colorskin/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (6)

#1 follow-up: @joyously
4 months ago

Here is some user feedback to consider before your review.

  • The headings need a bit of margin, so it won't look so cramped.
  • blockquote is styled as italic, but can have nested <em> and <cite> tags which are indistinguishable. It doesn't really need to be italics, because it has a left bar and a border.
  • The <big> tag is not big.
  • <q> tag is unstyled. (default removed)
  • The <small> tag is not small.
  • The Custom Menu widget is styled like a dropdown menu, but this is very difficult to use (hover on dropdown vertical menu) and won't work for mobile (no hover). It also pushes everything below it down when a submenu is havered.
  • You might want to hide the sticky header, menu, comment form, and widget areas for the print styles.
  • The gallery captions are really small.
  • I do not like the Customizer to have a different color scheme. I can't see all the details like the dashed lines.
  • In Customizer, General Colors - the color scheme option shows broken image symbols for the four choices. And clicking them doesn't seem to change anything.

#2 @effpandim
4 months ago

Thanks for the suggestions. I will make the corrections and submit it again.

#3 @themetracbot
4 months ago

  • Summary changed from THEME: Colorskin – 1.0.0 to THEME: Colorskin – 1.0.1

Colorskin - 1.0.1

A simple responsive wordpress theme, blue, green and red colors mainly for blog.

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/colorskin/1.0.1

SVN - https://themes.svn.wordpress.org/colorskin/1.0.1
ZIP - https://wordpress.org/themes/download/colorskin.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=colorskin/1.0.0&new_path=colorskin/1.0.1

History:

Ticket Summary Status Resolution Owner
#44132 THEME: Colorskin – 1.0.1 closed not-approved codexdemon

(this ticket)

#45611 THEME: Colorskin – 1.0.3 closed live rodicaelena


https://themes.svn.wordpress.org/colorskin/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#4 in reply to: ↑ 1 @effpandim
4 months ago

Replying to joyously:

Here is some user feedback to consider before your review.

  • The headings need a bit of margin, so it won't look so cramped.
  • blockquote is styled as italic, but can have nested <em> and <cite> tags which are indistinguishable. It doesn't really need to be italics, because it has a left bar and a border.
  • The <big> tag is not big.
  • <q> tag is unstyled. (default removed)
  • The <small> tag is not small.
  • The Custom Menu widget is styled like a dropdown menu, but this is very difficult to use (hover on dropdown vertical menu) and won't work for mobile (no hover). It also pushes everything below it down when a submenu is havered.
  • You might want to hide the sticky header, menu, comment form, and widget areas for the print styles.
  • The gallery captions are really small.
  • I do not like the Customizer to have a different color scheme. I can't see all the details like the dashed lines.
  • In Customizer, General Colors - the color scheme option shows broken image symbols for the four choices. And clicking them doesn't seem to change anything.

Hi @joyously

Thank you for your feedbacks. I've made some changes based on your suggestions.

Regards.

#5 @themetracbot
3 months ago

  • Owner set to codexdemon
  • Status changed from new to reviewing

#6 @codexdemon
3 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues. This is part of our long term goals to improve the theme quality and shorten the queues. You can read more about this change here: https://make.wordpress.org/themes.

Please do not get discouraged by the ticket being closed. We want you to resubmit your theme, but we do ask that you spend more time making sure that your theme meets all the requirements. You can upload your updated theme here: https://wordpress.org/themes/upload/

Because of the large number of themes waiting for review, we might not be able to follow up immediately. We will review your update when your theme reaches the top of the review queue.

  • REQUIRED: Found usage of constant "HEADER_TEXTCOLOR". Use add_theme_support( 'custom-header' ) instead. FILE: inc/custom-header.php
  • REQUIRED: The title tag must not be used. Use add_theme_support( 'title-tag' ) instead. FILE: inc/extras.php
  • REQUIRED: FOUND 3 ERRORS All untrusted data should be escaped properly before displaying. https://codex.wordpress.org/Data_Validation Eg, esc_url() should be used to escape URL, value in HTML attributes should be escaped with esc_attr().

FILE: inc/template-tags.php L107, L112 L143

  • REQUIRED: Invalid File Readme Content, No Informationa bout license file.
  • REQUIRED: Change this require get_template_directory() . '/inc/jetpack.php'; to this. Proper check is needed before loading third party PHP library. functions.php L236

For E.g.

if ( ! class_exists( 'wp_jetpack' )) {
require get_template_directory() . '/inc/jetpack.php';
}
Note: See TracTickets for help on using tickets.