WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 2 months ago

Last modified 2 months ago

#44144 closed theme (not-approved)

THEME: Sleekr Lite – 1.0.1

Reported by: Chefopld Owned by: codexdemon
Priority: new theme Keywords: theme-sleekr-lite
Cc: chefopld@…

Description

Sleekr Lite - 1.0.0

A responsive simple blogging theme for WordPress. Specially crafted for business blogs, Sleekr Lite guarantees a fast and smooth experience.

Theme URL - https://www.webhostface.com
Author URL - https://plus.google.com/+StefanStaykovBg

Trac Browser - https://themes.trac.wordpress.org/browser/sleekr-lite/1.0.0

SVN - https://themes.svn.wordpress.org/sleekr-lite/1.0.0
ZIP - https://wordpress.org/themes/download/sleekr-lite.1.0.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/sleekr-lite/1.0.0/screenshot.png

Change History (7)

#1 @themetracbot
4 months ago

  • Summary changed from THEME: Sleekr Lite – 1.0.0 to THEME: Sleekr Lite – 1.0.1

Sleekr Lite - 1.0.1

A responsive simple blogging theme for WordPress. Specially crafted for business blogs, Sleekr Lite guarantees a fast and smooth experience.

Theme URL - https://www.webhostface.com
Author URL - https://plus.google.com/+StefanStaykovBg

Trac Browser - https://themes.trac.wordpress.org/browser/sleekr-lite/1.0.1

SVN - https://themes.svn.wordpress.org/sleekr-lite/1.0.1
ZIP - https://wordpress.org/themes/download/sleekr-lite.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sleekr-lite/1.0.0&new_path=sleekr-lite/1.0.1

History:


https://themes.svn.wordpress.org/sleekr-lite/1.0.1/screenshot.png

#2 @joyously
3 months ago

Here is some user feedback to consider before your review.

  • The menu needs to have a fallback for when no menu is selected. The default value of fallback_cb parameter of wp_nav_menu() works really well, and it's core functionality.
  • header.php
    • Remove the favicon and related code. This is handled by core WordPress.
    • Remove the enqueue of jquery. If it is needed, put it in the dependency parameter for the script that needs it.
    • Remove jquery from the theme folder. It is bundled with WordPress.
    • Move the enqueue of the comment script to the setup function.
    • Change the hardcoded style to use enqueue. This has to be child theme friendly.
    • Remove the menu parameter from wp_nav_menu(). (also in footer.php)
    • Any restrictions (such as menu depth=2) need to be documented for the user.
  • See Proper Copyright/License Attribution for Themes to list all resources used (PHP, JS, CSS, fonts, images).
  • This screenshot shows a few problems:
    • The calendar widget is unreadable.
    • The theme is allowed only one link in the footer. (Theme URI or Author URI)
    • The RSS widget is oddly formatted.
    • The copyright text is limited to the left half of the footer. https://s2.postimg.org/joguimdsp/footer-widget-problems.jpg
  • The post date is shown in a format different from what I chose for date format.
  • Page links (generated by <!--nextpage-->) are not being output on Pages.
  • Floats are not being cleared properly after the content area.
  • <h6> is quite small. How is that a heading?
  • Tables look all smashed together.
  • Definition lists look like regular text.
  • <hr> is invisible.
  • You might want to hide the comment form and widget areas for the print styles.
  • Post navigation links would be nice.
  • The output of Pingbacks messed up the layout of the page. The HTML is showing, the comment is where the sidebar should be, the sidebar is in the footer. https://s2.postimg.org/ijort0kax/pingback-layout-problem.jpg
  • WARNING: wp-content/themes/sleekr-lite/functions/gallery-shortcode.php:11 - array_merge(): Argument #2 is not an array
  • WARNING: wp-content/themes/sleekr-lite/functions/gallery-shortcode.php:28 - Division by zero
  • Due to those warnings, I don't see any gallery. You can style the gallery without filtering the shortcode.
  • functions.php
    • The defines are not prefixed. Most of these should be removed, since the define happens at load time and not all filters are loaded. The template directory should be dynamic, not a constant.
    • The setup function indentation is messed up.
    • The content_width needs to be checking and setting the global.
    • Themes can only check for backward compatibility for 3 major versions. So remove the custom logo function.
  • The message for a search with no results says "Sorry, there are no posts." This is a little confusing and misleading. Searches should find posts, pages, custom post types. Saying there are no posts makes it sound like there aren't any, period, not that there were none that matched.
  • Search results should not show the author and date of static Pages.
  • The 404 page is not at all helpful. It says "Here are some helpful links to get you back on track:", but there are no links.
  • Customizer
    • Header Image - I removed the default header image and it still shows in the preview.
    • Colors - Header Text color does not work and needs a default value.
    • Colors - Background color needs a default value that matches the front end.
    • Site Identity - "Display site title and tagline" option does not change the preview.
  • I tested the whole theme and never saw a page that looked like the theme screenshot. The screenshot must be a screenshot of the theme, not just the image that the theme uses.

#3 @themetracbot
2 months ago

  • Owner set to codexdemon
  • Status changed from new to reviewing

#4 @codexdemon
2 months ago

Hello @Chefopld

Please let us know if you are ok with review the files which you submited or if you want to resubmit your files please do let me know. So i can start reviwing your theme.

#5 @codexdemon
2 months ago

Hello

I have given time for update file so i am starting review now of your theme

#6 @codexdemon
2 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello

Your theme has been reviewed against this Theme Review Guideline https://make.wordpress.org/themes/handbook/review/required/.

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues. This is part of our long term goals to improve the theme quality and shorten the queues. You can read more about this change here: https://make.wordpress.org/themes.

Please do not get discouraged by the ticket being closed. We want you to resubmit your theme, but we do ask that you spend more time making sure that your theme meets all the requirements. You can upload your updated theme here: https://wordpress.org/themes/upload/

Because of a large number of themes waiting for review, we might not be able to follow up immediately. We will review your update when your theme reaches the top of the review queue.

*REQUIRED: Error Code for favicon found. Favicons are handled by the "Site Icon" setting in the customizer since version 4.3. FILE: header.php

*REQUIRED: Remove the menu parameter from wp_nav_menu()

*REQUIRED: Remove jquery from the theme folder. It is bundled with WordPress.

*REQUIRED: text domain and prefix function all is a mismatch. Please used prefix name which you specified for theme text domain name.

*WARNING: wp-content/themes/sleekr-lite/functions/gallery-shortcode.php:11 - array_merge(): Argument #2 is not an array

WARNING: wp-content/themes/sleekr-lite/functions/gallery-shortcode.php:28 - Division by zero
Due to those warnings, I don't see any gallery. You can style the gallery without filtering the shortcode.

Page links (generated by <!--nextpage-->) are not being output on Pages.

#7 @Chefopld
2 months ago

Hey there, the theme was already reviewed and there were remarks that I was fixing, why did you review it again?

Note: See TracTickets for help on using tickets.