WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 4 months ago

#44169 closed theme (live)

THEME: Belise Lite – 1.0.9

Reported by: themeisle Owned by: rinkuyadav999
Priority: new theme Keywords: theme-belise-lite
Cc: ionut+worg@…

Description

Belise Lite - 1.0.8

Belise Lite is a clean and minimalist WordPress theme for restaurants and food websites. It provides a responsive design, nice food menus via Jetpack plugin, an Events section, and a beautiful portfolio also integrated with Jetpack. You can use Belise Lite to make your restaurant look stunning in the online zone. Apart from that, the theme is good for ecommerce because it is WooCommerce ready. Live Customizer, WPML compatibility, contact form integration, and quality support are other features that make Belise Lite great for your site.

Theme URL - https://themeisle.com/themes/belise-lite
Author URL - https://themeisle.com

Trac Browser - https://themes.trac.wordpress.org/browser/belise-lite/1.0.8

SVN - https://themes.svn.wordpress.org/belise-lite/1.0.8
ZIP - https://wordpress.org/themes/download/belise-lite.1.0.8.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#44169 THEME: Belise Lite – 1.0.9 closed live rinkuyadav999

(this ticket)

#49304 THEME: Belise Lite – 1.0.10 closed live themetracbot


https://themes.svn.wordpress.org/belise-lite/1.0.8/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Tags: is either empty or missing in style.css header.

Change History (20)

#1 @joyously
4 months ago

Here is some user feedback to consider before your review.

  • Custom widgets should be for presentation of existing data, since they will disappear on theme switch. So the Ribbon widget should be removed from the theme.
  • Improve the "Sidebar" widget area description to indicate when it is shown. Add descriptions for "Events section" and "Ribbon area" widget areas for when and where.
  • All restrictions (such as menu depth=2) need to be documented for the user.
  • The mobile menu is still reacting to hover and not click, which makes it difficult to use with a mouse (dropdowns on vertical menu), and about impossible to use with a finger (no hover). I think this might only be when I narrow the window, because loading a page with a narrow window the menu is not reacting to hover. But it should handle both.
  • My menu is wrapping, and because the dropdown submenus are so low, I have to mouse over a different top level item to get to the submenu. But then the second submenu shows instead of the first one. https://s1.postimg.org/bnu2p9nyn/wrapping-menu.jpg
  • One of my pet peeves is when a theme forces me to jump through hoops to see the front end of my site like my visitor sees it. I hate that! I have to either log out, use a different browser, or an incognito window. All of those get rid of my admin bar. Why can't the front end look the same for everyone? As an admin, I can already see it differently in Customizer without publishing the changes, so why should I have to take extra steps to check the front end? I personally would never use a theme that does that, and if the user is not aware that the theme is doing it, they might even think everyone is seeing that. Bad user experience, for sure.
  • Static Pages should show comments.
  • The link color in the footer is so difficult to see. (tan on white)
  • The user content text is tiring to read since it is so low contrast.
  • The blog page is centering the post excerpt. But excerpts can have HTML that looks bad centered. Really, user content should never be centered unless the user chooses it.
  • Using word-break: break-all on content makes text very difficult to read.
  • The blog page is showing differently on the incognito page from the one where I am logged in as admin. The incognito window looks worse. The windows are exactly the same size.

https://s2.postimg.org/56szi7krt/blog-page-incognito.jpg
https://s2.postimg.org/5v1u15jhl/blog-page-admin.jpg

  • The author bio box exposes the author's email address! This should not happen.
  • The author bio box uses the wrong name. I should see the one chosen in the user profile for "Display name publicly as" option.
  • blockquote is styled as centered, but can have all sorts of HTML tags in it (it is for extended quotations). I don't see how it can truly quote another document if it is styled as centered. Same goes for all uppercase and bold. It is as if someone is shouting, and loses the flexibility to handle all types of quotations. That's like saying "this is what they said", but not "this is how they said it". The "how" conveys meaning as well as the "what" does.
  • The ordered list is using counters for user content lists. It is not taking into account nested lists or the reverse and start attributes. Here is what my list should look like on the left, with the theme version on the right. https://s1.postimg.org/719p38rxr/list-counters.jpg
  • The <q> tag is styled like a block when it is intended for short, inline quotes. This messes up user sentences. Here I show the way the theme styles it on the left and how it would look without the q in the selectors on the right.

https://s1.postimg.org/cfe32d1mn/quote-tag.jpg

  • You might want to hide the menu, comment form, and widget areas for the print styles.
  • The comment date is not using my choice of date format.
  • I have my comment replies set to 5 levels, but the theme is showing Reply links for only 2 levels.
  • The 404 page says "Maybe try one of the links below or a search?", but there are no links below.
  • Customizer
    • Remove the Advanced Options section, as that adds content that disappears on theme switch.
    • Frontpage Sections - Front page is two words.
      • About Section - This is super confusing. There should be no content editing in a theme. It is very unclear whether what is changed here is stored back to the page or in the theme options. Either way, it is not something a theme should be doing. You could have a choice of Pages (or Posts), but not an editor.
      • Menus section - I can't even understand what this is about. Remove the content creation (text fields). Add explanation. Perhaps put the description that is at the bottom, at the top, or don't show any of this if the plugin it needs is not installed.
      • Big Title section - all of this is content creation. Remove it or use existing content.

#2 @rinkuyadav999
4 months ago

  • Owner set to rinkuyadav999
  • Status changed from new to reviewing

#3 @rinkuyadav999
4 months ago

Hi @themeisle

Required Issues:

Required from @joyously comments:

Creating Content: Front Page
CTA (Big title section)
About Content

Invalid Link
Page: /wp-admin/themes.php?page=belise-lite-welcome&tab=getting_started
There is a link 'Check recommended actions' when i click on it, it show me 'Sorry, you are not allowed to access this page.'. Check it. so i can review.

Theme Sniff Error:

belise-lite/inc/custom-header.php
48 ERROR Found usage of constant "HEADER_TEXTCOLOR". Use add_theme_support( 'custom-header' ) instead.

Setting: Display Site Title and Tagline
Tagline always display.

functions.php
Remove theme support 'search-form', 'comment-form', 'comment-list', because your theme is using custom function / file to render them.

Escape database value: functions.php L553, content-event-archive.php l28 get_the_permalink, content-frontpage.php L21 $content, content-main-events.php L15, customizer.php L252 L259. Cross check all files for this issue.

Translation ready: Make sure all strings are translation ready. header.php L34, class-ti-about-page.php ( also prefix TI_About_Page is other than theme prefix )

JavaScript Errors:
ReferenceError: jQuery is not defined /belise-lite/js/masonry-call.js AND belise-lite/js/functions.js

Demo Import files may be not allow. functions.php L392-404
Need second opinion: @greenshady, @jcastaneda, @grapplerulrich, @poena

@joyously please always write required and recommended issues in different sections.

Thanks

#4 @themeisle
4 months ago

Hi @rinkuyadav999 ,

Thank you for the review. We'll fix the issues you mentioned in the next days and let you know.

Regarding removing the Big title section and About section, is there a chance we can get a second opinion on this? We're asking as there were many discussions on this area.

Thank you

#5 @rinkuyadav999
4 months ago

Hi @themeisle

Yes, many discussions on this area but these are creating contents. Customize should be use for settings instead content. Small content allows like changing copyright text in footer etc. Anyway as per your request, Need second opinion: @greenshady, @jcastaneda, @grapplerulrich, @poena

Thanks

#6 follow-up: @themeisle
4 months ago

Hey @rinkuyadav999,

We are aware of the discussions, however unless we have gutenberg in core, I cannot see any other good enough solution for the "big title area", personally I haven't heard any user complaining that they lost few words when they switched to another theme.

Re: the about section I am not sure why you see this as content creation, there is no content created there, the content stays in the frontpage the_content(), we just added the capability for users to edit that content through the customizer, since it makes sense to have all things together and to avoid going to page edit screen for small edits.

Thank you for the review and @joyously!

#7 in reply to: ↑ 6 @joyously
4 months ago

Replying to themeisle:

Re: the about section I am not sure why you see this as content creation, there is no content created there, the content stays in the frontpage the_content(), we just added the capability for users to edit that content through the customizer, since it makes sense to have all things together and to avoid going to page edit screen for small edits.

Reread my note:

About Section - This is super confusing. There should be no content editing in a theme. It is very unclear whether what is changed here is stored back to the page or in the theme options. Either way, it is not something a theme should be doing. You could have a choice of Pages (or Posts), but not an editor.

While editing that page might make sense to the theme author, it does not make sense to me as an experienced user. Theme responsibility is for presentation of existing data. That's it. Not editing or creating more content. There is a lot of capability checking that should happen for editing. The capability for themes in the Customizer is edit_theme_options, but for a Page it would be edit_page and even more specific to that Page. Themes should not be writing to the database except for one theme option array, which should only have presentational information, not content.

#8 @themeisle
4 months ago

Hey @joyously,

I appreciate your input and your extensive testing, just as you said "it doesn't make sense for you", as for me using pages content to build another page or section is the WORST ux solution. However our opinions are highly subjective, I haven't done any tests to neither confirm or not our thoughts.

The beauty of the current system and the upside of a better search is that if our solution doesn't makes sense, people get stuck and choose other theme, in this way we can understand what experience users like or not based on usage and ratings. With a single way of building things, we might be really wrong without even knowing it :).

Ionut

#9 @rinkuyadav999
4 months ago

Hi @themeisle

Demo Import:
Files to import demo contents are not allow in theme so remove then and it's functions.

About Section:
You can not use customize to edit a page. Just display Select field and let user choose one page. and they will edit page on their official edit screen.

CTA (Big title section):
You can remove it OR display select field to choose a page like latest default theme. (if you want second opinion for it, then wait for admins comment)

Thanks

Version 0, edited 4 months ago by rinkuyadav999 (next)

#10 @poena
4 months ago

Hi
I haven't had the time to look at the code, or this specifically: added the capability for users to edit that content through the customizer, but I will notify the other team leads that we need look at it and make a decision, I just don't know when we will find the time.

#11 @ionutn
4 months ago

Hey @rinkuyadav999,

Thank you for your input, as an advice just saying you cannot can be frustrating for authors, linking at least to a doc explaning people why is not a good practice is helpful, if there is no explanation why this can't be done like it is, then the rule doesn't make sense in the first place :).

CTA ( big title )

  • I agree that current implementation with the big text editor might look like a lot of content can be added there, if we trim down the section, limit it to only a line of text, it would be acceptable?

About

  • Why you are saying "you cannot use customize to edit a page"? If you can explain or link to the guidelines, it would be helpful to understand, both widget/menu editing was added and I think there is a feature plugin for post/page editing through customizer as well.

Demo content

  • You say that is not allowed to bundle those files with the theme ones? Should we add a recommended action instead or what is the best practice?

Thanks!

#12 @rinkuyadav999
4 months ago

Hi @ionutn

CTA ( big title ):
This section is creating a CTA and theme can't create it. You can develop a plugin for these features.
Image is fine because it will not lose on theme switch.

About
I do not know why you asked again. Team Lead ( @poena ) already answered.
My opinion is still same: Yes, plugin can edit post in customize but not theme. 'Theme is to displaying contents instead editing posts / creating content'.
You can wait for final opinion of Team Leads.

Demo content
Yes, you can't bundle files to import demo. You can write instructions on your website Or whatever you like better.

Thanks

#13 @ionutn
4 months ago

Hey @rinkuyadav999,

  1. Big title

Maybe I couldn't make myself understood here, I am not looking to develop that in a plugin but to rather re-work it to fit the requirements, if I am wrong about them, you can point me to the right ones, for example I have found this : https://www.dropbox.com/s/un177z3lg5mjtpr/Screenshot%202017-08-18%2012.18.04.png?dl=0 .

  1. About part

@poena haven't said is not allowed and there is no written requirement on that, again I hate to argue and waste your time on that, hope you understand that as an author it feels hard to break the user experience just cause a person doesn't find it friendly enough, while we have tens thousand of users that are happy with it.

#14 @rinkuyadav999
4 months ago

Hi @ionutn

Big title:

Okay you can re-work. I will recommend a text field.

About Part:
You was saying that it updates existing page but it create content and stores in 'theme_mods_belise-lite'. see:

a:18:{i:0;b:0;s:18:"nav_menu_locations";a:5:{s:3:"top";i:176;s:7:"primary";i:176;s:16:"sidebar-menu-top";i:0;s:19:"sidebar-menu-middle";i:0;s:19:"sidebar-menu-bottom";i:0;}s:18:"custom_css_post_id";i:-1;s:23:"belise_front_page_title";s:29:"<p>Big title section Okay</p>";s:29:"belise_front_page_button_text";s:11:"Button Text";s:29:"belise_front_page_button_link";s:17:"http://google.com";s:23:"belise_front_page_image";s:85:"http://localhost/start/wpreview/wp-content/uploads/2013/09/dsc20040724_152504_532.jpg";s:11:"custom_logo";s:0:"";s:16:"header_textcolor";s:6:"dd3333";s:16:"background_color";s:6:"f2ebe0";s:20:"belise_contact_phone";s:10:"1234567890";s:28:"belise_nova_menu_title_links";b:1;s:20:"belise_contact_email";s:13:"some@some.com";s:31:"belise_menus_section_categories";a:1:{i:0;s:6:"random";}s:32:"belise_front_page_schedule_title";s:14:"Schedule Title";s:34:"belise_front_page_schedule_content";s:24:"<p>Schedule content.</p>";s:18:"belise_page_editor";s:760:"<p>Use this static Page to test the Theme's handling of the Front Page template file.</p><p>This is the Front Page content. Use this static Page to test the Front Page output of the Theme. The Theme should properly handle both Blog Posts Index as Front Page and static Page as Front Page.</p><p>If the site is set to display the Blog Posts Index as the Front Page, then this text should not be visible. If the site is set to display a static Page as the Front Page, then this text may or may not be visible. If the Theme does not include a front-page.php template file, then this text should appear on the Front Page when set to display a static Page. If the Theme does include a front-page.php template file, then this text may or may not appear. Updated.</p>";s:24:"belise_feature_thumbnail";s:76:"http://localhost/start/wpreview/wp-content/uploads/2013/06/hoodie_3_back.jpg";}

There is all content added in editor of about section. That's why i told, it is creating content.

Thanks

#15 @rinkuyadav999
4 months ago

As per slack discussion, Only single buy pro / UpSell link is allow without description.

#16 @grapplerulrich
4 months ago

I had a look at the three homepage sections "Big title", "Menus" and "About". Correct me if I am wrong that featured image and content are being saved to the current static frontpage for the "About" section. The content and the content and image from "Big title" and "Menus" are being saved to the settings.

I don't have a problem letting users edit the page content in the customizer. I can't think of any reason why this should have a negative impact on the users. When I changed my front page to one that already had content, my content was used for it. Maybe we could make it a bit clearer where the content comes from.

If the content from "Big title" and "Menus" are being saved to pages too with the editing happening in the customizer I would be OK with that.

I had a quick look through the code and have a few comments.

Required

  • masonry-call handle needs to be prefixed when enqueuing

Suggestion

This will make the code a bit shorter. If you have this function then you should use it everywhere or leave it.

function belise_woocommerce_activated() {
        return class_exists( 'woocommerce' );
}

Better way for

if ( ( 'event' == get_post_type() ) && is_single() ) {}
// is simpler code.
if ( is_singular( 'event' ) ) {}

$term->name = ''; in belise_remove_nova_markup() is redundant

#17 @themeisle
4 months ago

Hi @rinkuyadav999 ,

We need a bit more time, but we'll send an update in the next days.

Thank you

#18 @themetracbot
4 months ago

  • Summary changed from THEME: Belise Lite – 1.0.8 to THEME: Belise Lite – 1.0.9

Belise Lite - 1.0.9

Belise Lite is a clean and minimalist WordPress theme for restaurants and food websites. It provides a responsive design, nice food menus via Jetpack plugin, an Events section, and a beautiful portfolio also integrated with Jetpack. You can use Belise Lite to make your restaurant look stunning in the online zone. Apart from that, the theme is good for ecommerce because it is WooCommerce ready. Live Customizer, WPML compatibility, contact form integration, and quality support are other features that make Belise Lite great for your site.

Theme URL - https://themeisle.com/themes/belise-lite
Author URL - https://themeisle.com

Trac Browser - https://themes.trac.wordpress.org/browser/belise-lite/1.0.9

SVN - https://themes.svn.wordpress.org/belise-lite/1.0.9
ZIP - https://wordpress.org/themes/download/belise-lite.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=belise-lite/1.0.8&new_path=belise-lite/1.0.9

History:

Ticket Summary Status Resolution Owner
#44169 THEME: Belise Lite – 1.0.9 closed live rinkuyadav999

(this ticket)

#49304 THEME: Belise Lite – 1.0.10 closed live themetracbot


https://themes.svn.wordpress.org/belise-lite/1.0.9/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Tags: is either empty or missing in style.css header.

#19 @themeisle
4 months ago

Hi @rinkuyadav999 ,

We uploaded an update with the changes mentioned in the review. Please let us know if everything is ok.

@grapplerulrich thanks for the intervention.

Regards

#20 @rinkuyadav999
4 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi @themeisle

You can remove below code in future update because demo-content directory removed.

<?php
$import_data = BELISE_PHP_INCLUDE . '/demo-content/functions.php';
if ( file_exists( $import_data ) ) {
        require_once( $import_data );
}

Looks good to me.

Thanks

Note: See TracTickets for help on using tickets.