WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 3 months ago

#44223 closed theme (live)

THEME: Plumbers – 1.0.8

Reported by: pixelnx Owned by: acosmin
Priority: new theme Keywords: theme-plumbers
Cc: pixelnx@…

Description

Plumbers - 1.0.0

Plumber WordPress Theme is a unique and perfect WordPress theme , built for Plumbers services, Shops and also unique Plumber concepts to promote their business and build up a site with just few clicks. Theme is created using latest web standards that is HTML5 and CSS3. The user friendly environment of the Theme allows a non technical person to set up this Theme very easily with simple step by step guide. Knowing the importance of social media we have given options of social share and connect through which you can start generate traffic to your site from the first day.

Theme URL - http://pixelnx.com/wp/demo/plumbers-wordpress-theme
Author URL - http://www.pixelnx.com/

Trac Browser - https://themes.trac.wordpress.org/browser/plumbers/1.0.0

SVN - https://themes.svn.wordpress.org/plumbers/1.0.0
ZIP - https://wordpress.org/themes/download/plumbers.1.0.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/plumbers/1.0.0/screenshot.png

Change History (22)

#1 @themetracbot
4 months ago

  • Summary changed from THEME: Plumbers – 1.0.0 to THEME: Plumbers – 1.0.1

Plumbers - 1.0.1

Plumber WordPress Theme is a unique and perfect WordPress theme , built for Plumbers services, Shops and also unique Plumber concepts to promote their business and build up a site with just few clicks. Theme is created using latest web standards that is HTML5 and CSS3. The user friendly environment of the Theme allows a non technical person to set up this Theme very easily with simple step by step guide. Knowing the importance of social media we have given options of social share and connect through which you can start generate traffic to your site from the first day.

Theme URL - http://pixelnx.com/wp/demo/plumbers-wordpress-theme
Author URL - http://www.pixelnx.com/

Trac Browser - https://themes.trac.wordpress.org/browser/plumbers/1.0.1

SVN - https://themes.svn.wordpress.org/plumbers/1.0.1
ZIP - https://wordpress.org/themes/download/plumbers.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=plumbers/1.0.0&new_path=plumbers/1.0.1

History:


https://themes.svn.wordpress.org/plumbers/1.0.1/screenshot.png

#2 @acosmin
4 months ago

  • Owner set to acosmin
  • Status changed from new to reviewing

#3 @acosmin
4 months ago

Congrats, you're the winner of a random review!

http://i.imgur.com/FVL115w.gif

#4 @acosmin
4 months ago

  1. Demo content may be used to show the user how the options work. Use starter content, existing content, or installation instructions instead of placeholder content. Installation instructions should only be visible to users with the edit_theme_options capability, not to visitors.
    • Most of the lines in inc\customizer.php need to be changed to installation instructions
  1. Remove the
    • layouts folder, files not used.
    • languages folder, not used. I guess you want to use the wp.org translations system.
  1. readme.txt
    • No license information provided for the background image used in screenshot.png

#5 @themetracbot
3 months ago

  • Summary changed from THEME: Plumbers – 1.0.1 to THEME: Plumbers – 1.0.2

Plumbers - 1.0.2

Plumber WordPress Theme is a unique and perfect WordPress theme , built for Plumbers services, Shops and also unique Plumber concepts to promote their business and build up a site with just few clicks. Theme is created using latest web standards that is HTML5 and CSS3. The user friendly environment of the Theme allows a non technical person to set up this Theme very easily with simple step by step guide. Knowing the importance of social media we have given options of social share and connect through which you can start generate traffic to your site from the first day.

Theme URL - http://pixelnx.com/wp/demo/plumbers-wordpress-theme
Author URL - http://www.pixelnx.com/

Trac Browser - https://themes.trac.wordpress.org/browser/plumbers/1.0.2

SVN - https://themes.svn.wordpress.org/plumbers/1.0.2
ZIP - https://wordpress.org/themes/download/plumbers.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=plumbers/1.0.1&new_path=plumbers/1.0.2

History:


https://themes.svn.wordpress.org/plumbers/1.0.2/screenshot.png

#6 @pixelnx
3 months ago

Hey @acosmin ,
Thanks for reviewing the theme.

#7 @acosmin
3 months ago

  1. vendor/functions.php
    • L75 - https://wordpress.org needs to be translatable for locals also, take a look at one of the default themes for an example, twenty seventeen.
    • L79 - change date( 'Y' ) to date_i18n( __( 'Y', 'plumbers' ) )

#8 @themetracbot
3 months ago

  • Summary changed from THEME: Plumbers – 1.0.2 to THEME: Plumbers – 1.0.3

Plumbers - 1.0.3

Plumber WordPress Theme is a unique and perfect WordPress theme , built for Plumbers services, Shops and also unique Plumber concepts to promote their business and build up a site with just few clicks. Theme is created using latest web standards that is HTML5 and CSS3. The user friendly environment of the Theme allows a non technical person to set up this Theme very easily with simple step by step guide. Knowing the importance of social media we have given options of social share and connect through which you can start generate traffic to your site from the first day.

Theme URL - http://pixelnx.com/wp/demo/plumbers-wordpress-theme
Author URL - http://www.pixelnx.com/

Trac Browser - https://themes.trac.wordpress.org/browser/plumbers/1.0.3

SVN - https://themes.svn.wordpress.org/plumbers/1.0.3
ZIP - https://wordpress.org/themes/download/plumbers.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=plumbers/1.0.2&new_path=plumbers/1.0.3

History:


https://themes.svn.wordpress.org/plumbers/1.0.3/screenshot.png

#9 @acosmin
3 months ago

  • Status changed from reviewing to approved

#10 @greenshady
3 months ago

  • Status changed from approved to reopened

#11 @greenshady
3 months ago

  • Status changed from reopened to reviewing

#12 @greenshady
3 months ago

The theme code looks pretty good for the most part. There's a couple of issues we need to get squared away before your theme can be set live.

Content vs. Presentation

One of the foundational guidelines of the theme review team is making sure that themes are not storing content as theme options. This is to make sure that theme users have their content appear on their site regardless of what theme they're using.

The following customizer settings need to be rethought and handled in a way that allows the user to keep their content:

  • Slider Setting
  • Features Setting
  • Services Setting
  • Team Setting
  • Testimonial Setting

There are various avenues to correct this. For example, there existing testimonial plugins out there (Jetpack even has testimonials built in). Another option is to allow the user to select a page or a category of posts that exist on their site.

Handling the code for settings

In the following code (and pretty much most of your customize settings, you have several issues:

$wp_customize->add_setting(
        'topbar_facebook',
        array(
            'default' => 'Your facebook link',
            'sanitize_callback' => 'esc_url_raw',
        )
    );

1) Your facebook link should be translatable (also, facebook should be spelled Facebook).

2) Your facebook link is not a valid default for this setting. Only a URL is valid as a default or an empty string. An empty string would be the best option here.

3) The text "Your Facebook link" would be better as a description output via the control.

4) You can set a placeholder via the control with something like https://facebook.com.

#13 @acosmin
3 months ago

My thinking on the Content vs. Presentation issue was that those are not repeating fields (like widgets would work).

Also, most of those items would need only one line of text, with a few words. Creating pages for so little text isn't really a good idea in my opinion (it just adds more steps and it doesn't really solve the issue).

I guess 5 sections with with 4 textareas each is too much :) differences of opinion... will keep in mind

#14 @themetracbot
3 months ago

  • Summary changed from THEME: Plumbers – 1.0.3 to THEME: Plumbers – 1.0.4

Plumbers - 1.0.4

Plumber WordPress Theme is a unique and perfect WordPress theme , built for Plumbers services, Shops and also unique Plumber concepts to promote their business and build up a site with just few clicks. Theme is created using latest web standards that is HTML5 and CSS3. The user friendly environment of the Theme allows a non technical person to set up this Theme very easily with simple step by step guide. Knowing the importance of social media we have given options of social share and connect through which you can start generate traffic to your site from the first day.

Theme URL - http://pixelnx.com/wp/demo/plumbers-wordpress-theme
Author URL - http://www.pixelnx.com/

Trac Browser - https://themes.trac.wordpress.org/browser/plumbers/1.0.4

SVN - https://themes.svn.wordpress.org/plumbers/1.0.4
ZIP - https://wordpress.org/themes/download/plumbers.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=plumbers/1.0.3&new_path=plumbers/1.0.4

History:


https://themes.svn.wordpress.org/plumbers/1.0.4/screenshot.png

#15 @themetracbot
3 months ago

  • Summary changed from THEME: Plumbers – 1.0.4 to THEME: Plumbers – 1.0.5

Plumbers - 1.0.5

Plumber WordPress Theme is a unique and perfect WordPress theme , built for Plumbers services, Shops and also unique Plumber concepts to promote their business and build up a site with just few clicks. Theme is created using latest web standards that is HTML5 and CSS3. The user friendly environment of the Theme allows a non technical person to set up this Theme very easily with simple step by step guide. Knowing the importance of social media we have given options of social share and connect through which you can start generate traffic to your site from the first day.

Theme URL - http://pixelnx.com/wp/demo/plumbers-wordpress-theme
Author URL - http://www.pixelnx.com/

Trac Browser - https://themes.trac.wordpress.org/browser/plumbers/1.0.5

SVN - https://themes.svn.wordpress.org/plumbers/1.0.5
ZIP - https://wordpress.org/themes/download/plumbers.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=plumbers/1.0.4&new_path=plumbers/1.0.5

History:


https://themes.svn.wordpress.org/plumbers/1.0.5/screenshot.png

#16 @themetracbot
3 months ago

  • Summary changed from THEME: Plumbers – 1.0.5 to THEME: Plumbers – 1.0.6

Plumbers - 1.0.6

Plumber WordPress Theme is a unique and perfect WordPress theme , built for Plumbers services, Shops and also unique Plumber concepts to promote their business and build up a site with just few clicks. Theme is created using latest web standards that is HTML5 and CSS3. The user friendly environment of the Theme allows a non technical person to set up this Theme very easily with simple step by step guide. Knowing the importance of social media we have given options of social share and connect through which you can start generate traffic to your site from the first day.

Theme URL - http://pixelnx.com/wp/demo/plumbers-wordpress-theme
Author URL - http://www.pixelnx.com/

Trac Browser - https://themes.trac.wordpress.org/browser/plumbers/1.0.6

SVN - https://themes.svn.wordpress.org/plumbers/1.0.6
ZIP - https://wordpress.org/themes/download/plumbers.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=plumbers/1.0.5&new_path=plumbers/1.0.6

History:


https://themes.svn.wordpress.org/plumbers/1.0.6/screenshot.png

#17 @greenshady
3 months ago

Handling code for the settings

You didn't address most of what I mentioned earlier, so I'll try to explain this a bit better. Let's look at your current Facebook link option:

$wp_customize->add_setting( 
    'topbar_facebook',
    array(
        'default' => 'https://facebook.com',
        'sanitize_callback' => 'esc_url_raw',
    )
);
$wp_customize->add_control(
    'topbar_facebook',
    array(
        'label'         => __( 'Facebook Link', 'plumbers' ),
        'section'       => 'top_bar_setting',
        'type'          => 'text',    
    )
);

Here's how to code it:

$wp_customize->add_setting(
    'topbar_facebook',
    array(
        'default' => '',
        'sanitize_callback' => 'esc_url_raw',
    )
);
$wp_customize->add_control(
    'topbar_facebook',
    array(
        'label'         => __( 'Facebook Link', 'plumbers' ),
        'section'       => 'top_bar_setting',
        'type'          => 'text',
	'input_attrs'   => array( 'placeholder' => 'https://facebook.com' )
    )
);

There's still the other issues with most of the other controls and settings:

  • Any setting default text strings must be internationalized.
  • Any setting default must be valid data for the specific setting or an empty string (note that it shouldn't be demo data).
  • Use the placeholder attribute if you're just wanting to show what something should be.

Content vs. Presentation

This was not addressed at all.

#18 @themetracbot
3 months ago

  • Summary changed from THEME: Plumbers – 1.0.6 to THEME: Plumbers – 1.0.7

Plumbers - 1.0.7

Plumber WordPress Theme is a unique and perfect WordPress theme , built for Plumbers services, Shops and also unique Plumber concepts to promote their business and build up a site with just few clicks. Theme is created using latest web standards that is HTML5 and CSS3. The user friendly environment of the Theme allows a non technical person to set up this Theme very easily with simple step by step guide. Knowing the importance of social media we have given options of social share and connect through which you can start generate traffic to your site from the first day.

Theme URL - http://pixelnx.com/wp/demo/plumbers-wordpress-theme
Author URL - http://www.pixelnx.com/

Trac Browser - https://themes.trac.wordpress.org/browser/plumbers/1.0.7

SVN - https://themes.svn.wordpress.org/plumbers/1.0.7
ZIP - https://wordpress.org/themes/download/plumbers.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=plumbers/1.0.6&new_path=plumbers/1.0.7

History:


https://themes.svn.wordpress.org/plumbers/1.0.7/screenshot.png

#19 @greenshady
3 months ago

The Content vs. Presentation issue has still not been addressed. If you don't understand the issue, please ask me questions. I'm here to provide answers if need be.

#20 @pixelnx
3 months ago

Hello @greenshady ,

I have understood the concept of Content vs. Presentation as that you don't want us to save the content of user in the theme options, so when theme is uninstalled or removed, the content remains intact. But, here I am not getting how to do that?
Can you please help me in this, and I am not much sure whether I am right here or not.
If you can share any example about this, that would be great.

Thanks

#21 @themetracbot
3 months ago

  • Summary changed from THEME: Plumbers – 1.0.7 to THEME: Plumbers – 1.0.8

Plumbers - 1.0.8

Plumber WordPress Theme is a unique and perfect WordPress theme , built for Plumbers services, Shops and also unique Plumber concepts to promote their business and build up a site with just few clicks. Theme is created using latest web standards that is HTML5 and CSS3. The user friendly environment of the Theme allows a non technical person to set up this Theme very easily with simple step by step guide. Knowing the importance of social media we have given options of social share and connect through which you can start generate traffic to your site from the first day.

Theme URL - http://pixelnx.com/wp/demo/plumbers-wordpress-theme
Author URL - http://www.pixelnx.com/

Trac Browser - https://themes.trac.wordpress.org/browser/plumbers/1.0.8

SVN - https://themes.svn.wordpress.org/plumbers/1.0.8
ZIP - https://wordpress.org/themes/download/plumbers.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=plumbers/1.0.7&new_path=plumbers/1.0.8

History:


https://themes.svn.wordpress.org/plumbers/1.0.8/screenshot.png

#22 @greenshady
3 months ago

  • Resolution set to live
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.