WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 7 days ago

Last modified 7 days ago

#44239 closed theme (live)

THEME: Buzzo – 1.0.9

Reported by: awethemes Owned by: codexdemon
Priority: previously reviewed Keywords: theme-buzzo
Cc: support@…

Description

Buzzo - 1.0.4

Buzzo is a simple, responsive, gorgeous theme that will put your content without distraction. The theme does offer visual appeal by including large enticing featured images and bold headlines, which make it easy for your readers to browse lots of material.

Theme URL - http://awethemes.com/docs/buzzo
Author URL - http://awethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/buzzo/1.0.4

SVN - https://themes.svn.wordpress.org/buzzo/1.0.4
ZIP - https://wordpress.org/themes/download/buzzo.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=buzzo/1.0.3&new_path=buzzo/1.0.4

History:

Ticket Summary Status Resolution Owner
#40841 THEME: Buzzo – 1.0.3 closed not-approved Rohittm
#44239 THEME: Buzzo – 1.0.9 closed live codexdemon

(this ticket)

#49170 THEME: Buzzo – 1.0.10 closed live themetracbot


https://themes.svn.wordpress.org/buzzo/1.0.4/screenshot.png

Change History (29)

This ticket was mentioned in Slack in #themereview by anhskohbo. View the logs.


4 months ago

#2 @themetracbot
4 months ago

  • Owner set to codexdemon
  • Status changed from new to reviewing

#3 @codexdemon
4 months ago

Hello

I will review your theme, please let me know if you have to upload new version of this theme before I start to review

#4 @awethemes
4 months ago

Hi @codexdemon Yes, this is the lastest version. Thank you :)

#5 @codexdemon
4 months ago

Hello @awethemes

  • Recommended Subject tags should be specified in your style.css
  • REQUIRED: Please implement proper sanitization for values when saved to the database. https://codex.wordpress.org/Data_Validation#Input_Validation Eg, sanitize_text_field() should be used to sanitize text field, esc_url_raw for URL field, for sanitizing field with HTML tags, use wp_kses_post() for sanitization, use absint() to sanitize positive integer. Page inc/cat-meta.php
  • REQUIRED: All untrusted data should be escaped properly before displaying. https://codex.wordpress.org/Data_Validation Eg, esc_url() should be used to escape URL, value in HTML attributes should be escaped with esc_attr(). inc/template-tags.php L278
  • REQUIRED: Please update all strings in your language file folder or used WordPress default language provision.
  • REQUIRED: contributor can't be automatic
  • REQUIRED: In readme file, please mention both (CSS and Fonts) license information.
  • REQUIRED: In readme file, please mention Images license information.

#6 @themetracbot
4 months ago

  • Keywords changed from theme-buzzo, accessibility-ready to theme-buzzo accessibility-ready
  • Summary changed from THEME: Buzzo – 1.0.4 to THEME: Buzzo – 1.0.5

Buzzo - 1.0.5

Buzzo is a simple, responsive, gorgeous theme that will put your content without distraction. The theme does offer visual appeal by including large enticing featured images and bold headlines, which make it easy for your readers to browse lots of material.

Theme URL - http://awethemes.com/docs/buzzo
Author URL - http://awethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/buzzo/1.0.5

SVN - https://themes.svn.wordpress.org/buzzo/1.0.5
ZIP - https://wordpress.org/themes/download/buzzo.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=buzzo/1.0.4&new_path=buzzo/1.0.5

History:

Ticket Summary Status Resolution Owner
#40841 THEME: Buzzo – 1.0.3 closed not-approved Rohittm
#44239 THEME: Buzzo – 1.0.9 closed live codexdemon

(this ticket)

#49170 THEME: Buzzo – 1.0.10 closed live themetracbot


https://themes.svn.wordpress.org/buzzo/1.0.5/screenshot.png

#7 @awethemes
4 months ago

Hi @codexdemon,
Thank you for reviewing. I updated the theme. About "untrusted data should be escaped", I can't find the issues. I asked on slack channel (with below code) and they said it's fine.

printf(
	'<a href="%s" %s>%s</a>',
	esc_url( get_category_link( $cat->term_id ) ),
	buzzo_get_cat_color( $cat->term_id ) ? 'style="background-color:' . esc_attr( buzzo_get_cat_color( $cat->term_id ) ) . '"' : '',
	esc_html( $cat->name )
);

#8 @codexdemon
4 months ago

  • Status changed from reviewing to approved

@awethemes

I am approving theme for next level to key reviewer have a review on it. Thank you

#9 @awethemes
4 months ago

@codexdemon thank you :)

#10 @djrmom
3 months ago

  • Cc joedolson added
  • Status changed from approved to reopened

This needs an accessibility ready review before approval. cc @joedolson

#11 @djrmom
3 months ago

  • Status changed from reopened to reviewing

#12 @poena
2 months ago

accessibility-ready

https://make.wordpress.org/themes/handbook/review/accessibility/required/

Keyboard Navigation -did not pass
When I tab from the top of the theme, It was very confusing when the focus went from the site title directly to the search icon on the far right hand side.
When I tabbed away from the search icon, the focus was lost, to return to the first menu item on the left side.

Controls -did not pass
The menu toggle for the responsive menu does not have a screen reader text.

Skip Links -sort of pass
Something is affecting the text size of the Skip to Content skip link, it is really really small and I can hardly read it.

Forms -did not pass
Missing labels for search forms (The comment form is better).

Headings -pass
ARIA Landmark Roles -pass
Link Text -pass

Contrasts -did not pass
The post content text color #b1b1b1 only has a contrast Ratio of 2.14:1 against the white background.
The link color #bb833e only has a contrast Ratio of 3.27:1 against the white background.
The link color #bfbfbf only has a contrast Ratio of 1.84:1 against the white background.
The expected contrast ratio is 4.5:1

Images -did not pass
If the icon is representing text (e.g., there is no visible text), the icon must include fallback text for screen readers that indicates what the icon means.
The icons for the search forms does not have a screen reader text.

Media -none found
Screen Reader Text -pass
-Except the text size of the Skip to content is very small.

Not Allowed -none found

#13 @themetracbot
2 months ago

  • Summary changed from THEME: Buzzo – 1.0.5 to THEME: Buzzo – 1.0.6

Buzzo - 1.0.6

Buzzo is a simple, responsive, gorgeous theme that will put your content without distraction. The theme does offer visual appeal by including large enticing featured images and bold headlines, which make it easy for your readers to browse lots of material.

Theme URL - http://awethemes.com/docs/buzzo
Author URL - http://awethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/buzzo/1.0.6

SVN - https://themes.svn.wordpress.org/buzzo/1.0.6
ZIP - https://wordpress.org/themes/download/buzzo.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=buzzo/1.0.5&new_path=buzzo/1.0.6

History:

Ticket Summary Status Resolution Owner
#40841 THEME: Buzzo – 1.0.3 closed not-approved Rohittm
#44239 THEME: Buzzo – 1.0.9 closed live codexdemon

(this ticket)

#49170 THEME: Buzzo – 1.0.10 closed live themetracbot


https://themes.svn.wordpress.org/buzzo/1.0.6/screenshot.png

#14 @awethemes
2 months ago

thank you @poena
I just update the theme :)

#15 @codexdemon
7 weeks ago

  • Status changed from reviewing to approved

#16 @rabmalin
7 weeks ago

  • Status changed from approved to reopened

#17 @rabmalin
7 weeks ago

  • Status changed from reopened to reviewing

@codexdemon Do not approve the theme now. Accessibility review is going on.

#18 @codexdemon
7 weeks ago

@rabmalin Ahh sorry i miss that.

#19 @joedolson
3 weeks ago

I just did a quick re-check of the accessibility-ready issues @poena highlighted previously, and they do not appear to have been fixed. Please review those issues and address them or remove the 'accessibility-ready' tag from your theme. Thanks!

#20 @themetracbot
3 weeks ago

  • Keywords accessibility-ready removed
  • Summary changed from THEME: Buzzo – 1.0.6 to THEME: Buzzo – 1.0.7

Buzzo - 1.0.7

Buzzo is a simple, responsive, gorgeous theme that will put your content without distraction. The theme does offer visual appeal by including large enticing featured images and bold headlines, which make it easy for your readers to browse lots of material.

Theme URL - http://awethemes.com/docs/buzzo
Author URL - http://awethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/buzzo/1.0.7

SVN - https://themes.svn.wordpress.org/buzzo/1.0.7
ZIP - https://wordpress.org/themes/download/buzzo.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=buzzo/1.0.6&new_path=buzzo/1.0.7

History:

Ticket Summary Status Resolution Owner
#40841 THEME: Buzzo – 1.0.3 closed not-approved Rohittm
#44239 THEME: Buzzo – 1.0.9 closed live codexdemon

(this ticket)

#49170 THEME: Buzzo – 1.0.10 closed live themetracbot


https://themes.svn.wordpress.org/buzzo/1.0.7/screenshot.png

#21 @awethemes
3 weeks ago

Hi @joedolson, I'm sure we're fixed all issues about accessibility-ready above.
But now we're remove "accessibility-ready" as you recommend.

#22 @Mirucon
12 days ago

@codexdemon Can you please continue the review here, because the author has removed the accessibility-ready tag. If you don't see any issue, just mark this as approved.

#23 @codexdemon
11 days ago

  • Status changed from reviewing to approved

Hello @Mirucon

I didn't notice any issue, so I am approving this now.

#24 @rabmalin
10 days ago

  • Cc rabmalin added; joedolson removed
  • Status changed from approved to reopened

#25 @rabmalin
10 days ago

  • Status changed from reopened to reviewing

Hello,

Please fix following issues and re-upload your theme.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Issues

  • REQUIRED: Widget title should be passed through widget_title filter with parameters instance and id base. Ref: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/widgets/class-wp-widget-text.php
  • REQUIRED: Change date('Y') to date_i18n(__('Y','textdomain'))
  • REQUIRED: Remove search-form from add_theme_support( 'html5' ) as you are customizing it yourself.
  • REQUIRED: In readme file, please declare your theme copyright in following format.
    Fred WordPress Theme, Copyright 2012 Joe Smith
    Fred is distributed under the terms of the GNU GPL
    
  • REQUIRED: readme.txt - Keep full URL of image and its licensce. Note that, images from Unsplash are now not allowed due to some conflict in terms.
  • REQUIRED: Removing core settings is not allowed.
    $wp_customize->remove_control( 'display_header_text' );
    
  • REQUIRED: extras.php - Inside HTML attributes like placeholder, use esc_attr__() instead of __(). Please check in other places also/
  • REQUIRED: Remove <style> from template files. Please use proper enqueue approach.
  • REQUIRED: template-tags.php L218 - Escaping missing.
  • REQUIRED: Make sure excerpt_length and excerpt_more filter does not affect admin side. See Twenty Seventeen theme for reference.

#26 @themetracbot
7 days ago

  • Summary changed from THEME: Buzzo – 1.0.7 to THEME: Buzzo – 1.0.8

Buzzo - 1.0.8

Buzzo is a simple, responsive, gorgeous theme that will put your content without distraction. The theme does offer visual appeal by including large enticing featured images and bold headlines, which make it easy for your readers to browse lots of material.

Theme URL - http://awethemes.com/docs/buzzo
Author URL - http://awethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/buzzo/1.0.8

SVN - https://themes.svn.wordpress.org/buzzo/1.0.8
ZIP - https://wordpress.org/themes/download/buzzo.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=buzzo/1.0.7&new_path=buzzo/1.0.8

History:

Ticket Summary Status Resolution Owner
#40841 THEME: Buzzo – 1.0.3 closed not-approved Rohittm
#44239 THEME: Buzzo – 1.0.9 closed live codexdemon

(this ticket)

#49170 THEME: Buzzo – 1.0.10 closed live themetracbot


https://themes.svn.wordpress.org/buzzo/1.0.8/screenshot.png

#27 @themetracbot
7 days ago

  • Summary changed from THEME: Buzzo – 1.0.8 to THEME: Buzzo – 1.0.9

Buzzo - 1.0.9

Buzzo is a simple, responsive, gorgeous theme that will put your content without distraction. The theme does offer visual appeal by including large enticing featured images and bold headlines, which make it easy for your readers to browse lots of material.

Theme URL - http://awethemes.com/docs/buzzo
Author URL - http://awethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/buzzo/1.0.9

SVN - https://themes.svn.wordpress.org/buzzo/1.0.9
ZIP - https://wordpress.org/themes/download/buzzo.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=buzzo/1.0.8&new_path=buzzo/1.0.9

History:

Ticket Summary Status Resolution Owner
#40841 THEME: Buzzo – 1.0.3 closed not-approved Rohittm
#44239 THEME: Buzzo – 1.0.9 closed live codexdemon

(this ticket)

#49170 THEME: Buzzo – 1.0.10 closed live themetracbot


https://themes.svn.wordpress.org/buzzo/1.0.9/screenshot.png

#28 @rabmalin
7 days ago

  • Cc rabmalin removed
  • Resolution set to live
  • Status changed from reviewing to closed

Approving and setting live. It will take around 1 hour for theme to appear in the directory.

#29 @awethemes
7 days ago

Hi @rabmalin, many thanks! So now I can manager and update theme via SVN?

Note: See TracTickets for help on using tickets.