WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 2 months ago

Last modified 2 months ago

#44404 closed theme (not-approved)

THEME: Multipurposeo – 1.1

Reported by: aazztech Owned by: rabmalin
Priority: previously reviewed Keywords: theme-multipurposeo
Cc: contact@…

Description

Multipurposeo - 1.1

Multipurposeo is a modern and powerful multipurpose theme that combines both the beautiful material design and a ton of amazing features. With this theme, anyone can create a very attractive busniess website or a professional blog in no time. You can create professional website, blog, landing page, agency website, business websites with this theme very easily.

Theme URL - https://aazztech.com/product/multipurposeo-wordpress-multipurpose-theme
Author URL - https://aazztech.com

Trac Browser - https://themes.trac.wordpress.org/browser/multipurposeo/1.1

SVN - https://themes.svn.wordpress.org/multipurposeo/1.1
ZIP - https://wordpress.org/themes/download/multipurposeo.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=multipurposeo/1.0&new_path=multipurposeo/1.1

History:

Ticket Summary Status Resolution Owner
#42305 THEME: Multipurposeo – 1.0 closed not-approved poena
#44404 THEME: Multipurposeo – 1.1 closed not-approved rabmalin

(this ticket)


https://themes.svn.wordpress.org/multipurposeo/1.1/screenshot.png

Change History (4)

#1 @joyously
2 months ago

Here is some user feedback to consider before your review.

  • Custom widgets should be for presentation of existing data, since they will disappear on theme switch. So the Portfolio Item and Section Title widgets should be removed from the theme. The Portfolio Category Name widget should be changed to show a list of categories for the user to choose from.
  • The menu needs to have a real fallback for when no menu is selected. The default value of fallback_cb parameter of wp_nav_menu() works really well, and it's core functionality.
  • On a narrow window, the menu icon is only visible when at the top. Otherwise it is covered by the admin bar.
  • Javascript TypeError: $(...).offset(...) is undefined wp-content/themes/multipurposeo/js/main.js?ver=4.7.5 line 416
  • I am seeing placeholder content on the front end of my site. This should never happen. (phone number, address, blog title, copyright)
  • Social media icons should be disabled by default, since the URLs are not known. And the default value should be empty, not #.
  • With no widgets in the "Sidebar" widget area, there is still space reserved for it. What good is that?
  • The site title is using site_url() instead of home_url(), so it gets the wrong address.
  • There is no link to the comment anchor (for easy copy/paste). This is typically put on the comment date.
  • Static Pages should not show the author or the date.
  • The loader animation makes the page load seem slower.
  • The post date is not using my choice of date format (on both archive page and single post page). And on blog page it shows the date, but on category page it shows the time.
  • The post author is not a link to the author archive.
  • I happened to notice that one of the posts went missing as I changed the window width. Here is 762px and then at 737px. https://s18.postimg.org/xdhixxhrt/blog-page-762px.jpg https://s18.postimg.org/yh1n9w2ex/blog-page-737px.jpg
  • A long post title is truncated instead of wrapped, on a category page.
  • The category description looks like it is for the first post, since it is right above it. It seems like it should be just below the category title.
  • Floats are not being cleared properly after the content area.
  • Large images overflow the container. Use img {max-width:100%; height:auto} to fix.
  • .wp-caption img {width: auto} This CSS rule should be removed, because CSS overrides HTML attributes. Since the default for width is auto, there is no need to specify it. And when it is there, the user does not get what he chose.
  • The image captions are black on black, so invisible.
  • <h6> is quite small. How is that a heading?
  • The blockquote has large margins, which separates the quote a lot from text that explains it or a cite tag that says where it comes from.
  • Definition list looks like regular text.
  • Nested unordered list does not look nested.
  • Lists have no bullets or numbers.
  • Lists have a large line-height, which is too much! Can't make a short list!
  • Links look just like regular text. How would a visitor know what was linked?
  • Post navigation links would be nice.
  • You might want to use display:inline-block instead of float, so you don't get these layout quirks. https://s29.postimg.org/5jncolsdz/post-layout.jpg
  • .gallery-item img {width: 100%} This CSS rule should be removed, as the theme cannot know what the image width should be. It causes the browser to upscale thumbnails, which looks awful, and the user doesn't get the size he chose.
  • Page links (generated by <!--nextpage-->) are not being output on Posts.
  • I didn't notice it on other pages, but when I have a search with no results, the title displays and then nothing else until I scroll. That is so misleading. And, because it is a short page, there is a point where the javascript is switching to sticky header that makes the page jump and I can't scroll farther down. Why is there such a large gap between the title and the content, forcing me to scroll to search again?
  • Search results should not show the author and date of static Pages.
  • Customizer
    • Copyright should not have a hard-coded date.
    • Remove the Contact With Us section, as that adds content that disappears on theme switch.
    • Portfolio Section - Add description of when and where this is shown. Also, remove the text field which should only be used for inputs. You can have a link to the Widgets area. You might want to group this together with other sections that go together.
    • Remove the Working Process section, as that adds content that disappears on theme switch.
    • Remove the Team Members section, as that adds content that disappears on theme switch. Or change it to use existing content.
    • Remove the Features section, as that adds content that disappears on theme switch. Or change it to use existing content.
    • Remove the Counter up section, as that adds content that disappears on theme switch.
    • Remove the Why Choose Us section, as that adds content that disappears on theme switch. Or change it to use existing content.
    • Remove the Choose Us Top section, as that adds content that disappears on theme switch.
    • Remove the Services section, as that adds content that disappears on theme switch. Or change it to use existing content.
    • Remove the About Us section, as that adds content that disappears on theme switch. Or change it to use existing content.
    • Remove the Slider section, as that adds content that disappears on theme switch. Or change it to use existing content.
    • Remove the Header Top section, as that adds content that disappears on theme switch. Or perhaps make a widget area there.
    • Enable or Disable Any Section - Remove the question marks. Add description for when and where these sections are shown. I see they are all on by default, but I don't see any in the preview.

#2 @rabmalin
2 months ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#3 @rabmalin
2 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello,

Your theme has been reviewed against this Theme Review Guideline.

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues. This is part of our long term goals to improve the theme quality and shorten the queues. You can read more about this change here: https://make.wordpress.org/themes.

Please do not get discouraged by the ticket being closed. We want you to resubmit your theme, but we do ask that you spend more time making sure that your theme meets all the requirements. You can upload your updated theme here: https://wordpress.org/themes/upload/

Because of the large number of themes waiting for review, we might not be able to follow up immediately. We will review your update when your theme reaches the top of the review queue.

Issues

  • REQUIRED: All untrusted data should be escaped properly before displaying. https://codex.wordpress.org/Data_Validation Eg, esc_url() should be used to escape URL, value in HTML attributes should be escaped with esc_attr(). Generally in other places esc_html() is used. Please check thoroughly.
  • REQUIRED: Please implement proper sanitization for values when saved to database. https://codex.wordpress.org/Data_Validation#Input_Validation Eg, sanitize_text_field() should be used to sanitize text field, esc_url_raw for URL field, for sanitizing field with HTML tags, use wp_kses_post() for sanitization, use absint() to sanitize positive integer.
  • REQUIRED: Removing core settings is not allowed.
    $wpc->remove_section('colors');
    $wpc->remove_section('header_image');
    
  • REQUIRED: Escape home_url() with esc_url().
  • REQUIRED: Escape get_permalink() with esc_url().
  • REQUIRED: Required to use core-bundled scripts rather than including their own version of that script. For example jQuery. Remove jquery-1.12.3.js
  • REQUIRED: WordPress Features First - Use WordPress functionality and features first, if available. https://make.wordpress.org/themes/handbook/review/required/#core-functionality-and-features Eg, use the_posts_pagination() for numeric pagination in archive templates.
  • RECOMMENDED: Third party script and style handle should not be prefixed. See https://make.wordpress.org/themes/handbook/review/recommended/#stylesheets-and-scripts
  • REQUIRED: Plugins recommendation admin notice should be dismissable.
  • REQUIRED: Make sure excerpt_length and excerpt_more filter does not affect admin side. See Twenty Seventeen theme for reference.
  • REQUIRED: Remove search-form from add_theme_support( 'html5' ) as you are customizing it yourself.
  • REQUIRED: Please use get_template_directory() to load non template PHP files.
  • REQUIRED: Demo contents like social icons, phone, etc should be disabled by default. Those should be displayed only after user enter data.
  • REQUIRED: Widget title should be passed through widget_title filter with parameters instance and id base. Ref: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/widgets/class-wp-widget-text.php
  • REQUIRED: There is signigicant amount of content creation in theme options. Please remove those. Only non-trivial content creation is allowed in theme.

Important

Before re-submitting themes, please check Theme Review Guidelines very thoroughly. Also, test your theme with following plugins.

Theme Check Sniffs

Note: Errors need to be fixed and Warnings are things that need to be checked manually.

FILE: /var/www/review.dev/public_html/wp-content/themes/multipurposeo/comments.php
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
 131 | ERROR | Overriding WordPress globals is prohibited
----------------------------------------------------------------------------------

Time: 25055219 mins, 11.78 secs; Memory: 4Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/multipurposeo/functions.php
-----------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 12 LINES
-----------------------------------------------------------------------------------
 25 | ERROR | Short array syntax (open) is available since 5.4
 27 | ERROR | Short array syntax (close) is available since 5.4
 34 | ERROR | Short array syntax (open) is available since 5.4
 38 | ERROR | Short array syntax (close) is available since 5.4
 50 | ERROR | Short array syntax (open) is available since 5.4
 52 | ERROR | Short array syntax (close) is available since 5.4
 58 | ERROR | Short array syntax (open) is available since 5.4
 64 | ERROR | Short array syntax (close) is available since 5.4
 70 | ERROR | Short array syntax (open) is available since 5.4
 75 | ERROR | Short array syntax (close) is available since 5.4
 87 | ERROR | Short array syntax (open) is available since 5.4
 91 | ERROR | Short array syntax (close) is available since 5.4
-----------------------------------------------------------------------------------

Time: 25055219 mins, 11.92 secs; Memory: 4Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/multipurposeo/inc/class-tgm-plugin-activation.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 526 | ERROR | Silencing errors is forbidden
---------------------------------------------------------------------------------------------------------

#4 @jrf
2 months ago

Heads up for when you resubmit the theme: You are currently using the ThemeForest version of TGMPA. If you download a fresh copy of TGMPA using the Custom TGMPA Generator and choose "wordpress.org" as distribution channel, it will serve you with a customized download of TGMPA which will pass the Theme Check rules (text-domain and such).

Note: See TracTickets for help on using tickets.