WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 5 weeks ago

Last modified 5 weeks ago

#44462 closed theme (live)

THEME: blogster-utility – 1.0.8

Reported by: mp518 Owned by: Mirucon
Priority: new theme Keywords: theme-blogster-utility
Cc: prajapati.mahesh34@…

Description

blogster-utility - 1.0.1

blogster-utility will make your WordPress look beautiful everywhere.

Theme URL - http://www.wordpress.org
Author URL - https://profiles.wordpress.org/mp518

Trac Browser - https://themes.trac.wordpress.org/browser/blogster-utility/1.0.1

SVN - https://themes.svn.wordpress.org/blogster-utility/1.0.1
ZIP - https://wordpress.org/themes/download/blogster-utility.1.0.1.zip?nostats=1

History:


https://themes.svn.wordpress.org/blogster-utility/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (30)

This ticket was mentioned in Slack in #themereview by mahesh.prajapati. View the logs.


3 months ago

#2 @joyously
8 weeks ago

Here is some user feedback to consider before your review.

  • The menu dropdowns need a background color so that the submenu links are not white on white and so they can be read over the content.
  • The mobile menu is exactly like the desktop menu, which means it is not very usable on mobile. It still is activated by hover (touch screens have no hover), and due to the smaller window, it wraps around which is also bad for hover.
  • Comments are showing the ordered list number, which is confusing for paged and nested comments. Try using CSS to hide the number or CSS counters to make it more logical.
  • The content font size is a little small, but <h5> and <h6> are even smaller! How is that a heading? <h6> is only 10px, way too tiny!
  • An ordered list with a two digit number shows only half the number. The first digit is off the screen to the left.
  • <q> tag is unstyled. (default removed)
  • You might want to hide the menu, comment form, and widget areas for the print styles.
  • I'd like to still see my sidebar on the 404 page.
  • Customizer, Header Image - I chose a header image and it did not show in the preview.

#3 @themetracbot
8 weeks ago

  • Owner set to Mirucon
  • Status changed from new to reviewing

#4 @Mirucon
8 weeks ago

Hi @mp518!

Nice well-written theme, I just found a few issues.

Requied:

  • I set a header image, but nowhere it's shown. Make sure the user's image is shown there.
  • Please remove the 'rtl.css' file. It is unused and an almost empty file.

Design issues (recommended):

  • I think it'd be nice to have some padding for left and right sides on mobile view.
  • On mobile view, the font sizes for site title and tagline are exactly the same. Site title should be bigger.

Please fix these issues, and you might also want to fix what @joyously reported, then upload a new version here: https://wordpress.org/themes/upload/

Cheers,
Mirucon

#5 @mp518
8 weeks ago

@Mirucon and @joyously,

Thanks for review theme i will update new version soon.

#6 @themetracbot
8 weeks ago

  • Summary changed from THEME: blogster-utility – 1.0.1 to THEME: blogster-utility – 1.0.2

blogster-utility - 1.0.2

blogster-utility will make your WordPress look beautiful everywhere.

Theme URL - http://www.wordpress.org
Author URL - https://profiles.wordpress.org/mp518

Trac Browser - https://themes.trac.wordpress.org/browser/blogster-utility/1.0.2

SVN - https://themes.svn.wordpress.org/blogster-utility/1.0.2
ZIP - https://wordpress.org/themes/download/blogster-utility.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blogster-utility/1.0.1&new_path=blogster-utility/1.0.2

History:


https://themes.svn.wordpress.org/blogster-utility/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#7 @mp518
8 weeks ago

Hello @Mirucon,
I have fix issues as you asked so please review it.

Thanks in advance.
Regards,
Mahesh

Last edited 8 weeks ago by mp518 (previous) (diff)

#8 @Mirucon
7 weeks ago

Hi @mp518 ,

I found following issues on the latest version:

  • Please declare the copyright/license attribution of your theme on your readme file, like:

Fred WordPress Theme, Copyright 2012 Joe Smith
Fred is distributed under the terms of the GNU GPL

  • You need to show the user's copyright on the footer area like:

&copyright; 2017 Test site

  • Themes can't use the WordPress URL as a theme URL. Please link to your website related to this theme, or you can remove the theme URL. Theme URL is optional.
  • [Recommended] The content of README.md file should be about your theme, not _s. You can remove the file if you want.

Everything else looks fine now, it may get approved on next version.

Cheers,
Mirucon

#9 @themetracbot
7 weeks ago

  • Summary changed from THEME: blogster-utility – 1.0.2 to THEME: blogster-utility – 1.0.3

blogster-utility - 1.0.3

blogster-utility will make your WordPress look beautiful everywhere.

Theme URL - http://www.wordpress.org
Author URL - https://profiles.wordpress.org/mp518

Trac Browser - https://themes.trac.wordpress.org/browser/blogster-utility/1.0.3

SVN - https://themes.svn.wordpress.org/blogster-utility/1.0.3
ZIP - https://wordpress.org/themes/download/blogster-utility.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blogster-utility/1.0.2&new_path=blogster-utility/1.0.3

History:


https://themes.svn.wordpress.org/blogster-utility/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are woostudio, blogster-utility

#10 @themetracbot
7 weeks ago

  • Summary changed from THEME: blogster-utility – 1.0.3 to THEME: blogster-utility – 1.0.4

blogster-utility - 1.0.4

blogster-utility will make your WordPress look beautiful everywhere.

Theme URL - http://www.wordpress.org
Author URL - https://profiles.wordpress.org/mp518

Trac Browser - https://themes.trac.wordpress.org/browser/blogster-utility/1.0.4

SVN - https://themes.svn.wordpress.org/blogster-utility/1.0.4
ZIP - https://wordpress.org/themes/download/blogster-utility.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blogster-utility/1.0.3&new_path=blogster-utility/1.0.4

History:


https://themes.svn.wordpress.org/blogster-utility/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#11 @mp518
7 weeks ago

Hey @Mirucon,

Thank you so much. Here by i have uploaded latest version 1.0.4 you can check it i have all thing resolve in this version. I hope everything will be fine.

Thanks again.

Regards,
Mahesh

#12 @Mirucon
7 weeks ago

Hi @mp518,

  • The name shown on the footer area should be the site name, not the author's. So it should be got by bloginfo( 'name' ); And it seems the theme copyright has been deleted, but you can still have it if you want. Theme needs to have user's copyright, and/or theme's copyright. Read this to make your understanding... https://make.wordpress.org/themes/handbook/review/required/#licensing
  • balanceTags() is not a right function to sanitize textarea. Use sanitize_textarea_field() instead. balanceTags() is used when text is echoed, not as a sanitize function.
  • You haven't changed the theme URL yet.. you may be missed it out, please read the prev review again :)

Cheers,
Mirucon

#13 @Mirucon
7 weeks ago

And you need to fix the error reported by the Codesniffer:

FILE: ...grant/wordpress/wp-content/themes/blogster-utility/functions.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 188 | ERROR | like_escape() has been deprecated since WordPress
     |       | version 4.0. Use wpdb::esc_like() instead.
----------------------------------------------------------------------

#14 @themetracbot
7 weeks ago

  • Summary changed from THEME: blogster-utility – 1.0.4 to THEME: blogster-utility – 1.0.5

blogster-utility - 1.0.5

blogster-utility will make your WordPress look beautiful everywhere.

Theme URL -
Author URL - https://profiles.wordpress.org/mp518

Trac Browser - https://themes.trac.wordpress.org/browser/blogster-utility/1.0.5

SVN - https://themes.svn.wordpress.org/blogster-utility/1.0.5
ZIP - https://wordpress.org/themes/download/blogster-utility.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blogster-utility/1.0.4&new_path=blogster-utility/1.0.5

History:


https://themes.svn.wordpress.org/blogster-utility/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#15 @mp518
7 weeks ago

@Mirucon as you suggested change has been done in this latest version.

Last edited 7 weeks ago by mp518 (previous) (diff)

#16 @Mirucon
7 weeks ago

Hi @mp518,

The bloginfo() function is already echoed, please do not echo it twice. So your copyright section should be like this:

echo esc_html( ' &copy; 2017 ' . get_bloginfo( 'name' ) );

As soon as this error is fixed, I will mark it as approved :)

Cheers,
Mirucon

Last edited 7 weeks ago by Mirucon (previous) (diff)

#17 @themetracbot
7 weeks ago

  • Summary changed from THEME: blogster-utility – 1.0.5 to THEME: blogster-utility – 1.0.6

blogster-utility - 1.0.6

blogster-utility will make your WordPress look beautiful everywhere.

Theme URL -
Author URL - https://profiles.wordpress.org/mp518

Trac Browser - https://themes.trac.wordpress.org/browser/blogster-utility/1.0.6

SVN - https://themes.svn.wordpress.org/blogster-utility/1.0.6
ZIP - https://wordpress.org/themes/download/blogster-utility.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blogster-utility/1.0.5&new_path=blogster-utility/1.0.6

History:


https://themes.svn.wordpress.org/blogster-utility/1.0.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#18 @mp518
7 weeks ago

@Mirucon issue has been Resolved in latest version.

Cheers,
Mahesh

#19 @Mirucon
7 weeks ago

  • Status changed from reviewing to approved

Hi @mp518,

Now I've checked these things again, everything is fine! Marking this as approved.

  • Customizer - Everything works
  • Escaping everything - OK
  • License and credit - OK
  • NS Theme Check - No error found
  • Prefixing function names - OK
  • Sanitize customizer content - OK

This ticket has been moved to the new queue to wait for a final review by one of the key reviewers. You can check the queue here: https://themes.trac.wordpress.org/report/24

It normally takes 7 - 14 days to get a review (Probably it takes longer than that now). After the review, your theme is going to be set as 'live', then will be available on the WordPress.org theme directory.

Best wishes,
Mirucon

#20 @rabmalin
5 weeks ago

  • Cc rabmalin added
  • Status changed from approved to reopened

#21 @rabmalin
5 weeks ago

  • Status changed from reopened to reviewing

Hello,

Please fix following issues and re-upload your theme.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Issues

  • REQUIRED: Screenshot dimensions are wrong! Ratio of width to height should be 4:3. Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
  • REQUIRED: Remove dev files like phpcs.xml.dist
  • REQUIRED: Remove unused files and folders like layouts folder, etc. Please check thoroughly.
  • REQUIRED: readme.txt - Keep credit and URL of image used in the screenshot.
  • REQUIRED: customizer.php L44 - Translation issue.

#22 @themetracbot
5 weeks ago

  • Summary changed from THEME: blogster-utility – 1.0.6 to THEME: blogster-utility – 1.0.7

blogster-utility - 1.0.7

blogster-utility will make your WordPress look beautiful everywhere.

Theme URL -
Author URL - https://profiles.wordpress.org/mp518

Trac Browser - https://themes.trac.wordpress.org/browser/blogster-utility/1.0.7

SVN - https://themes.svn.wordpress.org/blogster-utility/1.0.7
ZIP - https://wordpress.org/themes/download/blogster-utility.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blogster-utility/1.0.6&new_path=blogster-utility/1.0.7

History:


https://themes.svn.wordpress.org/blogster-utility/1.0.7/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#23 @mp518
5 weeks ago

Hello @rabmalin,

Thanks for review theme. As per your suggestion i have made changes in latest version.

Regards,
Mahesh

#24 @rabmalin
5 weeks ago

Please check all issues mentioned above and reupload your theme again after fixing.

#25 @mp518
5 weeks ago

@rabmalin i have fixed all issue in 1.0.7 and if you are talking about translate issue then i have made compatible string now (same thing is available on default theme because in this theme have compatible not .po file uploaded). if anything wrong then please correct me.

#26 @rabmalin
5 weeks ago

Screenshot size issue. Image url and license missing in readme.

#27 @themetracbot
5 weeks ago

  • Summary changed from THEME: blogster-utility – 1.0.7 to THEME: blogster-utility – 1.0.8

blogster-utility - 1.0.8

blogster-utility will make your WordPress look beautiful everywhere.

Theme URL -
Author URL - https://profiles.wordpress.org/mp518

Trac Browser - https://themes.trac.wordpress.org/browser/blogster-utility/1.0.8

SVN - https://themes.svn.wordpress.org/blogster-utility/1.0.8
ZIP - https://wordpress.org/themes/download/blogster-utility.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blogster-utility/1.0.7&new_path=blogster-utility/1.0.8

History:


https://themes.svn.wordpress.org/blogster-utility/1.0.8/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#28 @mp518
5 weeks ago

Hello @rabmalin,

I have solve issue as you suggested. Please review it.

big thanks in advance.

#29 @rabmalin
5 weeks ago

  • Cc rabmalin removed
  • Resolution set to live
  • Status changed from reviewing to closed

Setting live.

#30 @mp518
5 weeks ago

Thank You so much

Note: See TracTickets for help on using tickets.