WordPress.org

Make WordPress Themes

Opened 3 months ago

Closed 3 months ago

Last modified 2 months ago

#44529 closed theme (not-approved)

THEME: Magazie Minimal – 0.1

Reported by: codexdemon Owned by: greenshady
Priority: new theme Keywords: theme-magazie-minimal
Cc: sanyog@…

Description

Magazie Minimal - 0.1

Magazie is a simple and easy to use, modern and creative, user friendly and elegant, WordPress theme for blog, news and magazine sites. It is responsive, cross browser compatible, SEO friendly theme with lots of highly created features. Theme comes with sidebar options. It is very light weighted theme based on customizer. Added custom widgets for Popular Post, Recent Post and Recommend. Try Magazie today and blog away. Our dedicated support team will guide you in every steps while using theme.

Theme URL - http://wpthematic.com/magazie/
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/magazie-minimal/0.1

SVN - https://themes.svn.wordpress.org/magazie-minimal/0.1
ZIP - https://wordpress.org/themes/download/magazie-minimal.0.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#44529 THEME: Magazie Minimal – 0.1 closed not-approved greenshady

(this ticket)

#44668 THEME: Magazie Minimal – 0.5 reviewing hiddenpearls


https://themes.svn.wordpress.org/magazie-minimal/0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (7)

This ticket was mentioned in Slack in #themereview by sanyog. View the logs.


3 months ago

#2 @greenshady
3 months ago

  • Owner set to greenshady
  • Status changed from new to reviewing

#3 @greenshady
3 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Unfortunately, your theme is not quite ready for inclusion in the WordPress theme directory. Because of the number of issues found in a partial review, I'm closing this ticket. Please take some time to make sure you familiarize yourself with the theme review guidelines. And, please do resubmit once you've fixed the following issues and feel comfortable that your theme is ready for a second review.

Thanks for submitting your theme. I hope we can include it in the future.

You can find the guidelines here: http://make.wordpress.org/themes/handbook/review/required

Google fonts SSL

When using Google fonts, make sure to use https so that you don't mess up sites with SSL certificates:

wp_enqueue_style( 'magazie-googleapis', 'http://fonts.googleapis.com/css?family=Roboto+Slab:300,400,700|Roboto:300,400,500,700,900|Prata|PT+Serif:400,700', array(), null );

Script handle prefixing

The scripts handle should be prefixed with your theme slug in functions.php:

wp_enqueue_script( 'scripts', get_template_directory_uri() . '/assets/js/scripts.js', array('jquery'), '4.5.0' );

Additionally, this scripts.js file is empty, so you shouldn't be loading it at all.

Prefixing: Function names

Your theme should use the same, unique prefix. There are functions with the following prefixes in functions.php:

magazie
wpsites
wpb
crunchify

Plugin territory: Post view count

Tracking post view counts is plugin territory and must be removed from the theme.

Plugin territory: Disabling comment URL

Disabling the comment URL is plugin territory. Themes should support the core fields.

Plugin territory: Shortcodes in text widgets

This bit of code should be left to plugins. Otherwise, text widgets are broken when a user switches themes.

add_filter('widget_text','do_shortcode');

Licensing

You're missing the license and copyright/author info for the screenshot image in readme.txt. A link is not sufficient.

You're also missing both the licensing and copyright info for the following items:

  • Shadow BT Roman font
  • Shadow BT Bold font

These must be licensed under a GPL-compatible license.

Language

The magazine.pot file should be renamed to magazie-minimal.pot to match your theme slug.

Furthermore, the text strings in the POT file should match those of your theme. This is from a different theme.

Textdomain

The textdomain used throughout your theme must be exactly magazie-minimal and not magazie.

Default/Demo options

Default theme options for social profile URLs should be empty.

Internationalization

The default footer copyright text should be internationalized.

Loading admin scripts

This code from inc/custom-widget/recommend-widget.php is loading scripts on every admin screen. Use the $hook_suffix parameter to only load when needed.

See: https://codex.wordpress.org/Plugin_API/Action_Reference/admin_enqueue_scripts

add_action( 'admin_enqueue_scripts', 'magazie_recommend_widgets_backend_enqueue' ); 
function magazie_recommend_widgets_backend_enqueue(){     
    wp_register_script( 'magazie-custom-widgets', get_template_directory_uri().'/assets/js/widgets.js', array( 'jquery' ), true );
    wp_enqueue_media();
    wp_enqueue_script( 'magazie-custom-widgets' );
}

#4 follow-up: @codexdemon
3 months ago

@greenshady
All is this you specified error ?
Magzie is the only text domian name where Magzie Minimal is Name of Theme

#5 in reply to: ↑ 4 @greenshady
3 months ago

Replying to codexdemon:

@greenshady
All is this you specified error ?

I don't understand the question.

Magzie is the only text domian name where Magzie Minimal is Name of Theme

magazie-minimal is the correct textdomain. We require the textdomain to match the theme name (all lowercase, hyphenated) so that it can use the language packs system on WordPress.org.

#6 @codexdemon
2 months ago

@greenshady I am submitting again this files. Please make this ticket open, so I can do submission again.

#7 @greenshady
2 months ago

You will get a new ticket when you submit your theme again.

Note: See TracTickets for help on using tickets.