WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 4 weeks ago

#44609 closed theme (live)

THEME: SShop – 1.0.8

Reported by: shrimp2t Owned by: kevinhaig
Priority: previously reviewed Keywords: theme-sshop
Cc: shrimp2t@…

Description

SShop - 1.0.5

SShop is the best free WooCommerce theme. It features a bespoke integration with WooCommerce itself plus many widgets like Sales countdown, Product tabs, Blog posts, Services, Sliders. SShop is responsive mobile optimized and using bootstrap framework and FontAwesome icons. There are several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it’s lean and extensible codebase making it a joy to customise and extend. Looking for a WooCommerce theme? Look no further!

Theme URL - http://demos.sshopwp.com/
Author URL - http://sshopwp.com/

Trac Browser - https://themes.trac.wordpress.org/browser/sshop/1.0.5

SVN - https://themes.svn.wordpress.org/sshop/1.0.5
ZIP - https://wordpress.org/themes/download/sshop.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sshop/1.0.4&new_path=sshop/1.0.5

History:

Ticket Summary Status Resolution Owner
#42865 THEME: SShop – 1.0.4 closed not-approved nileshg
#44609 THEME: SShop – 1.0.8 closed live kevinhaig

(this ticket)

#47069 THEME: SShop – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/sshop/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (33)

#1 @greenshady
3 months ago

  • Owner set to nileshg
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #themereview by shrimp2t. View the logs.


3 months ago

#3 @shrimp2t
3 months ago

Hi @nileshg, @greenshady

Any update for this ticket ?

This ticket was mentioned in Slack in #themereview by shrimp2t. View the logs.


3 months ago

#5 @Otto42
3 months ago

  • Owner nileshg deleted

@nileshg if you cannot perform reviews on a timely manner, please do not accept them.

#6 @shrimp2t
3 months ago

Hi @Otto42

Could you please place my ticket at the top of the queue because this is an update of ticket https://themes.trac.wordpress.org/ticket/42865 and i have been waiting so long to get review.

#7 @Otto42
3 months ago

@shrimp2t Sorry, queue doesn't work that way. You should ask in #themereview to see if a reviewer will take it over for you.

This ticket was mentioned in Slack in #themereview by shrimp2t. View the logs.


3 months ago

#9 @shrimp2t
3 months ago

Hi @greenshady, @rabmalin

This ticket is under reviewing but still no review issues, It has been 12 days.

This ticket was mentioned in Slack in #themereview by djrmom. View the logs.


3 months ago

#11 @lamarajan
3 months ago

Hello,

I can check on it. you can assign me @djrmom.

Regards,
Rajan

#12 @djrmom
3 months ago

  • Owner set to lamarajan

Thanks

#13 @lamarajan
3 months ago

hi @shrimp2t,

I have issues during theme installation.
Please fix this issue before move on to further review process.

Fatal error: Class 'SShop_Widget_Slider' not found in C:\xampp\htdocs\themereview\wp-includes\class-wp-widget-factory.php on line 106

Regards,
Rajan

#14 @shrimp2t
3 months ago

Thanks for reviewing my item, i will fix it right now

#15 @themetracbot
3 months ago

  • Summary changed from THEME: SShop – 1.0.5 to THEME: SShop – 1.0.6

SShop - 1.0.6

SShop is the best free WooCommerce theme. It features a bespoke integration with WooCommerce itself plus many widgets like Sales countdown, Product tabs, Blog posts, Services, Sliders. SShop is responsive mobile optimized and using bootstrap framework and FontAwesome icons. There are several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it’s lean and extensible codebase making it a joy to customise and extend. Looking for a WooCommerce theme? Look no further!

Theme URL - http://demos.sshopwp.com/
Author URL - http://sshopwp.com/

Trac Browser - https://themes.trac.wordpress.org/browser/sshop/1.0.6

SVN - https://themes.svn.wordpress.org/sshop/1.0.6
ZIP - https://wordpress.org/themes/download/sshop.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sshop/1.0.5&new_path=sshop/1.0.6

History:

Ticket Summary Status Resolution Owner
#42865 THEME: SShop – 1.0.4 closed not-approved nileshg
#44609 THEME: SShop – 1.0.8 closed live kevinhaig

(this ticket)

#47069 THEME: SShop – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/sshop/1.0.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#16 @shrimp2t
3 months ago

H @amarajan, any issues for this one ?

#17 @lamarajan
3 months ago

Hello, I am reviewing your theme I will send you updates.

#18 @lamarajan
3 months ago

Hello,

I have reviewed your theme, you need to fix these issues before approve this theme.

1) stable tag must be same as version of theme, in readme file.

2) mention author and version, year of released for third party plugins are recommended.

3) add change log for previous versions in changelog.txt is recommended

4) add short description for home page setting in readme file is recommeded

5) use is_active_sidebar() for checking dynamic sidebar in conditional tags
on line No. 23 tpl-home.php

6) do not use translation for html tags is required example in tpl-home.php line No. 29 .

7) needs translation for default value in get_theme_mod in sidebar-woocommerce.php, sidebar.php, etc.

8) no need of escaping for static text but translation is required so you can use (,) instead of esc_html(,) on sshop_widgets_init()

9)prefix for handler in google font is required because you use specific google font.

10) you can't use wp_dequeue_style(), and wp_dequeue_script()

11) prefix in handler is needed for custom css for woocommerce

12) you can't use wp_localize_script( 'countdown_format' => esc_html( '%D Days %H:%M:%S', 'sshop' ), ) directly.

13) you need escaping the variables inside woocommerce file and widgets also.

14) delete unnecessary files
15) delete unnecessary commented codes

such as public $_instance;

please check on translations and escaping because it is genuine part of theme.

Best regards,
Rajan

#19 @shrimp2t
2 months ago

Hi, @lamarajan

I am in the hospital with my daughter, I will back to fix it when she ok.

Please do not close my topic, i will fix it asap.

Thanks your so much.

#20 @lamarajan
2 months ago

Hello, @shrimp2t

Ok I will not close your ticket, but please inform me when theme is ready. Then, I will review it.

Get Well soon for your daughter.

Regards,
Rajan Lama

#21 @themetracbot
2 months ago

  • Summary changed from THEME: SShop – 1.0.6 to THEME: SShop – 1.0.7

SShop - 1.0.7

SShop is the best free WooCommerce theme. It features a bespoke integration with WooCommerce itself plus many widgets like Sales countdown, Product tabs, Blog posts, Services, Sliders. SShop is responsive mobile optimized and using bootstrap framework and FontAwesome icons. There are several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it’s lean and extensible codebase making it a joy to customise and extend. Looking for a WooCommerce theme? Look no further!

Theme URL - http://demos.sshopwp.com/
Author URL - http://sshopwp.com/

Trac Browser - https://themes.trac.wordpress.org/browser/sshop/1.0.7

SVN - https://themes.svn.wordpress.org/sshop/1.0.7
ZIP - https://wordpress.org/themes/download/sshop.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sshop/1.0.6&new_path=sshop/1.0.7

History:

Ticket Summary Status Resolution Owner
#42865 THEME: SShop – 1.0.4 closed not-approved nileshg
#44609 THEME: SShop – 1.0.8 closed live kevinhaig

(this ticket)

#47069 THEME: SShop – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/sshop/1.0.7/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#22 @shrimp2t
2 months ago

Hi @lamarajan

Thanks for not close my ticket.
I've update to version 1.0.7

Here is what i did:

1) Fixed

2) I don't understand what you want. If you're talking about recommend plugin i think this issue it not needed.

3) Added.

4)I think the readme file for theme is not available at this time, i just add it here to make it have a overview on github.com

5) Fixed.

6) Removed.

7) I've checked this issue, but all values from get_theme_mod are not echoing strings, Just are condition values, i think they are not required.

8) Use esc_html__() is better than __() :).

9) Fixed.

10)Maybe we can use, i'm not found any document about this one here https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts

11)I need to overwrite css of WooCommerce so we can't add prefix for woocommerce style file, http://prntscr.com/gaoal6

12) Why we can't use wp_localize_script like this, it's correct

wp_localize_script( 'sshop-woocommerce', 'SShop_WC_Config', array(
            'countdown_format' => esc_html__( '%D Days %H:%M:%S', 'sshop' ),
        ) );

13) All strings inside already escaping in site the function that calling this file or from function that return value.

14), 15, fixed

Also I checked with plugin NS Theme Check (that's required by theme reviewer admin), see the result:

http://prntscr.com/gao7fh

#23 @lamarajan
2 months ago

Hello, I am reviewing your theme. I will send you updates.

Regards,
Rajan

#24 @lamarajan
8 weeks ago

  • Status changed from reviewing to approved

Hi @shrimp2t,

1) For licensing,
Below is an example of a resource declaration specifying resource name, resource download link, copyright declaration, license type, license link:

jquery.sidr.js, https://github.com/artberri/sidr
Copyright (c) 2013 Alberto Varela, MIT License, https://github.com/artberri/sidr/blob/master/LICENSE


Reference: https://themes.trac.wordpress.org/ticket/30859 this is the ticket number.

2) By third party plugins, I means external js and css.

3) I know you need woocmmerce.css file for styling the wocommerce, but I think you can still prefix the handle of that file. Eg: "sshop-wocommerce" This prefix handle is required because prefix handle is genuine part of theme development.

4) For my point of view, you need to escape the value just before string is called. Its for your own safety.

5) For this one

wp_localize_script( 'sshop-woocommerce', 'SShop_WC_Config', array(
            'countdown_format' => esc_html__( '%D Days %H:%M:%S', 'sshop' ),
        ) );

let theme admin, decide it.

Congratulations, I am approving your theme but you need to fix these issues and upload the updated theme.

Cheers,
Rajan

#25 @imranaliweb
5 weeks ago

Hi @shrimp2t,

First of all, @lamarajan, who has given you pointing issues update them, then you will admin review your theme again.

Thanks
Imran Ali

#26 @kevinhaig
5 weeks ago

I will do this final review.

#27 @kevinhaig
5 weeks ago

  • Status changed from approved to reopened

Theme Review - SShop Version 1.0.7

  • Hi I am @kevinhaig and I have completed the second (final) review of your theme.
  • Sorry but the ticket has been reopened because there are requirements not met.
  • The review process follows procedures found in the theme handbook.
  • ref: https://make.wordpress.org/themes/handbook/review/
  • If you do not understand or agree with something in the review, please comment in the ticket.
  • I can then help you, or if I am not sure of something I will certainly seek a second opinion from another key reviewer.

Responding to the Review

  • Please respond with update or request an extension within 7 days, or theme may be closed.

Required Items

Code

All untrusted data should be escaped before output.
  • Check and fix escaping problem. , file: sshop\inc\extras.php, line: 37
  • get_permalink must be escaped, use esc_url() , file: sshop\inc\widgets\widget-blog.php, line: 56
  • get_permalink must be escaped, use esc_url() , file: sshop\template-parts\loop.php, line: 16
  • get_permalink must be escaped, use esc_url() , file: sshop\woocommerce\add-to-wishlist.php, line: 42

Core Functionality and Features

Use WordPress functionality and features first, if available.
  • add_theme_support() for custom-logo used but not found in tags list in style.css , file: sshop\functions.php, line: 73
  • Widget title filter must include three elements. Use apply_filters( 'widget_title', $title, $instance, $this->id_base ) , file: sshop\inc\widgets\widget-blog.php, line: 35
  • Widget title filter must include three elements. Use apply_filters( 'widget_title', $title, $instance, $this->id_base ) , file: sshop\inc\widgets\widget-product-categories.php, line: 69
  • Widget title filter must include three elements. Use apply_filters( 'widget_title', $title, $instance, $this->id_base ) , file: sshop\inc\widgets\widget-product-tabs.php, line: 120
  • Widget title filter must include three elements. Use apply_filters( 'widget_title', $title, $instance, $this->id_base ) , file: sshop\inc\widgets\widget-products.php, line: 101
  • Widget title filter must include three elements. Use apply_filters( 'widget_title', $title, $instance, $this->id_base ) , file: sshop\inc\widgets\widget-sales-countdown-products.php, line: 73

Licensing

Declare licenses of any resources included such as fonts or images, including screenshot images
  • you have not declared Font Awesome (2 licenses), Bootstrap, TGM Plugin Activation, WooCommerce Code
  • For images please provide download links and license type for images(including any images used in your screenshot) so licensing can be confirmed.
    • Please declare all images in the screenshot
    • Below is an example of how an image should be declared.
      Image description/use : CC0 by author, http://www.imageprovider.com/imagelink
      
No Theme Copyright in Footer
  • Do not put your copyright in the footer. It implies that all websites that use your theme are copyright by you and I don't think you want that. Typically theme authors grab the site title for this. Even if it is a default, if the user does not change the default you do not want to suggest that the website is copyright by you!

Recommended Items

It is not required to complete recommended items, but considered good practice

  • Missing wp_unslash() before sanitization. , file: sshop\inc\config\meta-box.php, line: 86
  • Detected usage of a non-sanitized input variable: $_POST , file: sshop\inc\config\meta-box.php, line: 86
  • Missing wp_unslash() before sanitization. , file: sshop\inc\config\meta-box.php, line: 115
  • Missing wp_unslash() before sanitization. , file: sshop\inc\config\meta-box.php, line: 118
  • Missing wp_unslash() before sanitization. , file: sshop\inc\dashboard.php, line: 39
  • Detected usage of a non-sanitized input variable: $_GET , file: sshop\inc\dashboard.php, line: 39
  • include() found. Please check if get_template_part() should be used instead. , file: sshop\inc\dashboard.php, line: 93
  • Missing wp_unslash() before sanitization. , file: sshop\inc\widgets\widget-base.php, line: 579
  • Detected usage of a non-sanitized input variable: $_REQUEST , file: sshop\inc\widgets\widget-base.php, line: 579
  • Missing wp_unslash() before sanitization. , file: sshop\inc\widgets\widget-base.php, line: 580
  • Detected usage of a non-sanitized input variable: $_REQUEST , file: sshop\inc\widgets\widget-base.php, line: 580
  • Missing wp_unslash() before sanitization. , file: sshop\inc\widgets\widget-base.php, line: 581
  • Detected usage of a non-sanitized input variable: $_REQUEST , file: sshop\inc\widgets\widget-base.php, line: 581
  • Missing wp_unslash() before sanitization. , file: sshop\inc\widgets\widget-base.php, line: 583
  • Detected usage of a non-sanitized input variable: $_REQUEST , file: sshop\inc\widgets\widget-base.php, line: 583
  • paginate_links() is discouraged. Use the_posts_pagination() instead. , file: sshop\woocommerce\loop\pagination.php, line: 32

#28 @daisy-themes
5 weeks ago

Last edited 5 weeks ago by daisy-themes (previous) (diff)

#29 @shrimp2t
4 weeks ago

Hi @kevinhaig ,

Thanks for reviewing my item.

I'll update assap.

#30 @themetracbot
4 weeks ago

  • Summary changed from THEME: SShop – 1.0.7 to THEME: SShop – 1.0.8

SShop - 1.0.8

SShop is the best free WooCommerce theme. It features a bespoke integration with WooCommerce itself plus many widgets like Sales countdown, Product tabs, Blog posts, Services, Sliders. SShop is responsive mobile optimized and using bootstrap framework and FontAwesome icons. There are several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it’s lean and extensible codebase making it a joy to customise and extend. Looking for a WooCommerce theme? Look no further!

Theme URL - http://demos.sshopwp.com/
Author URL - http://sshopwp.com/

Trac Browser - https://themes.trac.wordpress.org/browser/sshop/1.0.8

SVN - https://themes.svn.wordpress.org/sshop/1.0.8
ZIP - https://wordpress.org/themes/download/sshop.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sshop/1.0.7&new_path=sshop/1.0.8

History:

Ticket Summary Status Resolution Owner
#42865 THEME: SShop – 1.0.4 closed not-approved nileshg
#44609 THEME: SShop – 1.0.8 closed live kevinhaig

(this ticket)

#47069 THEME: SShop – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/sshop/1.0.8/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#31 @shrimp2t
4 weeks ago

Hi @kevinhaig

I've update to version 1.0.8.

I fixed all issues, except issue: paginate_links() is discouraged. Use the_posts_pagination() instead. , file: sshop\woocommerce\loop\pagination.php, line: 32 because this code is used in template file of WooCommerce and this is recommend issue.

Please check it again.

#32 @kevinhaig
4 weeks ago

  • Owner changed from lamarajan to kevinhaig
  • Status changed from reopened to reviewing

#33 @kevinhaig
4 weeks ago

  • Resolution set to live
  • Status changed from reviewing to closed

approving and setting live.

Note: See TracTickets for help on using tickets.