WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 3 months ago

#44651 closed theme (live)

THEME: GildRest – 1.0.3

Reported by: shoyamane Owned by: poena
Priority: new theme Keywords: theme-gildrest
Cc: yamane.info@…

Description

GildRest - 1.0

It is WordPress theme for restaurant.

Theme URL -
Author URL - https://profiles.wordpress.org/shoyamane

Trac Browser - https://themes.trac.wordpress.org/browser/gildrest/1.0

SVN - https://themes.svn.wordpress.org/gildrest/1.0
ZIP - https://wordpress.org/themes/download/gildrest.1.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/gildrest/1.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

Attachments (2)

gildrest-adminbar.png (44.3 KB) - added by poena 4 months ago.
gildrest-menu.png (58.7 KB) - added by poena 4 months ago.

Download all attachments as: .zip

Change History (12)

#1 @poena
4 months ago

  • Owner set to poena
  • Status changed from new to reviewing

#2 @poena
4 months ago

Hi!
Thank you for submitting your theme.
Your theme has been reviewed against these requirements:
https://make.wordpress.org/themes/handbook/review/required/

Lovely theme- the current screenshot does not make it justice.

There are a couple of things that needs to be fixed before the theme can go live.

Required

I was not able to find a copyright statement for the theme itself.
For explanation, please see https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

The screenshot should not be a logo or mockup.

Themes that use the sticky-post tag in style.css need to style sticky posts differently from other posts so that they are visually distinctive.

You need to add license and copyright information for any assets like images that you use in the theme and in the screenshot, the theme needs to be 100% GPL compatible.

The language files does not seem to be complete? Please update them.
Please remove any code or files that are not used (there are several blank files).
App.js is duplicated, please remove one.

When I am logged in, the WordPress admin bar covers the site title and the top part of the menu on smaller screen widths.
This needs to be fixed since the menu and the links are not clickable.
At 600 px width, the admin bar moves downwards and is displayed below the site title -this needs to be fixed, themes should not make any changes to the admin bar.

In cleanup.php:
No removing or modifying non-presentational hooks.
This is not allowed in themes: gildrest_cleanup

In archive-title.php:
Line 4, 16 single_cat_title is echoed by default, so it doesn't need to be echoed again here.

In searchform.php:
escape the action with esc_url, not esc_attr.

In header.php:
esc_attr() is used inside html attributes, not between html tags. To escape content between html tags, use esc_html().
instead of <h2 class="description"><?php echo esc_attr( get_bloginfo('description', 'display')); ?></h2>
you can just use <h2 class="description"><?php bloginfo('description'); ?></h2>

Errors from the Theme sniffer Plugin:

(https://github.com/WPTRT/theme-sniffer
https://make.wordpress.org/themes/2016/09/29/why-are-we-working-to-improve-the-automation-of-the-theme-review/)

gildrest/lib/comment-list.php
4 ERROR Overriding WordPress globals is prohibited

Include a parseable readme file, so that the theme can be presented correctly when changes are made to the theme directory:
https://make.wordpress.org/themes/2017/07/06/upcoming-directory-changes/

In header.php, the pingback should be conditional. See this example from Twenty Seventeen:

/**
 * Add a pingback url auto-discovery header for singularly identifiable articles.
 */
function twentyseventeen_pingback_header() {
	if ( is_singular() && pings_open() ) {
		printf( '<link rel="pingback" href="%s">' . "\n", get_bloginfo( 'pingback_url' ) );
	}
}
add_action( 'wp_head', 'twentyseventeen_pingback_header' );

You might want to add a recommended height for the site header image.

Last edited 4 months ago by poena (previous) (diff)

@poena
4 months ago

#3 @themetracbot
4 months ago

  • Summary changed from THEME: GildRest – 1.0 to THEME: GildRest – 1.0.1

GildRest - 1.0.1

It is a WordPress theme for restaurant.

Theme URL -
Author URL - https://profiles.wordpress.org/shoyamane

Trac Browser - https://themes.trac.wordpress.org/browser/gildrest/1.0.1

SVN - https://themes.svn.wordpress.org/gildrest/1.0.1
ZIP - https://wordpress.org/themes/download/gildrest.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=gildrest/1.0&new_path=gildrest/1.0.1

History:


https://themes.svn.wordpress.org/gildrest/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#4 @shoyamane
4 months ago

Hi @poena.

I fixed the theme under the blue sky of summer.
Please review again.

#5 @themetracbot
4 months ago

  • Summary changed from THEME: GildRest – 1.0.1 to THEME: GildRest – 1.0.2

GildRest - 1.0.2

It is a WordPress theme for restaurant.

Theme URL -
Author URL - https://profiles.wordpress.org/shoyamane

Trac Browser - https://themes.trac.wordpress.org/browser/gildrest/1.0.2

SVN - https://themes.svn.wordpress.org/gildrest/1.0.2
ZIP - https://wordpress.org/themes/download/gildrest.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=gildrest/1.0.1&new_path=gildrest/1.0.2

History:


https://themes.svn.wordpress.org/gildrest/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#6 @poena
3 months ago

Hi, sorry about the wait, hopefully I will find the time tomorrow.

#7 @poena
3 months ago

Hi!
Most of the problems I meantioned where fixed, and the menu seems to be working well.

These problems remain, sorry for not catching all of them in the first round:

In scripts.php, the font handle 'poppins' needs to be prefixed (since the font can be added with different font weights and styles)

In widgets.php, this text is missing translation functions: 'description' => 'Bottom Widget area',

In init.php, line 7, you are referencing a folder that does not exist.

Page/content.php is missing wp_link_pages(), so if a page break is added, the user can't see all of the content. Compare with single/content.php

I was not able to find a copyright statement for the theme itself.
Copyright is not the same as license. The GPL requires all copies to carry an appropriate copyright notice.
See: https://www.gnu.org/licenses/gpl-faq.html#IWantCredit
and https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

Example:
Fred WordPress Theme, Copyright 2012 Joe Smith
Fred is distributed under the terms of the GNU GPL

Please remove any code or files that are not used (there are several blank files).

In single/page content.php, you can simply use
the_post_thumbnail( 'large' );
instead of
echo get_the_post_thumbnail($post->ID, 'large');

The footer credit links needs to be the theme or author URI, and it can't be a coming soon page.
See: https://make.wordpress.org/themes/handbook/review/required/#selling-credits-and-links

Consider using the_comments_navigation() in comments.php,
it will handle the page count for you, and you can still specify the text.

#8 @themetracbot
3 months ago

  • Summary changed from THEME: GildRest – 1.0.2 to THEME: GildRest – 1.0.3

GildRest - 1.0.3

It is a WordPress theme for restaurant.

Theme URL -
Author URL - https://profiles.wordpress.org/shoyamane

Trac Browser - https://themes.trac.wordpress.org/browser/gildrest/1.0.3

SVN - https://themes.svn.wordpress.org/gildrest/1.0.3
ZIP - https://wordpress.org/themes/download/gildrest.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=gildrest/1.0.2&new_path=gildrest/1.0.3

History:


https://themes.svn.wordpress.org/gildrest/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#9 @shoyamane
3 months ago

Hi @poena.
I fixed the theme under the blue sky of summer.
Please review again.

#10 @poena
3 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi!
Thank you for the update. Your theme should be live in the directory shortly.

Note that you don't need the id here, the_post_thumbnail only has two parameters, $size and $attr:
https://developer.wordpress.org/reference/functions/the_post_thumbnail/

<?php the_post_thumbnail($post->ID, 'large'); ?> 

If you look at the source, you will see that the image does not have the class "size-large",
so the parameters are not interpreted correctly.
My guess would be that it only looks like it is working because of the css.

Note: See TracTickets for help on using tickets.