WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 5 months ago

#44652 closed theme (live)

THEME: OnlineMag – 1.0.2

Reported by: evisiontheme Owned by: sushil adhikari
Priority: previously reviewed Keywords: theme-onlinemag
Cc: evisionthemes@…

Description

OnlineMag - 0.1.0

OnlineMag, another clean magazine WordPress theme by eVision Themes.

Theme URL - http://evisionthemes.com/product/onlinemag/
Author URL - http://evisionthemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/onlinemag/0.1.0

SVN - https://themes.svn.wordpress.org/onlinemag/0.1.0
ZIP - https://wordpress.org/themes/download/onlinemag.0.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=onlinemag/0.0.1&new_path=onlinemag/0.1.0

History:

Ticket Summary Status Resolution Owner
#36080 THEME: OnlineMag – 0.0.1 closed not-approved kevinhaig
#44652 THEME: OnlineMag – 1.0.2 closed live sushil adhikari

(this ticket)

#46323 THEME: OnlineMag – 1.0.3 closed live themetracbot
#46362 THEME: OnlineMag – 1.0.4 closed live themetracbot
#46585 THEME: OnlineMag – 1.0.5 closed live themetracbot
#46748 THEME: OnlineMag – 1.0.6 closed live themetracbot
#47326 THEME: OnlineMag – 1.0.7 closed live themetracbot
#47530 THEME: OnlineMag – 1.0.8 closed live themetracbot
#49403 THEME: OnlineMag – 1.0.9 closed live themetracbot


https://themes.svn.wordpress.org/onlinemag/0.1.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

Change History (18)

#1 @joyously
5 months ago

Here is some user feedback to consider before your review.

  • The custom widgets need better names and descriptions. The name should be what the widget shows and the description should be a more verbose way to say the same thing.
  • This is how my static home Page looks when I activate the theme. Where is my static Page content? Why am I seeing these posts that aren't even the latest posts? Why do I have to hover to see the titles? How could that work for touch screens that have no hover?

https://s2.postimg.org/emt2ppm3d/home-page-default.jpg

  • I was able to click a submenu item from the menu once. Now I can't seem to get my cursor into the submenu. It always closes before I get the mouse there.
  • On a narrow window, I don't see the mobile menu icon. If I click the left side of the line with the search icon, I get an overlay with a very faint set of words. Hovering shows submenus, but it shouldn't (no hover on touch screens and vertical menu with dropdowns on hover is crazy).
  • The post meta is showing the wrong name for the post author. It should be the one chosen in User Profile - "Display name publicly as" option.
  • The post tags have a single comma at the beginning and none between the tags. "Tagged , css html title"
  • A post with many tags will overflow the container on an archive page. (due to no spaces between links I think)
  • A post with no title has no link to the single post page, from an archive.
  • A post with a long title overflows its container instead of wrapping, on an archive page.
  • <h6> is tiny. How is that a heading?
  • blockquote is styled as italic, but can have nested <em> and <cite> tags which are indistinguishable. It doesn't really need to be italics, because it has a left bar and a larger font size.
  • The link color is barely different from the normal text color. How can visitors find what is linked?
  • The <pre> tag is using a proportional font, which defeats the purpose of pre (preserving whitespace - which is gray - ha ha).
  • You might want to hide the menu, comment form, and widget areas for the print styles.
  • Theme should support the gallery default of 3 columns.
  • Customizer
    • Theme Options, Layout Options - Default Banner Image says "Please note that if you remove this image default banner image will appear". So is there a default to the default? Why isn't the default showing here? Where is this image used? Why is an image under Layout Options?
    • Home Blog Options - this should be renamed or description added because to me it sounds like options for when the latest posts are on the front. But it looks more like it is for the static Page on front.
    • Header Banner Advertisement - This is content creation. It would work better as a widget area so the user could keep the content and put whatever they want there instead of being limited to an image.
    • Top Header Settings - bunch of misspellings. Is the word you want "ticker"? (not "tiker" or "tinker") When I disable the ticker, there is still a set of orange arrows.
    • Colors - I changed the Primary color and not all instances of that color changed. (widget title border, ticker arrows on the page I was on)
    • Colors reset and All Reset - both say that you have to refresh the page after saving, but the preview should show all changes without user action or saving.

#2 @themetracbot
5 months ago

  • Summary changed from THEME: OnlineMag – 0.1.0 to THEME: OnlineMag – 0.1.1

OnlineMag - 0.1.1

OnlineMag, a clean and professional WordPress Magazine by eVision Themes

Theme URL - http://evisionthemes.com/product/onlinemag/
Author URL - http://evisionthemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/onlinemag/0.1.1

SVN - https://themes.svn.wordpress.org/onlinemag/0.1.1
ZIP - https://wordpress.org/themes/download/onlinemag.0.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=onlinemag/0.1.0&new_path=onlinemag/0.1.1

History:

Ticket Summary Status Resolution Owner
#36080 THEME: OnlineMag – 0.0.1 closed not-approved kevinhaig
#44652 THEME: OnlineMag – 1.0.2 closed live sushil adhikari

(this ticket)

#46323 THEME: OnlineMag – 1.0.3 closed live themetracbot
#46362 THEME: OnlineMag – 1.0.4 closed live themetracbot
#46585 THEME: OnlineMag – 1.0.5 closed live themetracbot
#46748 THEME: OnlineMag – 1.0.6 closed live themetracbot
#47326 THEME: OnlineMag – 1.0.7 closed live themetracbot
#47530 THEME: OnlineMag – 1.0.8 closed live themetracbot
#49403 THEME: OnlineMag – 1.0.9 closed live themetracbot


https://themes.svn.wordpress.org/onlinemag/0.1.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are onlinemag, flare

#3 @joyously
5 months ago

  • I still do not see my static Page content on the home page. Why would I choose a Page that I didn't want to see? It still looks like that screenshot, which is crazy.
  • The post meta is still showing the wrong name for the post author. It should be the one chosen in User Profile - "Display name publicly as" option.
  • A post with a long title still overflows its container instead of wrapping, on an archive page.
  • The "Latest" ticker is white on white on a narrow window. And each one is not the same size, so the longer ones push the page down, which makes it very annoying when trying to read the content that keeps moving up and down.

I didn't recheck everything, but did these few real quick (looking for the theme that changed my media settings).

#4 @themetracbot
5 months ago

  • Owner set to parthsanghvi
  • Status changed from new to reviewing

#5 @djrmom
5 months ago

  • Owner parthsanghvi deleted

This is being returned to the new queue again, as there has been no response yet from the reviewer. A reviewer should make an initial comment in ticket within 24 hours of being assigned, after which both reviewer and author should always communicate within 7 days.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#6 @themetracbot
5 months ago

  • Owner set to sushil adhikari

#7 @sushil adhikari
5 months ago

[Required: ]

  1. Demo Content:

The Latest slider below the header should be disabled until the user has explicitly set their content.
https://prnt.sc/ggh9vx

  1. Use localized data and support date option fromm the setting.
<div class="timer col-md-6">
   <?php $time = current_time('l, M j, Y');
        echo esc_attr($time);
        ?>
</div>

Refernce: https://codex.wordpress.org/Function_Reference/date_i18n

  1. Improper use of add_Action to add class on body. Use add_filter instead:
add_action( 'body_class', 'onlinemag_body_class', 10, 1);

Reference: https://developer.wordpress.org/reference/functions/body_class/

  1. Improper use of absint() for escaping number of post. Number of post can also be on negative. ie to retrieve all post we can use -1. Use intval() instead
$onlinemag_tinker_args = array(
    'post_type' => 'post',
    'posts_per_page' => absint( $onlinemag_customizer_all_values['onlinemag-header-no-of-tinker']) ,
    'ignore_sticky_posts' => 1,
);
  1. Improper use of esc_attr use esc_html instead
body.home.blog #page .site-content {
    background-color: #<?php echo esc_attr( $onlinemag_background_color );?>;
  }
  1. Front page setting doesn't work. Every default option of WordPress should be workable
  1. Remove any un used files. I didn't seen any upsells link on this theme
/*update to pro added*/
require_once( trailingslashit( get_template_directory() ) . 'trt-customize-pro/onlinemag/class-customize.php'

);

  1. You cannot use minified version unless original files provided
html5shiv.min.js respond.min.js
  1. sanitize function misssing in customizer/blog-section/blog.php . Let me know if there is different way of doing sanitization there

Here is one example:

$onlinemag_sections['onlinemag-blog-options'] =
    array(
        'priority'       => 230,
        'title'          => __( 'Home Blog Options', 'onlinemag' ),
    );

$onlinemag_settings_controls['onlinemag-blog-enable'] =
    array(
        'setting' =>     array(
            'default'              => $onlinemag_customizer_defaults['onlinemag-blog-enable']
        ),
        'control' => array(
            'label'                 =>  __( 'Enable Blog Section', 'onlinemag' ),
            'section'               => 'onlinemag-blog-options',
            'type'                  => 'checkbox',
            'priority'              => 10,
            'active_callback'       => ''
        )
    );

Note : Check on every files inside inc/customizer/*

  1. rewritin query is not allowed I guess, Please consult to admin reviewer for this.
function onlinemag_random_post() {
       global $wp;
       $wp->add_query_var('random');
       add_rewrite_rule('random/?$', 'index.php?random=1', 'onlinemag');
}
endif;
add_action('init','onlinemag_random_post');
  1. Also using template_redirect on theme:
add_action('template_redirect','onlinemag_random_post_template');

Both issue 10 and 11 falls on plugin territory.

  1. License missing for google fonts, Please include license for every font option you are using on customizer.

[ReCommend]
Better get ride of this existing customizer framework.

Thanks

#8 @evisiontheme
5 months ago

Thanks for the review @sushil-adhikari , we'll fix all the issues and update it as soon as possible.

Last edited 5 months ago by evisiontheme (previous) (diff)

#9 @themetracbot
5 months ago

  • Summary changed from THEME: OnlineMag – 0.1.1 to THEME: OnlineMag – 1.0.0

OnlineMag - 1.0.0

OnlineMag, A free magazine theme that has a beautiful design to help you start a professional looking news website. It can be used for any magazine niche such as tech, politics, sports, games, fashion, etc. With the available features you can optimize your website through clicks only and won’t have to write any code. The theme has responsive design, so, the contents of your website will look elegant on any device. For demo: http://demo.evisionthemes.com/onlinemag

Theme URL - http://evisionthemes.com/product/onlinemag/
Author URL - http://evisionthemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/onlinemag/1.0.0

SVN - https://themes.svn.wordpress.org/onlinemag/1.0.0
ZIP - https://wordpress.org/themes/download/onlinemag.1.0.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=onlinemag/0.1.1&new_path=onlinemag/1.0.0

History:

Ticket Summary Status Resolution Owner
#36080 THEME: OnlineMag – 0.0.1 closed not-approved kevinhaig
#44652 THEME: OnlineMag – 1.0.2 closed live sushil adhikari

(this ticket)

#46323 THEME: OnlineMag – 1.0.3 closed live themetracbot
#46362 THEME: OnlineMag – 1.0.4 closed live themetracbot
#46585 THEME: OnlineMag – 1.0.5 closed live themetracbot
#46748 THEME: OnlineMag – 1.0.6 closed live themetracbot
#47326 THEME: OnlineMag – 1.0.7 closed live themetracbot
#47530 THEME: OnlineMag – 1.0.8 closed live themetracbot
#49403 THEME: OnlineMag – 1.0.9 closed live themetracbot


https://themes.svn.wordpress.org/onlinemag/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#10 @sushil adhikari
5 months ago

Thank you @evisiontheme for a update. Here is what you missed from above list.

add_action( 'body_class', 'onlinemag_body_class', 10, 1);

License missing for google fonts, Please include license for every font option you are using on customizer.

sanitize function misssing in customizer/blog-section/blog.php . Let me know if there is different way of doing sanitization there

excerpt length will never be in negative integer, so please use absint() instead

function onlinemag_excerpt_length( $length ){
        global $onlinemag_customizer_all_values;
        $excerpt_length = $onlinemag_customizer_all_values['onlinemag-excerpt-length'];
        if ( empty( $excerpt_length) ) {
            $excerpt_length = $length;
        }
        return intval( $excerpt_length );

    }

The Latest slider below the header should be disabled until the user has explicitly set their content.

https://prnt.sc/ggh9vx

  1. escaping missing for onlinemag_category
$onlinemag_logs_args = array(
                          'post_type' => 'post',
                          'category_name' => $onlinemag_category,
                          'ignore_sticky_posts' => true,
                          'posts_per_page' => 4,
                      );

5.1 here as well

$onlinemag_logs_args = array(
                          'post_type' => 'post',
                          'category_name' => $onlinemag_category,
                          'ignore_sticky_posts' => true,
                          'posts_per_page' => 4,
                      );

5.2 here

$qargs = array(
                'posts_per_page' => $post_number,
                'no_found_rows'  => true,
                'ignore_sticky_posts'  => 1
            );
  1. Improper use of esc_attr() use esc_html instead


<p class="card-title"><?php echo esc_attr($onlinemag_category); ?></p>

6.1 here as well, Please follow late escaping method to escape

$onlinemag_feature_slider_category = esc_attr($onlinemag_customizer_all_values['onlinemag-featured-slider-category']);
  1. extra use of wp_reset_postdata(),please remove one..
         }
                        } else {
                            // no posts found
                        }
                        /* Restore original Post Data */
                        wp_reset_postdata();
                        ?>
                    </div><!-- content-bottom-post -->
                </div><!-- block holder -->
                <div class="clear"></div>
                <!--html generate-->
                <?php wp_reset_postdata(); // Reset ?>
  1. Is there any difference between online OnlineMag Widget Style 1 and OnlineMag Widget Style 2 widget. Here on widget code please use late escaping method..
  1. custom_class will be the string you are using absint() to escape
    <?php
    <label for="<?php echo absint($this->get_field_id( 'custom_class' )); ?>"><?php _e( 'Custom Class:', 'onlinemag' ); ?></label>
    
  1. Do not save default data on to database, https://make.wordpress.org/themes/handbook/review/required/#options-and-settings
function update( $new_instance, $old_instance ) {
            $instance = $old_instance;

            $instance['title']            = strip_tags($new_instance['title']);
            $instance['post_category']    = absint( $new_instance['post_category'] );
            $instance['post_number']      = absint( $new_instance['post_number'] );
            $instance['custom_class']     = esc_attr( $new_instance['custom_class'] );

            return $instance;
        }

#11 @evisiontheme
5 months ago

Hello @sushil-adhikari,

We are fixing some issues and few of the items are remaining.

Regarding the body class we have used the add_filter as well so just to manage different classes hope this will be ok.

Regarding the sanitize function misssing As you can check on the file /inc/frameworks/evision-customizer/evision-customizer.php you can see the public function on L-392. As we have our custom framework which sanitize on the basis of default value type as defined.

As this is working properly as well as, if this is form framework function prefix will also be ok as mentioned by admin reviewer previously.

Regards,
eVision Themes

#12 @themetracbot
5 months ago

  • Summary changed from THEME: OnlineMag – 1.0.0 to THEME: OnlineMag – 1.0.1

OnlineMag - 1.0.1

OnlineMag, A free magazine theme that has a beautiful design to help you start a professional looking news website. It can be used for any magazine niche such as tech, politics, sports, games, fashion, etc. With the available features you can optimize your website through clicks only and won’t have to write any code. The theme has responsive design, so, the contents of your website will look elegant on any device. For demo: http://demo.evisionthemes.com/onlinemag

Theme URL - http://evisionthemes.com/product/onlinemag/
Author URL - http://evisionthemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/onlinemag/1.0.1

SVN - https://themes.svn.wordpress.org/onlinemag/1.0.1
ZIP - https://wordpress.org/themes/download/onlinemag.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=onlinemag/1.0.0&new_path=onlinemag/1.0.1

History:

Ticket Summary Status Resolution Owner
#36080 THEME: OnlineMag – 0.0.1 closed not-approved kevinhaig
#44652 THEME: OnlineMag – 1.0.2 closed live sushil adhikari

(this ticket)

#46323 THEME: OnlineMag – 1.0.3 closed live themetracbot
#46362 THEME: OnlineMag – 1.0.4 closed live themetracbot
#46585 THEME: OnlineMag – 1.0.5 closed live themetracbot
#46748 THEME: OnlineMag – 1.0.6 closed live themetracbot
#47326 THEME: OnlineMag – 1.0.7 closed live themetracbot
#47530 THEME: OnlineMag – 1.0.8 closed live themetracbot
#49403 THEME: OnlineMag – 1.0.9 closed live themetracbot


https://themes.svn.wordpress.org/onlinemag/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#13 @evisiontheme
5 months ago

Hello @sushil-adhikari

We have fixed all the issues listed by you, regarding the issue related to 'late escaping' we are taking it as recommended, which we will check all the files and fix it on updates.

Regards,
eVision Themes

#14 @sushil adhikari
5 months ago

@evisiontheme

After this issue your theme will be ready to set live

  1. Customizer upsells links leads to page not found, either make it working or do not add this link
  1. This resembles the demo content, only show the section when user enables this feature

    The Latest slider below the header should be disabled until the user has explicitly set their content.

https://prnt.sc/ggh9vx

also date section on the top: https://prnt.sc/ghc7dj

  1. >>Is there any difference between online OnlineMag Widget Style 1 and OnlineMag Widget Style 2 widget. Here on widget code please use late escaping method..

Thanks

#15 @themetracbot
5 months ago

  • Summary changed from THEME: OnlineMag – 1.0.1 to THEME: OnlineMag – 1.0.2

OnlineMag - 1.0.2

OnlineMag, A free magazine theme that has a beautiful design to help you start a professional looking news website. It can be used for any magazine niche such as tech, politics, sports, games, fashion, etc. With the available features you can optimize your website through clicks only and won’t have to write any code. The theme has responsive design, so, the contents of your website will look elegant on any device. For demo: http://demo.evisionthemes.com/onlinemag

Theme URL - http://evisionthemes.com/product/onlinemag/
Author URL - http://evisionthemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/onlinemag/1.0.2

SVN - https://themes.svn.wordpress.org/onlinemag/1.0.2
ZIP - https://wordpress.org/themes/download/onlinemag.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=onlinemag/1.0.1&new_path=onlinemag/1.0.2

History:

Ticket Summary Status Resolution Owner
#36080 THEME: OnlineMag – 0.0.1 closed not-approved kevinhaig
#44652 THEME: OnlineMag – 1.0.2 closed live sushil adhikari

(this ticket)

#46323 THEME: OnlineMag – 1.0.3 closed live themetracbot
#46362 THEME: OnlineMag – 1.0.4 closed live themetracbot
#46585 THEME: OnlineMag – 1.0.5 closed live themetracbot
#46748 THEME: OnlineMag – 1.0.6 closed live themetracbot
#47326 THEME: OnlineMag – 1.0.7 closed live themetracbot
#47530 THEME: OnlineMag – 1.0.8 closed live themetracbot
#49403 THEME: OnlineMag – 1.0.9 closed live themetracbot


https://themes.svn.wordpress.org/onlinemag/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#16 @evisiontheme
5 months ago

Hello @sushil-adhikari ,

Thanks for the notice. We have fixed all the points you have listed again. Please confirm and let us know.

Regarding the widgets, they are different layout. You can review it once.

Regards
eVision Themes

#17 @evisiontheme
5 months ago

Also for verify, check this two styles in screenshots:

https://prnt.sc/ghepli
https://prnt.sc/ghepy7

#18 @sushil adhikari
5 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Great, Thank you for your contribution...I wish you all the best.

Best Regards
Sushil Adhikari

Note: See TracTickets for help on using tickets.