WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 3 months ago

Last modified 3 months ago

#44663 closed theme (live)

THEME: Newfangled – 1.0.5.1

Reported by: joyouswp Owned by: wenthemes
Priority: new theme Keywords: theme-newfangled
Cc: joyousthemes@…

Description

Newfangled - 1.0.0

Newfangled is a free WordPress theme to use for multipurpose. It fits for business,commercial Uses and other purposes. You can use multiple sliders and Icon with services, BreadCrumb with related featured image of Post and Page. It has a Clean look of Blog view and widgetized footer. Newfangled is a responsive, Translation Ready and Customizable Options. If you have any queries ping to this maild ID: joyousthemes@…

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/newfangled/1.0.0

SVN - https://themes.svn.wordpress.org/newfangled/1.0.0
ZIP - https://wordpress.org/themes/download/newfangled.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#44663 THEME: Newfangled – 1.0.5.1 closed live wenthemes

(this ticket)

#46263 THEME: Newfangled – 1.0.6 closed live themetracbot
#46729 THEME: Newfangled – 1.0.7 closed live themetracbot
#46803 THEME: Newfangled – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/newfangled/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

Change History (20)

This ticket was mentioned in Slack in #themereview by joyouswp. View the logs.


5 months ago

#2 @themetracbot
4 months ago

  • Summary changed from THEME: Newfangled – 1.0.0 to THEME: Newfangled – 1.0.1

Newfangled - 1.0.1

Newfangled is a free WordPress theme to use for multipurpose. It fits for business,commercial Uses and other purposes. You can use multiple sliders and Icon with services, BreadCrumb with related featured image of Post and Page. It has a Clean look of Blog view and widgetized footer. Newfangled is a responsive, Translation Ready and Customizable Options. If you have any queries ping to this maild ID: joyousthemes@…

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/newfangled/1.0.1

SVN - https://themes.svn.wordpress.org/newfangled/1.0.1
ZIP - https://wordpress.org/themes/download/newfangled.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=newfangled/1.0.0&new_path=newfangled/1.0.1

History:

Ticket Summary Status Resolution Owner
#44663 THEME: Newfangled – 1.0.5.1 closed live wenthemes

(this ticket)

#46263 THEME: Newfangled – 1.0.6 closed live themetracbot
#46729 THEME: Newfangled – 1.0.7 closed live themetracbot
#46803 THEME: Newfangled – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/newfangled/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#3 @themetracbot
4 months ago

  • Summary changed from THEME: Newfangled – 1.0.1 to THEME: Newfangled – 1.0.2

Newfangled - 1.0.2

Newfangled is a free WordPress theme to use for multipurpose. It fits for business,commercial Uses and other purposes. You can use multiple sliders and Icon with services, BreadCrumb with related featured image of Post and Page. It has a Clean look of Blog view and widgetized footer. Newfangled is a responsive, Translation Ready and Customizable Options. If you have any queries ping to this maild ID: joyousthemes@…

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/newfangled/1.0.2

SVN - https://themes.svn.wordpress.org/newfangled/1.0.2
ZIP - https://wordpress.org/themes/download/newfangled.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=newfangled/1.0.1&new_path=newfangled/1.0.2

History:

Ticket Summary Status Resolution Owner
#44663 THEME: Newfangled – 1.0.5.1 closed live wenthemes

(this ticket)

#46263 THEME: Newfangled – 1.0.6 closed live themetracbot
#46729 THEME: Newfangled – 1.0.7 closed live themetracbot
#46803 THEME: Newfangled – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/newfangled/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#4 @joyously
4 months ago

Here is some user feedback to consider before your review.

  • The breakpoint for the mobile menu is around 580px, which seems a bit small. What about tablets?
  • I have a static Page chosen to show on front, but I do not see it. Instead I see a title I did not write "Read Our Blog Posts" with smiley faces and 3 latest posts in skinny columns (full content). The theme needs to respect the user settings (show what I chose to show), and never show placeholder content to site visitors (title I didn't write).
  • If I don't choose any widgets for the sidebar, I still get a space reserved for it. What good is that?
  • I am showing my latest posts on a static Page. The title shown on that page is the first post title instead of the static Page title.
  • Something is strange about the padding on the menu items. It is only happening on the first submenu, but not the first item. https://s2.postimg.org/o0lqb6rkp/menu-item-weirdness.jpg
  • A post with no title has no link to the single post page, from an archive.
  • Text that goes on top of an image needs a little text-shadow to be readable.

https://s2.postimg.org/l2tcv89ax/text-over-image-needs-text-shadow.jpg

  • blockquote p a, blockquote p a:visited {color: #fff; font-size: 1.4rem;} This CSS should be removed. It makes the links white on white and a different size than the surrounding text.
  • List items have padding, making them tall. I can't make a short list!
  • Lists have a top margin, which look a little "off" when lists are nested.
  • <q> tag is unstyled. (default removed)
  • You might want to hide the menu, comment form, and widget areas for the print styles.
  • The page title is inconsistent. On static Pages, the title is on top of the header image and then the breadcrumbs. On a Post, it is there over the image (twice), but also above the post content. On an archive page and search page, the page title is above the content only. The 404 page does not have the header image.
  • The 404 page says "Maybe try one of the links below or a search?", but there are no links below.
  • A static Page with a featured image shows the image under the title and also above the content. A Post shows the image only once (under the title).
  • Customizer, Header Media - the default image should be shown here. It should match the front end.
  • Customizer, Theme Options, Home - the defaults don't make sense. Way at the bottom, it says "Enable Home Page Default Content Enable home page default content". But if it is default, why isn't it shown by default? Why are these other things I did not choose shown by default? Why would I make a Page full of content and then not show it? Why would the theme know better than I what I want on my home page? Why would I want the theme-provided stuff shown above what I wrote for my home page?
  • Customizer, Theme Options, Home - the Blog Posts section should not show full content since it is shown in columns. Each post is a different length and it looks awful to squeeze tables, images, lists, etc. into a skinny column.

#5 @themetracbot
4 months ago

  • Owner set to wenthemes
  • Status changed from new to reviewing

#6 @wenthemes
4 months ago

Hello,

Please fix following issues are re-upload your theme.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Issues

  • REQUIRED: Screenshot dimensions are wrong! Ratio of width to height should be 4:3. Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
  • REQUIRED: Incorrect prefix - structural_customizer_service_color() Please check in other places also. Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc. http://themereview.co/prefix-all-the-things/
  • REQUIRED: You can use the_posts_navigation() instead of newfangled_post_nav().
  • REQUIRED: Never use 'posts_per_page' => -1, in custom query. At least use some reasonable limit.
  • REQUIRED: Translation issue - functions.php L406
  • REQUIRED: All untrusted data should be escaped properly before displaying. https://codex.wordpress.org/Data_Validation Eg, esc_url() should be used to escape URL, value in HTML attributes should be escaped with esc_attr().

Please check above issues and fix those. Then I will review theme in more detail.

#7 @themetracbot
4 months ago

  • Summary changed from THEME: Newfangled – 1.0.2 to THEME: Newfangled – 1.0.3

Newfangled - 1.0.3

Newfangled is a free WordPress theme to use for multipurpose. It fits for business,commercial Uses and other purposes. You can use multiple sliders and Icon with services, BreadCrumb with related featured image of Post and Page. It has a Clean look of Blog view and widgetized footer. Newfangled is a responsive, Translation Ready and Customizable Options. If you have any queries ping to this maild ID: joyousthemes@…

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/newfangled/1.0.3

SVN - https://themes.svn.wordpress.org/newfangled/1.0.3
ZIP - https://wordpress.org/themes/download/newfangled.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=newfangled/1.0.2&new_path=newfangled/1.0.3

History:

Ticket Summary Status Resolution Owner
#44663 THEME: Newfangled – 1.0.5.1 closed live wenthemes

(this ticket)

#46263 THEME: Newfangled – 1.0.6 closed live themetracbot
#46729 THEME: Newfangled – 1.0.7 closed live themetracbot
#46803 THEME: Newfangled – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/newfangled/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#8 @joyouswp
4 months ago

@wenthemes Thanks for the review. I updated theme and resolve all those issues.

This ticket was mentioned in Slack in #themereview by joyouswp. View the logs.


4 months ago

This ticket was mentioned in Slack in #themereview by joyouswp. View the logs.


3 months ago

#11 @wenthemes
3 months ago

@joyouswp Please be patient. I will review the update today. :-)

#12 @wenthemes
3 months ago

Previous Issues Not Fixed

  • REQUIRED: Please remove newfangled_post_nav() function and use the_posts_navigation() in archive template.

Issues

  • REQUIRED: 404 Not Found - http://review.dev/wp-content/themes/newfangled/images/sidebar-icon.png"
  • REQUIRED: control-icon-picker.php - Prefixing issue.
  • REQUIRED: control-icon-picker.php - Do not use inline scripting. Use appropriate hook to load script.
  • REQUIRED: control-icon-picker.php L44 - Inline picker - translation issue.
  • REQUIRED: Non-printable characters were found in the functions.php file line 121.
  • REQUIRED: customizer.php - Escaping missing in several places. Eg, line 51, 55, etc.
  • REQUIRED: newfangled_admin_enqueue_scripts() - Admin scripts and styles should be loaded only in required admin pages. Currently those are loaded in all admin pages.
  • REQUIRED: <?php echo sprintf( esc_html('Mail Us', 'newfangled'), $theme_data->Name); ?> - This is not correct.
  • REQUIRED: 'capability' => 10, - For capability, use edit_theme_options. You should never use number for capability.
  • REQUIRED: options-config.php - Sanitization missing for breadcrumb_bg
  • REQUIRED: Remove search-form from add_theme_support( 'html5' ) as you are customizing it yourself.

#13 @themetracbot
3 months ago

  • Summary changed from THEME: Newfangled – 1.0.3 to THEME: Newfangled – 1.0.4

Newfangled - 1.0.4

Newfangled is a free WordPress theme to use for multipurpose. It fits for business,commercial Uses and other purposes. You can use multiple sliders and Icon with services, BreadCrumb with related featured image of Post and Page. It has a Clean look of Blog view and widgetized footer. Newfangled is a responsive, Translation Ready and Customizable Options. If you have any queries ping to this maild ID: joyousthemes@…

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/newfangled/1.0.4

SVN - https://themes.svn.wordpress.org/newfangled/1.0.4
ZIP - https://wordpress.org/themes/download/newfangled.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=newfangled/1.0.3&new_path=newfangled/1.0.4

History:

Ticket Summary Status Resolution Owner
#44663 THEME: Newfangled – 1.0.5.1 closed live wenthemes

(this ticket)

#46263 THEME: Newfangled – 1.0.6 closed live themetracbot
#46729 THEME: Newfangled – 1.0.7 closed live themetracbot
#46803 THEME: Newfangled – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/newfangled/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#14 @joyouswp
3 months ago

Hi @wenthemes,

Thanks for review., I updated v.1.0.4 and fixed all the issue you above mentioned. Please let me know if everything is ok.

#15 @wenthemes
3 months ago

Issues

  • REQUIRED: control-icon-picker.php L43 - In HTML attributes translation strings also need escaping. Use like this. data-title="<?php esc_attr_e('Inline picker','newfangled'); ?>"
  • REQUIRED: options-config.php - Sanitization missing for breadcrumb_bg. 'sanitize_callback' => 'esc_url', is not correct. For sanitization use esc_url_raw.

#16 @themetracbot
3 months ago

  • Summary changed from THEME: Newfangled – 1.0.4 to THEME: Newfangled – 1.0.5

Newfangled - 1.0.5

Newfangled is a free WordPress theme to use for multipurpose. It fits for business,commercial Uses and other purposes. You can use multiple sliders and Icon with services, BreadCrumb with related featured image of Post and Page. It has a Clean look of Blog view and widgetized footer. Newfangled is a responsive, Translation Ready and Customizable Options. If you have any queries ping to this maild ID: joyousthemes@…

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/newfangled/1.0.5

SVN - https://themes.svn.wordpress.org/newfangled/1.0.5
ZIP - https://wordpress.org/themes/download/newfangled.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=newfangled/1.0.4&new_path=newfangled/1.0.5

History:

Ticket Summary Status Resolution Owner
#44663 THEME: Newfangled – 1.0.5.1 closed live wenthemes

(this ticket)

#46263 THEME: Newfangled – 1.0.6 closed live themetracbot
#46729 THEME: Newfangled – 1.0.7 closed live themetracbot
#46803 THEME: Newfangled – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/newfangled/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#17 @joyouswp
3 months ago

@wenthemes Thank you., I submitted v.1.0.5.

#18 @themetracbot
3 months ago

  • Summary changed from THEME: Newfangled – 1.0.5 to THEME: Newfangled – 1.0.5.1

Newfangled - 1.0.5.1

Newfangled is a free WordPress theme to use for multipurpose. It fits for business,commercial Uses and other purposes. You can use multiple sliders and Icon with services, BreadCrumb with related featured image of Post and Page. It has a Clean look of Blog view and widgetized footer. Newfangled is a responsive, Translation Ready and Customizable Options. If you have any queries ping to this maild ID: joyousthemes@…

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/newfangled/1.0.5.1

SVN - https://themes.svn.wordpress.org/newfangled/1.0.5.1
ZIP - https://wordpress.org/themes/download/newfangled.1.0.5.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=newfangled/1.0.5&new_path=newfangled/1.0.5.1

History:

Ticket Summary Status Resolution Owner
#44663 THEME: Newfangled – 1.0.5.1 closed live wenthemes

(this ticket)

#46263 THEME: Newfangled – 1.0.6 closed live themetracbot
#46729 THEME: Newfangled – 1.0.7 closed live themetracbot
#46803 THEME: Newfangled – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/newfangled/1.0.5.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#19 @wenthemes
3 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Setting live. Good luck.

#20 @joyouswp
3 months ago

@wenthemes Thanks you so much for setting our theme live.

Note: See TracTickets for help on using tickets.