WordPress.org

Make WordPress Themes

Opened 3 months ago

Closed 4 weeks ago

#44679 closed theme (live)

THEME: luminous – 1.0.8

Reported by: juiiee8487 Owned by: Mirucon
Priority: previously reviewed Keywords: theme-luminous
Cc: juhir22495@…

Description

luminous - 1.0.1

Luminous Theme is a Clean and Elegant Blogger Template specially made for creative bloggers.

Theme URL -
Author URL - https://profiles.wordpress.org/juiiee8487

Trac Browser - https://themes.trac.wordpress.org/browser/luminous/1.0.1

SVN - https://themes.svn.wordpress.org/luminous/1.0.1
ZIP - https://wordpress.org/themes/download/luminous.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=luminous/1.0.0&new_path=luminous/1.0.1

History:

Ticket Summary Status Resolution Owner
#4111 THEME: Luminous Stone - 1.0 closed not-approved emiluzelac
#4144 THEME: Luminous Stone - 1.01 closed not-approved ArnoldGoodway
#43774 THEME: luminous – 1.0.0 closed not-approved rabmalin
#44679 THEME: luminous – 1.0.8 closed live Mirucon

(this ticket)


https://themes.svn.wordpress.org/luminous/1.0.1/screenshot.png

Change History (16)

#1 @themetracbot
2 months ago

  • Summary changed from THEME: luminous – 1.0.1 to THEME: luminous – 1.0.2

luminous - 1.0.2

Luminous Theme is a Clean and Elegant Blogger Template specially made for creative bloggers. It provides clean and gorgeous minimalistic layouts that make your content look great on any kind of device.

Theme URL -
Author URL - https://profiles.wordpress.org/juiiee8487

Trac Browser - https://themes.trac.wordpress.org/browser/luminous/1.0.2

SVN - https://themes.svn.wordpress.org/luminous/1.0.2
ZIP - https://wordpress.org/themes/download/luminous.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=luminous/1.0.1&new_path=luminous/1.0.2

History:

Ticket Summary Status Resolution Owner
#4111 THEME: Luminous Stone - 1.0 closed not-approved emiluzelac
#4144 THEME: Luminous Stone - 1.01 closed not-approved ArnoldGoodway
#43774 THEME: luminous – 1.0.0 closed not-approved rabmalin
#44679 THEME: luminous – 1.0.8 closed live Mirucon

(this ticket)


https://themes.svn.wordpress.org/luminous/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#2 @themetracbot
2 months ago

  • Summary changed from THEME: luminous – 1.0.2 to THEME: luminous – 1.0.3

luminous - 1.0.3

Luminous Theme is a Clean and Elegant Blogger Template specially made for creative bloggers. It provides clean and gorgeous minimalistic layouts that make your content look great on any kind of device.

Theme URL -
Author URL - https://profiles.wordpress.org/juiiee8487

Trac Browser - https://themes.trac.wordpress.org/browser/luminous/1.0.3

SVN - https://themes.svn.wordpress.org/luminous/1.0.3
ZIP - https://wordpress.org/themes/download/luminous.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=luminous/1.0.2&new_path=luminous/1.0.3

History:

Ticket Summary Status Resolution Owner
#4111 THEME: Luminous Stone - 1.0 closed not-approved emiluzelac
#4144 THEME: Luminous Stone - 1.01 closed not-approved ArnoldGoodway
#43774 THEME: luminous – 1.0.0 closed not-approved rabmalin
#44679 THEME: luminous – 1.0.8 closed live Mirucon

(this ticket)


https://themes.svn.wordpress.org/luminous/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#3 @joyously
8 weeks ago

See Proper Copyright/License Attribution for Themes to list all resources used (PHP, JS, CSS, fonts, images). Did you suddenly change the design? If you copied from Horkos, you need to give attribution.

Here is some user feedback to consider before your review.

  • A long site title overlaps itself. My screenshot does not look much like yours. I thought there was no menu, but it is there, white on white.

https://s2.postimg.org/iiy6ki2op/site-title-overlap.jpg

  • Any restructions (such as default menu depth=1) need to be documented for the user.
  • The mobile menu has a few problems. It still reacts to hover, so there is overlap. It also shows the more nested submenus as white on white. https://s2.postimg.org/xkakvzy1l/mobile-menu-problems.jpg
  • A post with no title has no link to the single post page, from an archive.
  • img, .wp-caption{width: auto !important;} This CSS rule should be removed, since CSS overrides HTML attributes. The use of !important should be kept to a minimum, so it is easier for user and child theme styles to override without having to use it also. Since the HTML width attribute is the only way the user has to specify the width, the CSS should not override it.
  • .featured-image-wrap img {max-height: 400px; width: 100% !important;} This CSS is guaranteed to distort images. The theme cannot know what width an image should be, so that should be removed.
  • Floats are not being cleared properly after the content area.
  • Tables look odd with everything centered. Please do not center user content unless the user chooses it.
  • Custom menu widget is styled the same as the main menu.
  • You might want to hide the menu and widget areas for the print styles. The comments should show, though.
  • Archive pages show the date in a different format, which is not the date format I chose in Settings.
  • Related Posts show the date in yet another format, which is not the one I chose.
  • The gallery captions are not shown. Why not? .gallery-caption {display: none;}
  • The gallery thumbnails are links, but they do not do anything when I click on them. You might want to try using add_theme_support('html5', 'gallery') to get better markup. .gallery-icon {cursor: default; pointer-events: none;}
  • The image attachment page shows the sidebar at the bottom. (on a 1070px window)
  • The search page with no matching results should show the search query, and perhaps a search box.
  • Search results should not show the author and date of static Pages.
  • The 404 page is not at all helpful, has two words run together in the message, and the sidebar is not on the side.
  • Customizer
    • Colors - Header Text color needs a default value to match the front end.
    • Theme Options
      • Remove the question marks for the checkbox options.
      • Invert the Author Bio box option, so it is consistent with core options and boolean logic: option should be to "Show", not "Hide" when checked.
      • Thank you for the gradient! (which it looks like you copied from Horkos - be sure to give credit)

#4 @themetracbot
8 weeks ago

  • Summary changed from THEME: luminous – 1.0.3 to THEME: luminous – 1.0.4

luminous - 1.0.4

Luminous Theme is a Clean and Elegant Blogger Template specially made for creative bloggers. It provides clean and gorgeous minimalistic layouts that make your content look great on any kind of device.

Theme URL -
Author URL - https://profiles.wordpress.org/juiiee8487

Trac Browser - https://themes.trac.wordpress.org/browser/luminous/1.0.4

SVN - https://themes.svn.wordpress.org/luminous/1.0.4
ZIP - https://wordpress.org/themes/download/luminous.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=luminous/1.0.3&new_path=luminous/1.0.4

History:

Ticket Summary Status Resolution Owner
#4111 THEME: Luminous Stone - 1.0 closed not-approved emiluzelac
#4144 THEME: Luminous Stone - 1.01 closed not-approved ArnoldGoodway
#43774 THEME: luminous – 1.0.0 closed not-approved rabmalin
#44679 THEME: luminous – 1.0.8 closed live Mirucon

(this ticket)


https://themes.svn.wordpress.org/luminous/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#5 @themetracbot
8 weeks ago

  • Owner set to Mirucon
  • Status changed from new to reviewing

#6 @Mirucon
8 weeks ago

Hi @juiiee8487,

Thanks for uploading theme! I reviwed your theme against these requirements: https://make.wordpress.org/themes/handbook/review/required

Required:

  • Please make sure no PHP warning / notices are not existed. These errors are found
( ! ) Notice: add_theme_support( 'html5' ) was called <strong>incorrectly</strong>. You need to pass an array of types. Please see <a href="https://codex.wordpress.org/Debugging_in_WordPress">Debugging in WordPress</a> for more information. (This message was added in version 3.6.1.) in /var/www/html/wp-includes/functions.php on line 4139
WARNING: wp-admin/admin-header.php:9 - Cannot modify header information - headers already sent by (output started at /var/www/html/wp-includes/functions.php:4139)
include('wp-admin/admin-header.php'), header
  • When loading Google Font from their CDN, make sure SSL connection is used. (Function.php Line: 7)
  • previous_posts_link() and next_posts_link() labels should be translatable. (index.php Line: 38, 39)
  • esc_attr() is used outside of attributes. Use esc_html() instead. (inc/customize.php line: 95-97)

Recommended:

  • It would be better if these things are escpaed:
    FILE: ...wordpress/wp-content/themes/luminous/inc/widget/recent_posts.php
    ----------------------------------------------------------------------
    FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 7 LINES
    ----------------------------------------------------------------------
      21 | WARNING | Expected next thing to be an escaping function (see
         |         | Codex for 'Data Validation'), not '$before_widget'
      22 | WARNING | Expected next thing to be an escaping function (see
         |         | Codex for 'Data Validation'), not '$before_title'
      23 | WARNING | Expected next thing to be an escaping function (see
         |         | Codex for 'Data Validation'), not '$title'
      24 | WARNING | Expected next thing to be an escaping function (see
         |         | Codex for 'Data Validation'), not '$after_title'
      87 | WARNING | Expected next thing to be an escaping function (see
         |         | Codex for 'Data Validation'), not '$after_widget'
     113 | WARNING | Expected next thing to be an escaping function (see
         |         | Codex for 'Data Validation'), not '$this'
     113 | WARNING | Expected next thing to be an escaping function (see
         |         | Codex for 'Data Validation'), not '$this'
     114 | WARNING | Expected next thing to be an escaping function (see
         |         | Codex for 'Data Validation'), not '$this'
     114 | WARNING | Expected next thing to be an escaping function (like
         |         | esc_html_e() or esc_attr_e()), not '_e'
    

Please fix the issues mentioned above, then upload a new version here: https://wordpress.org/themes/upload/

Cheers,
Mirucon


Please respond within 7 days. No response from the theme author for 7 days, the ticket will be closed due to inactivity.

Last edited 8 weeks ago by Mirucon (previous) (diff)

#7 @Mirucon
8 weeks ago

Sorry, forgetting to test customizer, but I found only one error on the theme customizer. Please also fix this issue:

  • Header Text Color - it doesn't make changes for the text color. Make sure the header text color is changed if its value is set.

#8 @themetracbot
7 weeks ago

  • Summary changed from THEME: luminous – 1.0.4 to THEME: luminous – 1.0.5

luminous - 1.0.5

Luminous Theme is a Clean and Elegant Blogger Template specially made for creative bloggers. It provides clean and gorgeous minimalistic layouts that make your content look great on any kind of device.

Theme URL -
Author URL - https://profiles.wordpress.org/juiiee8487

Trac Browser - https://themes.trac.wordpress.org/browser/luminous/1.0.5

SVN - https://themes.svn.wordpress.org/luminous/1.0.5
ZIP - https://wordpress.org/themes/download/luminous.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=luminous/1.0.4&new_path=luminous/1.0.5

History:

Ticket Summary Status Resolution Owner
#4111 THEME: Luminous Stone - 1.0 closed not-approved emiluzelac
#4144 THEME: Luminous Stone - 1.01 closed not-approved ArnoldGoodway
#43774 THEME: luminous – 1.0.0 closed not-approved rabmalin
#44679 THEME: luminous – 1.0.8 closed live Mirucon

(this ticket)


https://themes.svn.wordpress.org/luminous/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#9 @Mirucon
7 weeks ago

Hi @juiiee8487,

I've checked the latest version, you need to fix these issues before I mark this as approved. Sorry for not catching up these at the first round.

Required:

  • You need to have the non minified file of inc/js/bootstrap.min.js.

Recommended:

  • A hard coded date format found. It may be a good idea to use user's choice. (file: content-status.php, line: 11)

Cheers,
Mirucon

#10 @themetracbot
7 weeks ago

  • Summary changed from THEME: luminous – 1.0.5 to THEME: luminous – 1.0.6

luminous - 1.0.6

Luminous Theme is a Clean and Elegant Blogger Template specially made for creative bloggers. It provides clean and gorgeous minimalistic layouts that make your content look great on any kind of device.

Theme URL -
Author URL - https://profiles.wordpress.org/juiiee8487

Trac Browser - https://themes.trac.wordpress.org/browser/luminous/1.0.6

SVN - https://themes.svn.wordpress.org/luminous/1.0.6
ZIP - https://wordpress.org/themes/download/luminous.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=luminous/1.0.5&new_path=luminous/1.0.6

History:

Ticket Summary Status Resolution Owner
#4111 THEME: Luminous Stone - 1.0 closed not-approved emiluzelac
#4144 THEME: Luminous Stone - 1.01 closed not-approved ArnoldGoodway
#43774 THEME: luminous – 1.0.0 closed not-approved rabmalin
#44679 THEME: luminous – 1.0.8 closed live Mirucon

(this ticket)


https://themes.svn.wordpress.org/luminous/1.0.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#11 @Mirucon
7 weeks ago

I found some required items that you need to fix:

  • Make sure you have declared the licenses of the third party resources you have in your readme file. These licenses are not correctly declared.
* luminous theme uses Raleway font
* Segoe UI font Credit https://fonts.google.com/specimen/Raleway
* Theme also uses Bootstrap the most popular HTML, CSS, and JS library in the world. (http://getbootstrap.com/)
* Featurd image for post credit: https://www.pexels.com/photo/man-beach-holiday-woman-39691/

e.g.

normalize.css, Copyright 2012-2016 Nicolas Gallagher and Jonathan Neal
License: MIT Source: https://necolas.github.io/normalize.css/
  • $this->get_field_id( 'show_date' ) should be escaped using esc_attr(), so it will be like esc_attr( $this->get_field_id( 'show_date' ) ) (file: inc/widget/recent_posts.php line: 115, 116)
  • Please use esc_html() instead of esc_attr() when it's not html attribute. File: customize:php line: 98, 100, 101)
  • Please make sure you don't use echo when you use the esc_html_e() function. File: template-part/related-posts.php line: 32.

#12 @themetracbot
7 weeks ago

  • Summary changed from THEME: luminous – 1.0.6 to THEME: luminous – 1.0.7

luminous - 1.0.7

Luminous Theme is a Clean and Elegant Blogger Template specially made for creative bloggers. It provides clean and gorgeous minimalistic layouts that make your content look great on any kind of device.

Theme URL -
Author URL - https://profiles.wordpress.org/juiiee8487

Trac Browser - https://themes.trac.wordpress.org/browser/luminous/1.0.7

SVN - https://themes.svn.wordpress.org/luminous/1.0.7
ZIP - https://wordpress.org/themes/download/luminous.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=luminous/1.0.6&new_path=luminous/1.0.7

History:

Ticket Summary Status Resolution Owner
#4111 THEME: Luminous Stone - 1.0 closed not-approved emiluzelac
#4144 THEME: Luminous Stone - 1.01 closed not-approved ArnoldGoodway
#43774 THEME: luminous – 1.0.0 closed not-approved rabmalin
#44679 THEME: luminous – 1.0.8 closed live Mirucon

(this ticket)


https://themes.svn.wordpress.org/luminous/1.0.7/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#13 @Mirucon
7 weeks ago

  • You have missed escaping $this->get_field_id( 'show_date' ) using esc_attr() File: inc/widget/recent_posts.php line: 115
<p><input class="checkbox" type="checkbox" <?php checked( $show_date ); ?> id="<?php esc_attr( $this->get_field_id( 'show_date' ) ); ?>" name="<?php echo $this->get_field_name( 'show_date' ); ?>" />

Everything else looks fine now, will be approved next version.

#14 @themetracbot
7 weeks ago

  • Summary changed from THEME: luminous – 1.0.7 to THEME: luminous – 1.0.8

luminous - 1.0.8

Luminous Theme is a Clean and Elegant Blogger Template specially made for creative bloggers. It provides clean and gorgeous minimalistic layouts that make your content look great on any kind of device.

Theme URL -
Author URL - https://profiles.wordpress.org/juiiee8487

Trac Browser - https://themes.trac.wordpress.org/browser/luminous/1.0.8

SVN - https://themes.svn.wordpress.org/luminous/1.0.8
ZIP - https://wordpress.org/themes/download/luminous.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=luminous/1.0.7&new_path=luminous/1.0.8

History:

Ticket Summary Status Resolution Owner
#4111 THEME: Luminous Stone - 1.0 closed not-approved emiluzelac
#4144 THEME: Luminous Stone - 1.01 closed not-approved ArnoldGoodway
#43774 THEME: luminous – 1.0.0 closed not-approved rabmalin
#44679 THEME: luminous – 1.0.8 closed live Mirucon

(this ticket)


https://themes.svn.wordpress.org/luminous/1.0.8/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#15 @Mirucon
7 weeks ago

  • Status changed from reviewing to approved

Hi @juiiee8487,

Now I've checked through these things again, everything looks fine! Marking this as approved.

  • Customizer - Everything works
  • Escaping everything - OK
  • License and credit - OK
  • NS Theme Check - No error found
  • Prefixing function names - OK
  • Sanitizing customizer content - OK

This ticket has been moved to the new queue for a final review by one of the key reviewers. You can check the queue here: https://themes.trac.wordpress.org/report/24

It normally takes 2 or 3 weeks to get a review. After the review, your theme is going to be set as 'live', then will be available on the WordPress.org theme directory.

Good luck!

#16 @imranaliweb
4 weeks ago

  • Resolution set to live
  • Status changed from approved to closed

Hi @juiiee8487,

No, any one issue found,

Congratulations your theme is live, appear 1 to 2 hours on wp.org

Thanks
Imran Ali

Note: See TracTickets for help on using tickets.