WordPress.org

Make WordPress Themes

Opened 3 months ago

Closed 6 weeks ago

Last modified 6 weeks ago

#44756 closed theme (not-approved)

THEME: Easy-Press – 1.0.3

Reported by: ahmadaraj Owned by: rinkuyadav999
Priority: new theme Keywords: theme-easy-press accessibility-ready
Cc: araj1971@…

Description

Easy-Press - 1.0.3

EasyPress advance starter theme for wordpress, easy to customize and mobile friendly. EasyPress support any type of page builders, also having a full features to control pages, posts, feature images, footer widgets, header widgets, social icons, main navigation. EasyPress lightweight and fully schema.org microdata integrated WordPress theme, which boosts your communication with search engines.

Theme URL - http://wpeasypress.tk
Author URL - https://foura-studio.tk

Trac Browser - https://themes.trac.wordpress.org/browser/easy-press/1.0.3

SVN - https://themes.svn.wordpress.org/easy-press/1.0.3
ZIP - https://wordpress.org/themes/download/easy-press.1.0.3.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#44756 THEME: Easy-Press – 1.0.3 closed not-approved rinkuyadav999

(this ticket)


https://themes.svn.wordpress.org/easy-press/1.0.3/screenshot.png

Change History (3)

#1 @joyously
7 weeks ago

Here is some user feedback to consider before your review.

  • The menu needs to have a fallback for when no menu is selected. The default value of fallback_cb parameter of wp_nav_menu() works really well, and it's core functionality.
  • The dropdown effect for the menu is so slow, it's annoying.
  • The mobile menu should default to the same menu that the Primary menu has.
  • The mobile menu is not aware of window resize, so I can see two menus at once.
  • A very nested menu can disappear off the window edge.
  • I did not put any widgets into the Header widget areas, but the space is still preserved for it. My site title is squished into the corner instead of using the empty space the widgets aren't using.
  • Static Pages should show comments.
  • Any copyright statements on the front end should display the user's copyright, not the theme author's copyright.
  • The Custom Menu widget is showing only the top level links. Update: I found the submenu off to the right, outside the container. https://s26.postimg.org/6ugupqzwp/menu-widget.jpg
  • The Footer widget areas are not shown.
  • The post meta is very low contrast and won't pass accessibility review.
  • I do not like using text-transform: capitalize for links. That changes how sentences look.
  • I do not like using text-transform: capitalize for headings, either, but they are usually not sentences. They can have acronyms that would be messed up, though.
  • <h5> is quite small and <h6> is tiny. How is that a heading?
  • blockquote is styled as italic, but can have nested <em> and <cite> tags which are indistinguishable. It doesn't really need to be italics, because it has a left bar, a different background color, and padding.
  • <q> tag is unstyled. (default removed)
  • You might want to hide the menu, comment form, and widget areas for the print styles. The Print Preview is showing a blank first page, not all of the content (should be about 6 pages but it's 1), and the copyright on a page by itself.
  • Nested comments are showing the ordered list number, which is confusing for paged and nested comments. Try using CSS to hide the number or CSS counters to make it more logical.
  • The gallery post format is showing the captions centered, but the images left. It looks a bit odd. https://s26.postimg.org/uj0xyrlu1/gallery-offset.jpg
  • The image attachment page shows a small version of the image, with a link to the large version's file. Clicking on it takes the user outside of WordPress (no menu or sidebar), which should be avoided. Wouldn't it be easier to show the large image on the image attachment page, since that is what it is for? The CSS will keep it in the container.
  • This makes no sense: a search with no matches gives me this notice 8 times
    NOTICE: wp-content/themes/easy-press/inc/admin/meta-box.php:8 - Trying to get property of non-object
    
    Why would admin/meta-box.php be involved in a front end search page?
    Same thing for the 404 page.
  • Customizer
    • I think it is more clutter to put exclamation marks on options.
    • Footer widget - I don't think it's a good idea to register a widget area and not show it. I was able to put widgets into the footer widget areas and then I didn't see them. That's confusing. My preference would be to remove the enable/disable option. If the user puts no widgets, the widget area is not displayed. If they put some, it is displayed.
    • blog - Do these settings apply only to the Latest Posts listing? Or to all archives?
    • blog - The featured image location set to Content Left is a little confusing. It makes a separate column instead of floating the image left at the beginning of the content. I consider the content to be the stuff after the title and post meta, as that is what is labeled as entry-content.
    • blog - post image width description confuses the option. Is it the post or the post image? The 'for the blog' part doesn't help.
    • blog - Navigation type has a misspelling.
    • Header Top - same as Footer widgets
    • Colors, Body color - I expected this to be a background color. Can you add Text to the label?
    • Colors - several option names say Entery instead of Entry

#2 @rinkuyadav999
6 weeks ago

  • Keywords changed from theme-easy-press, accessibility-ready to theme-easy-press accessibility-ready
  • Owner set to rinkuyadav999
  • Status changed from new to reviewing

#3 @rinkuyadav999
6 weeks ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi @ahmadaraj

I found issues in your theme.

Text Domain

REQUIRED: This theme text domain does not match the theme's slug.
Also Theme Sniffer Error: comments.php L32 Missing singular placeholder, needed for some languages. See https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals

Minify

Please also provide non minify version of all css and js files.

License

I did not find license declaration of some third party js files. Please write license of all third party resources.
Also Font Awesome license for css and fonts are not same.

WordPress Compatibility

Theme should work with last 3 major version of WordPress.

Prefix

Image size identifier in add_image_size need to be prefix.
Do not prefix handle of wp_enqueue_style and wp_register_script for third party resources like superfish, fontawesome. For example easypress-fontawesome will be font-awesome. It helps WordPress to do not load same files multiple times.

Escape

Please escape all database value. Found theme-functions.php L205
Also get_permalink need to be escape.

Removing Core WordPress Hooks Callback

It is not allowed in theme. like wp_generator

WordPress have checked function ( https://developer.wordpress.org/reference/functions/checked/ ). You can use it in meta box instead custom code to do same.

Your theme have more than 5 required issues so i am closing this ticket. Please fix all required issues and submit your theme again. Make sure your theme follow each requirements: https://make.wordpress.org/themes/handbook/review/required/

Thanks

Last edited 6 weeks ago by rinkuyadav999 (previous) (diff)
Note: See TracTickets for help on using tickets.