WordPress.org

Make WordPress Themes

Changes between Initial Version and Version 1 of Ticket #44756, comment 3


Ignore:
Timestamp:
09/05/17 15:20:17 (7 weeks ago)
Author:
rinkuyadav999
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #44756, comment 3

    initial v1  
    1717== License == 
    1818 
    19 I did not find license declaration of some js third party js files. Please write license of all third party resources. 
     19I did not find license declaration of some third party js files. Please write license of all third party resources. 
    2020Also Font Awesome license for css and fonts are not same. 
    2121 
     
    2929 
    3030Image size identifier in add_image_size need to be prefix. 
    31 Do not prefix handle of wp_enqueue_style and wp_register_script for third party resources like superfish, fontawesome. For example easypress-fontawesome will be  font-awesome. So WordPress do not load same files multiple times. 
     31Do not prefix handle of wp_enqueue_style and wp_register_script for third party resources like superfish, fontawesome. For example easypress-fontawesome will be  font-awesome. It helps WordPress to do not load same files multiple times. 
    3232 
    3333 
     
    4444WordPress have checked function ( https://developer.wordpress.org/reference/functions/checked/ ). You can use it in meta box instead custom code to do same. 
    4545 
    46 Your theme have more than 5 required issues so i can closing this ticket. Please fix all required issue and submit your theme again. Make sure your theme follow each requirements: https://make.wordpress.org/themes/handbook/review/required/ 
     46Your theme have more than 5 required issues so i am closing this ticket. Please fix all required issues and submit your theme again. Make sure your theme follow each requirements: https://make.wordpress.org/themes/handbook/review/required/ 
    4747 
    4848