WordPress.org

Make WordPress Themes

Opened 5 months ago

Last modified 4 weeks ago

#44825 reviewing theme

THEME: BeAgency – 1.4.7

Reported by: bethememe Owned by: kevinhaig
Priority: previously reviewed Keywords: theme-beagency
Cc: admin@…

Description

BeAgency - 1.4.3

BeAgency is a very minimalistic yet creative WordPress theme for agencies and freelancers, which will help you make your project stand out from the crowd. Show off your latest photos and videos in all their glory with the responsive portfolio grid. Write blog posts with the beautiful, minimal blog. It is well documented which will help you to get your site running easy and fast.

Theme URL - http://betheme.me/themes/beagency/
Author URL - http://betheme.me/

Trac Browser - https://themes.trac.wordpress.org/browser/beagency/1.4.3

SVN - https://themes.svn.wordpress.org/beagency/1.4.3
ZIP - https://wordpress.org/themes/download/beagency.1.4.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=beagency/1.4.2&new_path=beagency/1.4.3

History:

Ticket Summary Status Resolution Owner
#27178 THEME: BeAgency Lite – 1.1.2 closed not-approved gadgetgal
#33994 THEME: BeAgency – 1.4.0 closed not-approved acosmin
#43623 THEME: BeAgency – 1.4.2 closed not-approved rabmalin
#44825 THEME: BeAgency – 1.4.7 reviewing kevinhaig

(this ticket)


https://themes.svn.wordpress.org/beagency/1.4.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

Change History (18)

#1 @joyously
3 months ago

Here is some user feedback to consider before your review.

  • If I don't put widgets in the sidebar, there is still space reserved for it.
  • Add a description to the widget area to indicate when and where it is shown, since it doesn't show on all pages.
  • The menu needs to have a fallback for when no menu is selected. The default value of fallback_cb parameter of wp_nav_menu() works really well, and it's core functionality.
  • The submenu display has a delay that feels sluggish.
  • Any restrictions (such as menu depth=3) needs to be documented for the user.
  • The mobile menu is reacting to hover. This is difficult to use with a mouse (dropdown on vertical menu) and a finger (no hover).
  • The archive pages are showing more posts than I have chosen in Settings "Blog pages show at most: x". The theme should not be doing more queries. Just show the ones already queried. This means there needs to be pagination shown.
  • Remove redundancy in the CSS. Instead of
    .carousel-inner > .item > a > img, 
    .carousel-inner > .item > img, 
    .img-responsive, .thumbnail a > img, 
    .thumbnail > img {
        display: block;
        height: auto;
        max-width: 100%;
    }
    
    just use img for the selector since it should apply to all images.
  • Because of using * {box-sizing: border-box} and .img-thumbnail {padding: 4px}, images are much smaller than they should be. A 150x150 image is showing as 142x142.
  • The image captions are on top of the image. This does not work well for dark images, for images with words, for small images, or for large captions.
  • The content font size seems small (14px) and several things are smaller!
  • Lists have a bottom margin, so it looks bad when lists are nested.
  • <hr> is barely visible.
  • You might want to hide the comment form and widget areas for the print styles.
  • Theme should support the gallery default of 3 columns.
  • The gallery captions almost completely cover the thumbnails and stick out on the right. Of course, the thumbnails show smaller than I chose because of the box-sizing and padding mentioned previously. https://s26.postimg.org/a39orkvyh/gallery-layout.jpg
  • I would prefer to see my sidebar on the search page.
  • Search results should not show the date of static Pages.
  • Search results show Posts as a skinny excerpt, but Pages and custom post types are full width.
  • The 404 page is not at all helpful. How about a sidebar or a search box?
  • Customizer
    • Opening the Custionizer for the first time, it says "Saved" in green. Theme should not be changing the Customizer CSS and should not save anything unless the user chooses Save. The theme author (betheme) is displayed; it has replaced the standard message showing what is being customized. This should not be changed by the theme, because there are other things in Customizer besides theme options. The X is red. It should not be.
    • https://s26.postimg.org/4hn9niv9l/customizer-changes.jpg
    • Site Footer - no hard coded dates (shows 2016)
    • Homepage - Home Page is two words. Add description for how to get this home page. Remove all of these text fields. Content should not be stored in theme options. (Remove the pink.)
    • General - Remove the pink. The way that the Home Page options have been changed does not work. There is no longer an option to show posts on the home page. The core options should not be changed.

#2 @themetracbot
3 months ago

  • Summary changed from THEME: BeAgency – 1.4.3 to THEME: BeAgency – 1.4.4

BeAgency - 1.4.4

BeAgency is a very minimalistic yet creative WordPress theme for agencies and freelancers, which will help you make your project stand out from the crowd. Show off your latest photos and videos in all their glory with the responsive portfolio grid. Write blog posts with the beautiful, minimal blog. It is well documented which will help you to get your site running easy and fast.

Theme URL - http://betheme.me/themes/beagency/
Author URL - http://betheme.me/

Trac Browser - https://themes.trac.wordpress.org/browser/beagency/1.4.4

SVN - https://themes.svn.wordpress.org/beagency/1.4.4
ZIP - https://wordpress.org/themes/download/beagency.1.4.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=beagency/1.4.3&new_path=beagency/1.4.4

History:

Ticket Summary Status Resolution Owner
#27178 THEME: BeAgency Lite – 1.1.2 closed not-approved gadgetgal
#33994 THEME: BeAgency – 1.4.0 closed not-approved acosmin
#43623 THEME: BeAgency – 1.4.2 closed not-approved rabmalin
#44825 THEME: BeAgency – 1.4.7 reviewing kevinhaig

(this ticket)


https://themes.svn.wordpress.org/beagency/1.4.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

#3 @themetracbot
3 months ago

  • Owner set to hidekazu
  • Status changed from new to reviewing

#4 @hidekazu
3 months ago

Hi bethememe,

I began reviewing the theme.
Give me around 5 days until I post my first review here.

The whole review process will be as described below.

  1. I review the theme according to theme review handbook and post the result here as a comment.
  2. You solve all the issues.
  3. You go to https://wordpress.org/themes/upload/ and reupload the new version.
    • The theme must have the same name
    • You need to change the Version tag in style.css
    • The new version will be attached to this ticket.
    • It's better to log your changes in a document.
  4. We repeat going through the process no.1 to 3 until I find no issues anymore.
  5. I approve the theme and this ticket will have a status approved.
  6. One of the admin will check this theme and review the theme himself/herself and make it live. It is possible that the admin reviewer adds more issues.

#5 @hidekazu
3 months ago

Hi bethememe,

Two buttons will appear on the second page of the category page.

#6 @themetracbot
3 months ago

  • Summary changed from THEME: BeAgency – 1.4.4 to THEME: BeAgency – 1.4.5

BeAgency - 1.4.5

BeAgency is a very minimalistic yet creative WordPress theme for agencies and freelancers, which will help you make your project stand out from the crowd. Show off your latest photos and videos in all their glory with the responsive portfolio grid. Write blog posts with the beautiful, minimal blog. It is well documented which will help you to get your site running easy and fast.

Theme URL - http://betheme.me/themes/beagency/
Author URL - http://betheme.me/

Trac Browser - https://themes.trac.wordpress.org/browser/beagency/1.4.5

SVN - https://themes.svn.wordpress.org/beagency/1.4.5
ZIP - https://wordpress.org/themes/download/beagency.1.4.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=beagency/1.4.4&new_path=beagency/1.4.5

History:

Ticket Summary Status Resolution Owner
#27178 THEME: BeAgency Lite – 1.1.2 closed not-approved gadgetgal
#33994 THEME: BeAgency – 1.4.0 closed not-approved acosmin
#43623 THEME: BeAgency – 1.4.2 closed not-approved rabmalin
#44825 THEME: BeAgency – 1.4.7 reviewing kevinhaig

(this ticket)


https://themes.svn.wordpress.org/beagency/1.4.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

#7 @hidekazu
3 months ago

  • Status changed from reviewing to approved

"Thank you very much for sharing your theme!

I don't find any issues anymore. As I told you before, one of the theme review team admins will check this theme and review again before making it live.It is possible that the admin reviewer adds more issues. I'm a new reviewer and need double check."

#8 @kevinhaig
2 months ago

I will do this final

#9 @kevinhaig
2 months ago

  • Status changed from approved to reopened

Theme Review - BeAgency Version 1.4.3

  • Hi I am @kevinhaig and I have completed the second (final) review of your theme.
  • Sorry but the ticket has been reopened because there are requirements not met.
  • The review process follows procedures found in the theme handbook.
  • ref: https://make.wordpress.org/themes/handbook/review/
  • If you do not understand or agree with something in the review, please comment in the ticket.
  • I can then help you, or if I am not sure of something I will certainly seek a second opinion from another key reviewer.

Responding to the Review

  • Please respond with update or request an extension within 7 days, or theme may be closed.

Required Items

Code

All untrusted data should be escaped before output.
  • why are you escaping a hard coded url? , file: beagency\footer.php, line: 19
  • Check and fix escaping problem. , file: beagency\footer.php, line: 21, use wp_kses_post()
  • get_the_permalink must be escaped, use esc_url() , file: beagency\inc\template-tags.php, line: 129
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 17
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 18
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 27
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 36
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 77
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 115
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 119
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 122
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 122
Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.
  • add_image_size() handles should be prefixed with beagency. , file: beagency\functions.php, line: 45
  • wp_enqueue_script() handle is betheme-admin-script. Handles should be prefixed with beagency. However if this is a bundled sscript, you should not prefix the handle unless you have edited the file. , file: beagency\inc\extras.php, line: 271
  • This function name should be prefixed. Please use beagency. , file: beagency\inc\template-tags.php, line: 14, actually, this function is no longer needed, use the_posts_navigation() from core
  • This function name should be prefixed. Please use beagency. , file: beagency\inc\template-tags.php, line: 42, actually this function is no longet needed, just use the_post_navigation() from core.

Core Functionality and Features

Use WordPress functionality and features first, if available.
  • add_theme_support() for post-formats used but not found in tags list in style.css , file: beagency\functions.php, line: 66
  • Theme support for comment-reply found, threaded-comments must be added to your tags list in style.css , file: beagency\functions.php, line: 147

Other Required

  • Please remove the BeTheme logo from Customizer, this area is not exclusive to your theme, it can be used by others.

Licensing

  • you have declared simple line icons, but I don't see where you are including them?
  • You have not declared infinite scroll.
  • You have not delared magnific.popup.
  • You have not declared jRespond.
  • You have not declared Owl carousel.
  • You have not declared Portfolio-images.
  • You have not declared smooth scroll.
  • You have not declared Superfish.
Declare licenses of any resources included such as fonts or images, including screenshot images
  • For resources please include: declaration (ex Copyright 2015, by John Smith), resource download link, license type, and license download
  • Below is an example of a resource declaration specifying resource name, resource download link, copyright declaration, license type, license link:
    jQuery Nivo Slider v3.2, http://nivo.dev7studios.com
    Copyright 2012, Dev7studios, MIT License, http://www.opensource.org/licenses/mit-license.php
    
  • Where did you get the image for the screen shot?
  • For images please provide download links and license type for images(including any images used in your screenshot) so licensing can be confirmed.
    • Below is an example of how an image should be declared.
      Image description/use : CC0 by author, http://www.imageprovider.com/imagelink
      

#10 @themetracbot
8 weeks ago

  • Summary changed from THEME: BeAgency – 1.4.5 to THEME: BeAgency – 1.4.6

BeAgency - 1.4.6

BeAgency is a very minimalistic yet creative WordPress theme for agencies and freelancers, which will help you make your project stand out from the crowd. Show off your latest photos and videos in all their glory with the responsive portfolio grid. Write blog posts with the beautiful, minimal blog. It is well documented which will help you to get your site running easy and fast.

Theme URL - http://betheme.me/themes/beagency/
Author URL - http://betheme.me/

Trac Browser - https://themes.trac.wordpress.org/browser/beagency/1.4.6

SVN - https://themes.svn.wordpress.org/beagency/1.4.6
ZIP - https://wordpress.org/themes/download/beagency.1.4.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=beagency/1.4.5&new_path=beagency/1.4.6

History:

Ticket Summary Status Resolution Owner
#27178 THEME: BeAgency Lite – 1.1.2 closed not-approved gadgetgal
#33994 THEME: BeAgency – 1.4.0 closed not-approved acosmin
#43623 THEME: BeAgency – 1.4.2 closed not-approved rabmalin
#44825 THEME: BeAgency – 1.4.7 reviewing kevinhaig

(this ticket)


https://themes.svn.wordpress.org/beagency/1.4.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

#11 @kevinhaig
8 weeks ago

  • Owner changed from hidekazu to kevinhaig
  • Status changed from reopened to reviewing

Theme Review - BeAgency Version 1.4.6

  • Below is the review of the latest update of your theme.

Responding to the Review

  • Please respond with update or request an extension within 7 days, or theme may be closed.

Required Items

Code

PHP/JS Errors
  • Silencing errors is forbidden , file: beagency\inc\tgmpa\tgm-plugin-activation.php, line: 526
    • I say this error last time but was not sure what to do with it, so I checked into it.
    • please use the TGMPA Generator to download a custom version of the plugin, and this error should go away.
    • http://tgmpluginactivation.com/download/
All untrusted data should be escaped before output.
  • any option you retrieve from your KIRKI option system that is not in a conditional statement, must be escaped before output. Yo still have many options that are not being escaped. If you do not agee with this then indicate why in the ticket.
  • Check and fix escaping problem. , file: beagency\header.php, line: 25
  • Check and fix escaping problem. , file: beagency\inc\extras.php, line: 244
  • Check and fix escaping problem. , file: beagency\inc\extras.php, line: 248
  • Check and fix escaping problem. , file: beagency\inc\extras.php, line: 249
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 17
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 19
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 38
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 75
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 82
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 123
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 128
  • Check and fix escaping problem. , file: beagency\template-home-page.php, line: 131

Core Functionality and Features

Use WordPress functionality and features first, if available.
  • add_theme_support() for custom-logo used but not found in tags list in style.css , file: beagency\functions.php, line: 67

Stylesheets and Scripts

Include all scripts and resources it uses rather than hot-linking. The exception to this is Google Fonts.
Required to use core-bundled scripts rather than including their own version of that script. For example jQuery.
  • You have not declared Portfolio-images. Actually this looks like imagesloaded.js. You need to use the version supplied by core and not this one.

#12 @jrf
8 weeks ago

Heads-up: when you download the new TGMPA version using the Custom TGMPA Generator, make sure you choose "wordpress.org" as distribution channel. You were now using the ThemeForest version of TGMPA (and yes, they are different).

#13 @bethememe
7 weeks ago

I will submit a new version this week. Please do not close this ticket.

#14 @themetracbot
6 weeks ago

  • Summary changed from THEME: BeAgency – 1.4.6 to THEME: BeAgency – 1.4.7

BeAgency - 1.4.7

BeAgency is a very minimalistic yet creative WordPress theme for agencies and freelancers, which will help you make your project stand out from the crowd. Show off your latest photos and videos in all their glory with the responsive portfolio grid. Write blog posts with the beautiful, minimal blog. It is well documented which will help you to get your site running easy and fast.

Theme URL - http://betheme.me/themes/beagency/
Author URL - http://betheme.me/

Trac Browser - https://themes.trac.wordpress.org/browser/beagency/1.4.7

SVN - https://themes.svn.wordpress.org/beagency/1.4.7
ZIP - https://wordpress.org/themes/download/beagency.1.4.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=beagency/1.4.6&new_path=beagency/1.4.7

History:

Ticket Summary Status Resolution Owner
#27178 THEME: BeAgency Lite – 1.1.2 closed not-approved gadgetgal
#33994 THEME: BeAgency – 1.4.0 closed not-approved acosmin
#43623 THEME: BeAgency – 1.4.2 closed not-approved rabmalin
#44825 THEME: BeAgency – 1.4.7 reviewing kevinhaig

(this ticket)


https://themes.svn.wordpress.org/beagency/1.4.7/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

#15 @kevinhaig
5 weeks ago

Sorry but I am on holidays for a couple of weeks. I will pick up the review then.

#16 @kevinhaig
5 weeks ago

You have not dealt with the following requirements:

PHP/JS Errors

  • Silencing errors is forbidden , file: beagency\inc\tgmpa\tgm-plugin-activation.php, line: 526
    • I brought up this error last time but was not sure what to do with it, so I checked into it. Please use the TGMPA Generator to download a custom version of the plugin, and this error should go away.
    • http://tgmpluginactivation.com/download/

Stylesheets and Scripts

Include all scripts and resources it uses rather than hot-linking. The exception to this is Google Fonts.
Required to use core-bundled scripts rather than including their own version of that script. For example jQuery.
  • You have not declared Portfolio-images. Actually this looks like imagesloaded.js. You need to use the version supplied by core and not this one.

#17 @rabmalin
5 weeks ago

@bethememe To fix error in TGM library, use WordPress.org version when generating TGM library. http://tgmpluginactivation.com/download/

#18 @bethememe
4 weeks ago

I need some more time to fix this. Its been hell of a week. Please do not close this ticket.

Note: See TracTickets for help on using tickets.