WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 2 months ago

Last modified 2 months ago

#44843 closed theme (live)

THEME: Carbon Lite – 1.0.7

Reported by: vincentdubroeucq Owned by: rabmalin
Priority: new theme Keywords: theme-carbon-lite accessibility-ready
Cc: vincent.dubroeucq@…

Description

Carbon Lite - 1.0.0

A bold theme for bold bloggers. Carbon Lite features a simple layout supported by fat typography.

Theme URL -
Author URL - http://vincentdubroeucq.com

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-lite/1.0.0

SVN - https://themes.svn.wordpress.org/carbon-lite/1.0.0
ZIP - https://wordpress.org/themes/download/carbon-lite.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#44843 THEME: Carbon Lite – 1.0.7 closed live rabmalin

(this ticket)

#48130 THEME: Carbon Lite – 1.0.8 closed live themetracbot
#49552 THEME: Carbon Lite – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/carbon-lite/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

Change History (35)

#1 @themetracbot
6 months ago

  • Keywords changed from theme-carbon-lite, accessibility-ready to theme-carbon-lite accessibility-ready
  • Summary changed from THEME: Carbon Lite – 1.0.0 to THEME: Carbon Lite – 1.0.1

Carbon Lite - 1.0.1

A bold theme for bold bloggers. Carbon Lite features a simple layout supported by fat typography.

Theme URL -
Author URL - http://vincentdubroeucq.com

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-lite/1.0.1

SVN - https://themes.svn.wordpress.org/carbon-lite/1.0.1
ZIP - https://wordpress.org/themes/download/carbon-lite.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=carbon-lite/1.0.0&new_path=carbon-lite/1.0.1

History:

Ticket Summary Status Resolution Owner
#44843 THEME: Carbon Lite – 1.0.7 closed live rabmalin

(this ticket)

#48130 THEME: Carbon Lite – 1.0.8 closed live themetracbot
#49552 THEME: Carbon Lite – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/carbon-lite/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#2 @themetracbot
5 months ago

  • Summary changed from THEME: Carbon Lite – 1.0.1 to THEME: Carbon Lite – 1.0.2

Carbon Lite - 1.0.2

A bold theme for bold bloggers. Carbon Lite features a simple layout supported by fat typography.

Theme URL -
Author URL - http://vincentdubroeucq.com

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-lite/1.0.2

SVN - https://themes.svn.wordpress.org/carbon-lite/1.0.2
ZIP - https://wordpress.org/themes/download/carbon-lite.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=carbon-lite/1.0.1&new_path=carbon-lite/1.0.2

History:

Ticket Summary Status Resolution Owner
#44843 THEME: Carbon Lite – 1.0.7 closed live rabmalin

(this ticket)

#48130 THEME: Carbon Lite – 1.0.8 closed live themetracbot
#49552 THEME: Carbon Lite – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/carbon-lite/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#3 @joyously
5 months ago

Here is some user feedback to consider before your review.

  • Having the title change size on hover can cause problems due to it wrapping differently. This GIF shows it at 15 frames per second only. It goes much faster than this, and could cause seizures in those susceptible.

https://s26.postimg.org/7au9crzrd/title-changing-size.gif

  • You can't quite tell in the previous GIF, but when the title is large, it is covered by the admin bar.
  • I do not like my desktop menu behind a menu icon.
  • A post title with a long word will overflow its container instead of wrapping.
  • A post without a title has no link to the single post page, from an archive page.
  • blockquote is styled as italic, but can have nested <em> and <cite> tags which are indistinguishable. It doesn't really need to be italics, because it has a left bar, a box shadow, and a larger font size.
  • Table headers are dark gray, but if those are links it is black on gray, or unreadable.
  • <q> tag is unstyled. (default removed)
  • You might want to hide the comment form and widget areas for the print styles. The comment author avatars are quite large and out of place also.
  • Nested comments show a bullet.

#4 @vincentdubroeucq
5 months ago

Thanks a lot for your feedback !
I'll act on it asap !

#5 @themetracbot
4 months ago

  • Summary changed from THEME: Carbon Lite – 1.0.2 to THEME: Carbon Lite – 1.0.3

Carbon Lite - 1.0.3

A bold theme for bold bloggers. Carbon Lite features a simple layout supported by fat typography.

Theme URL -
Author URL - http://vincentdubroeucq.com

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-lite/1.0.3

SVN - https://themes.svn.wordpress.org/carbon-lite/1.0.3
ZIP - https://wordpress.org/themes/download/carbon-lite.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=carbon-lite/1.0.2&new_path=carbon-lite/1.0.3

History:

Ticket Summary Status Resolution Owner
#44843 THEME: Carbon Lite – 1.0.7 closed live rabmalin

(this ticket)

#48130 THEME: Carbon Lite – 1.0.8 closed live themetracbot
#49552 THEME: Carbon Lite – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/carbon-lite/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#6 @themetracbot
4 months ago

  • Owner set to rumiko
  • Status changed from new to reviewing

#7 @rumiko
4 months ago

Hi @vincentdubroeucq,

I began reviewing the theme.
Give me around 10 days until I post my first review here.

The whole review process will be as described below.

  1. I review the theme according to theme review handbook and post the result here as a comment.
  2. You solve all the issues.
  3. You go to https://wordpress.org/themes/upload/ and reupload the new version.
    • The theme must have the same name
    • You need to change the Version tag in style.css
    • The new version will be attached to this ticket.
    • It's better to log your changes in a document.
  4. We repeat going through the process no.1 to 3 until I find no issues anymore.
  5. I approve the theme and this ticket will have a status approved.
  6. One of the admin will check this theme and review the theme himself/herself and make it live. It is possible that the admin reviewer adds more issues.Hi @example,

I began reviewing the theme.
Give me around 10 days until I post my first review here.

The whole review process will be as described below.

  1. I review the theme according to theme review handbook and post the result here as a comment.
  2. You solve all the issues.
  3. You go to https://wordpress.org/themes/upload/ and reupload the new version.
    • The theme must have the same name
    • You need to change the Version tag in style.css
    • The new version will be attached to this ticket.
    • It's better to log your changes in a document.
  4. We repeat going through the process no.1 to 3 until I find no issues anymore.
  5. I approve the theme and this ticket will have a status approved.
  6. One of the admin will check this theme and review the theme himself/herself and make it live. It is possible that the admin reviewer adds more issues.

#8 @rumiko
4 months ago

You need to have Theme URI: tag in the style.css.

Last edited 4 months ago by rumiko (previous) (diff)

#9 @vincentdubroeucq
4 months ago

Thanks a lot for your comment.
For now, the theme has no homepage, and I don't have the link to the repo yet. I'm pretty sure it'll be https://wordpress.org/themes/carbon-lite/, but I'll wait to put it in place.
Thanks a lot for your time !

#10 @joyously
4 months ago

You need to have Theme URI: tag in the style.css.

Umm, no, the Theme URI tag is optional.

I'm pretty sure it'll be https://wordpress.org/themes/carbon-lite/, but I'll wait to put it in place.

No, only the default themes Twenty* can use the wordpress.org URI.

#11 @rabmalin
4 months ago

@vincentdubroeucq Please respond or update your theme to keep ticket open. Generally, ticket is closed if there is no response from theme author for 7 days.

#12 @vincentdubroeucq
4 months ago

Hi,
Ok, but I have nothing to respond to.
@joyously submitted a few UX problems, I fixed them, and now I'm waiting for @rumiko to do the initial review.

#13 @rabmalin
4 months ago

  • Owner changed from rumiko to rabmalin

#14 @vincentdubroeucq
4 months ago

Ok, thanks for your time !

#15 @rabmalin
4 months ago

Issues

  • REQUIRED: Include all scripts and resources it uses rather than hot-linking. The exception to this is Google Fonts.
  • REQUIRED: functions.php L50 - Please prefix image size name. Eg, carbon-lite-blog-thumbnail
  • REQUIRED: You can use either carbon or carbon-lite as your theme prefix, but you need to make it uniform. Please check thoroughly.
  • REQUIRED: In readme file, please declare your theme copyright in following format.
    Fred WordPress Theme, Copyright 2012 Joe Smith
    Fred is distributed under the terms of the GNU GPL
    
  • REQUIRED: Update your POT file according to your theme. Copyright in pot file is still pointing to other. Or you can remove whole languages folder if you want to take advantage of WordPress Language Pack.
  • REQUIRED: Please keep unminified version of main-scripts.min.js
  • REQUIRED: carbon_lite_body_classes() - Value from get_theme_mod() is used without escaping. Please use proper escaping function.
  • REQUIRED: Remove search-form from add_theme_support( 'html5' ) as you are customizing it yourself.
  • REQUIRED: Remove comment-list from add_theme_support( 'html5' ) as you are customizing it yourself.

#16 @vincentdubroeucq
4 months ago

Wow, that was quick and helpful.
Thanks a lot !
I'll act on it asap

#17 @vincentdubroeucq
4 months ago

Hi,
Thanks a lot for your feedback.
I made tweaks according to your directions, except for this:

  • main-script.min.js is a concatenated and minified file coming from carbon-lite-js-detection.js, carbon-lite-navigation.js, and carbon-lite-skip-link-focus-fix.js. The three scripts are included, unminified. If WP_DEBUG is on, then these three are enqueued. Else, the single, concatenated and minified file is enqueued. Do you really think I should include just a concatenated version of the scripts ?

#18 @themetracbot
4 months ago

  • Summary changed from THEME: Carbon Lite – 1.0.3 to THEME: Carbon Lite – 1.0.4

Carbon Lite - 1.0.4

A bold theme for bold bloggers. Carbon Lite features a simple layout supported by fat typography.

Theme URL -
Author URL - http://vincentdubroeucq.com

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-lite/1.0.4

SVN - https://themes.svn.wordpress.org/carbon-lite/1.0.4
ZIP - https://wordpress.org/themes/download/carbon-lite.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=carbon-lite/1.0.3&new_path=carbon-lite/1.0.4

History:

Ticket Summary Status Resolution Owner
#44843 THEME: Carbon Lite – 1.0.7 closed live rabmalin

(this ticket)

#48130 THEME: Carbon Lite – 1.0.8 closed live themetracbot
#49552 THEME: Carbon Lite – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/carbon-lite/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#19 @rabmalin
4 months ago

Please fix following few issues and general review will be complete from my side.

Issues

Note

  • Since the theme has accessibility-ready tag, there would another round of review for accessibility. And it will take around 2 months. After a11y review is complete, your theme will be set live.

#20 @poena
4 months ago

accessibility-ready

https://make.wordpress.org/themes/handbook/review/accessibility/required/

Keyboard Navigation -did not pass
Menu: When I skip past the last menu item, the focus is on the main page but the menu is still open, covering the page.

Controls -did not pass
The screen reader text for the menu close button is
<span class="screen-reader-text"><?php esc_html_x( 'Close', 'Menu close button', 'carbon-lite' ); ?></span>
but esc_html_x does not echo the text so the span is empty.

Social links menus:
The fallback menus that is used when no menu has been selected does not seem to have a screen reader text and it does not have a fallback icon? The menu item is invisible until I accidentally hover over it or tab to it.
When I tab to or hover over the link I see a small white, empty box.

Skip Links -pass
Forms -pass
Headings -pass
ARIA Landmark Roles -did not pass
If a particular role appears more than once on a page, you should provide an ARIA label for that role.
Link Text -pass
Contrasts -pass
Images -did not pass
Icons and icon fonts: If the icon is supplementing text (e.g., it appears with text that indicates function or purpose),
then the icon should be hidden from screen readers using aria-hidden.
Home, menu, next and previous arrows, tags, pencil (edit)

Media -pass
Screen Reader Text -pass

Not Allowed -pass/none found.

#21 @vincentdubroeucq
4 months ago

Hi, @rabmalin,
Thanks a lot for your time.
When you talk about the singular placeholder, you simply mean replacing

esc_html( _nx( 'One thought on &ldquo;%2$s&rdquo;', '%1$s thoughts on &ldquo;%2$s&rdquo;', get_comments_number(), 'comments title', 'carbon-lite' ) ),

with

esc_html( _nx( '%1$s thought on &ldquo;%2$s&rdquo;', '%1$s thoughts on &ldquo;%2$s&rdquo;', get_comments_number(), 'comments title', 'carbon-lite' ) ), ?

Thanks a lot for the missing escaping ! That's important !

Hi @poena,
Thanks for the time taken to review the theme.
I made the correction @rabmalin mentionned, but please give me a couple more days to do yours.
I'll upload a new version once everything is done.
Thank you both !

#22 @rabmalin
3 months ago

@vincentdubroeucq Check Twenty Seventeen how that placeholder issue in comments.php can be fixed. https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentyseventeen/comments.php#L31

#23 @themetracbot
3 months ago

  • Summary changed from THEME: Carbon Lite – 1.0.4 to THEME: Carbon Lite – 1.0.5

Carbon Lite - 1.0.5

A bold theme for bold bloggers. Carbon Lite features a simple layout supported by fat typography.

Theme URL -
Author URL - http://vincentdubroeucq.com

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-lite/1.0.5

SVN - https://themes.svn.wordpress.org/carbon-lite/1.0.5
ZIP - https://wordpress.org/themes/download/carbon-lite.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=carbon-lite/1.0.4&new_path=carbon-lite/1.0.5

History:

Ticket Summary Status Resolution Owner
#44843 THEME: Carbon Lite – 1.0.7 closed live rabmalin

(this ticket)

#48130 THEME: Carbon Lite – 1.0.8 closed live themetracbot
#49552 THEME: Carbon Lite – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/carbon-lite/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#24 @vincentdubroeucq
3 months ago

Hi,
Concerning the icon not aria-hidden issue: they are generated by JavaScript. Basically a small js script replaces the <span>s with the data-icon attributes but you can't add an aria-hidden to them directly. I had to wrap them in another <span>. Not the most elegant solution.

Thanks a lot for your time and patience !

#25 @rabmalin
3 months ago

@vincentdubroeucq General review is complete from my side. @poena will confirm regarding a11y issues and your theme will be set live if ready.

#26 @poena
3 months ago

Hi
The update looks good but I must have forgotten to check the search form in the first review.
There is no submit button, just an icon.

I recommend checking how they solved it in twenty Seventeen.
https://themes.trac.wordpress.org/browser/twentyseventeen/1.3/searchform.php

#27 @themetracbot
3 months ago

  • Summary changed from THEME: Carbon Lite – 1.0.5 to THEME: Carbon Lite – 1.0.6

Carbon Lite - 1.0.6

A bold theme for bold bloggers. Carbon Lite features a simple layout supported by fat typography.

Theme URL -
Author URL - http://vincentdubroeucq.com

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-lite/1.0.6

SVN - https://themes.svn.wordpress.org/carbon-lite/1.0.6
ZIP - https://wordpress.org/themes/download/carbon-lite.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=carbon-lite/1.0.5&new_path=carbon-lite/1.0.6

History:

Ticket Summary Status Resolution Owner
#44843 THEME: Carbon Lite – 1.0.7 closed live rabmalin

(this ticket)

#48130 THEME: Carbon Lite – 1.0.8 closed live themetracbot
#49552 THEME: Carbon Lite – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/carbon-lite/1.0.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#28 @vincentdubroeucq
3 months ago

Hi,
I just put the icon into a standard button. Now the form is complete.
Hope that's enough !
Thanks for your time !

Last edited 3 months ago by vincentdubroeucq (previous) (diff)

#29 @rabmalin
3 months ago

Pinging @poena for final confirmation regarding a11y.

#30 @poena
3 months ago

Hi

There is no screen reader text for the submit button,

"if the icon is representing text (e.g., there is no visible text), the icon must include fallback text for screen readers that indicates what the icon means."

#31 @themetracbot
3 months ago

  • Summary changed from THEME: Carbon Lite – 1.0.6 to THEME: Carbon Lite – 1.0.7

Carbon Lite - 1.0.7

A bold theme for bold bloggers. Carbon Lite features a simple layout supported by fat typography.

Theme URL -
Author URL - http://vincentdubroeucq.com

Trac Browser - https://themes.trac.wordpress.org/browser/carbon-lite/1.0.7

SVN - https://themes.svn.wordpress.org/carbon-lite/1.0.7
ZIP - https://wordpress.org/themes/download/carbon-lite.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=carbon-lite/1.0.6&new_path=carbon-lite/1.0.7

History:

Ticket Summary Status Resolution Owner
#44843 THEME: Carbon Lite – 1.0.7 closed live rabmalin

(this ticket)

#48130 THEME: Carbon Lite – 1.0.8 closed live themetracbot
#49552 THEME: Carbon Lite – 1.1.0 closed live themetracbot


https://themes.svn.wordpress.org/carbon-lite/1.0.7/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#32 @vincentdubroeucq
3 months ago

Stupid mistake.
Is that right, now @poena ?

#33 @vincentdubroeucq
2 months ago

Hi,
Is the theme alright now, @poena ?
Thanks a lot for your time !

#34 @rabmalin
2 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Setting live. Final a11y issue mentioned above looks fixed in the latest update. If anything remaining we can fix in next update. Good luck.

#35 @vincentdubroeucq
2 months ago

Thanks a lot for your time !

Note: See TracTickets for help on using tickets.