WordPress.org

Make WordPress Themes

Opened 5 months ago

Closed 2 months ago

Last modified 2 months ago

#44849 closed theme (live)

THEME: Bani – 1.0.6

Reported by: salttechno Owned by: ShinichiN
Priority: previously reviewed Keywords: theme-bani
Cc: sales@…, merohappylife@…

Description

Bani - 1.0.1

Modern, clean & elegant WordPress blog theme.

Theme URL - https://themes.salttechno.com/downloads/bani/
Author URL - https://themes.salttechno.com

Trac Browser - https://themes.trac.wordpress.org/browser/bani/1.0.1

SVN - https://themes.svn.wordpress.org/bani/1.0.1
ZIP - https://wordpress.org/themes/download/bani.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=bani/1.0.0&new_path=bani/1.0.1

History:

Ticket Summary Status Resolution Owner
#44539 THEME: Bani – 1.0.0 closed not-approved rabmalin
#44849 THEME: Bani – 1.0.6 closed live ShinichiN

(this ticket)

#47183 THEME: Bani – 1.0.7 closed live themetracbot


https://themes.svn.wordpress.org/bani/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (29)

#1 @themetracbot
4 months ago

  • Summary changed from THEME: Bani – 1.0.1 to THEME: Bani – 1.0.2

#2 @joyously
3 months ago

Here is some user feedback to consider before your review.

  • Themes are not allowed to add links to the admin bar.
  • The "About Bani" admin page says there is a custom widget for About Me/Us, but there isn't (and shouldn't be).
  • I get this javascript error : TypeError: self.el is null wp-content/themes/bani/js/typed.js?ver=4.7.5 line 614
  • The fallback menu does not show submenus on mobile.
  • The mobile menu does not scroll, but can be taller than the window.
  • The breakpoints are not quite right for the mobile menu. Down to 586px, the menu is still hover/dropdown. Around 583px, it changes to vertical with click to open submenu, but title is on left. Title switches to top around 560px, but there is no menu icon until around 540px.
  • A long site title makes the header tall, which covers the page title and most of the header image. It also doesn't let me see very much content at once.
  • There is no link to the comment anchor (for easy copy/paste). This is typically put on the comment date.
  • The footer credit link says "Site by Salt Techno", which is inaccurate. "Theme", not "Site".
  • On my normal window size (~1070px), the sidebar has so much padding and margin that it is too skinny. The placeholder text for the search widget is cut off. Text I tried to flow around a thumbnail is too long to wrap (actually the margin on the image is too big). The menu widget should be indented to show the structure, but there isn't much room.

https://s26.postimg.org/cr62s33k9/sidebar-issues.jpg

  • The "Instagram Footer" widget area is using a trademark name at the beginning of its name, and is customized for a specific plugin for an external service. This does not seem right. When I put other widgets there, they are not formatted correctly (calendar is full width, menu is horizontal and submenu very tall). Please rename this widget area and make sure all core widgets work correctly here.
  • Theme is showing placeholder content to site visitors (welcome and intro). This should never happen. This type of feature should be disabled by default since the content is demo content.
  • The latest posts page should show only latest posts, nothing additional (welcome and intro, featured posts). That sort of thing should only be on static home Page, if enabled.
  • I do not like content to move on hover. It makes it difficult to read or to click where I intend.
  • The Older Posts link is on the right and points to the right. For left-to-right languages, this feels backward. Older should be on the left. It works for RTL, though.
  • Having many different sizes of posts causes layouts like this. I don't know if there's fix besides standardizing the sizes.

https://s26.postimg.org/xls2krtmx/latest-posts-layout.jpg

  • Why would you move the calendar title to the bottom? (calendar widget)
  • List items have a large bottom margin, which means lists are tall. Can't make a short list!
  • Links are barely different from the rest of the text.
  • Showing the categories twice seems excessive. If there are many categories, the first ones overflow off the top of the title area and the other post meta is not visible. I'm not complaining, but it presents an inaccurate view of the post. https://s26.postimg.org/557crsrt5/many-categories.jpg
  • The Print Preview shows the sticky header multiple times. It shows only part of the content (the page I tried should have had about 5 pages, but it showed 2). It shows the footer widget area.
  • Theme should support the gallery default of 3 columns.
  • Customizer
    • Footer Settings - the default value should match the front end, but the date should not be hard coded. The default value is all uppercase and the front end is not.
    • Footer Settings - checkbox for "Hide Social Icons" should be reversed to "Show Social Icons" for consistency with core options and boolean logic.
    • Colors - Header Text color default value should match front end.
    • Featured Posts Settings - invert checkbox (from "Hide" to "Show") Home Page is two words.
    • Cover Section Settings - Remove this section as it is content creation. Themes should store only presentation options, not content. Or rework it to use existing content.
    • Homepage Settings - Home Page is two words. Rename this to Latest Posts or something because Posts are not always shown on the home page.
    • Homepage Settings - Having two checkboxes for sidebar is like one option with four values, but not all four values make sense. It would be better to have just one option with 3 values: left, right, none.

#3 @salttechno
3 months ago

Hello @joyously ,

Thank you for your comments. This will definitely help us in improving our theme. We will try to work on these points as soon as possible.

Regards,
SaltTechno

#4 @themetracbot
3 months ago

  • Owner set to ShinichiN
  • Status changed from new to reviewing

#5 @ShinichiN
3 months ago

Hi @salttechno,

I began reviewing the theme.
Give me around 5 days until I post my first review here.

The whole review process will be as described below.

  1. I review the theme according to theme review handbook and post the result here as a comment.
  2. You solve all the issues.
  3. You go to https://wordpress.org/themes/upload/ and reupload the new version.
    • The theme must have the same name
    • You need to change the Version tag in style.css
    • The new version will be attached to this ticket.
    • It's better to log your changes in a document.
  4. We repeat going through the process no.1 to 3 until I find no issues anymore.
  5. I approve the theme and this ticket will have a status approved.
  6. One of the admin will check this theme and review the theme himself/herself and make it live. It is possible that the admin reviewer adds more issues.

Thanks!!

#6 @salttechno
3 months ago

Hello @ShinichiN ,

Thank you for your reply.

Can you please try to provide your first review today? I'll try to solve those issues and upload a new version today itself. It can save some time for both of us.

Regards,
SaltTechno

#7 @ShinichiN
3 months ago

Alright, it looks like I don't find a lot. And also, I'm on theme review at a contributor day.

A quick question,

  • what do you mean by "Instagram Footer"? If not the famous instagram, i don't think it's allowed to use.

#8 @salttechno
3 months ago

Hello @ShinichiN

Thank you for the quick reply.

About the question:
That's just a sidebar in the footer where admin can add any widget. I'll remove 'Instagram' from the name and upload the theme in some time.

Regards,
SaltTechno

#9 @themetracbot
3 months ago

  • Summary changed from THEME: Bani – 1.0.2 to THEME: Bani – 1.0.3

Bani - 1.0.3

Modern, clean & elegant WordPress blog theme. The theme is designed with the classic elegance to keep your reader/website visitor more focused on the content & images. Our professional designers have kept the design simple yet eye-pleasing. We have added customizable slider for featured posts at the top.

Theme URL - https://themes.salttechno.com/wordpress-theme/bani-free-blog-theme
Author URL - https://themes.salttechno.com

Trac Browser - https://themes.trac.wordpress.org/browser/bani/1.0.3

SVN - https://themes.svn.wordpress.org/bani/1.0.3
ZIP - https://wordpress.org/themes/download/bani.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=bani/1.0.2&new_path=bani/1.0.3

History:

Ticket Summary Status Resolution Owner
#44539 THEME: Bani – 1.0.0 closed not-approved rabmalin
#44849 THEME: Bani – 1.0.6 closed live ShinichiN

(this ticket)

#47183 THEME: Bani – 1.0.7 closed live themetracbot


https://themes.svn.wordpress.org/bani/1.0.3/screenshot.png

#10 @salttechno
3 months ago

Hello @ShinichiN

When can I expect your next review?

Thanks,
SaltTechno

#11 @ShinichiN
3 months ago

@salttechno Otherwise, I didn't find any more issues on requirements.

## Required

Please make the get_theme_mod's default text translatable.

echo wp_kses_post(get_theme_mod('bani_cover_subtitle', 'Welcome to my blog!'));

Once it's done, I'll pass it to the admins :)

#12 @themetracbot
3 months ago

  • Summary changed from THEME: Bani – 1.0.3 to THEME: Bani – 1.0.4

Bani - 1.0.4

Modern, clean & elegant WordPress blog theme. The theme is designed with the classic elegance to keep your reader/website visitor more focused on the content & images. Our professional designers have kept the design simple yet eye-pleasing. We have added customizable slider for featured posts at the top.

Theme URL - https://themes.salttechno.com/wordpress-theme/bani-free-blog-theme
Author URL - https://themes.salttechno.com

Trac Browser - https://themes.trac.wordpress.org/browser/bani/1.0.4

SVN - https://themes.svn.wordpress.org/bani/1.0.4
ZIP - https://wordpress.org/themes/download/bani.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=bani/1.0.3&new_path=bani/1.0.4

History:

Ticket Summary Status Resolution Owner
#44539 THEME: Bani – 1.0.0 closed not-approved rabmalin
#44849 THEME: Bani – 1.0.6 closed live ShinichiN

(this ticket)

#47183 THEME: Bani – 1.0.7 closed live themetracbot


https://themes.svn.wordpress.org/bani/1.0.4/screenshot.png

#13 @salttechno
3 months ago

Hello @ShinichiN

Thank you for your review. :-)

We have updated all occurrences of get_theme_mod's default text. Those are translatable now.

Regards,
SaltTechno

#14 @ShinichiN
3 months ago

  • Status changed from reviewing to approved

Thank you very much for sharing your theme!

I don't find any issues anymore. As I told you before, one of the theme review team admins will check this theme and review again before making it live.It is possible that the admin reviewer adds more issues. I'm a new reviewer and need double check.

#15 @kafleg
2 months ago

  • Cc merohappylife@… added
  • Status changed from approved to reopened

I will do this final review.

#16 @salttechno
2 months ago

Hello @kafleg

Thank you. Let me know changes required. I'll try to fix them as quickly as possible.

Regards,
SaltTechno

#17 @kafleg
2 months ago

Hello @salttechno,
Here is my review.

Please respond with an update or request an extension within 7 days, or theme may be closed.
Follows: https://make.wordpress.org/themes/handbook/review/required/

Required

  • Missing singular placeholder, needed for some languages. See https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals Check twentyseventeen theme for the reference.
  • Overriding WordPress globals is prohibited custom-comments.php line 10
  • Strings should have translatable content template-tags.phpline 55, 62
  • Strings should have translatable content single.php line 25
  • Commented codes found on single.php file. Remove unnecessary commented codes.
  • Background image URL need to be escape with esc_url in single.php file. Please check all files and check proper escaping for URL, attributes, html etc.
  • rtl.css have commented codes. Remove it if not necessary.
  • Is your theme rtl-language-support ready? If not remove tags from style.css
  • From July 27 2017, images from Pixabay are not GPL compatible. Later they reverted license to CC0 but they added some terms which makes it non-GPL. There is still discussion going. https://pixabay.com/sv/forum/questions-about-pixabay-11/terms-large-scale-copying-cc0-and-gpl-5248/ Either change it to other OR wait until there comes some conclusion from the discussion.
  • Use a proper function for escaping. wp_kses_post is not valid for every places. Check escaping properly and use it.
  • Image source need to escape with esc_url. It's missing on theme. Check every theme files and use escape function properly.
  • Layouts folder is not necessary, remove it.
  • Make your own theme pot file. # Copyright (C) 2017 Automattic you have default underscores pot file.
  • Facebook, twitter etc filed type must be URL and it's sanitize callback function is esc_url_raw. So, check your theme sanitization and validation functions properly.
  • License of TGM plugin activation is missing on readme file. Add proper license of the external resources used on theme.
  • Development files need to be placed on github or similar other places. It's not good to place development files on theme. sass file.

Regards
@kafleg

#18 @salttechno
2 months ago

Hello @kafleg

Thank you for the review. I'll work on it and upload the theme ASAP. I have one doubt about image license. Can I use images from unsplash if not from pixabay?

Regards,
SaltTechno

#19 @kafleg
2 months ago

Images from unsplash are no longer allowed. Please find other best place yourself for images.

#20 @themetracbot
2 months ago

  • Summary changed from THEME: Bani – 1.0.4 to THEME: Bani – 1.0.5

Bani - 1.0.5

A comprehensive blog theme with a fresh, clean & elegant design. The theme is designed with the classic elegance to keep your reader more focused on the content & images. Our professional designers have kept the design simple yet eye-pleasing. You can customize most of the theme settings with live preview. Native WordPress customizer is used to make it easy for you to edit theme settings. We have added a customizable slider for featured posts and a cover section at the top for your blog introduction. The theme is lightweight with less than 40kb style.css (you can minimize it further easily). It is fully responsive theme built on world’s most loved framework for responsive websites, Bootstrap 4. You can use all latest WordPress page builder plugins like Site Origin, Elementor, Beaver Builder etc. This is a perfect WordPress theme for any kind of blog. Bani is a classic blog theme with RTL language support and is completely translation-ready. Our support team is always there to answer your queries. The theme will be regularly updated with new features. Check demo at http://bani.themesease.com. To know more about the theme, visit https://themes.salttechno.com/wordpress-theme/bani-free-blog-theme/.

Theme URL - https://themes.salttechno.com/wordpress-theme/bani-free-blog-theme/
Author URL - https://themes.salttechno.com

Trac Browser - https://themes.trac.wordpress.org/browser/bani/1.0.5

SVN - https://themes.svn.wordpress.org/bani/1.0.5
ZIP - https://wordpress.org/themes/download/bani.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=bani/1.0.4&new_path=bani/1.0.5

History:

Ticket Summary Status Resolution Owner
#44539 THEME: Bani – 1.0.0 closed not-approved rabmalin
#44849 THEME: Bani – 1.0.6 closed live ShinichiN

(this ticket)

#47183 THEME: Bani – 1.0.7 closed live themetracbot


https://themes.svn.wordpress.org/bani/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: Could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.

#21 @salttechno
2 months ago

Hello @kafleg ,

Thanks a lot for your review. It helped me improve my knowledge and the theme.

I have updated theme and resolved issues you had mentioned in your review. Please review it and let me know your comments.

Regards,
SaltTechno

#22 @salttechno
2 months ago

Hello @kafleg

When can I expect next review?

Regards,
SaltTechno

#23 @salttechno
2 months ago

Hello @kafleg ,

Can you please review this updated theme?

Regards,
SaltTechno

#24 @kafleg
2 months ago

Hello @salttechno,
Solve the below-listed issues and resubmit your theme again.

Required

Theme Sniffer Issues

Use Theme Sniffer plugin and check errors and warning on your theme. https://github.com/WPTRT/theme-sniffer/releases/download/0.1.4/ns-theme-check.0.1.4.zip [Errors need to be fixed and Warnings are things that need to be checked manually.]

  • footer.php The $text arg must be a single string literal, not "get_theme_mod( 'bani_footer_text_left', ( '(c) Copyright 2017 - All Rights Reserved', 'bani' ) )".
  • index.php The $text arg must be a single string literal, not "get_theme_mod( 'bani_cover_subtitle', ( 'Welcome to my blog!', 'bani' ) )".
  • The $text arg must be a single string literal, not "get_theme_mod( 'bani_cover_static_title', ( 'I am a', 'bani' ) )".
  • The $text arg must be a single string literal, not "get_theme_mod('bani_cover_paragraph', ( 'This is a perfect place to introduce yourself and this blog. You can easily customize this text from WordPress admin panel. If you want, you can disable this section. You can also customize colors used for this template easily.', 'bani' ))".

Codes

  • ... should be …
  • Inline scripts found on theme index.php file. Enqueue it via functions file.
  • content.php, image source missing escaping. Please check other files as well.
  • Commented codes found on extras.php. Remove unused and commented codes.

Regards

#25 @themetracbot
2 months ago

  • Summary changed from THEME: Bani – 1.0.5 to THEME: Bani – 1.0.6

Bani - 1.0.6

A comprehensive blog theme with a fresh, clean & elegant design. The theme is designed with the classic elegance to keep your reader more focused on the content & images. Our professional designers have kept the design simple yet eye-pleasing. You can customize most of the theme settings with live preview. Native WordPress customizer is used to make it easy for you to edit theme settings. We have added a customizable slider for featured posts and a cover section at the top for your blog introduction. The theme is lightweight with less than 40kb style.css (you can minimize it further easily). It is fully responsive theme built on world’s most loved framework for responsive websites, Bootstrap 4. You can use all latest WordPress page builder plugins like Site Origin, Elementor, Beaver Builder etc. This is a perfect WordPress theme for any kind of blog. Bani is a classic blog theme with RTL language support and is completely translation-ready. Our support team is always there to answer your queries. The theme will be regularly updated with new features. Check demo at http://bani.themesease.com. To know more about the theme, visit https://themes.salttechno.com/wordpress-theme/bani-free-blog-theme/.

Theme URL - https://themes.salttechno.com/wordpress-theme/bani-free-blog-theme/
Author URL - https://themes.salttechno.com

Trac Browser - https://themes.trac.wordpress.org/browser/bani/1.0.6

SVN - https://themes.svn.wordpress.org/bani/1.0.6
ZIP - https://wordpress.org/themes/download/bani.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=bani/1.0.5&new_path=bani/1.0.6

History:

Ticket Summary Status Resolution Owner
#44539 THEME: Bani – 1.0.0 closed not-approved rabmalin
#44849 THEME: Bani – 1.0.6 closed live ShinichiN

(this ticket)

#47183 THEME: Bani – 1.0.7 closed live themetracbot


https://themes.svn.wordpress.org/bani/1.0.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: Could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.

#26 @salttechno
2 months ago

Hello @kafleg

Thank you for the review. I have made all the changes and uploaded the theme again.

Please review it and let me know if any issues.

Regards,
SaltTechno

#27 @kafleg
2 months ago

  • Status changed from reopened to reviewing

#28 @kafleg
2 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

No more issues found. Setting live. It may take some while to appear on the repository. Thank you so much for your coordination while reviewing theme. Good Luck !!

#29 @salttechno
2 months ago

Thank you, @kafleg for the review. :)

Note: See TracTickets for help on using tickets.