WordPress.org

Make WordPress Themes

Attachments (6)

calendar.jpg (13.3 KB) - added by garinungkadol 7 years ago.
linked-image.jpg (71.0 KB) - added by garinungkadol 7 years ago.
non-captioned-images.jpg (63.1 KB) - added by garinungkadol 7 years ago.
post-thumbnail.jpg (58.0 KB) - added by garinungkadol 7 years ago.
post-title.jpg (28.9 KB) - added by garinungkadol 7 years ago.
wide-images.jpg (31.8 KB) - added by garinungkadol 7 years ago.

Download all attachments as: .zip

Change History (8)

#1 @garinungkadol
7 years ago

  • Owner set to garinungkadol
  • Status changed from new to assigned

#2 @garinungkadol
7 years ago

  • Keywords synchold added
  • Resolution set to not-approved
  • Status changed from assigned to closed

THEME REVIEW RESULTS
This is a near complete review. Below are the theme review results. Anything marked FAIL needs to be addressed. Anything marked REQUIRED is needed to be fixed while anything marked RECOMMENDED is strongly advised. Other points may be raised purely for information.

Recommend that the next review focus on theme options.

RECOMMENDATION: NOT-APPROVED


Issues from Previous Review: PASS

  • FIXED: Theme author has removed non-GPL compatible fonts.
  • PARTIAL-FIX: License has been defined but you must also include the License URI. If you are going to license your theme under GPL3, you can use this link: http://www.gnu.org/licenses/gpl.html

Theme Check Results: PASS

The following are optional:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to add_custom_image_header was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_custom_background() was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

Debugger results: FAIL
Upon theme activation / All posts and pages
Notice: Undefined variable: options in C:\xampp\htdocs\wordpress\themereview\wp-content\themes\creative-foliage\functions.php on line 40

All posts
-- Debug: Undefined variable: commenter on line 64 of C:\xampp\htdocs\wordpress\themereview\wp-content\themes\creative-foliage\functions.php
-- Debug: Undefined variable: aria_req on line 64 of C:\xampp\htdocs\wordpress\themereview\wp-content\themes\creative-foliage\functions.php
-- Debug: Undefined variable: commenter on line 67 of C:\xampp\htdocs\wordpress\themereview\wp-content\themes\creative-foliage\functions.php
-- Debug: Undefined variable: aria_req on line 67 of C:\xampp\htdocs\wordpress\themereview\wp-content\themes\creative-foliage\functions.php
-- Debug: Undefined variable: commenter on line 70 of C:\xampp\htdocs\wordpress\themereview\wp-content\themes\creative-foliage\functions.php


Deprecated Calls: FAIL
Argument in wp_get_recent_posts() Used in wp-content/themes/creative-foliage/sidebar.php on line 14.
Passing an integer number of posts is deprecated. Pass an array of arguments instead. Deprecated in version 3.1.


Test data results: FAIL
Blog Post Index

  • REQUIRED: Posts with no titles should still include a link to the single post view
  • REQUIRED: You must provide page navigation for posts using <!--nextpage-->. Make use of wp_link_pages. This applies to Single Post View as well.

Single Post View

  • FAIL: Comments are not being displayed.
  • REQUIRED: Wide-images should not overflow the content area. Consider using max-width in your css with a value close to what you've set for $content_width. See wide-image.jpg and linked-image.jpg.
  • Non-captioned images with center or no alignment do not have a border unlike right and left aligned images. See non-captioned-images.jpg

Pages

  • FAIL: Pages with comments enabled are not displaying comments.

Visual issues / functionality / browser checks: FAIL

  • FAIL: Check your implementation of Navigation Menus. The first menu is always shown no matter what menu selection I make in the admin page.
  • FAIL: No content is displayed in the Theme Options page.
  • RECOMMENDED: You should rename your sidebar widget. Instead of 'Right Sidebar' it should be 'Footer' because that is where the widget content is being placed.

Validation: FAIL
CSS: PASS

HTML: FAIL

  • You have a </p> without <p> in footer.php

Code Quality:

  • FAIL: You are loading the wrong text domain. You are loading the text domain 'echo' but you are using 'foliage' in template files.
  • REQUIRED: Since you are providing translation support, all text must be translatable. Check functions.php. For example:
    Line 50		'name' => 'Right Sidebar',
    

should be

	'name' => __( 'Right Sidebar', 'my-text-domain' ),
  • RECOMMENDED: For consistency, I would recommend using 'foliage' for your prefix.

Other notes

  • REQUIRED: Your screenshot should be a "reasonable facsimile" of the Theme after it is initially activated with default options.

Information
If there are any issues once resolved, please re-submit your Theme using the uploader tool on wordpress.org/extend/themes, and a new Trac ticket will be generated.
Note:

  • Re-submitted Themes are given review priority over new Themes.

You can use the following tools to recreate the issues raised above if any have been:

Themes should be reviewed using define('WP_DEBUG', true); in wp-config.php
You can also view the Theme Review page.

Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:

  • 1) Leave a comment on this ticket
  • 2) Email the theme-reviewers email list
  • 3) Use the #wordpress-themes channel on irc.freenode.net
Note: See TracTickets for help on using tickets.