WordPress.org

Make WordPress Themes

Opened 3 months ago

Last modified 71 minutes ago

#45134 reviewing theme

THEME: Applicator – 1.5.8

Reported by: briansahagun Owned by: burkeingraffia
Priority: new theme Keywords: theme-applicator accessibility-ready
Cc: briansahagun@…

Description

Applicator - 0.2

A WordPress Theme that is accessibility-ready, SEO and mobile-friendly.

Theme URL - http://applicator.dysinelab.com/
Author URL - http://briansahagun.com

Trac Browser - https://themes.trac.wordpress.org/browser/applicator/0.2

SVN - https://themes.svn.wordpress.org/applicator/0.2
ZIP - https://wordpress.org/themes/download/applicator.0.2.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#45134 THEME: Applicator – 1.5.8 reviewing burkeingraffia

(this ticket)


https://themes.svn.wordpress.org/applicator/0.2/screenshot.png
Theme Check Results:

  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments 'Pages:'
  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments 'Next page'
  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments 'Previous page'

Attachments (4)

applicator.zip (1.1 MB) - added by briansahagun 3 months ago.
Revised Applicator Theme
applicator.2.zip (1.1 MB) - added by briansahagun 3 months ago.
Version 0.4
applicator.3.zip (1.1 MB) - added by briansahagun 3 months ago.
Version 0.5
applicator.4.zip (1.1 MB) - added by briansahagun 3 months ago.
Version 0.6

Change History (37)

#1 follow-up: @poena
3 months ago

  • Keywords changed from theme-applicator, accessibility-ready to theme-applicator accessibility-ready

Hi!

Please make sure to correct the problems with the translation mentioned in the Theme Check results above.

The screenshot should not be a logo or mockup, it should be a reasonable representation of what the theme can look like.

Remove any unused code and files (temp files and tester page template?).

Make sure all custom globals and all functions are prefixed, including the htmlok variations and the custom get_comments_popup_link, get_comments_number_str

Minified files may be used, but you need to include a human readable version. I was not able to find a non minified version of modernizer

I am seeing the following JS error:

Uncaught ReferenceError: aplDataCommentFormNote is not defined
    at applicator.js:902
    at applicator.js:970
    at applicator.js:992

Recommended
The theme looks somewhat unstyled, for example it looks like there is no right or left margin so the post content goes right up to the side of the browser window.

#2 follow-up: @grapplerulrich
3 months ago

There are some strings that are not translation ready in inc/tags/post-classification.php inc/tags/breadcrumbs-nav.php

@briansahagun
3 months ago

Revised Applicator Theme

#3 in reply to: ↑ 1 @briansahagun
3 months ago

Hi @poena thanks for the review.

I revised all the items that you've mentioned.

Please check again.

Replying to poena:

Hi!

Please make sure to correct the problems with the translation mentioned in the Theme Check results above.

The screenshot should not be a logo or mockup, it should be a reasonable representation of what the theme can look like.

Remove any unused code and files (temp files and tester page template?).

Make sure all custom globals and all functions are prefixed, including the htmlok variations and the custom get_comments_popup_link, get_comments_number_str

Minified files may be used, but you need to include a human readable version. I was not able to find a non minified version of modernizer

I am seeing the following JS error:

Uncaught ReferenceError: aplDataCommentFormNote is not defined
    at applicator.js:902
    at applicator.js:970
    at applicator.js:992

Recommended
The theme looks somewhat unstyled, for example it looks like there is no right or left margin so the post content goes right up to the side of the browser window.

#4 in reply to: ↑ 2 @briansahagun
3 months ago

Hi @grapplerulrich - thanks for the review. I resolved this item in the new .zip attachment.

Replying to grapplerulrich:

There are some strings that are not translation ready in inc/tags/post-classification.php inc/tags/breadcrumbs-nav.php

@briansahagun
3 months ago

Version 0.4

@briansahagun
3 months ago

Version 0.5

#5 follow-up: @poena
3 months ago

Hi!
We can't work with attached zip files, you need to upload the theme here: https://wordpress.org/themes/upload/

@briansahagun
3 months ago

Version 0.6

#6 @themetracbot
3 months ago

  • Summary changed from THEME: Applicator – 0.2 to THEME: Applicator – 0.6

#7 in reply to: ↑ 5 @briansahagun
3 months ago

Hello, already uploaded thru the proper method. Thanks.

Replying to poena:

Hi!
We can't work with attached zip files, you need to upload the theme here: https://wordpress.org/themes/upload/

#8 @themetracbot
3 months ago

  • Summary changed from THEME: Applicator – 0.6 to THEME: Applicator – 0.7

#9 @themetracbot
2 months ago

  • Summary changed from THEME: Applicator – 0.7 to THEME: Applicator – 0.8

Applicator - 0.8

A WordPress Theme that is accessibility-ready, SEO and mobile-friendly.

Theme URL - http://applicator.dysinelab.com/
Author URL - http://briansahagun.com

Trac Browser - https://themes.trac.wordpress.org/browser/applicator/0.8

SVN - https://themes.svn.wordpress.org/applicator/0.8
ZIP - https://wordpress.org/themes/download/applicator.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=applicator/0.7&new_path=applicator/0.8

History:

Ticket Summary Status Resolution Owner
#45134 THEME: Applicator – 1.5.8 reviewing burkeingraffia

(this ticket)


https://themes.svn.wordpress.org/applicator/0.8/screenshot.png
Theme Check Results:

  • WARNING: Found a translation function that is missing a text-domain. Function esc_attr, with the arguments '

#10 @themetracbot
2 months ago

  • Summary changed from THEME: Applicator – 0.8 to THEME: Applicator – 0.9

#11 @themetracbot
2 months ago

  • Summary changed from THEME: Applicator – 0.9 to THEME: Applicator – 0.9.1

#12 @themetracbot
2 months ago

  • Summary changed from THEME: Applicator – 0.9.1 to THEME: Applicator – 0.9.3

#13 @themetracbot
6 weeks ago

  • Summary changed from THEME: Applicator – 0.9.3 to THEME: Applicator – 0.9.5

#14 @themetracbot
5 weeks ago

  • Summary changed from THEME: Applicator – 0.9.5 to THEME: Applicator – 1.0.5

#15 @themetracbot
4 weeks ago

  • Summary changed from THEME: Applicator – 1.0.5 to THEME: Applicator – 1.1.3

Applicator - 1.1.3

A WordPress Theme that is accessibility-ready, SEO and mobile-friendly.

Theme URL - http://applicator.dysinelab.com/
Author URL - http://briansahagun.com

Trac Browser - https://themes.trac.wordpress.org/browser/applicator/1.1.3

SVN - https://themes.svn.wordpress.org/applicator/1.1.3
ZIP - https://wordpress.org/themes/download/applicator.1.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=applicator/1.0.5&new_path=applicator/1.1.3

History:

Ticket Summary Status Resolution Owner
#45134 THEME: Applicator – 1.5.8 reviewing burkeingraffia

(this ticket)


https://themes.svn.wordpress.org/applicator/1.1.3/screenshot.png
Theme Check Results:

  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are applicator, id

#16 @themetracbot
4 weeks ago

  • Summary changed from THEME: Applicator – 1.1.3 to THEME: Applicator – 1.1.4

#17 @themetracbot
4 weeks ago

  • Owner set to burkeingraffia
  • Status changed from new to reviewing

#18 follow-up: @burkeingraffia
4 weeks ago

Hi @briansahagun

Is the theme version used here:

http://applicator.dysinelab.com/

the latest version?

#19 in reply to: ↑ 18 ; follow-up: @burkeingraffia
4 weeks ago

Never mind, I see that it is version 0.2 in

http://applicator.dysinelab.com/wp-content/themes/applicator/style.css?ver=4.7.6

I'll run it locally. :)

#20 @themetracbot
3 weeks ago

  • Summary changed from THEME: Applicator – 1.1.4 to THEME: Applicator – 1.2.0

#21 in reply to: ↑ 19 @briansahagun
3 weeks ago

Sorry for the late reply. Yes, that's correct - it's way beyond the development.

I still have to update the screenshot image.

Thank you.

Replying to burkeingraffia:

Never mind, I see that it is version 0.2 in

http://applicator.dysinelab.com/wp-content/themes/applicator/style.css?ver=4.7.6

I'll run it locally. :)

#22 @themetracbot
3 weeks ago

  • Summary changed from THEME: Applicator – 1.2.0 to THEME: Applicator – 1.3.7

#23 @themetracbot
2 weeks ago

  • Summary changed from THEME: Applicator – 1.3.7 to THEME: Applicator – 1.4.1

#24 follow-up: @themetracbot
2 weeks ago

  • Summary changed from THEME: Applicator – 1.4.1 to THEME: Applicator – 1.4.3

#25 in reply to: ↑ 24 @burkeingraffia
2 weeks ago

Replying to themetracbot:

Thank you for the continuous updates, @briansahagun .

I have been doing a full assessment of v.1.3.7 when I have had free time, but now that you have updated to a new version, I might have to start from the beginning, especially for accessibility issues. For coding issues I can just see what files have changed and check those as isolated test cases.

Would you please let me know when you are finished making changes for a while so I can be confident that the theme version I am assessing is current?

Thanks, and best of luck to you!
Burke

Applicator - 1.4.3

A WordPress Theme that is mobile-friendly and accessibility-ready.

Theme URL - http://applicator.dysinelab.com/
Author URL - http://briansahagun.com

Trac Browser - https://themes.trac.wordpress.org/browser/applicator/1.4.3

SVN - https://themes.svn.wordpress.org/applicator/1.4.3
ZIP - https://wordpress.org/themes/download/applicator.1.4.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=applicator/1.4.1&new_path=applicator/1.4.3

History:

Ticket Summary Status Resolution Owner
#45134 THEME: Applicator – 1.5.8 reviewing burkeingraffia

(this ticket)


https://themes.svn.wordpress.org/applicator/1.4.3/screenshot.png

#26 follow-up: @rabmalin
7 days ago

@burkeingraffia Have you checked the latest update?

#27 @themetracbot
7 days ago

  • Summary changed from THEME: Applicator – 1.4.3 to THEME: Applicator – 1.5.2

#28 in reply to: ↑ 26 @briansahagun
7 days ago

@burkeingraffia - Hi, 1.5.2 is the latest update. I won't be uploading updates until it has been approved.

Thanks.

Replying to rabmalin:

@burkeingraffia Have you checked the latest update?

#29 @burkeingraffia
7 days ago

@briansahagun @rabmalin Hi! I will do thorough assessment now that I know there won't be any changes for a while. Thanks. :) Please give me until the end of the weekend - my calendar is very full right now.

#30 follow-up: @burkeingraffia
5 days ago

I have done a test of the required elements of the site. This theme uses the "accessibility-ready" tag, but there are a few items that need to be addressed related to accessibility:

Regarding visual indication of current focus (when tabbing):

Sometimes there is not a visible focus. For example, using the tab key after the search function or hamburger/mobile menu, the user does not know where the focus is. Also, on the title, site description link, search, and hamburger/mobile menu the color contrast between the background blue and the dark blue focus border does not comply to the 4.5:1 ratio. See: https://webaim.org/resources/contrastchecker/

When the hamburger/mobile menu is open, the tab focus transfers to the main page, instead of staying within the left slide-in menu.

Regarding the "skip navigation" menu:

I see that on the home, page, and search post types the skip navigation is present, but it is not working on the single post or archive pages.

Other than the items above, I see no problems with the way this is coded. You do enqueue the style.css file, so it is valid, but it is in no way actually being used by the theme to style the site. I'm not sure if this will cause problems in the future.

The theme passed the Theme Check plugin test, but here is some more info it provide:

INFO: Themes that use the tag accessibility-ready will need to undergo an accessibility review. See https://make.wordpress.org/themes/handbook/review/accessibility/

INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs.
The domain found is applicator

INFO: inc/functions/icons.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 9: require_once( $svg_icons );

INFO: inc/functions/customizer-custom-colors.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 11: require_once( get_parent_theme_file_path( '/inc/functions/customizer-color-

#31 @themetracbot
77 minutes ago

  • Summary changed from THEME: Applicator – 1.5.2 to THEME: Applicator – 1.5.6

#32 in reply to: ↑ 30 @briansahagun
73 minutes ago

Hi I updated the theme:

  • Fixed tabbing on the Main Header
  • Seems like Chrome updated the outline color from blue to dark gray - please check
  • Tabbing of Main Menu (hamburger)
  • Skip Navigation is visible on all pages even for short pages

Thanks.

Replying to burkeingraffia:

I have done a test of the required elements of the site. This theme uses the "accessibility-ready" tag, but there are a few items that need to be addressed related to accessibility:

Regarding visual indication of current focus (when tabbing):

Sometimes there is not a visible focus. For example, using the tab key after the search function or hamburger/mobile menu, the user does not know where the focus is. Also, on the title, site description link, search, and hamburger/mobile menu the color contrast between the background blue and the dark blue focus border does not comply to the 4.5:1 ratio. See: https://webaim.org/resources/contrastchecker/

When the hamburger/mobile menu is open, the tab focus transfers to the main page, instead of staying within the left slide-in menu.

Regarding the "skip navigation" menu:

I see that on the home, page, and search post types the skip navigation is present, but it is not working on the single post or archive pages.

Other than the items above, I see no problems with the way this is coded. You do enqueue the style.css file, so it is valid, but it is in no way actually being used by the theme to style the site. I'm not sure if this will cause problems in the future.

The theme passed the Theme Check plugin test, but here is some more info it provide:

INFO: Themes that use the tag accessibility-ready will need to undergo an accessibility review. See https://make.wordpress.org/themes/handbook/review/accessibility/

INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs.
The domain found is applicator

INFO: inc/functions/icons.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 9: require_once( $svg_icons );

INFO: inc/functions/customizer-custom-colors.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 11: require_once( get_parent_theme_file_path( '/inc/functions/customizer-color-

#33 @themetracbot
71 minutes ago

  • Summary changed from THEME: Applicator – 1.5.6 to THEME: Applicator – 1.5.8
Note: See TracTickets for help on using tickets.