WordPress.org

Make WordPress Themes

Opened 5 months ago

Last modified 26 hours ago

#45134 reviewing theme

THEME: Applicator – 2.2.5.07

Reported by: briansahagun Owned by: id4ijaz
Priority: new theme Keywords: theme-applicator
Cc: briansahagun@…

Description

Applicator - 0.2

A WordPress Theme that is accessibility-ready, SEO and mobile-friendly.

Theme URL - http://applicator.dysinelab.com/
Author URL - http://briansahagun.com

Trac Browser - https://themes.trac.wordpress.org/browser/applicator/0.2

SVN - https://themes.svn.wordpress.org/applicator/0.2
ZIP - https://wordpress.org/themes/download/applicator.0.2.zip?nostats=1

History:


https://themes.svn.wordpress.org/applicator/0.2/screenshot.png
Theme Check Results:

  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments 'Pages:'
  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments 'Next page'
  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments 'Previous page'

Attachments (4)

applicator.zip (1.1 MB) - added by briansahagun 5 months ago.
Revised Applicator Theme
applicator.2.zip (1.1 MB) - added by briansahagun 5 months ago.
Version 0.4
applicator.3.zip (1.1 MB) - added by briansahagun 5 months ago.
Version 0.5
applicator.4.zip (1.1 MB) - added by briansahagun 5 months ago.
Version 0.6

Change History (78)

#1 follow-up: @poena
5 months ago

  • Keywords changed from theme-applicator, accessibility-ready to theme-applicator accessibility-ready

Hi!

Please make sure to correct the problems with the translation mentioned in the Theme Check results above.

The screenshot should not be a logo or mockup, it should be a reasonable representation of what the theme can look like.

Remove any unused code and files (temp files and tester page template?).

Make sure all custom globals and all functions are prefixed, including the htmlok variations and the custom get_comments_popup_link, get_comments_number_str

Minified files may be used, but you need to include a human readable version. I was not able to find a non minified version of modernizer

I am seeing the following JS error:

Uncaught ReferenceError: aplDataCommentFormNote is not defined
    at applicator.js:902
    at applicator.js:970
    at applicator.js:992

Recommended
The theme looks somewhat unstyled, for example it looks like there is no right or left margin so the post content goes right up to the side of the browser window.

#2 follow-up: @grapplerulrich
5 months ago

There are some strings that are not translation ready in inc/tags/post-classification.php inc/tags/breadcrumbs-nav.php

@briansahagun
5 months ago

Revised Applicator Theme

#3 in reply to: ↑ 1 @briansahagun
5 months ago

Hi @poena thanks for the review.

I revised all the items that you've mentioned.

Please check again.

Replying to poena:

Hi!

Please make sure to correct the problems with the translation mentioned in the Theme Check results above.

The screenshot should not be a logo or mockup, it should be a reasonable representation of what the theme can look like.

Remove any unused code and files (temp files and tester page template?).

Make sure all custom globals and all functions are prefixed, including the htmlok variations and the custom get_comments_popup_link, get_comments_number_str

Minified files may be used, but you need to include a human readable version. I was not able to find a non minified version of modernizer

I am seeing the following JS error:

Uncaught ReferenceError: aplDataCommentFormNote is not defined
    at applicator.js:902
    at applicator.js:970
    at applicator.js:992

Recommended
The theme looks somewhat unstyled, for example it looks like there is no right or left margin so the post content goes right up to the side of the browser window.

#4 in reply to: ↑ 2 @briansahagun
5 months ago

Hi @grapplerulrich - thanks for the review. I resolved this item in the new .zip attachment.

Replying to grapplerulrich:

There are some strings that are not translation ready in inc/tags/post-classification.php inc/tags/breadcrumbs-nav.php

@briansahagun
5 months ago

Version 0.4

@briansahagun
5 months ago

Version 0.5

#5 follow-up: @poena
5 months ago

Hi!
We can't work with attached zip files, you need to upload the theme here: https://wordpress.org/themes/upload/

@briansahagun
5 months ago

Version 0.6

#6 @themetracbot
5 months ago

  • Summary changed from THEME: Applicator – 0.2 to THEME: Applicator – 0.6

#7 in reply to: ↑ 5 @briansahagun
5 months ago

Hello, already uploaded thru the proper method. Thanks.

Replying to poena:

Hi!
We can't work with attached zip files, you need to upload the theme here: https://wordpress.org/themes/upload/

#8 @themetracbot
5 months ago

  • Summary changed from THEME: Applicator – 0.6 to THEME: Applicator – 0.7

#9 @themetracbot
4 months ago

  • Summary changed from THEME: Applicator – 0.7 to THEME: Applicator – 0.8

Applicator - 0.8

A WordPress Theme that is accessibility-ready, SEO and mobile-friendly.

Theme URL - http://applicator.dysinelab.com/
Author URL - http://briansahagun.com

Trac Browser - https://themes.trac.wordpress.org/browser/applicator/0.8

SVN - https://themes.svn.wordpress.org/applicator/0.8
ZIP - https://wordpress.org/themes/download/applicator.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=applicator/0.7&new_path=applicator/0.8

History:


https://themes.svn.wordpress.org/applicator/0.8/screenshot.png
Theme Check Results:

  • WARNING: Found a translation function that is missing a text-domain. Function esc_attr, with the arguments '

#10 @themetracbot
4 months ago

  • Summary changed from THEME: Applicator – 0.8 to THEME: Applicator – 0.9

#11 @themetracbot
4 months ago

  • Summary changed from THEME: Applicator – 0.9 to THEME: Applicator – 0.9.1

#12 @themetracbot
4 months ago

  • Summary changed from THEME: Applicator – 0.9.1 to THEME: Applicator – 0.9.3

#13 @themetracbot
3 months ago

  • Summary changed from THEME: Applicator – 0.9.3 to THEME: Applicator – 0.9.5

#14 @themetracbot
3 months ago

  • Summary changed from THEME: Applicator – 0.9.5 to THEME: Applicator – 1.0.5

#15 @themetracbot
3 months ago

  • Summary changed from THEME: Applicator – 1.0.5 to THEME: Applicator – 1.1.3

Applicator - 1.1.3

A WordPress Theme that is accessibility-ready, SEO and mobile-friendly.

Theme URL - http://applicator.dysinelab.com/
Author URL - http://briansahagun.com

Trac Browser - https://themes.trac.wordpress.org/browser/applicator/1.1.3

SVN - https://themes.svn.wordpress.org/applicator/1.1.3
ZIP - https://wordpress.org/themes/download/applicator.1.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=applicator/1.0.5&new_path=applicator/1.1.3

History:


https://themes.svn.wordpress.org/applicator/1.1.3/screenshot.png
Theme Check Results:

  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are applicator, id

#16 @themetracbot
3 months ago

  • Summary changed from THEME: Applicator – 1.1.3 to THEME: Applicator – 1.1.4

#17 @themetracbot
3 months ago

  • Owner set to burkeingraffia
  • Status changed from new to reviewing

#18 follow-up: @burkeingraffia
3 months ago

Hi @briansahagun

Is the theme version used here:

http://applicator.dysinelab.com/

the latest version?

#19 in reply to: ↑ 18 ; follow-up: @burkeingraffia
3 months ago

Never mind, I see that it is version 0.2 in

http://applicator.dysinelab.com/wp-content/themes/applicator/style.css?ver=4.7.6

I'll run it locally. :)

#20 @themetracbot
3 months ago

  • Summary changed from THEME: Applicator – 1.1.4 to THEME: Applicator – 1.2.0

#21 in reply to: ↑ 19 @briansahagun
3 months ago

Sorry for the late reply. Yes, that's correct - it's way beyond the development.

I still have to update the screenshot image.

Thank you.

Replying to burkeingraffia:

Never mind, I see that it is version 0.2 in

http://applicator.dysinelab.com/wp-content/themes/applicator/style.css?ver=4.7.6

I'll run it locally. :)

#22 @themetracbot
3 months ago

  • Summary changed from THEME: Applicator – 1.2.0 to THEME: Applicator – 1.3.7

#23 @themetracbot
3 months ago

  • Summary changed from THEME: Applicator – 1.3.7 to THEME: Applicator – 1.4.1

#24 follow-up: @themetracbot
3 months ago

  • Summary changed from THEME: Applicator – 1.4.1 to THEME: Applicator – 1.4.3

#25 in reply to: ↑ 24 @burkeingraffia
3 months ago

Replying to themetracbot:

Thank you for the continuous updates, @briansahagun .

I have been doing a full assessment of v.1.3.7 when I have had free time, but now that you have updated to a new version, I might have to start from the beginning, especially for accessibility issues. For coding issues I can just see what files have changed and check those as isolated test cases.

Would you please let me know when you are finished making changes for a while so I can be confident that the theme version I am assessing is current?

Thanks, and best of luck to you!
Burke

Applicator - 1.4.3

A WordPress Theme that is mobile-friendly and accessibility-ready.

Theme URL - http://applicator.dysinelab.com/
Author URL - http://briansahagun.com

Trac Browser - https://themes.trac.wordpress.org/browser/applicator/1.4.3

SVN - https://themes.svn.wordpress.org/applicator/1.4.3
ZIP - https://wordpress.org/themes/download/applicator.1.4.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=applicator/1.4.1&new_path=applicator/1.4.3

History:


https://themes.svn.wordpress.org/applicator/1.4.3/screenshot.png

#26 follow-up: @rabmalin
2 months ago

@burkeingraffia Have you checked the latest update?

#27 @themetracbot
2 months ago

  • Summary changed from THEME: Applicator – 1.4.3 to THEME: Applicator – 1.5.2

#28 in reply to: ↑ 26 @briansahagun
2 months ago

@burkeingraffia - Hi, 1.5.2 is the latest update. I won't be uploading updates until it has been approved.

Thanks.

Replying to rabmalin:

@burkeingraffia Have you checked the latest update?

#29 @burkeingraffia
2 months ago

@briansahagun @rabmalin Hi! I will do thorough assessment now that I know there won't be any changes for a while. Thanks. :) Please give me until the end of the weekend - my calendar is very full right now.

#30 follow-up: @burkeingraffia
2 months ago

I have done a test of the required elements of the site. This theme uses the "accessibility-ready" tag, but there are a few items that need to be addressed related to accessibility:

Regarding visual indication of current focus (when tabbing):

Sometimes there is not a visible focus. For example, using the tab key after the search function or hamburger/mobile menu, the user does not know where the focus is. Also, on the title, site description link, search, and hamburger/mobile menu the color contrast between the background blue and the dark blue focus border does not comply to the 4.5:1 ratio. See: https://webaim.org/resources/contrastchecker/

When the hamburger/mobile menu is open, the tab focus transfers to the main page, instead of staying within the left slide-in menu.

Regarding the "skip navigation" menu:

I see that on the home, page, and search post types the skip navigation is present, but it is not working on the single post or archive pages.

Other than the items above, I see no problems with the way this is coded. You do enqueue the style.css file, so it is valid, but it is in no way actually being used by the theme to style the site. I'm not sure if this will cause problems in the future.

The theme passed the Theme Check plugin test, but here is some more info it provide:

INFO: Themes that use the tag accessibility-ready will need to undergo an accessibility review. See https://make.wordpress.org/themes/handbook/review/accessibility/

INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs.
The domain found is applicator

INFO: inc/functions/icons.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 9: require_once( $svg_icons );

INFO: inc/functions/customizer-custom-colors.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 11: require_once( get_parent_theme_file_path( '/inc/functions/customizer-color-

#31 @themetracbot
2 months ago

  • Summary changed from THEME: Applicator – 1.5.2 to THEME: Applicator – 1.5.6

#32 in reply to: ↑ 30 @briansahagun
2 months ago

Hi I updated the theme:

  • Fixed tabbing on the Main Header
  • Seems like Chrome updated the outline color from blue to dark gray - please check
  • Tabbing of Main Menu (hamburger)
  • Skip Navigation is visible on all pages even for short pages

Thanks.

Replying to burkeingraffia:

I have done a test of the required elements of the site. This theme uses the "accessibility-ready" tag, but there are a few items that need to be addressed related to accessibility:

Regarding visual indication of current focus (when tabbing):

Sometimes there is not a visible focus. For example, using the tab key after the search function or hamburger/mobile menu, the user does not know where the focus is. Also, on the title, site description link, search, and hamburger/mobile menu the color contrast between the background blue and the dark blue focus border does not comply to the 4.5:1 ratio. See: https://webaim.org/resources/contrastchecker/

When the hamburger/mobile menu is open, the tab focus transfers to the main page, instead of staying within the left slide-in menu.

Regarding the "skip navigation" menu:

I see that on the home, page, and search post types the skip navigation is present, but it is not working on the single post or archive pages.

Other than the items above, I see no problems with the way this is coded. You do enqueue the style.css file, so it is valid, but it is in no way actually being used by the theme to style the site. I'm not sure if this will cause problems in the future.

The theme passed the Theme Check plugin test, but here is some more info it provide:

INFO: Themes that use the tag accessibility-ready will need to undergo an accessibility review. See https://make.wordpress.org/themes/handbook/review/accessibility/

INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs.
The domain found is applicator

INFO: inc/functions/icons.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 9: require_once( $svg_icons );

INFO: inc/functions/customizer-custom-colors.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 11: require_once( get_parent_theme_file_path( '/inc/functions/customizer-color-

#33 @themetracbot
2 months ago

  • Summary changed from THEME: Applicator – 1.5.6 to THEME: Applicator – 1.5.8

#34 @themetracbot
2 months ago

  • Summary changed from THEME: Applicator – 1.5.8 to THEME: Applicator – 1.6.1

#35 follow-up: @burkeingraffia
2 months ago

@briansahagun I see that you have made some changes. I have found two new issues:

  1. After using the background color change feature in the dashboard customizer and then resetting to the default scheme, each page shows/flashes its content briefly, and then the content of that page drops down beneath the fold of the page.
  1. When adding widgets to various places on the site, they look unstyled or in the wrong place. I also noticed that the left and right margins have changed so that the site is not full width as it was previously. Perhaps these two things are related. Check the width and float of id="main-content-header-aside".

Also the "Main Actions" sidebar that places the widgets in the header creates a full width div that sits on top of the main menu (class="ct main-actions---ct"), covering up the menu so the menu items are still visible but are not clickable by a mouse.

For accessibility I still see the following issues.

  1. Left fly-in menu. Tabbing should not close the menu. When that menu is open, the only way it should close when tabbing is to tab to the Close(x) and select Enter or to use the Esc key.

The way it is now is that after tabbing a few times, the menu disappears and the focus takes the user to the main screen.

You do have to be able to tab through the menu as if it were its own separate window object, jumping back to the first tab order after cycling through the whole tab order of that menu as a separate UI.

  1. Something that is still not WCAG compliant is the contrast between the default blue background and the blue colored focus. However, since this color scheme is variable and changeable in the dashboard, you leave it up to the user to change. I recommend perhaps making the default colors have more contrast. Currently they are #11AAFF (background) and (#4E8FFF) focus color. Use this tool:

https://webaim.org/resources/contrastchecker/

Last edited 2 months ago by burkeingraffia (previous) (diff)

#36 @burkeingraffia
8 weeks ago

@briansahagun @rabmalin @themetracbot

I am leaving town tomorrow, October 23 and will not be able to work on this theme again until December 5, 2017. Please have it reassigned to someone else. It wouldn't be fair to Brian to leave me as the analyst. Thanks!

Burke

#37 @rabmalin
8 weeks ago

  • Owner burkeingraffia deleted

#38 @themetracbot
8 weeks ago

  • Owner set to id4ijaz

#39 @id4ijaz
8 weeks ago

Hi @briansahagun

I'm just assigned this theme to review. It is a formal message and let me know if you are active. Say Hello, and I will then start reviewing your theme.

If there is anything you want to change or update the version, Please do that and Reply.

#40 @rabmalin
8 weeks ago

@id4ijaz Please continue review. Theme author is pretty active and uploading the updates in regular manner.

#41 @id4ijaz
8 weeks ago

Its ok.

#42 @themetracbot
7 weeks ago

  • Summary changed from THEME: Applicator – 1.6.1 to THEME: Applicator – 1.7.4

#43 in reply to: ↑ 35 @briansahagun
7 weeks ago

@id4ijaz Hi, thank you for taking over the Theme Review.

Here are the updates:

  • Fixed the Color Customizer
  • Fixed Main Actions Widget
  • Fixed Tabbing to cycle within the active component

Replying to burkeingraffia:

@briansahagun I see that you have made some changes. I have found two new issues:

  1. After using the background color change feature in the dashboard customizer and then resetting to the default scheme, each page shows/flashes its content briefly, and then the content of that page drops down beneath the fold of the page.
  1. When adding widgets to various places on the site, they look unstyled or in the wrong place. I also noticed that the left and right margins have changed so that the site is not full width as it was previously. Perhaps these two things are related. Check the width and float of id="main-content-header-aside".

Also the "Main Actions" sidebar that places the widgets in the header creates a full width div that sits on top of the main menu (class="ct main-actions---ct"), covering up the menu so the menu items are still visible but are not clickable by a mouse.

For accessibility I still see the following issues.

  1. Left fly-in menu. Tabbing should not close the menu. When that menu is open, the only way it should close when tabbing is to tab to the Close(x) and select Enter or to use the Esc key.

The way it is now is that after tabbing a few times, the menu disappears and the focus takes the user to the main screen.

You do have to be able to tab through the menu as if it were its own separate window object, jumping back to the first tab order after cycling through the whole tab order of that menu as a separate UI.

  1. Something that is still not WCAG compliant is the contrast between the default blue background and the blue colored focus. However, since this color scheme is variable and changeable in the dashboard, you leave it up to the user to change. I recommend perhaps making the default colors have more contrast. Currently they are #11AAFF (background) and (#4E8FFF) focus color. Use this tool:

https://webaim.org/resources/contrastchecker/

#44 @themetracbot
7 weeks ago

  • Summary changed from THEME: Applicator – 1.7.4 to THEME: Applicator – 1.7.5

#45 @id4ijaz
7 weeks ago

@briansahagun
now started the review of updated version.

#46 @themetracbot
7 weeks ago

  • Summary changed from THEME: Applicator – 1.7.5 to THEME: Applicator – 1.7.9

#47 @themetracbot
7 weeks ago

  • Summary changed from THEME: Applicator – 1.7.9 to THEME: Applicator – 1.8.2

#48 @themetracbot
7 weeks ago

  • Summary changed from THEME: Applicator – 1.8.2 to THEME: Applicator – 1.8.4

#49 @rabmalin
7 weeks ago

@briansahagun Updating theme everyday wont help to speed up the review process. Please properly communicate and collaborate with theme reviewer.

#50 @briansahagun
7 weeks ago

@id4ijaz @rabmalin I understand. Please hold off the review because I have a latest update that I would commit for the review. Thank you for understanding.

#51 @id4ijaz
7 weeks ago

its ok

#52 @themetracbot
7 weeks ago

  • Summary changed from THEME: Applicator – 1.8.4 to THEME: Applicator – 1.8.8

Applicator - 1.8.8

A WordPress Theme that is mobile-friendly and accessibility-ready.

Theme URL - http://applicator.dysinelab.com/
Author URL - http://briansahagun.com

Trac Browser - https://themes.trac.wordpress.org/browser/applicator/1.8.8

SVN - https://themes.svn.wordpress.org/applicator/1.8.8
ZIP - https://wordpress.org/themes/download/applicator.1.8.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=applicator/1.8.4&new_path=applicator/1.8.8

History:


https://themes.svn.wordpress.org/applicator/1.8.8/screenshot.png
Theme Check Results:

  • WARNING: Found a translation function that is missing a text-domain. Function esc_html, with the arguments 'applicator'
  • WARNING: Found a translation function that is missing a text-domain. Function esc_attr, with the arguments 'applicator'

#53 @themetracbot
7 weeks ago

  • Summary changed from THEME: Applicator – 1.8.8 to THEME: Applicator – 1.8.9

#54 follow-ups: @briansahagun
7 weeks ago

Hi @id4ijaz @rabmalin - please review version 1.8.9.

I will be updating only after your feedback.

Thank you.

#55 @themetracbot
7 weeks ago

  • Summary changed from THEME: Applicator – 1.8.9 to THEME: Applicator – 1.9.0

#56 in reply to: ↑ 54 @briansahagun
7 weeks ago

Sorry, please review 1.9.0. Had an error in translation functions with the previous one. Thanks.

Replying to briansahagun:

Hi @id4ijaz @rabmalin - please review version 1.8.9.

I will be updating only after your feedback.

Thank you.

#57 in reply to: ↑ 54 @briansahagun
7 weeks ago

Sorry, please review 1.9.0. Had an error in translation functions with the previous one. Thanks.

Replying to briansahagun:

Hi @id4ijaz @rabmalin - please review version 1.8.9.

I will be updating only after your feedback.

Thank you.

#58 follow-up: @id4ijaz
6 weeks ago

SEE ISSUES

RECOMMENDED

TYPOGRAPHY

  • Default and Custom options (radio buttons ) in color scheme of colors are used for header background so there should be an indication for header background .http://prntscr.com/h58cd4


#59 @themetracbot
6 weeks ago

  • Summary changed from THEME: Applicator – 1.9.0 to THEME: Applicator – 2.0.1

#60 in reply to: ↑ 58 @briansahagun
6 weeks ago

Hi @id4ijaz - I already fixed the Calendar Style.

Regarding the Custom Color Scheme, I will soon be adding colors that will affect buttons and text - so it's not particular on the header only.

Thank you.

Replying to id4ijaz:

SEE ISSUES

RECOMMENDED

TYPOGRAPHY

  • Default and Custom options (radio buttons ) in color scheme of colors are used for header background so there should be an indication for header background .http://prntscr.com/h58cd4


#61 @themetracbot
6 weeks ago

  • Summary changed from THEME: Applicator – 2.0.1 to THEME: Applicator – 2.0.6

#62 @id4ijaz
5 weeks ago

  • Status changed from reviewing to approved

Hi @ briansahagun
Thanks for your updates. It works fine now. Marking this as approved.
Now, one of the theme review team admins will check this theme and review again before making it live.It is possible that the admin reviewer adds more issues.

#63 @rabmalin
4 weeks ago

  • Status changed from approved to reopened

#64 @rabmalin
4 weeks ago

  • Status changed from reopened to reviewing

This theme needs accessibility review before approval.
Ping @joedolson @davidakennedy @poena

#65 follow-up: @joedolson
3 weeks ago

1) Keyboard Navigation - Fail

  • Keyboard tab sequence should match the visual order. Examples of problems:
  • Menu toggle appears before menu, but is focused after.
  • Menu toggle appears on the left side of the page, but is focused after the search toggle, on the right.
  • After activating the search toggle, focus moves to the search field. To the right of the search field is an 'x' to hide the search field, but the focus moves first to the search toggle, which is *now* the search submit button, then back to the close button.
  • When navigating post meta, focus sequence goes date, author name, author thumbnail, but the visual order is date, author thumbnail, author name.

2) Controls - Pass

3) Skip links - Pass.

4) Forms - Pass. Note: the visual distance between the 'optional' indicator on the comment form and the relative label makes it very difficult to see those element relationships.

5) Headings - Pass

6) ARIA Landmark Roles - Fail

There are *way* too many complementary regions on each page. Landmark regions are only useful if they provide navigation aid. If there are too many of them, you might as well just have a list of individual paragraphs on the page.

7) Link text - Pass. It's a bit unusual to use the excerpt as a continue reading link, but it is unique.

8) Contrasts - Fail.

  • #fff on #00aaff = 2.56:1
  • Search placeholder in header way below contrast requirements
  • Footer: #808080 on #fff

9) Images: Pass

10) Media: None identified; default pass.

11) Screen Reader text: pass

12) Not allowed: Pass

#66 @themetracbot
3 weeks ago

  • Summary changed from THEME: Applicator – 2.0.6 to THEME: Applicator – 2.2.2

#67 in reply to: ↑ 65 @briansahagun
3 weeks ago

Updates made:

  • Comments: moved "optional" beside the label
  • role="complementary": reduced to two: on the Main Header Aside and Secondary Content Aside
  • Contrasts: changed #808080 to #505050 on white background; increased the opacity of Search placeholder on #00aaff

Regarding tabindex:

  • I prioritized the order of content in HTML then applied layout in CSS
  • I prioritized the layout in CSS more than the tabindex

How do you suggest I should go about this? Should I alter the tabindex thru JS?

Replying to joedolson:

1) Keyboard Navigation - Fail

  • Keyboard tab sequence should match the visual order. Examples of problems:
  • Menu toggle appears before menu, but is focused after.
  • Menu toggle appears on the left side of the page, but is focused after the search toggle, on the right.
  • After activating the search toggle, focus moves to the search field. To the right of the search field is an 'x' to hide the search field, but the focus moves first to the search toggle, which is *now* the search submit button, then back to the close button.
  • When navigating post meta, focus sequence goes date, author name, author thumbnail, but the visual order is date, author thumbnail, author name.

2) Controls - Pass

3) Skip links - Pass.

4) Forms - Pass. Note: the visual distance between the 'optional' indicator on the comment form and the relative label makes it very difficult to see those element relationships.

5) Headings - Pass

6) ARIA Landmark Roles - Fail

There are *way* too many complementary regions on each page. Landmark regions are only useful if they provide navigation aid. If there are too many of them, you might as well just have a list of individual paragraphs on the page.

7) Link text - Pass. It's a bit unusual to use the excerpt as a continue reading link, but it is unique.

8) Contrasts - Fail.

  • #fff on #00aaff = 2.56:1
  • Search placeholder in header way below contrast requirements
  • Footer: #808080 on #fff

9) Images: Pass

10) Media: None identified; default pass.

11) Screen Reader text: pass

12) Not allowed: Pass

#68 @joedolson
12 days ago

No, you should definitely not manually alter tabindex values. You should either adapt the design to match the content order or adapt the content order to match the design. Manually altering tabindex is an extremely fragile way of achieving the goal, which would quickly break in most real-world scenarios.

#69 @briansahagun
11 days ago

Hi @joedolson - I'm not sure about rearranging the HTML document outline to conform to the visual design.

My priority is designing the DOM order to match the information architecture (e.g., page name comes ahead menu).

CSS, as the presentation layer, gave me the freedom to visually layout the site in different ways.

I understand that I tagged this theme as "accessibility-ready" but only when you pointed out this issue that I realized that there might be visually-impaired users with visually-capable users by their sides while using the site - and the DOM order (HTML) isn't match with the layout of elements (CSS).

https://www.w3.org/TR/WCAG20-TECHS/C27.html

May I know if this is a strict rule? Because I'm thinking of removing the "accessibility-ready" tag if ever it won't pass because I really value the current architecture of the site.

Thanks.

#70 @joedolson
10 days ago

It's fine for the page name to come before the menu. However, what's important for accessibility is that the visual appearance is consistent with the internal structure, and right now it isn't.

This is primarily relevant to sighted users who are dependent on sequential navigation rather than a pointing device. The navigation of the site will become non-intuitive for those users, as the visual appearance will not match the direction they need to move in their controls.

Yes, this is a strict rule.

#71 follow-up: @Mirucon
41 hours ago

@briansahagun Would you like to update the theme? Please note that tickets have no activity for more than 7 days may be closed due to inactivity.

#72 in reply to: ↑ 71 @briansahagun
41 hours ago

@Mirucon - yes, will be uploading something today. Thanks.

@joedolson - Please note that I will be removing the "accessibility" tag.

Thanks.

Replying to Mirucon:

@briansahagun Would you like to update the theme? Please note that tickets have no activity for more than 7 days may be closed due to inactivity.

#73 @themetracbot
27 hours ago

  • Keywords accessibility-ready removed
  • Summary changed from THEME: Applicator – 2.2.2 to THEME: Applicator – 2.2.5.07

#74 @Mirucon
26 hours ago

@id4ijaz The accessibility-tag has been removed. Can you continue the review, or mark this as approved if you don't see issues anymore?

Note: See TracTickets for help on using tickets.