WordPress.org

Make WordPress Themes

Opened 3 months ago

Last modified 8 days ago

#45178 approved theme

THEME: Schema Lite – 1.0.4

Reported by: MyThemeShop Owned by: WPBrigade
Priority: new theme Keywords: theme-schema-lite
Cc: admin@…

Description

Schema Lite - 1.0.0

Schema Lite is a fast loading, ultra-SEO friendly WordPress theme that features rich snippets in order to help search engines identify all parts of your site and rank you higher. Full fledged demo >>>>>> http://demo.mythemeshop.com/s/?theme=Schema%20Lite <<<<<<

Theme URL - http://mythemeshop.com/themes/schema-lite/
Author URL - https://mythemeshop.com

Trac Browser - https://themes.trac.wordpress.org/browser/schema-lite/1.0.0

SVN - https://themes.svn.wordpress.org/schema-lite/1.0.0
ZIP - https://wordpress.org/themes/download/schema-lite.1.0.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/schema-lite/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (21)

#1 @MyThemeShop
3 months ago

Submitted theme again with the new name, please refer this ticket https://themes.trac.wordpress.org/ticket/45090

#2 @AbdulWahab610
4 weeks ago

  • Owner set to WPBrigade
  • Status changed from new to reviewing

#3 follow-up: @WPBrigade
4 weeks ago

Hi, @MyThemeShop

I'm just assigned this theme to review. It is a formal message and let me know if you are active, Say Hello, and I will then start reviewing your theme.

If there is anything you want to change or update the version, Please do that and Reply.

Cheers!

#4 in reply to: ↑ 3 @MyThemeShop
4 weeks ago

Hi @WPBrigade

That's great! Sure, please start reviewing the theme.

Looking forward to your feedback. Thank you.

#5 @WPBrigade
4 weeks ago

Hi there,

I have gone through your theme and found these issues, Please fix them and upload, I will review them again.

Required:

  • Customizer: on unchecking “Display Site Title and Tagline” checkbox, navigation menu also disappears with Title.
  • Customizer: After setting and removing logo, navigation menu also disappears with logo.
  • Theme URI should be the URI of working demo site, not the image or a download option for it.

Recommended:

  • Non-breaking text in the title, content, and comments should have no adverse effects on layout or functionality.
  • Header image and navigation background image should be one but not same image for each of them separately.
  • Use esc_html_e instead of _e.

Best of luck!

#6 follow-up: @themetracbot
3 weeks ago

  • Summary changed from THEME: Schema Lite – 1.0.0 to THEME: Schema Lite – 1.0.1

Schema Lite - 1.0.1

Schema Lite is a fast loading, ultra-SEO friendly WordPress theme that features rich snippets in order to help search engines identify all parts of your site and rank you higher. Full fledged demo >>>>>> http://demo.mythemeshop.com/s/?theme=Schema%20Lite <<<<<<

Theme URL - http://mythemeshop.com/themes/schema-lite/
Author URL - https://mythemeshop.com

Trac Browser - https://themes.trac.wordpress.org/browser/schema-lite/1.0.1

SVN - https://themes.svn.wordpress.org/schema-lite/1.0.1
ZIP - https://wordpress.org/themes/download/schema-lite.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=schema-lite/1.0.0&new_path=schema-lite/1.0.1

History:


https://themes.svn.wordpress.org/schema-lite/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#7 in reply to: ↑ 6 @MyThemeShop
3 weeks ago

Hello @WPBrigade,
Thank you for the review, we have fixed navigation disappearing issue.
About the Theme URI, according to the handbook we can use webpage URI where user can find more information about the theme.

Theme URI: The URL of a public web page where users can find more information about the theme.

https://developer.wordpress.org/themes/basics/main-stylesheet-style-css/

If anything else, please let us know.
Thank you.

#8 @WPBrigade
3 weeks ago

Hi, @MyThemeShop

I have gone through your uploaded theme and found some issues, Please fix them and upload again.

Required

  • Customizer: After setting and removing the logo, Site’s title also disappears with logo.
  • Escaping: All untrusted URL data should be escaped properly before displaying. e.g., esc_url() should be used to escape URL on the source of the image tag. https://codex.wordpress.org/Data_Validation
  • Widget-social.php -line 18, Use unique prefix with the class name.
  • It is not required to make changelog file externally to show version changes, information in readme file is enough.

Thank you.

#9 @themetracbot
3 weeks ago

  • Summary changed from THEME: Schema Lite – 1.0.1 to THEME: Schema Lite – 1.0.2

Schema Lite - 1.0.2

Schema Lite is a fast loading, ultra-SEO friendly WordPress theme that features rich snippets in order to help search engines identify all parts of your site and rank you higher. Full fledged demo >>>>>> http://demo.mythemeshop.com/s/?theme=Schema%20Lite <<<<<<

Theme URL - http://mythemeshop.com/themes/schema-lite/
Author URL - https://mythemeshop.com

Trac Browser - https://themes.trac.wordpress.org/browser/schema-lite/1.0.2

SVN - https://themes.svn.wordpress.org/schema-lite/1.0.2
ZIP - https://wordpress.org/themes/download/schema-lite.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=schema-lite/1.0.1&new_path=schema-lite/1.0.2

History:


https://themes.svn.wordpress.org/schema-lite/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#10 @WPBrigade
3 weeks ago

Hi, @MyThemeShop

I have gone through your uploaded theme and found some issues, Please fix them.

Required

  • Functions.php: escape properly –line 256.
  • Customizer.php: use proper sanitization –line 146. Text area is allowing script tags. https://developer.wordpress.org/reference/functions/wp_kses/
  • Customizer.php: use proper sanitization for radio type controls.
  • Single.php: escaping required –line 78.
  • Explain usage of variable “$schema_lite_full_posts” in pages: index.php, archive.php and search.php
  • Remove unused code instead of commenting it out.

Thank you.

#11 @themetracbot
3 weeks ago

  • Summary changed from THEME: Schema Lite – 1.0.2 to THEME: Schema Lite – 1.0.3

Schema Lite - 1.0.3

Schema Lite is a fast loading, ultra-SEO friendly WordPress theme that features rich snippets in order to help search engines identify all parts of your site and rank you higher. Full fledged demo >>>>>> http://demo.mythemeshop.com/s/?theme=Schema%20Lite <<<<<<

Theme URL - http://mythemeshop.com/themes/schema-lite/
Author URL - https://mythemeshop.com

Trac Browser - https://themes.trac.wordpress.org/browser/schema-lite/1.0.3

SVN - https://themes.svn.wordpress.org/schema-lite/1.0.3
ZIP - https://wordpress.org/themes/download/schema-lite.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=schema-lite/1.0.2&new_path=schema-lite/1.0.3

History:


https://themes.svn.wordpress.org/schema-lite/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#12 @WPBrigade
3 weeks ago

Hi, @MyThemeShop

I have gone through your uploaded theme and everything looks like Good.

Only escaping remain in functions.php#line 256. Here you should need to escape get_theme_mod().

Thank you.

#13 @themetracbot
3 weeks ago

  • Summary changed from THEME: Schema Lite – 1.0.3 to THEME: Schema Lite – 1.0.4

Schema Lite - 1.0.4

Schema Lite is a fast loading, ultra-SEO friendly WordPress theme that features rich snippets in order to help search engines identify all parts of your site and rank you higher. Full fledged demo >>>>>> http://demo.mythemeshop.com/s/?theme=Schema%20Lite <<<<<<

Theme URL - http://mythemeshop.com/themes/schema-lite/
Author URL - https://mythemeshop.com

Trac Browser - https://themes.trac.wordpress.org/browser/schema-lite/1.0.4

SVN - https://themes.svn.wordpress.org/schema-lite/1.0.4
ZIP - https://wordpress.org/themes/download/schema-lite.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=schema-lite/1.0.3&new_path=schema-lite/1.0.4

History:


https://themes.svn.wordpress.org/schema-lite/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#14 @MyThemeShop
3 weeks ago

Hi @WPBrigade,
we have made the changes, please take a look.
Thanks.

#15 @WPBrigade
2 weeks ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi @MyThemeShop

Thanks for your update. It looks fine now. Marking this as approved.

Now, one of the theme review team admins will check this theme and review again before making it live.It is possible that the admin reviewer adds more issues.

Cheers!

#16 @rabmalin
2 weeks ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#17 @rabmalin
2 weeks ago

  • Status changed from reopened to reviewing

#18 @rabmalin
2 weeks ago

@WPBrigade You were trying to approve theme, right?

#19 @WPBrigade
8 days ago

@rabmalin

Oops! Sorry.
Yes, I was trying to approve the theme but mistakenly choose not-approved option.

May I approve it now or new ticket is generated for it?

#20 @rabmalin
8 days ago

Yes, you can approve.

#21 @WPBrigade
8 days ago

  • Status changed from reviewing to approved
Note: See TracTickets for help on using tickets.